searching for reviewer(automatedtester)
ff6be2623035cfa8b70f514aab2e4f8dbcb43756: Bug 1473614 - Expose API docs for MessageManagerDestroyedPromise and Sleep. r=automatedtester
Andreas Tolfsen <ato@sny.no> - Fri, 03 Aug 2018 16:11:23 +0100 - rev 827305
Push 118509 by bmo:gl@mozilla.com at Tue, 07 Aug 2018 19:00:09 +0000
Bug 1473614 - Expose API docs for MessageManagerDestroyedPromise and Sleep. r=automatedtester
684c928574c6896fde319a7a947e2125ca37a366: Bug 1473614 - Fix exported symbols in sync. r=automatedtester
Andreas Tolfsen <ato@sny.no> - Fri, 03 Aug 2018 16:10:53 +0100 - rev 827304
Push 118509 by bmo:gl@mozilla.com at Tue, 07 Aug 2018 19:00:09 +0000
Bug 1473614 - Fix exported symbols in sync. r=automatedtester The "exported" keyword is no longer needed.
c76d0cb71ad460386bf10e8c09ece7f6d2d76ec3: Bug 1473614 - Add sync function Sleep for pausing async functions. r=automatedtester
Andreas Tolfsen <ato@sny.no> - Fri, 03 Aug 2018 16:10:23 +0100 - rev 827303
Push 118509 by bmo:gl@mozilla.com at Tue, 07 Aug 2018 19:00:09 +0000
Bug 1473614 - Add sync function Sleep for pausing async functions. r=automatedtester This adds a new public API to the Marionette sync module that can "pause" async functions for an arbitrary amount of hardcoded time. This can be useful for debugging purposes.
075c87b1393a66c60f796383efd8f697d36893a1: Bug 1473614 - Add type checks to PollPromise and TimedPromise. r=automatedtester
Andreas Tolfsen <ato@sny.no> - Fri, 03 Aug 2018 16:08:45 +0100 - rev 827302
Push 118509 by bmo:gl@mozilla.com at Tue, 07 Aug 2018 19:00:09 +0000
Bug 1473614 - Add type checks to PollPromise and TimedPromise. r=automatedtester This patch introduces stricted type checks for the sync module's PollPromise and TimedPromise. This may seem excessive, but we have had real and severe bugs in this area before.
541bad93631c1dfbb89fd0c7c32fb11662df2d40: Bug 1480810 - Drop PREF_COMPLEX from Marionette prefs module. r=automatedtester
Andreas Tolfsen <ato@sny.no> - Fri, 03 Aug 2018 16:33:56 +0100 - rev 826852
Push 118394 by maglione.k@gmail.com at Sun, 05 Aug 2018 20:34:06 +0000
Bug 1480810 - Drop PREF_COMPLEX from Marionette prefs module. r=automatedtester A warning appears in the console when you run xpcshell tests that the PREF_COMPLEX type is no longer, and we should therefore remove it from Marionette as well.
027922b5ef0442e4ebb07043d2b57961e6195a78: Bug 1473614 - Expose API docs for MessageManagerDestroyedPromise and Sleep. r=automatedtester
Andreas Tolfsen <ato@sny.no> - Fri, 03 Aug 2018 16:11:23 +0100 - rev 826851
Push 118394 by maglione.k@gmail.com at Sun, 05 Aug 2018 20:34:06 +0000
Bug 1473614 - Expose API docs for MessageManagerDestroyedPromise and Sleep. r=automatedtester
1d28e128807c3969771d1722bc567713606add73: Bug 1473614 - Fix exported symbols in sync. r=automatedtester
Andreas Tolfsen <ato@sny.no> - Fri, 03 Aug 2018 16:10:53 +0100 - rev 826850
Push 118394 by maglione.k@gmail.com at Sun, 05 Aug 2018 20:34:06 +0000
Bug 1473614 - Fix exported symbols in sync. r=automatedtester The "exported" keyword is no longer needed.
1ee58097b1412972a3ce2a6be6114025747f3f0a: Bug 1473614 - Add sync function Sleep for pausing async functions. r=automatedtester
Andreas Tolfsen <ato@sny.no> - Fri, 03 Aug 2018 16:10:23 +0100 - rev 826849
Push 118394 by maglione.k@gmail.com at Sun, 05 Aug 2018 20:34:06 +0000
Bug 1473614 - Add sync function Sleep for pausing async functions. r=automatedtester This adds a new public API to the Marionette sync module that can "pause" async functions for an arbitrary amount of hardcoded time. This can be useful for debugging purposes.
87a0ebcd004ffb9c15716b36635286bb4e3bd167: Bug 1473614 - Add type checks to PollPromise and TimedPromise. r=automatedtester
Andreas Tolfsen <ato@sny.no> - Fri, 03 Aug 2018 16:08:45 +0100 - rev 826848
Push 118394 by maglione.k@gmail.com at Sun, 05 Aug 2018 20:34:06 +0000
Bug 1473614 - Add type checks to PollPromise and TimedPromise. r=automatedtester This patch introduces stricted type checks for the sync module's PollPromise and TimedPromise. This may seem excessive, but we have had real and severe bugs in this area before.
0ad9872c27e07e5f9dbbb62ec41e5be180e98f05: Bug 1470659 - Move timeouts test to separate file. r=automatedtester,whimboo
Andreas Tolfsen <ato@sny.no> - Sat, 21 Jul 2018 18:35:23 +0100 - rev 825617
Push 118150 by maglione.k@gmail.com at Thu, 02 Aug 2018 04:47:08 +0000
Bug 1470659 - Move timeouts test to separate file. r=automatedtester,whimboo For similar reasons as for platformName, tests for configuring the timeouts object do not belong in the same parent test as those for response body structure.
e99e43a1e400b532ae84c36519da8e0cbc7143ac: Bug 1470659 - Add setWindowRect capability to geckodriver. r=automatedtester
Andreas Tolfsen <ato@sny.no> - Sat, 21 Jul 2018 18:32:01 +0100 - rev 825615
Push 118150 by maglione.k@gmail.com at Thu, 02 Aug 2018 04:47:08 +0000
Bug 1470659 - Add setWindowRect capability to geckodriver. r=automatedtester It will never be possible to configure setWindowRect, and trying to do so will cause geckodriver to return with an error.
20c023fb254c10ad540825753b49ca75af96e0c6: Bug 1447977 - Handle cyclic references in element prototypes. r=automatedtester a=test-only draft
Andreas Tolfsen <ato@sny.no> - Fri, 06 Jul 2018 20:08:37 +0100 - rev 824983
Push 118017 by bmo:edilee@mozilla.com at Tue, 31 Jul 2018 21:53:17 +0000
Bug 1447977 - Handle cyclic references in element prototypes. r=automatedtester a=test-only JavaScript objects can be nested to any depth, and as such we must check that the value to be serialised contains a cyclic structure before attempting to marshaling it. We handle this correctly for collections and arbitrary objects by relying on JSON.stringify. For example with arrays: let arr = []; arr.push(arr); And for objects: let obj = {}; obj.reference = obj; However, members of the different element prototypes (HTMLElement, SVGElement, XULElement, et al.) may also contain cyclic references via user-defined own properties: let body = document.documentElement; body.reference = body; JSON.stringify enumerates an object's own properties, which means it picks up on body's "reference" property in the above example. Marionette needs to special case element prototypes because we want to marshal them as web elements. This patch replaces JSON.stringify with a custom function for testing if a value contains cyclic structures that special-cases elements. MozReview-Commit-ID: 1TQtHrjf401
43f6112e957876670aa24461d6d751a8de5b3cfb: Bug 1447977 - Move cyclic object test function to evaluate. r=automatedtester a=test-only draft
Andreas Tolfsen <ato@sny.no> - Fri, 06 Jul 2018 18:35:21 +0100 - rev 824982
Push 118017 by bmo:edilee@mozilla.com at Tue, 31 Jul 2018 21:53:17 +0000
Bug 1447977 - Move cyclic object test function to evaluate. r=automatedtester a=test-only Moves the innards of assert.acyclic to evaluate.isCyclic so it can be called externally without throwing. It makes more sense for this function to be exposed on the evaluate module, since other behaviour related to JSON marshaling is also defined there. MozReview-Commit-ID: 4WjEy8Sjqrm
332084df66518b9065ce7f4eebbda8ae5db41338: Bug 1447977 - Move evaluate module API docs to RST. r=automatedtester a=test-only draft
Andreas Tolfsen <ato@sny.no> - Fri, 06 Jul 2018 16:36:19 +0100 - rev 824981
Push 118017 by bmo:edilee@mozilla.com at Tue, 31 Jul 2018 21:53:17 +0000
Bug 1447977 - Move evaluate module API docs to RST. r=automatedtester a=test-only MozReview-Commit-ID: I5Pj8EsNyFc
e9d0102d718ffcb48ecf4882528d69e1c3946893: Bug 1475279 - Remove copy-pasted algorithmic steps from wdspec tests. r=automatedtester
Andreas Tolfsen <ato@sny.no> - Thu, 12 Jul 2018 17:17:55 +0100 - rev 821994
Push 117242 by rwood@mozilla.com at Tue, 24 Jul 2018 13:33:52 +0000
Bug 1475279 - Remove copy-pasted algorithmic steps from wdspec tests. r=automatedtester We agreed some time ago that it would not be possible to keep the copy-pasted specification algorithm steps up-to-date in the WPT wdspec tests. This patch removes all such steps.
666d7dc7a32cbcacb8ef4b0120cf849a7ca8a911: Bug 1477476 - Drop geckodriver check for malformed sessionId from Marionette. r=automatedtester
Andreas Tolfsen <ato@sny.no> - Sat, 21 Jul 2018 14:17:35 +0100 - rev 821993
Push 117242 by rwood@mozilla.com at Tue, 24 Jul 2018 13:33:52 +0000
Bug 1477476 - Drop geckodriver check for malformed sessionId from Marionette. r=automatedtester Marionette used to return a session UUID starting with "{" and ending with "}" from the uuid-generator in Gecko. It has not done this for a very long time rendering this geckodriver check needless.
0a9411bc7b5dcfac1c3e2deacaa8d0b65d5b3a85: Bug 1477474 - Return moz:geckodriverVersion on session creation. r=automatedtester
Andreas Tolfsen <ato@sny.no> - Sat, 21 Jul 2018 14:09:53 +0100 - rev 821992
Push 117242 by rwood@mozilla.com at Tue, 24 Jul 2018 13:33:52 +0000
Bug 1477474 - Return moz:geckodriverVersion on session creation. r=automatedtester This introduces a new extension capability, moz:geckodriverVersion, that will be returned on session creation with the geckodriver version number.
eacc31a62f16f7585f847981e0b48269db66ec5f: Bug 1477474 - Stop logging geckodriver version on startup. r=automatedtester
Andreas Tolfsen <ato@sny.no> - Sat, 21 Jul 2018 14:09:02 +0100 - rev 821991
Push 117242 by rwood@mozilla.com at Tue, 24 Jul 2018 13:33:52 +0000
Bug 1477474 - Stop logging geckodriver version on startup. r=automatedtester Any info-level log entries emitted before session creation will not be subject to the requested log level from moz:firefoxOptions. This can confuse users, so instead of logging the geckodriver version number on starting the program, we can return it later during session creation as an extension capability. Additionally this patch reduces the log level of the port geckodriver listens to from info to debug for similar reasons.
abc2e543c4972a763438bb502549bcc7e42278f1: Bug 1476305 - Add pref to not truncate Marionette log messages. r=automatedtester
Andreas Tolfsen <ato@sny.no> - Tue, 17 Jul 2018 16:35:22 +0100 - rev 821989
Push 117242 by rwood@mozilla.com at Tue, 24 Jul 2018 13:33:52 +0000
Bug 1476305 - Add pref to not truncate Marionette log messages. r=automatedtester Marionette currently truncates a selection of log messages that exceed 250 characters. It is however sometimes, usually when debugging locally, to not truncate logs so one can see exactly what is sent to and fro the server.
d0a25eb8031ec334947f258373df4c781672a3ee: Bug 1475279 - Remove copy-pasted algorithmic steps from wdspec tests. r?automatedtester draft
Andreas Tolfsen <ato@sny.no> - Thu, 12 Jul 2018 17:17:55 +0100 - rev 817386
Push 116053 by bmo:ato@sny.no at Thu, 12 Jul 2018 16:19:29 +0000
Bug 1475279 - Remove copy-pasted algorithmic steps from wdspec tests. r?automatedtester We agreed some time ago that it would not be possible to keep the copy-pasted specification algorithm steps up-to-date in the WPT wdspec tests. This patch removes all such steps. MozReview-Commit-ID: 9ThRdsqLg4k
b4cd5a640564cee2dda926724bf2faeb8934d702: Bug 1447977 - Handle cyclic references in element prototypes. r=automatedtester
Andreas Tolfsen <ato@sny.no> - Fri, 06 Jul 2018 20:08:37 +0100 - rev 816831
Push 115850 by bmo:tvijiala@mozilla.com at Wed, 11 Jul 2018 10:05:08 +0000
Bug 1447977 - Handle cyclic references in element prototypes. r=automatedtester JavaScript objects can be nested to any depth, and as such we must check that the value to be serialised contains a cyclic structure before attempting to marshaling it. We handle this correctly for collections and arbitrary objects by relying on JSON.stringify. For example with arrays: let arr = []; arr.push(arr); And for objects: let obj = {}; obj.reference = obj; However, members of the different element prototypes (HTMLElement, SVGElement, XULElement, et al.) may also contain cyclic references via user-defined own properties: let body = document.documentElement; body.reference = body; JSON.stringify enumerates an object's own properties, which means it picks up on body's "reference" property in the above example. Marionette needs to special case element prototypes because we want to marshal them as web elements. This patch replaces JSON.stringify with a custom function for testing if a value contains cyclic structures that special-cases elements. MozReview-Commit-ID: 1TQtHrjf401
cbb958819d32f25d41d0e6fe61105d57a882b3eb: Bug 1447977 - Move cyclic object test function to evaluate. r=automatedtester
Andreas Tolfsen <ato@sny.no> - Fri, 06 Jul 2018 18:35:21 +0100 - rev 816830
Push 115850 by bmo:tvijiala@mozilla.com at Wed, 11 Jul 2018 10:05:08 +0000
Bug 1447977 - Move cyclic object test function to evaluate. r=automatedtester Moves the innards of assert.acyclic to evaluate.isCyclic so it can be called externally without throwing. It makes more sense for this function to be exposed on the evaluate module, since other behaviour related to JSON marshaling is also defined there. MozReview-Commit-ID: 4WjEy8Sjqrm
dccb4ac6468a39d0266039d5c0ad0ca9cbe2c462: Bug 1447977 - Move evaluate module API docs to RST. r=automatedtester
Andreas Tolfsen <ato@sny.no> - Fri, 06 Jul 2018 16:36:19 +0100 - rev 816829
Push 115850 by bmo:tvijiala@mozilla.com at Wed, 11 Jul 2018 10:05:08 +0000
Bug 1447977 - Move evaluate module API docs to RST. r=automatedtester MozReview-Commit-ID: I5Pj8EsNyFc
038aa18eb4096e93148ce00baef477e4d3ed4a44: Bug 1447977 - Handle cyclic references in element prototypes. r?automatedtester draft
Andreas Tolfsen <ato@sny.no> - Fri, 06 Jul 2018 20:08:37 +0100 - rev 816079
Push 115750 by bmo:ato@sny.no at Tue, 10 Jul 2018 15:58:46 +0000
Bug 1447977 - Handle cyclic references in element prototypes. r?automatedtester JavaScript objects can be nested to any depth, and as such we must check that the value to be serialised contains a cyclic structure before attempting to marshaling it. We handle this correctly for collections and arbitrary objects by relying on JSON.stringify. For example with arrays: let arr = []; arr.push(arr); And for objects: let obj = {}; obj.reference = obj; However, members of the different element prototypes (HTMLElement, SVGElement, XULElement, et al.) may also contain cyclic references via user-defined own properties: let body = document.documentElement; body.reference = body; JSON.stringify enumerates an object's own properties, which means it picks up on body's "reference" property in the above example. Marionette needs to special case element prototypes because we want to marshal them as web elements. This patch replaces JSON.stringify with a custom function for testing if a value contains cyclic structures that special-cases elements. MozReview-Commit-ID: 1TQtHrjf401
b42f3d93e0375205df2c0bae39fdccbc86ecabc2: Bug 1447977 - Handle cyclic references in element prototypes. r?automatedtester draft
Andreas Tolfsen <ato@sny.no> - Fri, 06 Jul 2018 20:08:37 +0100 - rev 816078
Push 115749 by bmo:ato@sny.no at Tue, 10 Jul 2018 15:56:00 +0000
Bug 1447977 - Handle cyclic references in element prototypes. r?automatedtester JavaScript objects can be nested to any depth, and as such we must check that the value to be serialised contains a cyclic structure before attempting to marshaling it. We handle this correctly for collections and arbitrary objects by relying on JSON.stringify. For example with arrays: let arr = []; arr.push(arr); And for objects: let obj = {}; obj.reference = obj; However, members of the different element prototypes (HTMLElement, SVGElement, XULElement, et al.) may also contain cyclic references via user-defined own properties: let body = document.documentElement; body.reference = body; JSON.stringify enumerates an object's own properties, which means it picks up on body's "reference" property in the above example. Marionette needs to special case element prototypes because we want to marshal them as web elements. This patch replaces JSON.stringify with a custom function for testing if a value contains cyclic structures that special-cases elements. MozReview-Commit-ID: 1TQtHrjf401
4edf3ef4c78c6bb2ead534760a333d5cdd1e5b20: Bug 1447977 - Move cyclic object test function to evaluate. r?automatedtester draft
Andreas Tolfsen <ato@sny.no> - Fri, 06 Jul 2018 18:35:21 +0100 - rev 816077
Push 115749 by bmo:ato@sny.no at Tue, 10 Jul 2018 15:56:00 +0000
Bug 1447977 - Move cyclic object test function to evaluate. r?automatedtester Moves the innards of assert.acyclic to evaluate.isCyclic so it can be called externally without throwing. It makes more sense for this function to be exposed on the evaluate module, since other behaviour related to JSON marshaling is also defined there. MozReview-Commit-ID: 4WjEy8Sjqrm
427cf313322203975deeebabb1c7e775d6a7efb8: Bug 1447977 - Move evaluate module API docs to RST. r?automatedtester draft
Andreas Tolfsen <ato@sny.no> - Fri, 06 Jul 2018 16:36:19 +0100 - rev 816076
Push 115749 by bmo:ato@sny.no at Tue, 10 Jul 2018 15:56:00 +0000
Bug 1447977 - Move evaluate module API docs to RST. r?automatedtester MozReview-Commit-ID: I5Pj8EsNyFc
6637d206368f4e1186d1042ab4e0fcfb2c88e411: Bug 1471201 - Increase webdriver HTTPD Keep-Alive timeout to 90s. r=automatedtester
Andreas Tolfsen <ato@sny.no> - Thu, 05 Jul 2018 12:50:33 +0100 - rev 814680
Push 115315 by jhofmann@mozilla.com at Thu, 05 Jul 2018 22:52:02 +0000
Bug 1471201 - Increase webdriver HTTPD Keep-Alive timeout to 90s. r=automatedtester Increasing geckodriver's Keep-Alive timeout duration to 90 seconds, from the default five seconds, will reduce the number of HTTP connections a persistent-enabled client will have to make, potentially boosting performance. In more recent hyper versions the default is 90 seconds, which means we can get rid of this line when hyper is upgraded. This will help mitigate https://github.com/mozilla/geckodriver/issues/1304 but not fundamentally resolve it, due to a standard library bug in Python 2.7's urllib. MozReview-Commit-ID: 98AFDQgWfpw
65c324517ab5e981728cecce4be09b152fde6ec5: Bug 1471201 - Increase webdriver HTTPD Keep-Alive timeout to 90s. r?automatedtester draft
Andreas Tolfsen <ato@sny.no> - Thu, 05 Jul 2018 12:50:33 +0100 - rev 814464
Push 115214 by bmo:ato@sny.no at Thu, 05 Jul 2018 11:58:41 +0000
Bug 1471201 - Increase webdriver HTTPD Keep-Alive timeout to 90s. r?automatedtester Increasing geckodriver's Keep-Alive timeout duration to 90 seconds, from the default five seconds, will reduce the number of HTTP connections a persistent-enabled client will have to make, potentially boosting performance. In more recent hyper versions the default is 90 seconds, which means we can get rid of this line when hyper is upgraded. This will help mitigate https://github.com/mozilla/geckodriver/issues/1304 but not fundamentally resolve it, due to a standard library bug in Python 2.7's urllib. MozReview-Commit-ID: 98AFDQgWfpw
6c187edf1253d37cf6a61b8e52ab13c4d7a02fca: Bug 1472112 - [geckodriver] Fix build job on Travis for win32 platform. r=automatedtester
Henrik Skupin <mail@hskupin.info> - Fri, 29 Jun 2018 11:02:49 +0200 - rev 812736
Push 114664 by bmo:johannes.willbold@rub.de at Fri, 29 Jun 2018 22:48:56 +0000
Bug 1472112 - [geckodriver] Fix build job on Travis for win32 platform. r=automatedtester Upgrading the docker image from the unsupported Ubuntu 15.10 release to the 16.04 LTS release let us build the win32 binary successfully. DON'T BUILD MozReview-Commit-ID: 9Z0MPsMqyTu
2e0af0221a8ea76a9445c51e9f86b025766e7721: Bug 1457054 - [wdspec] Align formatting of custom delete cookie command. r=automatedtester
Henrik Skupin <mail@hskupin.info> - Thu, 26 Apr 2018 11:08:05 +0200 - rev 789410
Push 108268 by bmo:emilio@crisal.io at Sun, 29 Apr 2018 00:05:47 +0000
Bug 1457054 - [wdspec] Align formatting of custom delete cookie command. r=automatedtester MozReview-Commit-ID: KPePHYHT0CP
149859d8a23d280e1e8b62ce9747dbbf71e18a85: Bug 1457054 - [wdspec] Remove unwanted docstrings with reference to the spec. r=automatedtester
Henrik Skupin <mail@hskupin.info> - Thu, 26 Apr 2018 11:06:06 +0200 - rev 789409
Push 108268 by bmo:emilio@crisal.io at Sun, 29 Apr 2018 00:05:47 +0000
Bug 1457054 - [wdspec] Remove unwanted docstrings with reference to the spec. r=automatedtester MozReview-Commit-ID: 8pxozHr4gZs
ab7307312bb7ded67672b9d8cb2ec723dea1f23d: Bug 1457054 - [wdspec] Use correct assertions for delete cookie tests. r=automatedtester
Henrik Skupin <mail@hskupin.info> - Thu, 26 Apr 2018 11:05:01 +0200 - rev 789408
Push 108268 by bmo:emilio@crisal.io at Sun, 29 Apr 2018 00:05:47 +0000
Bug 1457054 - [wdspec] Use correct assertions for delete cookie tests. r=automatedtester MozReview-Commit-ID: HsqeIkF5Wq7
672e7d5d8f40a04ccd87b0f84eb4ade0f19cbdd4: Bug 1428795 - Reset Marionette state when initialisation fails. r=automatedtester
Andreas Tolfsen <ato@sny.no> - Mon, 26 Feb 2018 20:37:58 +0000 - rev 762126
Push 101094 by bmo:edilee@mozilla.com at Thu, 01 Mar 2018 21:25:03 +0000
Bug 1428795 - Reset Marionette state when initialisation fails. r=automatedtester If Marionette throws inside try...catch block that spawns the TCP listener, we fail to reset the altered recommended preferences to their original state, leaving a possibility of tainting the profile. By calling the uninitialisation code when an error is thrown we ensure all relevant state gets reset. MozReview-Commit-ID: XiiIEFMZQY
d1cb6c61dcf8dee823bf9416cd7046af8c1dd00b: Bug 1428795 - Uninitalise Marionette on xpcom-will-shutdown. r=automatedtester
Andreas Tolfsen <ato@sny.no> - Mon, 26 Feb 2018 20:36:29 +0000 - rev 762125
Push 101094 by bmo:edilee@mozilla.com at Thu, 01 Mar 2018 21:25:03 +0000
Bug 1428795 - Uninitalise Marionette on xpcom-will-shutdown. r=automatedtester Marionette was previously uninitialised when xpcom-shutdown fired. This may be too late to reset preferences and other state related to the browser. This patch moves Marionette to run uninitialisation code on xpcom-will-shutdown. MozReview-Commit-ID: 3ytX2k2rrOp
6f92c0b0abe832829cafc4342a773f2cafeed242: Bug 1428795 - Set MOZ_MARIONETTE in component. r=automatedtester
Andreas Tolfsen <ato@sny.no> - Mon, 26 Feb 2018 20:34:54 +0000 - rev 762124
Push 101094 by bmo:edilee@mozilla.com at Thu, 01 Mar 2018 21:25:03 +0000
Bug 1428795 - Set MOZ_MARIONETTE in component. r=automatedtester Setting the MOZ_MARIONETTE environment variable is not a task that naturally belongs to the TCP listener. This patch moves it to the Marionette XPCOM component. MozReview-Commit-ID: 7896Sv91wFy
65fa19a430ba699ea4a0b01fb33eb02e59ef8fd8: Bug 1428795 - Move recommended prefs to component. r=automatedtester
Andreas Tolfsen <ato@sny.no> - Mon, 26 Feb 2018 20:31:19 +0000 - rev 762123
Push 101094 by bmo:edilee@mozilla.com at Thu, 01 Mar 2018 21:25:03 +0000
Bug 1428795 - Move recommended prefs to component. r=automatedtester Setting the recommended preferences is not a task specific to the TCP listener. It makes more sense to set these in the Marionette XPCOM component where we manage the Marionette lifetime. MozReview-Commit-ID: G2RuLhKnX9X
4427476afb562761c9c7d062e2a30ade34042a2f: Bug 1428795 - Reset Marionette state when initialisation fails. r?automatedtester draft
Andreas Tolfsen <ato@sny.no> - Mon, 26 Feb 2018 20:37:58 +0000 - rev 761791
Push 101000 by bmo:ato@sny.no at Thu, 01 Mar 2018 14:20:13 +0000
Bug 1428795 - Reset Marionette state when initialisation fails. r?automatedtester If Marionette throws inside try...catch block that spawns the TCP listener, we fail to reset the altered recommended preferences to their original state, leaving a possibility of tainting the profile. By calling the uninitialisation code when an error is thrown we ensure all relevant state gets reset. MozReview-Commit-ID: XiiIEFMZQY
452dfba83839c55f0b1e21457c7bf9b00fbd7ada: Bug 1428795 - Uninitalise Marionette on xpcom-will-shutdown. r?automatedtester draft
Andreas Tolfsen <ato@sny.no> - Mon, 26 Feb 2018 20:36:29 +0000 - rev 761790
Push 101000 by bmo:ato@sny.no at Thu, 01 Mar 2018 14:20:13 +0000
Bug 1428795 - Uninitalise Marionette on xpcom-will-shutdown. r?automatedtester Marionette was previously uninitialised when xpcom-shutdown fired. This may be too late to reset preferences and other state related to the browser. This patch moves Marionette to run uninitialisation code on xpcom-will-shutdown. MozReview-Commit-ID: 3ytX2k2rrOp
40b3706385a8f538e5811fb2d661c770e66c1930: Bug 1428795 - Set MOZ_MARIONETTE in component. r?automatedtester draft
Andreas Tolfsen <ato@sny.no> - Mon, 26 Feb 2018 20:34:54 +0000 - rev 761789
Push 101000 by bmo:ato@sny.no at Thu, 01 Mar 2018 14:20:13 +0000
Bug 1428795 - Set MOZ_MARIONETTE in component. r?automatedtester Setting the MOZ_MARIONETTE environment variable is not a task that naturally belongs to the TCP listener. This patch moves it to the Marionette XPCOM component. MozReview-Commit-ID: 7896Sv91wFy
1015df6e4bf8e41da352c46948840905bfe6fa5c: Bug 1428795 - Move recommended prefs to component. r?automatedtester draft
Andreas Tolfsen <ato@sny.no> - Mon, 26 Feb 2018 20:31:19 +0000 - rev 761788
Push 101000 by bmo:ato@sny.no at Thu, 01 Mar 2018 14:20:13 +0000
Bug 1428795 - Move recommended prefs to component. r?automatedtester Setting the recommended preferences is not a task specific to the TCP listener. It makes more sense to set these in the Marionette XPCOM component where we manage the Marionette lifetime. MozReview-Commit-ID: G2RuLhKnX9X
c4fe0ca380a6309d37e9df5c0692e64a455e76ce: Bug 1433463 - WebDriver:ElementSendKeys should not run unfocussing steps. r=automatedtester a=test-only
Andreas Tolfsen <ato@sny.no> - Thu, 22 Feb 2018 11:26:01 +0000 - rev 761668
Push 100982 by stransky@redhat.com at Thu, 01 Mar 2018 09:41:46 +0000
Bug 1433463 - WebDriver:ElementSendKeys should not run unfocussing steps. r=automatedtester a=test-only According to the WebDriver standard the Element Send Keys command should not run the unfocussing steps. Not blurring the element causes the DOM "change" event not to fire, but the specification only expects the "input" event to fire. The standard does, however, expect the Element Clear command to run the unfocussing steps and to blur the element for historical reasons. MozReview-Commit-ID: FHD1whho0jT
8306ccb1dd271181c80e9eba2129e4d563f5f204: Bug 1375637 - Make test_async_script_timeout less likely to fail. r=automatedtester, a=test-only
Andreas Tolfsen <ato@sny.no> - Wed, 07 Feb 2018 18:15:20 +0000 - rev 761640
Push 100982 by stransky@redhat.com at Thu, 01 Mar 2018 09:41:46 +0000
Bug 1375637 - Make test_async_script_timeout less likely to fail. r=automatedtester, a=test-only By increasing the duration before setTimeout fires the callback and the execute_async_script call returns control to the user we are less likely that there is a race condition between the relatively short 100 ms interruption time. MozReview-Commit-ID: BVKRiU7a2gK
681062e657f33e9e91982acce1e1184da9d70efc: Bug 1428795 - Reset Marionette state when initialisation fails. r?automatedtester draft
Andreas Tolfsen <ato@sny.no> - Mon, 26 Feb 2018 20:37:58 +0000 - rev 760064
Push 100524 by bmo:ato@sny.no at Mon, 26 Feb 2018 20:44:16 +0000
Bug 1428795 - Reset Marionette state when initialisation fails. r?automatedtester If Marionette throws inside try try...catch block that spawns the TCP listener, we fail to reset the altered recommended preferences to their original state, leaving a possibility of tainting the profile. By calling the uninitialisation code when an error is thrown we ensure all relevant state gets reset. MozReview-Commit-ID: XiiIEFMZQY
5b2501efefafda2b0921d1e9f52ef5e2d95a25e7: Bug 1428795 - Uninitalise Marionette on xpcom-will-shutdown. r?automatedtester draft
Andreas Tolfsen <ato@sny.no> - Mon, 26 Feb 2018 20:36:29 +0000 - rev 760063
Push 100524 by bmo:ato@sny.no at Mon, 26 Feb 2018 20:44:16 +0000
Bug 1428795 - Uninitalise Marionette on xpcom-will-shutdown. r?automatedtester Marionette was previously uninitialised when xpcom-shutdown fired. This may be too late to reset preferences and other state related to the browser. This patch moves Marionette to run uninitialisation code on xpcom-will-shutdown. MozReview-Commit-ID: 3ytX2k2rrOp
45cfaec03c47d3e0ed24fb362f50fb2be54cfdc6: Bug 1428795 - Set MOZ_MARIONETTE in component. r?automatedtester draft
Andreas Tolfsen <ato@sny.no> - Mon, 26 Feb 2018 20:34:54 +0000 - rev 760062
Push 100524 by bmo:ato@sny.no at Mon, 26 Feb 2018 20:44:16 +0000
Bug 1428795 - Set MOZ_MARIONETTE in component. r?automatedtester Setting the MOZ_MARIONETTE environment variable is not a task that naturally belongs to the TCP listener. This patch moves it to the Marionette XPCOM component. MozReview-Commit-ID: 7896Sv91wFy
2a1ebf29262ba42ebbf562f09521c8182953d21d: Bug 1428795 - Move recommended prefs to component. r?automatedtester draft
Andreas Tolfsen <ato@sny.no> - Mon, 26 Feb 2018 20:31:19 +0000 - rev 760061
Push 100524 by bmo:ato@sny.no at Mon, 26 Feb 2018 20:44:16 +0000
Bug 1428795 - Move recommended prefs to component. r?automatedtester Setting the recommended preferences is not a task specific to the TCP listener. It makes more sense to set these in the Marionette XPCOM component where we manage the Marionette lifetime. MozReview-Commit-ID: G2RuLhKnX9X
042d7adef0bdb9dc80e825c3997ace7519477c42: Bug 1433463 - WebDriver:ElementSendKeys should not run unfocussing steps. r=automatedtester
Andreas Tolfsen <ato@sny.no> - Thu, 22 Feb 2018 11:26:01 +0000 - rev 758660
Push 100152 by bmo:cmanchester@mozilla.com at Thu, 22 Feb 2018 22:44:32 +0000
Bug 1433463 - WebDriver:ElementSendKeys should not run unfocussing steps. r=automatedtester According to the WebDriver standard the Element Send Keys command should not run the unfocussing steps. Not blurring the element causes the DOM "change" event not to fire, but the specification only expects the "input" event to fire. The standard does, however, expect the Element Clear command to run the unfocussing steps and to blur the element for historical reasons. MozReview-Commit-ID: FHD1whho0jT
21ec7e94b244d0d304daedb79d956817692e9bb8: Bug 1433463 - WebDriver:ElementSendKeys should not run unfocussing steps. r?automatedtester draft
Andreas Tolfsen <ato@sny.no> - Thu, 22 Feb 2018 11:26:01 +0000 - rev 758434
Push 100054 by bmo:ato@sny.no at Thu, 22 Feb 2018 13:19:45 +0000
Bug 1433463 - WebDriver:ElementSendKeys should not run unfocussing steps. r?automatedtester According to the WebDriver standard the Element Send Keys command should not run the unfocussing steps. Not blurring the element causes the DOM "change" event not to fire, but the specification only expects the "input" event to fire. The standard does, however, expect the Element Clear command to run the unfocussing steps and to blur the element for historical reasons. MozReview-Commit-ID: FHD1whho0jT
eef22afbcb5ef33240be721cd1b7afc0b67f76d8: Bug 1439995 - Add user prompt checks for script execution commands. r?automatedtester draft
Andreas Tolfsen <ato@sny.no> - Thu, 22 Feb 2018 12:00:33 +0000 - rev 758425
Push 100047 by bmo:ato@sny.no at Thu, 22 Feb 2018 12:02:35 +0000
Bug 1439995 - Add user prompt checks for script execution commands. r?automatedtester WebDriver:{ExecuteScript,ExecuteAsyncScript} were missing user prompt checks. This patch does not add any tests because Marionette does not yet implement the user prompt handler as described in the specification, which means that the relevant tests in WPT are incorrect for this behaviour. MozReview-Commit-ID: BRTAm1ptsQw