searching for reviewer(Honza)
9fcfb36da6fe80f1b1647700eb2e9b55d5db9a07: Bug 1484682 - Ensure the sidebar can overflow; r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 23 Aug 2018 09:46:02 +0000 - rev 831021
Push 118868 by bmo:zjz@zjz.name at Fri, 24 Aug 2018 07:04:39 +0000
Bug 1484682 - Ensure the sidebar can overflow; r=Honza. The sidebar regressed at some point and wasn't showing a scrollbar when it was needed. This patch fixes that by making the sidebar overflow and adds a test to make sure we don't regress. Differential Revision: https://phabricator.services.mozilla.com/D3976
6fe10cab33ca07a9b6ce8e9a0ce5e41a672945e5: Bug 1485300 - Remove duplicated implementation of NetworkObserver. r=Honza
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 22 Aug 2018 12:16:23 +0000 - rev 831001
Push 118868 by bmo:zjz@zjz.name at Fri, 24 Aug 2018 07:04:39 +0000
Bug 1485300 - Remove duplicated implementation of NetworkObserver. r=Honza MozReview-Commit-ID: F3yDYfmsv59 Differential Revision: https://phabricator.services.mozilla.com/D3970
28d5979962b7aacb307fbbaf1ce438d5560044ce: Bug 1483880 - Always hide the autocompletion popup in acceptProposedCompletion; r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Wed, 22 Aug 2018 11:40:09 +0000 - rev 830766
Push 118854 by bmo:a.beingessner@gmail.com at Wed, 22 Aug 2018 20:13:35 +0000
Bug 1483880 - Always hide the autocompletion popup in acceptProposedCompletion; r=Honza. When hitting enter, if there was no autocompletionText shown (because the input was matching a proposed value), then the autocompletion popup wasn't closed. We now close it every time, and only check the completionText to insert a possible string after the cursor. A test case is added to make sure we don't regress this. Differential Revision: https://phabricator.services.mozilla.com/D3763
6bfff0d1a5a429717625871d7f7f866d55817070: Bug 1484764 - Prevent netmonitors is undefined exception when closing tools during page load. r=Honza
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 21 Aug 2018 17:06:19 +0000 - rev 830752
Push 118854 by bmo:a.beingessner@gmail.com at Wed, 22 Aug 2018 20:13:35 +0000
Bug 1484764 - Prevent netmonitors is undefined exception when closing tools during page load. r=Honza Differential Revision: https://phabricator.services.mozilla.com/D3863
fd86a6388333a146b2ca7dcea00f3e3343aae139: Bug 1465644 - Part 3. Hide Splitter if the network panel detail has not opened. r=honza
Mantaroh Yoshinaga <mantaroh@gmail.com> - Wed, 22 Aug 2018 16:08:27 +0900 - rev 830704
Push 118847 by bmo:hskupin@gmail.com at Wed, 22 Aug 2018 09:09:03 +0000
Bug 1465644 - Part 3. Hide Splitter if the network panel detail has not opened. r=honza Network monitor has the splitter box. This splitter is displayed between the request list panel and network details panel. However, this splitter is displayed even if the network details panel has not displayed. This patch will set the spliter size to zero if the network details panel is collapsed.
68bff34cbddd1703e706bce5124c4c358352702a: Bug 1482070 - Move NetworkResponseListener to its own file. r=Honza
Alexandre Poirot <poirot.alex@gmail.com> - Thu, 16 Aug 2018 08:57:54 -0700 - rev 830335
Push 118832 by bmo:ntim.bugs@gmail.com at Tue, 21 Aug 2018 13:33:17 +0000
Bug 1482070 - Move NetworkResponseListener to its own file. r=Honza Summary: Depends On D3605 Reviewers: Honza! Tags: #secure-revision Bug #: 1482070 Differential Revision: https://phabricator.services.mozilla.com/D3606 MozReview-Commit-ID: IH9R6N7auXO
6871a98b8b0b27c70848cbd3241db7272a1ee60b: Bug 1482070 - Rename NetworkMonitor to NetworkObserver and move it next to the NetworkMonitorActor. r=Honza
Alexandre Poirot <poirot.alex@gmail.com> - Thu, 16 Aug 2018 05:30:22 -0700 - rev 830334
Push 118832 by bmo:ntim.bugs@gmail.com at Tue, 21 Aug 2018 13:33:17 +0000
Bug 1482070 - Rename NetworkMonitor to NetworkObserver and move it next to the NetworkMonitorActor. r=Honza Summary: Depends On D3604 Reviewers: Honza! Tags: #secure-revision Bug #: 1482070 Differential Revision: https://phabricator.services.mozilla.com/D3605 MozReview-Commit-ID: ArS8SxVraiu
e4b6ce31de8d57f7e772232bda29727e82ec6ea5: Bug 1482070 - Move StackTraceCollector to its own file. r=Honza
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 14 Aug 2018 08:54:10 -0700 - rev 830333
Push 118832 by bmo:ntim.bugs@gmail.com at Tue, 21 Aug 2018 13:33:17 +0000
Bug 1482070 - Move StackTraceCollector to its own file. r=Honza Summary: Depends On D3603 Reviewers: Honza! Tags: #secure-revision Bug #: 1482070 Differential Revision: https://phabricator.services.mozilla.com/D3604 MozReview-Commit-ID: 53aaLHR6lv
cc2fffaa4633bebab54f78e42277e8eeb23521c6: Bug 1482070 - Move ChannelEventSink to its own file. r=Honza
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 14 Aug 2018 08:50:25 -0700 - rev 830332
Push 118832 by bmo:ntim.bugs@gmail.com at Tue, 21 Aug 2018 13:33:17 +0000
Bug 1482070 - Move ChannelEventSink to its own file. r=Honza Summary: Depends On D3602 Reviewers: Honza! Tags: #secure-revision Bug #: 1482070 Differential Revision: https://phabricator.services.mozilla.com/D3603 MozReview-Commit-ID: Kr3vYvP1oCZ
f269b019428d8d9e2984c8345d3fd9e40d013b8d: Bug 1482070 - Move DocumentEventsListener to its own file. r=Honza
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 14 Aug 2018 08:14:04 -0700 - rev 830331
Push 118832 by bmo:ntim.bugs@gmail.com at Tue, 21 Aug 2018 13:33:17 +0000
Bug 1482070 - Move DocumentEventsListener to its own file. r=Honza Summary: Depends On D3601 Reviewers: Honza! Tags: #secure-revision Bug #: 1482070 Differential Revision: https://phabricator.services.mozilla.com/D3602 MozReview-Commit-ID: 2ksi5eir4mb
5b6d222516808471f3e435b151f29dd51b587a19: Bug 1482070 - Move ContentProcessListener to its own file. r=Honza
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 14 Aug 2018 08:11:57 -0700 - rev 830330
Push 118832 by bmo:ntim.bugs@gmail.com at Tue, 21 Aug 2018 13:33:17 +0000
Bug 1482070 - Move ContentProcessListener to its own file. r=Honza Summary: Depends On D3600 Reviewers: Honza! Tags: #secure-revision Bug #: 1482070 Differential Revision: https://phabricator.services.mozilla.com/D3601 MozReview-Commit-ID: CHReMMFXFHT
e6cb4956e53f6b9bc7c2e70ff7a5d3f44065c66d: Bug 1482070 - Move ConsoleReflowListener to its own file. r=Honza
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 14 Aug 2018 08:09:38 -0700 - rev 830329
Push 118832 by bmo:ntim.bugs@gmail.com at Tue, 21 Aug 2018 13:33:17 +0000
Bug 1482070 - Move ConsoleReflowListener to its own file. r=Honza Summary: Depends On D3599 Reviewers: Honza! Tags: #secure-revision Bug #: 1482070 Differential Revision: https://phabricator.services.mozilla.com/D3600 MozReview-Commit-ID: 8pL6y7F4chU
985b16e1735621130527b12af5adb3505496e048: Bug 1482070 - Move ConsoleAPIListener to its own file. r=Honza
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 14 Aug 2018 08:07:28 -0700 - rev 830328
Push 118832 by bmo:ntim.bugs@gmail.com at Tue, 21 Aug 2018 13:33:17 +0000
Bug 1482070 - Move ConsoleAPIListener to its own file. r=Honza Summary: Depends On D3598 Reviewers: Honza! Tags: #secure-revision Bug #: 1482070 Differential Revision: https://phabricator.services.mozilla.com/D3599 MozReview-Commit-ID: k3KVzlmXOR
71e21bc8aa29936516dc0f2574a6bcad803ac035: Bug 1482070 - Move ConsoleServiceListener to its own file. r=Honza
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 14 Aug 2018 08:05:30 -0700 - rev 830327
Push 118832 by bmo:ntim.bugs@gmail.com at Tue, 21 Aug 2018 13:33:17 +0000
Bug 1482070 - Move ConsoleServiceListener to its own file. r=Honza Summary: Depends On D3597 Reviewers: Honza! Tags: #secure-revision Bug #: 1482070 Differential Revision: https://phabricator.services.mozilla.com/D3598 MozReview-Commit-ID: 7jdh33iKfgU
c6c757dc5f0b12d4f7eb506aefd13ab69e1b0649: Bug 1482070 - Move ConsoleProgressListener to its own file. r=Honza
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 14 Aug 2018 08:02:41 -0700 - rev 830326
Push 118832 by bmo:ntim.bugs@gmail.com at Tue, 21 Aug 2018 13:33:17 +0000
Bug 1482070 - Move ConsoleProgressListener to its own file. r=Honza Reviewers: Honza! Tags: #secure-revision Bug #: 1482070 Differential Revision: https://phabricator.services.mozilla.com/D3597 MozReview-Commit-ID: 99V3BJqKqZH
e1e8061780fdf074a510b94240ab303f89950a4d: Bug 1467572 - Part 15: Fix unit tests for RDM to work with the new RDM design. r=Honza
Gabriel Luong <gabriel.luong@gmail.com> - Wed, 15 Aug 2018 17:27:51 -0400 - rev 829621
Push 118782 by bmo:mtigley@mozilla.com at Thu, 16 Aug 2018 04:40:36 +0000
Bug 1467572 - Part 15: Fix unit tests for RDM to work with the new RDM design. r=Honza - Various element IDs and strings were renamed in the preceeding patches before this. This fixes the strings and element ID reference in the RDM unit tests. - Fixed RDM unit tests to work with new native context menu which used to be <select> elements.
06c72f105c508ef96f368ed2f180f94b192501c0: Bug 1467572 - Part 12: Use native context menu instead of select element in the Device selector. r=Honza
Gabriel Luong <gabriel.luong@gmail.com> - Wed, 15 Aug 2018 17:27:46 -0400 - rev 829618
Push 118782 by bmo:mtigley@mozilla.com at Thu, 16 Aug 2018 04:40:36 +0000
Bug 1467572 - Part 12: Use native context menu instead of select element in the Device selector. r=Honza - Removes all the unused styling for the <select> and <option> elements and the toolbar-dropdown class.
aed506e2100a0dd8e5325912edca9f74be9f3edf: Bug 1467572 - Part 11: Use native context menu instead of select elements in the DPR menu. r=Honza
Gabriel Luong <gabriel.luong@gmail.com> - Wed, 15 Aug 2018 17:27:44 -0400 - rev 829617
Push 118782 by bmo:mtigley@mozilla.com at Thu, 16 Aug 2018 04:40:36 +0000
Bug 1467572 - Part 11: Use native context menu instead of select elements in the DPR menu. r=Honza
b55503cf4ad4328e5bf5e1f9b590b97332789a66: Bug 1467572 - Part 10: Reuse the network throttling menu in the network monitor in RDM. r=Honza
Gabriel Luong <gabriel.luong@gmail.com> - Wed, 15 Aug 2018 17:27:43 -0400 - rev 829616
Push 118782 by bmo:mtigley@mozilla.com at Thu, 16 Aug 2018 04:40:36 +0000
Bug 1467572 - Part 10: Reuse the network throttling menu in the network monitor in RDM. r=Honza - Removes the duplicate dropdown arrow icon that is used in both RDM and Network monitor - Converts the network throttling menu in the network monitor to be a shared component that can be used in both RDM and network monitor - Move the common styles for the dropdown menu button into toolbars.css
81d81c2f9098f782581869d6bafc09800e7601b9: Bug 1467572 - Part 9: Use native context menu instead of select elements in the reload condition menu of RDM. r=Honza
Gabriel Luong <gabriel.luong@gmail.com> - Wed, 15 Aug 2018 17:27:41 -0400 - rev 829615
Push 118782 by bmo:mtigley@mozilla.com at Thu, 16 Aug 2018 04:40:36 +0000
Bug 1467572 - Part 9: Use native context menu instead of select elements in the reload condition menu of RDM. r=Honza - Converts the reload condition <select> to use native context menu - Converts the showMenu util to be reusable by both RDM and the Network Monitor - Renames getToplevelWindow to getTopLevelWindow - Renames the reload condition menu to be a setting menu in RDM according to the designs - Uses the new photon setting icon in RDM
41d85a6f8a2a04ed8f0206da7b3e3a2c997b3f04: Bug 1467572 - Part 15: Fix unit tests for RDM to work with the new RDM design. r=Honza
Gabriel Luong <gabriel.luong@gmail.com> - Wed, 15 Aug 2018 17:27:51 -0400 - rev 829588
Push 118782 by bmo:mtigley@mozilla.com at Thu, 16 Aug 2018 04:40:36 +0000
Bug 1467572 - Part 15: Fix unit tests for RDM to work with the new RDM design. r=Honza - Various element IDs and strings were renamed in the preceeding patches before this. This fixes the strings and element ID reference in the RDM unit tests. - Fixed RDM unit tests to work with new native context menu which used to be <select> elements.
abb52c2c68ab5063ba4bcc83cdeeef8a83a1e643: Bug 1467572 - Part 12: Use native context menu instead of select element in the Device selector. r=Honza
Gabriel Luong <gabriel.luong@gmail.com> - Wed, 15 Aug 2018 17:27:46 -0400 - rev 829585
Push 118782 by bmo:mtigley@mozilla.com at Thu, 16 Aug 2018 04:40:36 +0000
Bug 1467572 - Part 12: Use native context menu instead of select element in the Device selector. r=Honza - Removes all the unused styling for the <select> and <option> elements and the toolbar-dropdown class.
470b9ce4ba0fd5b6c5b88f3d7b95492791d77815: Bug 1467572 - Part 11: Use native context menu instead of select elements in the DPR menu. r=Honza
Gabriel Luong <gabriel.luong@gmail.com> - Wed, 15 Aug 2018 17:27:44 -0400 - rev 829584
Push 118782 by bmo:mtigley@mozilla.com at Thu, 16 Aug 2018 04:40:36 +0000
Bug 1467572 - Part 11: Use native context menu instead of select elements in the DPR menu. r=Honza
37609995dc8f1ce64c3bcd7bc9b89928c013173d: Bug 1467572 - Part 10: Reuse the network throttling menu in the network monitor in RDM. r=Honza
Gabriel Luong <gabriel.luong@gmail.com> - Wed, 15 Aug 2018 17:27:43 -0400 - rev 829583
Push 118782 by bmo:mtigley@mozilla.com at Thu, 16 Aug 2018 04:40:36 +0000
Bug 1467572 - Part 10: Reuse the network throttling menu in the network monitor in RDM. r=Honza - Removes the duplicate dropdown arrow icon that is used in both RDM and Network monitor - Converts the network throttling menu in the network monitor to be a shared component that can be used in both RDM and network monitor - Move the common styles for the dropdown menu button into toolbars.css
636bf5ce96f79a4481dfb08a2394667b37b957d3: Bug 1467572 - Part 9: Use native context menu instead of select elements in the reload condition menu of RDM. r=Honza
Gabriel Luong <gabriel.luong@gmail.com> - Wed, 15 Aug 2018 17:27:41 -0400 - rev 829582
Push 118782 by bmo:mtigley@mozilla.com at Thu, 16 Aug 2018 04:40:36 +0000
Bug 1467572 - Part 9: Use native context menu instead of select elements in the reload condition menu of RDM. r=Honza - Converts the reload condition <select> to use native context menu - Converts the showMenu util to be reusable by both RDM and the Network Monitor - Renames getToplevelWindow to getTopLevelWindow - Renames the reload condition menu to be a setting menu in RDM according to the designs - Uses the new photon setting icon in RDM
85c46ce628cd4b21a3ba5e47306031ef55aee1d1: Bug 1467572 - Part 15: Fix unit tests for RDM to work with the new RDM design. r=Honza draft
Gabriel Luong <gabriel.luong@gmail.com> - Tue, 14 Aug 2018 17:54:55 -0400 - rev 829220
Push 118750 by bmo:gl@mozilla.com at Tue, 14 Aug 2018 21:55:43 +0000
Bug 1467572 - Part 15: Fix unit tests for RDM to work with the new RDM design. r=Honza - Various element IDs and strings were renamed in the preceeding patches before this. This fixes the strings and element ID reference in the RDM unit tests. - Fixed RDM unit tests to work with new native context menu which used to be <select> elements. MozReview-Commit-ID: 2GQPfA3rVyo
a2ea7996091a6db0a7d1124b3a7d5c6a6651b66f: Bug 1467572 - Part 12: Use native context menu instead of select element in the Device selector. r=Honza draft
Gabriel Luong <gabriel.luong@gmail.com> - Tue, 14 Aug 2018 17:54:54 -0400 - rev 829217
Push 118750 by bmo:gl@mozilla.com at Tue, 14 Aug 2018 21:55:43 +0000
Bug 1467572 - Part 12: Use native context menu instead of select element in the Device selector. r=Honza - Removes all the unused styling for the <select> and <option> elements and the toolbar-dropdown class. MozReview-Commit-ID: 1sf6VSBIJy9
8672371de55d45e83eb5e7d7b5033cf902c782d2: Bug 1467572 - Part 11: Use native context menu instead of select elements in the DPR menu. r=Honza draft
Gabriel Luong <gabriel.luong@gmail.com> - Tue, 14 Aug 2018 17:54:54 -0400 - rev 829216
Push 118750 by bmo:gl@mozilla.com at Tue, 14 Aug 2018 21:55:43 +0000
Bug 1467572 - Part 11: Use native context menu instead of select elements in the DPR menu. r=Honza MozReview-Commit-ID: Jt9XNzO9R89
b3a1517ec227122c88b9f97248ee7146c542f557: Bug 1467572 - Part 10: Reuse the network throttling menu in the network monitor in RDM. r=Honza draft
Gabriel Luong <gabriel.luong@gmail.com> - Tue, 14 Aug 2018 17:54:54 -0400 - rev 829215
Push 118750 by bmo:gl@mozilla.com at Tue, 14 Aug 2018 21:55:43 +0000
Bug 1467572 - Part 10: Reuse the network throttling menu in the network monitor in RDM. r=Honza - Removes the duplicate dropdown arrow icon that is used in both RDM and Network monitor - Converts the network throttling menu in the network monitor to be a shared component that can be used in both RDM and network monitor - Move the common styles for the dropdown menu button into toolbars.css MozReview-Commit-ID: EQPscJlIpav
b70dfd53c9d911adcc7ccb55054fee34345e9b14: Bug 1467572 - Part 9: Use native context menu instead of select elements in the reload condition menu of RDM. r=Honza draft
Gabriel Luong <gabriel.luong@gmail.com> - Tue, 14 Aug 2018 17:54:54 -0400 - rev 829214
Push 118750 by bmo:gl@mozilla.com at Tue, 14 Aug 2018 21:55:43 +0000
Bug 1467572 - Part 9: Use native context menu instead of select elements in the reload condition menu of RDM. r=Honza - Converts the reload condition <select> to use native context menu - Converts the showMenu util to be reusable by both RDM and the Network Monitor - Renames getToplevelWindow to getTopLevelWindow - Renames the reload condition menu to be a setting menu in RDM according to the designs - Uses the new photon setting icon in RDM MozReview-Commit-ID: FBSQMhs7Sxx
e906e53dd6ba1b75a2b6ab6913776cb931810a70: Bug 1299344 - Fix exceptions when accessing DOMWindow and contentCharset when reload page against the netmonitor. r=Honza
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 13 Aug 2018 12:37:41 +0000 - rev 828742
Push 118704 by bmo:rcaliman@mozilla.com at Mon, 13 Aug 2018 16:58:07 +0000
Bug 1299344 - Fix exceptions when accessing DOMWindow and contentCharset when reload page against the netmonitor. r=Honza Differential Revision: https://phabricator.services.mozilla.com/D3020
a28c7f13b6a6f5d1471cb98de79a59316cd25475: Bug 1479521 - Only run browser_jsterm_accessibility.js with old jsterm; r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Mon, 13 Aug 2018 10:07:00 +0000 - rev 828741
Push 118704 by bmo:rcaliman@mozilla.com at Mon, 13 Aug 2018 16:58:07 +0000
Bug 1479521 - Only run browser_jsterm_accessibility.js with old jsterm; r=Honza. Depends on D2826 Differential Revision: https://phabricator.services.mozilla.com/D2827
6011582e3f69efcbba042b286523d2016c174c18: Bug 1479521 - Update tests to match the new jsterm behavior; r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Mon, 13 Aug 2018 08:37:09 +0000 - rev 828740
Push 118704 by bmo:rcaliman@mozilla.com at Mon, 13 Aug 2018 16:58:07 +0000
Bug 1479521 - Update tests to match the new jsterm behavior; r=Honza. Some test were relying on the existence of the complete function and were using it in order to do integration test. We modify those and instead trigger real user interaction for making those assertions. Additional test cases are added to the test files they fit in so we have a broader coverage of user interaction in regard to autocompletion. Depends on D2825 Differential Revision: https://phabricator.services.mozilla.com/D2826
65f3480a713b33098891dadd7d504313aa39775d: Bug 1479521 - Remove browser_jsterm_no_autocompletion_on_defined_variables.js; r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Mon, 13 Aug 2018 08:39:16 +0000 - rev 828739
Push 118704 by bmo:rcaliman@mozilla.com at Mon, 13 Aug 2018 16:58:07 +0000
Bug 1479521 - Remove browser_jsterm_no_autocompletion_on_defined_variables.js; r=Honza. The test wasn't doing what it was supposed to do (there was definitely an autocomplete text displayed, we were not waiting properly for it.). Also, the original issue with this was that that an unwanted token was entered instead of the one the user wanted (user generated). Maybe at that time the autocomplete did not contained user defined variables, but now we do, and we are testing that in other tests. Depends on D2824 Differential Revision: https://phabricator.services.mozilla.com/D2825
9838d4b3680d806475d4ae6dbbf9410e6be991da: Bug 1479521 - Refactor JsTerm autocompletion behavior; r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Mon, 13 Aug 2018 10:07:15 +0000 - rev 828738
Push 118704 by bmo:rcaliman@mozilla.com at Mon, 13 Aug 2018 16:58:07 +0000
Bug 1479521 - Refactor JsTerm autocompletion behavior; r=Honza. We used to rely on different things to both display the autocompletion text and accept an autocompletion. This patches introduces new helper functions in order to make the code more easy to reason about. We also rollback our decision to show the popup when there is only 1 item in the autocompletion list in order to be more consistent with what Chrome does. Differential Revision: https://phabricator.services.mozilla.com/D2824
d2d335ca743b25de0e9b6a103828d4ce0a20aab1: Bug 1482826 - Fix DAMP autocomplete test; r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Mon, 13 Aug 2018 10:07:18 +0000 - rev 828736
Push 118704 by bmo:rcaliman@mozilla.com at Mon, 13 Aug 2018 16:58:07 +0000
Bug 1482826 - Fix DAMP autocomplete test; r=Honza. We can now simply call setInputValue and the autocompletion will happen. Since we are forcing the call to jsterm.complete, there were 2 calls made to the server, making the measurements in the test erroneous. This also revealed a race in setInputValue: the text was set by codeMirror before the cursor was actually moved. Which means we were sending an erroneous autocompletion query to the server. We use codeMirror.operation to tell codeMirror to both set the text and the cursor in a single operation. Differential Revision: https://phabricator.services.mozilla.com/D3192
3b4079e158a715f799293acd4ef30a51ea0c6ad6: Bug 1467572 - Part 15: Fix unit tests for RDM to work with the new RDM design. r=Honza draft
Gabriel Luong <gabriel.luong@gmail.com> - Sat, 11 Aug 2018 16:06:05 -0400 - rev 828620
Push 118683 by bmo:gl@mozilla.com at Sat, 11 Aug 2018 20:18:50 +0000
Bug 1467572 - Part 15: Fix unit tests for RDM to work with the new RDM design. r=Honza - Various element IDs and strings were renamed in the preceeding patches before this. This fixes the strings and element ID reference in the RDM unit tests. - Fixed RDM unit tests to work with new native context menu which used to be <select> elements. MozReview-Commit-ID: 1mOKEHAodjL
cdaf4748bb8c14f436a2ca7f5acdd0325bf23830: Bug 1467572 - Part 12: Use native context menu instead of select element in the Device selector. r=Honza draft
Gabriel Luong <gabriel.luong@gmail.com> - Sat, 11 Aug 2018 16:06:04 -0400 - rev 828617
Push 118683 by bmo:gl@mozilla.com at Sat, 11 Aug 2018 20:18:50 +0000
Bug 1467572 - Part 12: Use native context menu instead of select element in the Device selector. r=Honza - Removes all the unused styling for the <select> and <option> elements and the toolbar-dropdown class. MozReview-Commit-ID: DGLwtNVVlQd
d65ec212a3d45fc2f16c5139b215e6f646a9817c: Bug 1467572 - Part 11: Use native context menu instead of select elements in the DPR menu. r=Honza draft
Gabriel Luong <gabriel.luong@gmail.com> - Sat, 11 Aug 2018 16:06:04 -0400 - rev 828616
Push 118683 by bmo:gl@mozilla.com at Sat, 11 Aug 2018 20:18:50 +0000
Bug 1467572 - Part 11: Use native context menu instead of select elements in the DPR menu. r=Honza MozReview-Commit-ID: F6RyVrzodKo
ad1866f2e3077a47e98a4c959bf75b96e82f54b5: Bug 1467572 - Part 10: Reuse the network throttling menu in the network monitor in RDM. r=Honza draft
Gabriel Luong <gabriel.luong@gmail.com> - Sat, 11 Aug 2018 16:06:04 -0400 - rev 828615
Push 118683 by bmo:gl@mozilla.com at Sat, 11 Aug 2018 20:18:50 +0000
Bug 1467572 - Part 10: Reuse the network throttling menu in the network monitor in RDM. r=Honza - Removes the duplicate dropdown arrow icon that is used in both RDM and Network monitor - Converts the network throttling menu in the network monitor to be a shared component that can be used in both RDM and network monitor - Move the common styles for the dropdown menu button into toolbars.css MozReview-Commit-ID: KvyjUDXirjy
7a4f7c067b26a286dcfe63f7c6aa76bfa6fa0d0b: Bug 1467572 - Part 9: Use native context menu instead of select elements in the reload condition menu of RDM. r=Honza draft
Gabriel Luong <gabriel.luong@gmail.com> - Sat, 11 Aug 2018 16:06:04 -0400 - rev 828614
Push 118683 by bmo:gl@mozilla.com at Sat, 11 Aug 2018 20:18:50 +0000
Bug 1467572 - Part 9: Use native context menu instead of select elements in the reload condition menu of RDM. r=Honza - Converts the reload condition <select> to use native context menu - Converts the showMenu util to be reusable by both RDM and the Network Monitor - Renames getToplevelWindow to getTopLevelWindow - Renames the reload condition menu to be a setting menu in RDM according to the designs - Uses the new photon setting icon in RDM MozReview-Commit-ID: LI6bcoqvT9i
ce455e421b0b4656a66dca47b004ba61669ba022: Bug 1479521 - Only run browser_jsterm_accessibility.js with old jsterm; r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Fri, 10 Aug 2018 11:41:20 +0000 - rev 828512
Push 118683 by bmo:gl@mozilla.com at Sat, 11 Aug 2018 20:18:50 +0000
Bug 1479521 - Only run browser_jsterm_accessibility.js with old jsterm; r=Honza. Depends on D2826 Differential Revision: https://phabricator.services.mozilla.com/D2827
618fe87eb9f0f55f7b9e35d2fcb7e69649e9fb4b: Bug 1479521 - Update tests to match the new jsterm behavior; r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Fri, 10 Aug 2018 16:48:38 +0000 - rev 828511
Push 118683 by bmo:gl@mozilla.com at Sat, 11 Aug 2018 20:18:50 +0000
Bug 1479521 - Update tests to match the new jsterm behavior; r=Honza. Some test were relying on the existence of the complete function and were using it in order to do integration test. We modify those and instead trigger real user interaction for making those assertions. Additional test cases are added to the test files they fit in so we have a broader coverage of user interaction in regard to autocompletion. Depends on D2825 Differential Revision: https://phabricator.services.mozilla.com/D2826
67fc7d23d665f175f6f61448a5afbbb9f712395b: Bug 1479521 - Remove browser_jsterm_no_autocompletion_on_defined_variables.js; r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Fri, 10 Aug 2018 11:28:48 +0000 - rev 828510
Push 118683 by bmo:gl@mozilla.com at Sat, 11 Aug 2018 20:18:50 +0000
Bug 1479521 - Remove browser_jsterm_no_autocompletion_on_defined_variables.js; r=Honza. The test wasn't doing what it was supposed to do (there was definitely an autocomplete text displayed, we were not waiting properly for it.). Also, the original issue with this was that that an unwanted token was entered instead of the one the user wanted (user generated). Maybe at that time the autocomplete did not contained user defined variables, but now we do, and we are testing that in other tests. Depends on D2824 Differential Revision: https://phabricator.services.mozilla.com/D2825
39c853b19002e947f3b3b0dd93f50ebd37186f4e: Bug 1479521 - Refactor JsTerm autocompletion behavior; r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Fri, 10 Aug 2018 16:28:55 +0000 - rev 828509
Push 118683 by bmo:gl@mozilla.com at Sat, 11 Aug 2018 20:18:50 +0000
Bug 1479521 - Refactor JsTerm autocompletion behavior; r=Honza. We used to rely on different things to both display the autocompletion text and accept an autocompletion. This patches introduces new helper functions in order to make the code more easy to reason about. We also rollback our decision to show the popup when there is only 1 item in the autocompletion list in order to be more consistent with what Chrome does. Differential Revision: https://phabricator.services.mozilla.com/D2824
84038cfbf8dbe01a4c861ca8ab0b08c6a0c4a43f: Bug 1467572 - Part 15: Fix unit tests for RDM to work with the new RDM design. r=Honza draft
Gabriel Luong <gabriel.luong@gmail.com> - Fri, 10 Aug 2018 16:04:33 -0400 - rev 828373
Push 118677 by bmo:gl@mozilla.com at Fri, 10 Aug 2018 20:59:19 +0000
Bug 1467572 - Part 15: Fix unit tests for RDM to work with the new RDM design. r=Honza - Various element IDs and strings were renamed in the preceeding patches before this. This fixes the strings and element ID reference in the RDM unit tests. - Fixed RDM unit tests to work with new native context menu which used to be <select> elements. MozReview-Commit-ID: JSak9K9YCRL
8debfa32ed7e68304e9261d120007a240c199d51: Bug 1467572 - Part 12: Use native context menu instead of select element in the Device selector. r=Honza draft
Gabriel Luong <gabriel.luong@gmail.com> - Fri, 10 Aug 2018 16:04:33 -0400 - rev 828370
Push 118677 by bmo:gl@mozilla.com at Fri, 10 Aug 2018 20:59:19 +0000
Bug 1467572 - Part 12: Use native context menu instead of select element in the Device selector. r=Honza - Removes all the unused styling for the <select> and <option> elements and the toolbar-dropdown class. MozReview-Commit-ID: InrQ3KjqEMI
a8f5c0210a749b605ac8b70d73732c8805435314: Bug 1467572 - Part 11: Use native context menu instead of select elements in the DPR menu. r=Honza draft
Gabriel Luong <gabriel.luong@gmail.com> - Fri, 10 Aug 2018 16:04:32 -0400 - rev 828369
Push 118677 by bmo:gl@mozilla.com at Fri, 10 Aug 2018 20:59:19 +0000
Bug 1467572 - Part 11: Use native context menu instead of select elements in the DPR menu. r=Honza MozReview-Commit-ID: 41N5YaSgE7q
c356e2decb2ae402334bb04c20c9ceadd5c80427: Bug 1467572 - Part 10: Reuse the network throttling menu in the network monitor in RDM. r=Honza draft
Gabriel Luong <gabriel.luong@gmail.com> - Fri, 10 Aug 2018 16:04:32 -0400 - rev 828368
Push 118677 by bmo:gl@mozilla.com at Fri, 10 Aug 2018 20:59:19 +0000
Bug 1467572 - Part 10: Reuse the network throttling menu in the network monitor in RDM. r=Honza - Removes the duplicate dropdown arrow icon that is used in both RDM and Network monitor - Converts the network throttling menu in the network monitor to be a shared component that can be used in both RDM and network monitor - Move the common styles for the dropdown menu button into toolbars.css MozReview-Commit-ID: J3E2P5zNlhm
8ea637e1dca093ea3b4ddc179882b007b5a1f11e: Bug 1467572 - Part 9: Use native context menu instead of select elements in the reload condition menu of RDM. r=Honza draft
Gabriel Luong <gabriel.luong@gmail.com> - Fri, 10 Aug 2018 16:04:32 -0400 - rev 828367
Push 118677 by bmo:gl@mozilla.com at Fri, 10 Aug 2018 20:59:19 +0000
Bug 1467572 - Part 9: Use native context menu instead of select elements in the reload condition menu of RDM. r=Honza - Converts the reload condition <select> to use native context menu - Converts the showMenu util to be reusable by both RDM and the Network Monitor - Renames getToplevelWindow to getTopLevelWindow - Renames the reload condition menu to be a setting menu in RDM according to the designs - Uses the new photon setting icon in RDM MozReview-Commit-ID: 99puSAZRBBW