ff5f08b322cba975d55d95bbed83ff751cb7a9df: Automatic version bump CLOSED TREE NO BUG a=release
Mihai Tabara <mtabara@mozilla.com> - Tue, 26 Jun 2018 17:42:45 +0300 - rev 817740
Push
116155 by bmo:jacek@codeweavers.com at Fri, 13 Jul 2018 12:18:34 +0000
Automatic version bump CLOSED TREE NO BUG a=release
f5d910003349dc82145a16ca59de7800423180ae: No bug - Tagging 4ad4c31db9b1526aab8641be98fec8e0d63a4a7e with FIREFOX_60_1_0esr_BUILD2, FIREFOX_60_1_0esr_RELEASE a=release CLOSED TREE
Mihai Tabara <mtabara@mozilla.com> - Tue, 26 Jun 2018 17:32:05 +0300 - rev 817739
Push
116155 by bmo:jacek@codeweavers.com at Fri, 13 Jul 2018 12:18:34 +0000
No bug - Tagging 4ad4c31db9b1526aab8641be98fec8e0d63a4a7e with FIREFOX_60_1_0esr_BUILD2, FIREFOX_60_1_0esr_RELEASE a=release CLOSED TREE
a770a41395855421b7592205baa055d1b3a6c416: Bug 1473513 - create LazyActorClass based off ObservedActorFactory and RegisterdFactory classes for use in RootActor and BrowsingContextActor; r=ochameau
draft
yulia <ystartsev@mozilla.com> - Wed, 11 Jul 2018 18:34:22 +0200 - rev 817738
Push
116154 by bmo:ystartsev@mozilla.com at Fri, 13 Jul 2018 12:05:03 +0000
Bug 1473513 - create LazyActorClass based off ObservedActorFactory and RegisterdFactory classes for use in RootActor and BrowsingContextActor; r=ochameau
MozReview-Commit-ID: LRuhNzBLrZh
8d70cbfad6e7ba41f131e0bfc35eba26c04282a1: Bug 1473513 - create LazyActorClass based off ObservedActorFactory and RegisterdFactory classes for use in RootActor and BrowsingContextActor; r=ochameau
draft
yulia <ystartsev@mozilla.com> - Wed, 11 Jul 2018 18:34:22 +0200 - rev 817737
Push
116153 by bmo:ystartsev@mozilla.com at Fri, 13 Jul 2018 12:00:27 +0000
Bug 1473513 - create LazyActorClass based off ObservedActorFactory and RegisterdFactory classes for use in RootActor and BrowsingContextActor; r=ochameau
MozReview-Commit-ID: LRuhNzBLrZh
dee1945e42d44fa5d963356a94aec2a95104a208: Bug 1475461 - part 2: Make callers of PLDHashTable::Search() const methods if possible r?ehsan
draft
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 13 Jul 2018 19:01:53 +0900 - rev 817736
Push
116152 by masayuki@d-toybox.com at Fri, 13 Jul 2018 11:42:50 +0000
Bug 1475461 - part 2: Make callers of PLDHashTable::Search() const methods if possible r?ehsan
Some callers of PLDHashTable::Search() use const_cast, some others are not
const methods due to non-const PLDHashTable::Search().
This patch removes const_cast from the former and mark some methods of the
latter const.
MozReview-Commit-ID: C8ayoi7mXc1
b32f7a1e75bb7d39a934847ff556692d30fbbdae: Bug 1475461 - part 1: Mark PLDHashTable::Search() and called by it as const r?ehsan
draft
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 13 Jul 2018 16:56:29 +0900 - rev 817735
Push
116152 by masayuki@d-toybox.com at Fri, 13 Jul 2018 11:42:50 +0000
Bug 1475461 - part 1: Mark PLDHashTable::Search() and called by it as const r?ehsan
PLDHashTable::Search() does not modify any members. So, this method and
methods called by it should be marked as const.
MozReview-Commit-ID: 6g4jrYK1j9E
af4202a61c3b8caebf6210402712b577151f9486: Bug 1475153 - Make TSFTextStore::RecordCompositionStartAction() merge new composition with previous composition if IME commits composition and restart composition to replace the previous commit string r?m_kato
draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 12 Jul 2018 22:40:07 +0900 - rev 817734
Push
116152 by masayuki@d-toybox.com at Fri, 13 Jul 2018 11:42:50 +0000
Bug 1475153 - Make TSFTextStore::RecordCompositionStartAction() merge new composition with previous composition if IME commits composition and restart composition to replace the previous commit string r?m_kato
When user removes all composition string of MS Pinyin, MS Wubi, MS ChangJie and
MS Quick with Backspace key, IME commits last character temporarily and
restart composition to replace the last character with empty string when
user tries to remove last one character.
This causes flicking composition string because the additional composition
selects the character and it may be painted immediately before removed, and
also editor will have unnecessary undo transaction.
Therefore, as same as
bug 1208043, TSFTextStore::RecordCompositionStartAction()
should restart last composition in such case. Fortunately, we implemented
similar code for
bug 1208043, however, unfortunately, we don't have preceding
pending compositionstart in this case. Therefore, this patch makes
pending compositionend store start offset of composition. Then, we can
restart composition only with information stored by pending compositionend
action. Additionally, this patch renames the method checking pending
actions for self-describing the new meaning.
MozReview-Commit-ID: 1RyuacxEbky
fdecc491e2ba106daaa2e469180d162e976c371d: Bug 1462257 - TextComposition should dispatch eCompositionChange event when eCompositionCommit is being fired immediately after eCompositionStart r?m_kato
draft
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 11 Jul 2018 23:05:39 +0900 - rev 817733
Push
116152 by masayuki@d-toybox.com at Fri, 13 Jul 2018 11:42:50 +0000
Bug 1462257 - TextComposition should dispatch eCompositionChange event when eCompositionCommit is being fired immediately after eCompositionStart r?m_kato
TextEditor modifies composition string or selected string when first
eCompositionChange event is received. However, TextComposition dispatches
eCompositionChange event ("text" event of DOM) only when composition string
becomes non-empty if current composition string is empty. So, when IME
dispatches only eCompositionStart and eCompositionCommit events for removing
selected text, TextEditor does nothing. This hacky behavior is used by
MS Pinyin on Windows 10 at least.
For supporting this behavior, we need to make TextComposition dispatch
eCompositionChange event when eCompositionChange(AsIs) event is fired
even before dispatching eCompositionChange event.
Although from point of view of web apps, the hacky composition should be
merged into the previous composition if it's possible but it's out of scope
of this bug.
MozReview-Commit-ID: 7QfeBJamGTU
9b67bcfc703b1d10765b074ef3761714673d5f74: Bug 1399126 - Make nsWindow for Windows not notify widget listener of activated/inactivated if active window is changed from/to popup window r?jimm
draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 10 Jul 2018 21:24:06 +0900 - rev 817732
Push
116152 by masayuki@d-toybox.com at Fri, 13 Jul 2018 11:42:50 +0000
Bug 1399126 - Make nsWindow for Windows not notify widget listener of activated/inactivated if active window is changed from/to popup window r?jimm
Some odd mouse drivers try to activate a window which the mouse driver wants to
scroll its content (such window is typically under the mouse cursor when mouse
wheel is turned). However, this is illegal behavior and such odd mouse drivers
try to activate our popup windows which won't be activated without such apps.
We prevented this odd focus behavior with fixing of
bug 953146. However, it
did NOT stop notifying widget listener of activating nor inactivating the
windows. Therefore, that caused a lot of reflow for supporting
-moz-window-inactive pseudo class.
This patch makes nsWindow::DealWithPopups() consume WM_ACTIVATE message before
nsWindow::ProcessMessage() because nsWindow::ProcessMessage() notifies widget
listener of activating and inactivating window even when focus move from and to
our popup window. So, in other words, this patch stops notifying widget
listener of activating and inactivating window when focus moves from/to
a popup window.
MozReview-Commit-ID: 2dyq07zHZKp
fd398d689bff3e1a5a2ab3ba762a2eb4236cea1f: Bug 1450882 - part 4: Make C++ users of nsICommandParams use nsCommandParams directly r?ehsan
draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 10 Jul 2018 20:04:21 +0900 - rev 817731
Push
116152 by masayuki@d-toybox.com at Fri, 13 Jul 2018 11:42:50 +0000
Bug 1450882 - part 4: Make C++ users of nsICommandParams use nsCommandParams directly r?ehsan
nsICommandParams is implemented only by nsCommandParams. So, all C++ users
can treat all instances of nsICommandParams as nsCommandParams. Therefore,
this patch makes all set/get value calls use non-virtual methods and all
constructors directly create nsCommandParams instance.
MozReview-Commit-ID: CscgK0gKp5g
61e78a2937e58bb1d9fbc4218a35d1875c242cb1: Bug 1450882 - part 3: Create non-virtual methods to nsCommandParams and expose its header r?ehsan
draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 10 Jul 2018 18:48:43 +0900 - rev 817730
Push
116152 by masayuki@d-toybox.com at Fri, 13 Jul 2018 11:42:50 +0000
Bug 1450882 - part 3: Create non-virtual methods to nsCommandParams and expose its header r?ehsan
nsCommandParams is used internally but accessed via nsICommandParams. For
such internal users, nsCommandParams should have non-virtual methods to
get/set values.
The new method names are similar to Preferences API for consistency with it.
MozReview-Commit-ID: FJwWMFzV9w
b88ed9efd16d2ead93396c66eaf205295b3f923d: Bug 1450882 - part 2: Make nsICommandParams::GetCStringValue() and nsICommandParams::SetCStringValue() treat nsACString instead of char r?ehsan
draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 10 Jul 2018 18:04:46 +0900 - rev 817729
Push
116152 by masayuki@d-toybox.com at Fri, 13 Jul 2018 11:42:50 +0000
Bug 1450882 - part 2: Make nsICommandParams::GetCStringValue() and nsICommandParams::SetCStringValue() treat nsACString instead of char r?ehsan
nsICommandParams::GetCStringValue() and nsICommandParams::SetCStringValue()
treat char. However, this makes their callers complicated. So, they should
be rewritten as treating nsACString.
MozReview-Commit-ID: DWO9veSyzyG
6d93793b56508954b74bf467396e43efcf9d8f9a: Bug 1450882 - part 1: Make nsICommandParams builtinclass r?ehsan
draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 10 Jul 2018 16:50:44 +0900 - rev 817728
Push
116152 by masayuki@d-toybox.com at Fri, 13 Jul 2018 11:42:50 +0000
Bug 1450882 - part 1: Make nsICommandParams builtinclass r?ehsan
nsICommandParams is not implemented with JS. Therefore, we can make it
builtinclass.
MozReview-Commit-ID: Gutw79akyaJ
d2a787ce12be5a0e65de9315ebbb291536e6bf0a: Bug 1475515 - Remove member initialization for union Extra::mMessage. r?bz
draft
Andi-Bogdan Postelnicu <bpostelnicu@mozilla.com> - Fri, 13 Jul 2018 14:39:12 +0300 - rev 817727
Push
116151 by bmo:bpostelnicu@mozilla.com at Fri, 13 Jul 2018 11:41:25 +0000
Bug 1475515 - Remove member initialization for union Extra::mMessage. r?bz
MozReview-Commit-ID: GgJyXg5KxQm
44327808bb83bd2e4100955bb44e5ae7aa6c2779: Bug 1475515 - Remove member initialization for union Extra::mMessage. r?bz
draft
Andi-Bogdan Postelnicu <bpostelnicu@mozilla.com> - Fri, 13 Jul 2018 14:39:12 +0300 - rev 817726
Push
116150 by bmo:bpostelnicu@mozilla.com at Fri, 13 Jul 2018 11:40:25 +0000
Bug 1475515 - Remove member initialization for union Extra::mMessage. r?bz
MozReview-Commit-ID: GgJyXg5KxQm
83aecdb2656b372b7b7bb35014f9f35e22043872: Bug 1463860 - Don't play a beep when the find string is not find when Whole Word matching is enabled; it simply beeps too much. r?ehsan
draft bug-1463860
Mike de Boer <mdeboer@mozilla.com> - Fri, 13 Jul 2018 13:25:02 +0200 - rev 817725
Push
116149 by mdeboer@mozilla.com at Fri, 13 Jul 2018 11:25:45 +0000
Bug 1463860 - Don't play a beep when the find string is not find when Whole Word matching is enabled; it simply beeps too much. r?ehsan
MozReview-Commit-ID: S6dvbV5Q5d
ed68a42fffb0641e3c5506d8acfc06cf1801949a: Bug 1475509 - Stop setting custom text selection styles on dark/light themes. r=dao
draft
Tim Nguyen <ntim.bugs@gmail.com> - Fri, 13 Jul 2018 12:20:18 +0100 - rev 817724
Push
116148 by bmo:ntim.bugs@gmail.com at Fri, 13 Jul 2018 11:20:56 +0000
Bug 1475509 - Stop setting custom text selection styles on dark/light themes. r=dao
MozReview-Commit-ID: 62YSwEYOn6X
ef56de523c110b29c336e1b157dd89c4f5493e6b: Backed out changeset 16e2aaf4043c (bug 1474940) for causing crashes on crashtests/1393272.webm
Cosmin Sabou <csabou@mozilla.com> - Fri, 13 Jul 2018 14:13:05 +0300 - rev 817723
Push
116148 by bmo:ntim.bugs@gmail.com at Fri, 13 Jul 2018 11:20:56 +0000
Backed out changeset 16e2aaf4043c (
bug 1474940) for causing crashes on crashtests/1393272.webm
6c91bb87806ba149d9e9982c6065fef60cb1cb1e: Backed out 2 changesets (bug 1474722) for causing multiple mochitest failures on several files. CLOSED TREE
Cosmin Sabou <csabou@mozilla.com> - Fri, 13 Jul 2018 13:10:56 +0300 - rev 817722
Push
116148 by bmo:ntim.bugs@gmail.com at Fri, 13 Jul 2018 11:20:56 +0000
Backed out 2 changesets (
bug 1474722) for causing multiple mochitest failures on several files. CLOSED TREE
Backed out changeset 68019e52d1b9 (
bug 1474722)
Backed out changeset 77597cd3461c (
bug 1474722)
bbca8d90968e7c82f084e89385509bfde123e9ff: Bug 1475189 - Block storage access in tracking sub-resources when not in iframes - part 3 - image cache, r=ehsan
Andrea Marchesini <amarchesini@mozilla.com> - Fri, 13 Jul 2018 12:02:19 +0200 - rev 817721
Push
116148 by bmo:ntim.bugs@gmail.com at Fri, 13 Jul 2018 11:20:56 +0000
Bug 1475189 - Block storage access in tracking sub-resources when not in iframes - part 3 - image cache, r=ehsan