feaacb78a655de78b106c8b1fcd6f5ad6af9c5e7: Bug 1387143 part 21. Remove nsISelection getters for anchor and focus points. r=mats
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 08 May 2018 13:52:38 -0400 - rev 792779
Push 109185 by maglione.k@gmail.com at Tue, 08 May 2018 21:28:15 +0000
Bug 1387143 part 21. Remove nsISelection getters for anchor and focus points. r=mats Instead of copying spec-duplicating comments from nsISelection.idl to Selection.webidl, this just points the latter to the right spec.
7fc2c97cc372ee868693db92409de6571af4f59f: Bug 1387143 part 20. Remove nsISelectionPrivate. r=mats
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 08 May 2018 13:52:38 -0400 - rev 792778
Push 109185 by maglione.k@gmail.com at Tue, 08 May 2018 21:28:15 +0000
Bug 1387143 part 20. Remove nsISelectionPrivate. r=mats
a80dee62407afee16adf2b8093eb468f262cbe68: Bug 1387143 part 19. Remove remaining methods from nsISelectionPrivate. r=mats
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 08 May 2018 13:52:38 -0400 - rev 792777
Push 109185 by maglione.k@gmail.com at Tue, 08 May 2018 21:28:15 +0000
Bug 1387143 part 19. Remove remaining methods from nsISelectionPrivate. r=mats
aa7dc2628f1213f6fb3fb3b45dc681ae7b79abcb: Bug 1387143 part 18. Remove ScrollIntoView bits from nsISelectionPrivate. r=mats
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 08 May 2018 13:52:38 -0400 - rev 792776
Push 109185 by maglione.k@gmail.com at Tue, 08 May 2018 21:28:15 +0000
Bug 1387143 part 18. Remove ScrollIntoView bits from nsISelectionPrivate. r=mats
146396f37e7d030a5b4fb904dc9ccf885f75e252: Bug 1387143 part 17. Remove GetRangesForInterval bits from nsISelectionPrivate. r=mats
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 08 May 2018 13:52:38 -0400 - rev 792775
Push 109185 by maglione.k@gmail.com at Tue, 08 May 2018 21:28:15 +0000
Bug 1387143 part 17. Remove GetRangesForInterval bits from nsISelectionPrivate. r=mats
db8412ba88f25342985edf421e63d09c2428a6ab: Bug 1387143 part 16. Remove nsISelectionPrivate::GetType. r=mats
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 08 May 2018 13:52:38 -0400 - rev 792774
Push 109185 by maglione.k@gmail.com at Tue, 08 May 2018 21:28:15 +0000
Bug 1387143 part 16. Remove nsISelectionPrivate::GetType. r=mats
4d6054f4b7e9494ce6a57c365a4565bd69ab1ad4: Bug 1387143 part 15. Remove nsISelectionPrivate::Get/SetSelectionDirection. r=mats
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 08 May 2018 13:52:38 -0400 - rev 792773
Push 109185 by maglione.k@gmail.com at Tue, 08 May 2018 21:28:15 +0000
Bug 1387143 part 15. Remove nsISelectionPrivate::Get/SetSelectionDirection. r=mats
8bd354b5a5915bf0680ef62a866b1ae96e31a004: Bug 1387143 part 14. Remove nsISelectionPrivate::GetCachedFrameOffset. r=mats.
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 08 May 2018 13:52:37 -0400 - rev 792772
Push 109185 by maglione.k@gmail.com at Tue, 08 May 2018 21:28:15 +0000
Bug 1387143 part 14. Remove nsISelectionPrivate::GetCachedFrameOffset. r=mats.
0cc853cc9de3e34e590cb8f58faeb44578a8084e: Bug 1387143 part 13. Remove nsISelectionPrivate::Get/SetCanCacheFrameOffset. r=mats
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 08 May 2018 13:52:37 -0400 - rev 792771
Push 109185 by maglione.k@gmail.com at Tue, 08 May 2018 21:28:15 +0000
Bug 1387143 part 13. Remove nsISelectionPrivate::Get/SetCanCacheFrameOffset. r=mats
70603ce0a11e5aebf35ba69b6b0d92b900525b81: Bug 1387143 part 12. Remove nsISelectionPrivate::Add/RemoveSelectionListener. r=mats
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 08 May 2018 13:52:37 -0400 - rev 792770
Push 109185 by maglione.k@gmail.com at Tue, 08 May 2018 21:28:15 +0000
Bug 1387143 part 12. Remove nsISelectionPrivate::Add/RemoveSelectionListener. r=mats None of the C++ callers of RemoveSelectionListener care about whether the listener was already-added, and the only JS caller is in a test and knows the listener was added. So the behavior change to no-op instead of throwing when trying to remove a nonexistent listener is OK. Furthermore, the removal is null-safe, so there's no point to explicitly failing if null is passed (which it never is). Since content can't directly add selection listeners, we can just use an infallible append instead of returning errors callers don't check for anyway. Also, no one passes null to AddSelectionListener, so we don't have to worry about that part.
dd568f984ca5b3e34d2f5dfc24f6ebfb8b76f941: Bug 1387143 part 11. Support non-XPCOM weakreference on Selection. r=mats
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 08 May 2018 13:52:37 -0400 - rev 792769
Push 109185 by maglione.k@gmail.com at Tue, 08 May 2018 21:28:15 +0000
Bug 1387143 part 11. Support non-XPCOM weakreference on Selection. r=mats This way we don't have to deal with QI to get a Selection out of a weakref. mfbt weakrefs don't have a SizeOfOnlyThis. In any case, the memory used by the weakref itself is pretty minor...
560215a5ceda5097e64fed8b9b544ce700e1807f: Bug 1387143 part 10. Remove toString bits from nsISelection and nsISelectionPrivate. r=mats.
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 08 May 2018 13:52:37 -0400 - rev 792768
Push 109185 by maglione.k@gmail.com at Tue, 08 May 2018 21:28:15 +0000
Bug 1387143 part 10. Remove toString bits from nsISelection and nsISelectionPrivate. r=mats.
26a0de789a136f820e45d1eaaf0521b4fd74efbf: Bug 1387143 part 9. Remove nsISelectionPrivate::Get/SetAncestorLimiter. r=mats
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 08 May 2018 13:52:37 -0400 - rev 792767
Push 109185 by maglione.k@gmail.com at Tue, 08 May 2018 21:28:15 +0000
Bug 1387143 part 9. Remove nsISelectionPrivate::Get/SetAncestorLimiter. r=mats
89f2f9869b1a720152890ae2e6f759f58e6b6ac0: Bug 1387143 part 8. Remove nsISelectionPrivate::Get/SetInterlinePosition. r=mats
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 08 May 2018 13:52:37 -0400 - rev 792766
Push 109185 by maglione.k@gmail.com at Tue, 08 May 2018 21:28:15 +0000
Bug 1387143 part 8. Remove nsISelectionPrivate::Get/SetInterlinePosition. r=mats
bb9383d7bde7cb642757aa9b2c244fbac341ef71: Bug 1387143 part 7. Move the TABLESELECTION_* constants from nsISelectionPrivate to a TableSelection enum. r=mats
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 08 May 2018 13:52:36 -0400 - rev 792765
Push 109185 by maglione.k@gmail.com at Tue, 08 May 2018 21:28:15 +0000
Bug 1387143 part 7. Move the TABLESELECTION_* constants from nsISelectionPrivate to a TableSelection enum. r=mats
dd98009e26447ff332574207efa009c10ce2cb6d: Bug 1387143 part 6. Remove some unused constants from nsISelectionPrivate and Selection. r=mats
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 08 May 2018 13:52:36 -0400 - rev 792764
Push 109185 by maglione.k@gmail.com at Tue, 08 May 2018 21:28:15 +0000
Bug 1387143 part 6. Remove some unused constants from nsISelectionPrivate and Selection. r=mats
fe33adcc329269c15e486d32bcf472e96e647c63: Bug 1387143 part 5. Remove JS use of nsISelectionPrivate. r=mats
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 08 May 2018 13:52:36 -0400 - rev 792763
Push 109185 by maglione.k@gmail.com at Tue, 08 May 2018 21:28:15 +0000
Bug 1387143 part 5. Remove JS use of nsISelectionPrivate. r=mats
0328bcd0039ec3be9de874d7c0ff3e72a833e899: Bug 1387143 part 4. Stop using nsISelection in remaining xpidl. r=mats
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 08 May 2018 13:52:36 -0400 - rev 792762
Push 109185 by maglione.k@gmail.com at Tue, 08 May 2018 21:28:15 +0000
Bug 1387143 part 4. Stop using nsISelection in remaining xpidl. r=mats
a42b86ea3a3b14ae7f90b587491227efb270d45a: Bug 1387143 part 3. Stop using nsISelection in nsISelectionController. r=mats
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 08 May 2018 13:52:36 -0400 - rev 792761
Push 109185 by maglione.k@gmail.com at Tue, 08 May 2018 21:28:15 +0000
Bug 1387143 part 3. Stop using nsISelection in nsISelectionController. r=mats
ec666bcb050bb9e469ea6616d88307977efda081: Bug 1387143 part 2. Stop using nsISelection in nsIDocumentEncoder. r=mats
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 08 May 2018 13:52:36 -0400 - rev 792760
Push 109185 by maglione.k@gmail.com at Tue, 08 May 2018 21:28:15 +0000
Bug 1387143 part 2. Stop using nsISelection in nsIDocumentEncoder. r=mats
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip