fe2ccd9e0ce36b610407037ce27a4540c0e3a2f9: Bug 1278748 - part2 : correct default value of webidl's property. draft
Alastor Wu <alwu@mozilla.com> - Tue, 05 Jul 2016 15:08:50 +0800 - rev 383969
Push 22139 by alwu@mozilla.com at Tue, 05 Jul 2016 11:21:07 +0000
Bug 1278748 - part2 : correct default value of webidl's property. Line default value : https://w3c.github.io/webvtt/#webvtt-cue-line Position default value : https://w3c.github.io/webvtt/#webvtt-cue-position MozReview-Commit-ID: 7S5EXlU2qRF
cf997bd1ba9f85605a78f19d58394a116729098e: Bug 1278748 - part1 : cue's attribute can be set multiple times. draft
Alastor Wu <alwu@mozilla.com> - Tue, 05 Jul 2016 15:08:42 +0800 - rev 383968
Push 22139 by alwu@mozilla.com at Tue, 05 Jul 2016 11:21:07 +0000
Bug 1278748 - part1 : cue's attribute can be set multiple times. MozReview-Commit-ID: CqM5vbXwO78
c59396417c172f394de5658378bed1f876473885: Bug 1284422 part.11 Remove "IMS: " and "IMEStateManager::" from log of IMEStateManager.cpp r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 05 Jul 2016 19:05:23 +0900 - rev 383967
Push 22138 by masayuki@d-toybox.com at Tue, 05 Jul 2016 11:19:36 +0000
Bug 1284422 part.11 Remove "IMS: " and "IMEStateManager::" from log of IMEStateManager.cpp r?m_kato MozReview-Commit-ID: K5PwEiHTJQX
316fc3d92e543a10ee61a4545fa40894dc717a8f: Bug 1284422 part.10 Remove "IMCO: " from log of IMEContentObserver.cpp r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 05 Jul 2016 18:58:16 +0900 - rev 383966
Push 22138 by masayuki@d-toybox.com at Tue, 05 Jul 2016 11:19:36 +0000
Bug 1284422 part.10 Remove "IMCO: " from log of IMEContentObserver.cpp r?m_kato MozReview-Commit-ID: Ko7MpkeZ27K
a761ce63239993aae8d47a4cca3ffe63954d2785: Bug 1284422 part.9 Remove "ContentCache(InParent|InChild)?: " from log of ContentCache.cpp since the classes are not in same process under current designr?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 05 Jul 2016 18:56:18 +0900 - rev 383965
Push 22138 by masayuki@d-toybox.com at Tue, 05 Jul 2016 11:19:36 +0000
Bug 1284422 part.9 Remove "ContentCache(InParent|InChild)?: " from log of ContentCache.cpp since the classes are not in same process under current designr?m_kato MozReview-Commit-ID: LwDBBwfkZKx
ee4f065ea52566860ad750593b9a3dfe23988692: Bug 1284422 part.8 Fix odd indent of MOZ_LOG() in nsGtkKeyUtils.cpp (mainly caused by replacing from PR_LOG()) r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 05 Jul 2016 18:50:02 +0900 - rev 383964
Push 22138 by masayuki@d-toybox.com at Tue, 05 Jul 2016 11:19:36 +0000
Bug 1284422 part.8 Fix odd indent of MOZ_LOG() in nsGtkKeyUtils.cpp (mainly caused by replacing from PR_LOG()) r?m_kato MozReview-Commit-ID: KOOeJeKiBAF
e4ac158ae5e387925cd504be2bccce46360a1418: Bug 1284422 part.7 Replace "KeymapWrapper(%p): " with "%p " in nsGtkKeyUtils.cpp r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 05 Jul 2016 18:48:12 +0900 - rev 383963
Push 22138 by masayuki@d-toybox.com at Tue, 05 Jul 2016 11:19:36 +0000
Bug 1284422 part.7 Replace "KeymapWrapper(%p): " with "%p " in nsGtkKeyUtils.cpp r?m_kato MozReview-Commit-ID: 8HcQ4Aj0eqI
ae618aa417ad0aea013a7d07b82734b678967fb5: Bug 1284422 part.6 Reduce indent of MOZ_LOG() in IMContextWrapper.cpp r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 05 Jul 2016 18:44:18 +0900 - rev 383962
Push 22138 by masayuki@d-toybox.com at Tue, 05 Jul 2016 11:19:36 +0000
Bug 1284422 part.6 Reduce indent of MOZ_LOG() in IMContextWrapper.cpp r?m_kato MozReview-Commit-ID: 4jHFhQiUoHv
a735216456c23c7aa7c870aec2c0545cac94dc91: Bug 1284422 part.5 Remove "GTKIM: " from log of IMContextWrapper.cpp r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 05 Jul 2016 18:41:48 +0900 - rev 383961
Push 22138 by masayuki@d-toybox.com at Tue, 05 Jul 2016 11:19:36 +0000
Bug 1284422 part.5 Remove "GTKIM: " from log of IMContextWrapper.cpp r?m_kato MozReview-Commit-ID: 1rn6Azf0gLi
7eb5d7d4c892dfb40094bdb3721a5d7992d85d59: Bug 1284422 part.4 Fix odd indent of MOZ_LOG() in TextInputHandler.mm r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 05 Jul 2016 18:38:53 +0900 - rev 383960
Push 22138 by masayuki@d-toybox.com at Tue, 05 Jul 2016 11:19:36 +0000
Bug 1284422 part.4 Fix odd indent of MOZ_LOG() in TextInputHandler.mm r?m_kato MozReview-Commit-ID: 4ua3yoSgAJv
bae75090714069ffa012d94e9f5382144928ba05: Bug 1284422 part.3 Remove "IMM: " from log of IMMHandler.cpp r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 05 Jul 2016 18:35:43 +0900 - rev 383959
Push 22138 by masayuki@d-toybox.com at Tue, 05 Jul 2016 11:19:36 +0000
Bug 1284422 part.3 Remove "IMM: " from log of IMMHandler.cpp r?m_kato MozReview-Commit-ID: IfPneGddBfR
81d07b0c6c455b32abd2106ab42d054d6f4060b4: Bug 1284422 part.2 Fix odd indent of MOZ_LOG() in TSFTextStore.cpp (mainly caused by replacing from PR_LOG()) r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 05 Jul 2016 18:33:20 +0900 - rev 383958
Push 22138 by masayuki@d-toybox.com at Tue, 05 Jul 2016 11:19:36 +0000
Bug 1284422 part.2 Fix odd indent of MOZ_LOG() in TSFTextStore.cpp (mainly caused by replacing from PR_LOG()) r?m_kato MozReview-Commit-ID: 88EW9lN1DMD
0a13b546072c28880c18dea59b61bdbcc584e6dd: Bug 1284422 part.1 Remove "TSF: " from log of TSFTextStore.cpp r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 05 Jul 2016 18:06:39 +0900 - rev 383957
Push 22138 by masayuki@d-toybox.com at Tue, 05 Jul 2016 11:19:36 +0000
Bug 1284422 part.1 Remove "TSF: " from log of TSFTextStore.cpp r?m_kato MozReview-Commit-ID: D2lgQxFWWVB
be13fd231dc4309f2c67ac19b6404c6ee907d971: Bug 1224994 part.13 Fix some comments which say "locked content" in TSFTextStore.cpp r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 04 Jul 2016 15:53:58 +0900 - rev 383956
Push 22138 by masayuki@d-toybox.com at Tue, 05 Jul 2016 11:19:36 +0000
Bug 1224994 part.13 Fix some comments which say "locked content" in TSFTextStore.cpp r?m_kato MozReview-Commit-ID: Jze8WtPx82G
1f06f9bafb890d1e394794bc6eb7b8650a5e6dec: Bug 1224994 part.12 Rename the variable names for the result of TSFTextStore::SelectionForTSF() to selectionForTSF r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 01 Jul 2016 14:13:46 +0900 - rev 383955
Push 22138 by masayuki@d-toybox.com at Tue, 05 Jul 2016 11:19:36 +0000
Bug 1224994 part.12 Rename the variable names for the result of TSFTextStore::SelectionForTSF() to selectionForTSF r?m_kato MozReview-Commit-ID: 9gYiIKVohQl
9f9f7aa1436ad1fb7fb468c623ca3a6b778aaf01: Bug 1224994 part.11 Rename TSFTextStore::CurrentSelection() to TSFTextStore::SelectionForTSF() r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 01 Jul 2016 14:09:52 +0900 - rev 383954
Push 22138 by masayuki@d-toybox.com at Tue, 05 Jul 2016 11:19:36 +0000
Bug 1224994 part.11 Rename TSFTextStore::CurrentSelection() to TSFTextStore::SelectionForTSF() r?m_kato MozReview-Commit-ID: 9KVLN63NL9Z
f3a33c2a298d4cfbec9a21e35930057455cb0477: Bug 1224994 part.10 Rename TSFTextStore::mSelection to TSFTextStore::mSelectionForTSF for making its meaning clearer r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 01 Jul 2016 14:01:26 +0900 - rev 383953
Push 22138 by masayuki@d-toybox.com at Tue, 05 Jul 2016 11:19:36 +0000
Bug 1224994 part.10 Rename TSFTextStore::mSelection to TSFTextStore::mSelectionForTSF for making its meaning clearer r?m_kato MozReview-Commit-ID: K9tVAw9aCaN
cb5d5bf2b5f4438ed194c1cde657b428dac6b86b: Bug 1224994 part.9 TSFTextStore shouldn't set selection when there is unknown pending text changes r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 30 Jun 2016 17:55:01 +0900 - rev 383952
Push 22138 by masayuki@d-toybox.com at Tue, 05 Jul 2016 11:19:36 +0000
Bug 1224994 part.9 TSFTextStore shouldn't set selection when there is unknown pending text changes r?m_kato I'm still not sure what we should do in this case, though. If mContentForTSF is initialized and there are some unknown changes in actual contents, i.e., not caused by composition of the active TIP itself, we cannot set selection range properly in some cases. For example, if TSF tires to set non-empty selection range but the range has been removed by web apps. For now, let's try to return E_FAIL in such case because that should occur at reconversion or something immediately after previous content change not caused by previous composition. If TIP does nothing in this case, user can retry with same operation after all pending text changes are notified to TSF. MozReview-Commit-ID: 9unrNVeC1tW
5e0ad7ba1c08e1bf39e0f75b1c956ac067a2146d: Bug 1224994 part.8 Don't notify TSF of text changes while there is cached content r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 30 Jun 2016 15:04:02 +0900 - rev 383951
Push 22138 by masayuki@d-toybox.com at Tue, 05 Jul 2016 11:19:36 +0000
Bug 1224994 part.8 Don't notify TSF of text changes while there is cached content r?m_kato Same as selection change notification, text change notification shouldn't be notified to TSF while there is cachec content because neither TSF nor TIP may allow to change text by web applications during keeping storing cached content. This patch makes TSFTextStore stores and merges text changes until MaybeFlushPendingNotifications() is called and there is no cached content. MozReview-Commit-ID: 9fj0GREbX18
ae5d09bb1e37dbf82f50bceb32e5a0cc25067a73: Bug 1224994 part.7 Don't notify TSF of selection changes while there is a cached content r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 30 Jun 2016 16:17:11 +0900 - rev 383950
Push 22138 by masayuki@d-toybox.com at Tue, 05 Jul 2016 11:19:36 +0000
Bug 1224994 part.7 Don't notify TSF of selection changes while there is a cached content r?m_kato TSFTextStore shouldn't notify TSF of selection change until MaybeFlushPendingNotifications() is called and there is no cached content because while there is cached content, neither TSF nor TIP may allow to change selection by web applications. Therefore, ITextStoreACP::GetSelection() and similar methods need to use mSelection instead of actual selection in the focused editor. Therefore, TSFTextStore should store selection change data during keeping storing content cache and notify it when the cache is cleared. So, when TSFTextStore notifies TSF of selection change, TSFTextStore needs to update mSelection to the actual selection which is stored in mPendingSelectionChangeData. MozReview-Commit-ID: 8ZWASzu7Znv
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip