fcadbe00a8d0d6e563cdcf7291edcfae74759931: Bug 1414084 - Part 8 - Unify menu item EventDispatcher messages. r?grisha draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 18 Mar 2018 16:42:57 +0100 - rev 769126
Push 103041 by mozilla@buttercookie.de at Sun, 18 Mar 2018 15:52:54 +0000
Bug 1414084 - Part 8 - Unify menu item EventDispatcher messages. r?grisha As a final step, these can be merged as well. MozReview-Commit-ID: Ezx2mQY0s85
8d08733ec07e3c01ec0890a6f54674e1af454f1c: Bug 1414084 - Part 7 - Use only one list to store menu items added from Gecko. r?grisha draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 18 Mar 2018 15:37:51 +0100 - rev 769125
Push 103041 by mozilla@buttercookie.de at Sun, 18 Mar 2018 15:52:54 +0000
Bug 1414084 - Part 7 - Use only one list to store menu items added from Gecko. r?grisha Now that the UI code for handling both the old NativeWindow API and Web- extensions is more or less the same and both are using the same MenuItemInfo class, there's no longer any real need to keep items added through the two APIs in separate lists - in fact doing so makes it harder to preserve the ordering of menu items if the activity and its menu are destroyed and need to be re- created later on from the stored lists of MenuItemInfos. MozReview-Commit-ID: 7xtdkUnudES
cc44472ae017bbc36008732c66c29a0a6cc9115b: Bug 1414084 - Part 6 - Use one set of functions for managing MenuItems in the UI. r?grisha draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 18 Mar 2018 14:17:03 +0100 - rev 769124
Push 103041 by mozilla@buttercookie.de at Sun, 18 Mar 2018 15:52:54 +0000
Bug 1414084 - Part 6 - Use one set of functions for managing MenuItems in the UI. r?grisha The original add-on functions have some additional capabilities regarding e.g. checkboxes, disabling the menu or nested menu items that right now aren't required for Webextensions (yet?), but in that case they will simply not be used. MozReview-Commit-ID: DPT8gV2gb6q
6e8fe5dee9608ffc47fe8320cebd3ae63d4111f1: Bug 1414084 - Part 5 - Unify menu click event handling. r?grisha draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 18 Mar 2018 14:24:15 +0100 - rev 769123
Push 103041 by mozilla@buttercookie.de at Sun, 18 Mar 2018 15:52:54 +0000
Bug 1414084 - Part 5 - Unify menu click event handling. r?grisha Now that both Webextensions and the NativeWindow API manage their onClick call- back handling by UUID, we can start using the same EventDispatcher message for both. MozReview-Commit-ID: J3RRXrwPdTI
eaec4d82a132b21c00a4f8e52e3dd01b06f7c635: Bug 1414084 - Part 4 - Move menu item ID generation into the UI. r?grisha draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 18 Mar 2018 15:43:27 +0100 - rev 769122
Push 103041 by mozilla@buttercookie.de at Sun, 18 Mar 2018 15:52:54 +0000
Bug 1414084 - Part 4 - Move menu item ID generation into the UI. r?grisha Since the NativeWindow API now only uses UUIDs as well when dealing with its consumers, we can leave generation of the menu to the Android UI code of Firefox. MozReview-Commit-ID: 1qDLDnePfFE
1100bd9cd0a91e7e7d55109c0d0137bcdef4d6df: Bug 1414084 - Part 3 - Store NativeWindow menu callbacks by UUID. r?grisha draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 18 Mar 2018 13:33:42 +0100 - rev 769121
Push 103041 by mozilla@buttercookie.de at Sun, 18 Mar 2018 15:52:54 +0000
Bug 1414084 - Part 3 - Store NativeWindow menu callbacks by UUID. r?grisha MozReview-Commit-ID: 7nEhAUxOIsW
8ef46cdb000b8f0b5ab0a1055f4497c8313eb1ee: Bug 1414084 - Part 2 - Use UUIDs for the NativeWindow menu API, too. r?grisha draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 18 Mar 2018 13:26:16 +0100 - rev 769120
Push 103041 by mozilla@buttercookie.de at Sun, 18 Mar 2018 15:52:54 +0000
Bug 1414084 - Part 2 - Use UUIDs for the NativeWindow menu API, too. r?grisha At the moment, the code for handling of JS-created main menu items is more or less duplicated between the old NativeWindow API and Webextensions, with the only real difference being that the former communicates directly via menu item IDs, while the latter uses UUIDs for messaging between Gecko and the UI. By switching the NativeWindow API to using UUIDs as well, we will be able to unify this code again. As for backward compatibility - the return value of NativeWindow.menu.add was valid for the current session only, so no migration would be necessary - the return value of NativeWindow.menu add was already effectively only an opaque value which only had real meaning for subsequent calls to menu.update and menu.remove, so it shouldn't really matter whether we return a plain numeric ID or an UUID in string form - old-style add-ons are now unsupported for better or for worse and our one in- tree caller won't have any problems with this change MozReview-Commit-ID: HdRNhrx1pu7
80e05a302aec6f3463e719eada2d3f3f12e1ae20: Bug 1414084 - Part 1 - No longer track MenuItemInfo "added" data. r?grisha draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 18 Mar 2018 13:49:31 +0100 - rev 769119
Push 103041 by mozilla@buttercookie.de at Sun, 18 Mar 2018 15:52:54 +0000
Bug 1414084 - Part 1 - No longer track MenuItemInfo "added" data. r?grisha We no longer use that value anywhere, so we can just stop keeping track of it. MozReview-Commit-ID: D1IgX1t8SKI
1ebcc948c3bd06e024f62b4c6f7692e1bfe4b289: Bug 1414084 - Part 0 - Cleanups. r? draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 25 Feb 2018 20:53:01 +0100 - rev 769118
Push 103041 by mozilla@buttercookie.de at Sun, 18 Mar 2018 15:52:54 +0000
Bug 1414084 - Part 0 - Cleanups. r? MozReview-Commit-ID: B3ZGN2X8JXH
c57cb961847b5e52cee1e6bdd14dcc0679bd6718: Local build tweaks and base commit draft
Jan Henning <jh+bugzilla@buttercookie.de> - Thu, 28 Jul 2016 20:04:34 +0200 - rev 769117
Push 103041 by mozilla@buttercookie.de at Sun, 18 Mar 2018 15:52:54 +0000
Local build tweaks and base commit MozReview-Commit-ID: H5pdKja8p2a
fd82d0ac37243eda703171d91dd963fabe2f4aad: Hobbesfox draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 12 Aug 2017 22:07:29 +0200 - rev 769116
Push 103041 by mozilla@buttercookie.de at Sun, 18 Mar 2018 15:52:54 +0000
Hobbesfox MozReview-Commit-ID: JVp98nUnBMo
94aea3bae4800756982ca71fc571e642dbe4bb08: Bug 1441892 : TelemetryController.savePing removed draft
akriti <akriti.v10@gmail.com> - Sun, 18 Mar 2018 20:49:33 +0530 - rev 769115
Push 103040 by bmo:akriti.v10@gmail.com at Sun, 18 Mar 2018 15:20:32 +0000
Bug 1441892 : TelemetryController.savePing removed MozReview-Commit-ID: LQC8UM30ywu
c95914b99a80ddcef784f8add723cf47aa7e52dc: Backed out changeset 607c65430afe draft
akriti <akriti.v10@gmail.com> - Sun, 18 Mar 2018 20:38:33 +0530 - rev 769114
Push 103040 by bmo:akriti.v10@gmail.com at Sun, 18 Mar 2018 15:20:32 +0000
Backed out changeset 607c65430afe MozReview-Commit-ID: G24L1oXvFH1
10cf089146e0434c8aac55c22c44f4996e54d351: Bug 1441892 : telemetryController.savePing removed draft
akriti <akriti.v10@gmail.com> - Sun, 18 Mar 2018 19:09:27 +0530 - rev 769113
Push 103039 by bmo:akriti.v10@gmail.com at Sun, 18 Mar 2018 15:06:25 +0000
Bug 1441892 : telemetryController.savePing removed MozReview-Commit-ID: LpcmrV9eKmI
e7f6cb1ec402f4a543e433955882b313a1f01b6e: Backed out changeset 607c65430afe draft
akriti <akriti.v10@gmail.com> - Sun, 18 Mar 2018 19:06:13 +0530 - rev 769112
Push 103039 by bmo:akriti.v10@gmail.com at Sun, 18 Mar 2018 15:06:25 +0000
Backed out changeset 607c65430afe MozReview-Commit-ID: BI1a8GsMVlZ
5600b102624b59fce31b2c446f50f84e86784777: bug 1446749 - make resolver keep TRR status when cherry-picking adddresses r?mcmanus draft
Daniel Stenberg <daniel@haxx.se> - Sun, 18 Mar 2018 15:39:56 +0100 - rev 769111
Push 103038 by bmo:daniel@haxx.se at Sun, 18 Mar 2018 14:42:11 +0000
bug 1446749 - make resolver keep TRR status when cherry-picking adddresses r?mcmanus ... as they otherwise appear in the about:networking list as "false" while having been resolved by TRR. MozReview-Commit-ID: 9g9fUExvyjS
2c4a055ed5d45fe9ca33ae1b450b40e31c9fb8aa: Merge inbound to mozilla-central. a=merge
Brindusan Cristian <cbrindusan@mozilla.com> - Sun, 18 Mar 2018 11:48:00 +0200 - rev 769110
Push 103038 by bmo:daniel@haxx.se at Sun, 18 Mar 2018 14:42:11 +0000
Merge inbound to mozilla-central. a=merge
a8b3ac1e9f25625b6d3e7111c1f53ad36fd2edc2: Bug 1446584 - Make SVG use the same definition of whitespace as HTML/CSS r=jwatt
Robert Longson <longsonr@gmail.com> - Sun, 18 Mar 2018 07:14:32 +0000 - rev 769109
Push 103038 by bmo:daniel@haxx.se at Sun, 18 Mar 2018 14:42:11 +0000
Bug 1446584 - Make SVG use the same definition of whitespace as HTML/CSS r=jwatt
8b53f6e4c56584b359e5c98eacb653fe78f6b9e7: Bug 1446668: Remove now unused localization message. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 17 Mar 2018 20:26:09 +0100 - rev 769108
Push 103038 by bmo:daniel@haxx.se at Sun, 18 Mar 2018 14:42:11 +0000
Bug 1446668: Remove now unused localization message. r=smaug Reviewers: smaug Bug #: 1446668 Differential Revision: https://phabricator.services.mozilla.com/D759 MozReview-Commit-ID: HRuJtM2mWeq
7f31d84595e5eca480e1924480f76b13596d1074: Bug 1446668: Remove setUserData crashtests. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 17 Mar 2018 20:21:54 +0100 - rev 769107
Push 103038 by bmo:daniel@haxx.se at Sun, 18 Mar 2018 14:42:11 +0000
Bug 1446668: Remove setUserData crashtests. r=smaug Reviewers: smaug Bug #: 1446668 Differential Revision: https://phabricator.services.mozilla.com/D758 MozReview-Commit-ID: wyAvCCWbrS
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip