fb567b55cbdeb6eab06f15c689bfcfbc7551e39b: Bug 1382904: Optimize XPCOMUtils.generateQI. r?florian draft
Kris Maglione <maglione.k@gmail.com> - Thu, 20 Jul 2017 18:38:14 -0700 - rev 612727
Push 69588 by maglione.k@gmail.com at Fri, 21 Jul 2017 01:38:54 +0000
Bug 1382904: Optimize XPCOMUtils.generateQI. r?florian XPCOMUtils.generateQI is called a lot, and the current implementation is especially inefficient. It relies on calling the stringification slow path twice for each interface ID, which begins to add up fast given how often it's called. MozReview-Commit-ID: 2O87wBVMA2G
6bfa5f2324e6a9515f2f252a1b932e6cbaf77f49: Bug 1351349 - Blacklist Intel HD Graphics 510/520/530 for Windows 7 without platform update; r?dvander draft
Kevin Chen <kechen@mozilla.com> - Thu, 20 Jul 2017 18:09:47 +0800 - rev 612726
Push 69587 by bmo:kechen@mozilla.com at Fri, 21 Jul 2017 01:34:24 +0000
Bug 1351349 - Blacklist Intel HD Graphics 510/520/530 for Windows 7 without platform update; r?dvander MozReview-Commit-ID: F94OfZGBRQj
fb67150f6481d23e5a22d1e4cf0e6dc0efb2eb12: Bug 1380529 - Only permit "ES256" as pubkey type for WebAuthn (3/3) r?ttaubert draft
J.C. Jones <jjones@mozilla.com> - Fri, 14 Jul 2017 09:57:52 -0700 - rev 612725
Push 69586 by bmo:jjones@mozilla.com at Fri, 21 Jul 2017 01:30:43 +0000
Bug 1380529 - Only permit "ES256" as pubkey type for WebAuthn (3/3) r?ttaubert Web Authentication uses JWK algorithm names (ES256) instead of WebCrypto names (such as P-256). There are other JWK algorithm names, but our current U2F-backed implementation only can support ES256 anyway, as that's all that FIDO U2F devices understand. This patch limits us to the name ES256 for the "alg" parameter. MozReview-Commit-ID: 3V5DMzVzPad
af8604073a9843c3f3cb1766088d1ffb8000f35d: Bug 1380529 - Use CBOR for the Create Credential WebAuthn call (2/3) r?ttaubert draft
J.C. Jones <jjones@mozilla.com> - Thu, 13 Jul 2017 18:12:50 -0700 - rev 612724
Push 69586 by bmo:jjones@mozilla.com at Fri, 21 Jul 2017 01:30:43 +0000
Bug 1380529 - Use CBOR for the Create Credential WebAuthn call (2/3) r?ttaubert The WebAuthn Create Credential method should encode its results using CBOR; this patch changes to that format. The CBOR formats for the U2F data are specified in [1][2] The attestation data format is in [3] The high-level layout is in [4] [1] https://w3c.github.io/webauthn/#generating-an-attestation-object [2] https://w3c.github.io/webauthn/#fido-u2f-attestation [3] https://w3c.github.io/webauthn/#sec-attestation-data [4] https://w3c.github.io/webauthn/#sctn-attestation MozReview-Commit-ID: BYoFCJSxlLt
254db2d1620d2fff0358d35ab5af310b57617c0a: Bug 1374477 - Photon SVG changes for page action panel. r?mikedeboer draft
Drew Willcoxon <adw@mozilla.com> - Thu, 20 Jul 2017 18:29:17 -0700 - rev 612723
Push 69585 by dwillcoxon@mozilla.com at Fri, 21 Jul 2017 01:30:14 +0000
Bug 1374477 - Photon SVG changes for page action panel. r?mikedeboer MozReview-Commit-ID: 5oGeJPT8j3f
1c43b226e0236be2056e6d5370fc518b91640fc3: Bug 1374477 - Update consumers of Photon page action panel for changed identifiers. r?mikedeboer draft
Drew Willcoxon <adw@mozilla.com> - Thu, 20 Jul 2017 18:29:17 -0700 - rev 612722
Push 69585 by dwillcoxon@mozilla.com at Fri, 21 Jul 2017 01:30:14 +0000
Bug 1374477 - Update consumers of Photon page action panel for changed identifiers. r?mikedeboer MozReview-Commit-ID: 1skE8YJaqA7
d7ea161fd5010bfd45bd347db0030082c8285477: Bug 1374477 - Update Photon page action panel CSS. r?mikedeboer draft
Drew Willcoxon <adw@mozilla.com> - Thu, 20 Jul 2017 18:29:17 -0700 - rev 612721
Push 69585 by dwillcoxon@mozilla.com at Fri, 21 Jul 2017 01:30:14 +0000
Bug 1374477 - Update Photon page action panel CSS. r?mikedeboer MozReview-Commit-ID: K5vAkfK1Skr
9ccadbeec25cf3f6667182b455fdd7f0f1d71514: Bug 1374477 - Remove page actions from browser.xul. r?mikedeboer draft
Drew Willcoxon <adw@mozilla.com> - Thu, 20 Jul 2017 18:27:35 -0700 - rev 612720
Push 69585 by dwillcoxon@mozilla.com at Fri, 21 Jul 2017 01:30:14 +0000
Bug 1374477 - Remove page actions from browser.xul. r?mikedeboer MozReview-Commit-ID: 5nlXfKOx3Aq
93af365aa9e5b0342f29e643af0ae198b7fec17e: Bug 1374477 - Add browser-pageActions.js for Photon page actions. r?mikedeboer draft
Drew Willcoxon <adw@mozilla.com> - Thu, 20 Jul 2017 18:27:31 -0700 - rev 612719
Push 69585 by dwillcoxon@mozilla.com at Fri, 21 Jul 2017 01:30:14 +0000
Bug 1374477 - Add browser-pageActions.js for Photon page actions. r?mikedeboer MozReview-Commit-ID: DUl7WlSnk4k
331f40ea2dc74d1c09fba2bdaee5afbd24fa27c3: Bug 1374477 - Add PageActions.jsm for Photon page actions. r?mikedeboer draft
Drew Willcoxon <adw@mozilla.com> - Thu, 20 Jul 2017 18:14:12 -0700 - rev 612718
Push 69585 by dwillcoxon@mozilla.com at Fri, 21 Jul 2017 01:30:14 +0000
Bug 1374477 - Add PageActions.jsm for Photon page actions. r?mikedeboer MozReview-Commit-ID: ASMQlPX5t1i
74bcc5970c84936dce7b274e89e59c7974988e94: Bug 1380529 - Only permit "ES256" as pubkey type for WebAuthn (3/3) r?ttaubert draft
J.C. Jones <jjones@mozilla.com> - Fri, 14 Jul 2017 09:57:52 -0700 - rev 612717
Push 69584 by bmo:jjones@mozilla.com at Fri, 21 Jul 2017 01:26:09 +0000
Bug 1380529 - Only permit "ES256" as pubkey type for WebAuthn (3/3) r?ttaubert Web Authentication uses JWK algorithm names (ES256) instead of WebCrypto names (such as P-256). There are other JWK algorithm names, but our current U2F-backed implementation only can support ES256 anyway, as that's all that FIDO U2F devices understand. This patch limits us to the name ES256 for the "alg" parameter. MozReview-Commit-ID: 3V5DMzVzPad
8308135efa9cb8c2b9c37058fb0f5afa9b74c247: Bug 1380529 - Use CBOR for the Create Credential WebAuthn call (2/3) r?ttaubert draft
J.C. Jones <jjones@mozilla.com> - Thu, 13 Jul 2017 18:12:50 -0700 - rev 612716
Push 69584 by bmo:jjones@mozilla.com at Fri, 21 Jul 2017 01:26:09 +0000
Bug 1380529 - Use CBOR for the Create Credential WebAuthn call (2/3) r?ttaubert The WebAuthn Create Credential method should encode its results using CBOR; this patch changes to that format. The CBOR formats for the U2F data are specified in [1][2] The attestation data format is in [3] The high-level layout is in [4] [1] https://w3c.github.io/webauthn/#generating-an-attestation-object [2] https://w3c.github.io/webauthn/#fido-u2f-attestation [3] https://w3c.github.io/webauthn/#sec-attestation-data [4] https://w3c.github.io/webauthn/#sctn-attestation MozReview-Commit-ID: BYoFCJSxlLt
243f68a01b00ed30d244ce4404d5ec9a44260572: Bug 1382697 - Remove native nsinstall; r?glandium draft
Gregory Szorc <gps@mozilla.com> - Thu, 20 Jul 2017 15:40:56 -0700 - rev 612715
Push 69583 by bmo:gps@mozilla.com at Fri, 21 Jul 2017 01:16:23 +0000
Bug 1382697 - Remove native nsinstall; r?glandium We've introduced configure functionality to make the file installation mode configurable. While we haven't yet, we'll likely need to support hard links and some linking primitive on Windows. We know we'll be writing code to handle this in Python for mozpack/install manifests. I'm not keen on duplicating this functionality for nsinstall.c. We already have a Python version of nsinstall (nsinstall.py). It is used on Windows by default. And after recent changes to improve it, it should have feature parity with nsinstall.c. While invoking Python for simple file I/O is heavyweight, so is growing new features on a very crufty C program. It is easier to standardize on Python. So this commit removes the native nsinstall program. For the historical record, nsinstall's copyright line says it was authored by Brendan Eich in 1995. This was likely some of the oldest code in the Firefox repository. But history lives on: there is still a copy of nsinstall.c in the repository as part of NSS. For now... With this change and the transition of non-Windows builds to nsinstall.py (which obeys configure's --with-file-install-mode), there are no meaningful symlinks in the objdir for a full Linux build when --with-file-install-mode=copy is used! The only remaining symlinks are in _virtualenv (which we don't really have control over) and the "ld" symlink in build/unix/gold/ld. I don't think we really care about these since the important thing is for dist/ to be symlink free, which it is. MozReview-Commit-ID: A4OLmlc64lh
23e30e2f5ad3520d0487c6c14343ca5858c5ee5c: Bug 1382697 - Teach nsinstall.py to handle symlinks and file install mode; r?glandium draft
Gregory Szorc <gps@mozilla.com> - Thu, 20 Jul 2017 16:32:36 -0700 - rev 612714
Push 69583 by bmo:gps@mozilla.com at Fri, 21 Jul 2017 01:16:23 +0000
Bug 1382697 - Teach nsinstall.py to handle symlinks and file install mode; r?glandium The main difference between nsinstall.py and nsinstall.c is that nsinstall.py doesn't support symlinks. This prevents nsinstall.py from being used as a drop-in replacement for nsinstall.c on non-Windows platforms. This commit teaches nsinstall.py about symlinks. While we're here, it also now honors the configure flag to define the file installation mode. So, it will symlink if told to and copy otherwise. Probably the biggest risk to this change is that the buildconfig import may fail. The Firefox build system is OK. I'm not sure if anything outside of it attempts to invoke nsinstall.py. I guess we'll find out! MozReview-Commit-ID: IBifwA8RIuj
4db425961f4bd98be7fe64da21c6e30085ed8c30: Bug 1382697 - Change chmod() logic; r?glandium draft
Gregory Szorc <gps@mozilla.com> - Thu, 20 Jul 2017 18:15:43 -0700 - rev 612713
Push 69583 by bmo:gps@mozilla.com at Fri, 21 Jul 2017 01:16:23 +0000
Bug 1382697 - Change chmod() logic; r?glandium copy_all_entries() and handleTarget() recursively call each other. Both functions were calling chmod() and handling time updates as needed. Since handleTarget() is called for each file and directory, it is the only thing that needs to update metadata. The redundant call in copy_all_entries() has been removed. The call in handleTarget() has been moved ahead of copy_all_entries() to ensure the target directory has proper permissions before copy_all_entries() is called and that directory is operated on. MozReview-Commit-ID: ECXo7MeAxsR
d65e1172d49f9ba8a5bc2d3f38b703f550c622af: Bug 1382898 - Disable the Stop / Reload animation if the stop / reload buttons are placed outside of the nav-bar due to bug 1382894. r?gijs draft
Jared Wein <jwein@mozilla.com> - Thu, 20 Jul 2017 20:55:58 -0400 - rev 612712
Push 69582 by bmo:jaws@mozilla.com at Fri, 21 Jul 2017 00:56:17 +0000
Bug 1382898 - Disable the Stop / Reload animation if the stop / reload buttons are placed outside of the nav-bar due to bug 1382894. r?gijs MozReview-Commit-ID: 1LgSYvl7YGR
629dea20425d8af0d8ebed362867708e141ad9ed: Bug 1381991 - Pin to Overflow animation is placed in the wrong position when using a non-default font-size. r?sfoster draft
Jared Wein <jwein@mozilla.com> - Thu, 20 Jul 2017 12:31:06 -0400 - rev 612711
Push 69582 by bmo:jaws@mozilla.com at Fri, 21 Jul 2017 00:56:17 +0000
Bug 1381991 - Pin to Overflow animation is placed in the wrong position when using a non-default font-size. r?sfoster MozReview-Commit-ID: ERE1FnTuIWF
a7f0c16dbd3ef628c1ca8740c1b21eb0c07859af: Bug 1380815 - Fade overflow menu icon to grey after item is pinned. r?sfoster draft
Jared Wein <jwein@mozilla.com> - Thu, 20 Jul 2017 10:53:45 -0400 - rev 612710
Push 69582 by bmo:jaws@mozilla.com at Fri, 21 Jul 2017 00:56:17 +0000
Bug 1380815 - Fade overflow menu icon to grey after item is pinned. r?sfoster MozReview-Commit-ID: 2LQrWDxrTny
b4a15299733145a8bc1d01bd2cb4fe0010d65803: Bug 1355922 - Save to Pocket should have an associated animation. r?gijs draft
Jared Wein <jwein@mozilla.com> - Thu, 20 Jul 2017 09:59:22 -0400 - rev 612709
Push 69581 by bmo:jaws@mozilla.com at Fri, 21 Jul 2017 00:48:59 +0000
Bug 1355922 - Save to Pocket should have an associated animation. r?gijs The animations on the pocket-button and library-button are disabled if they are not in the nav-bar due to issues with getting overflow:hidden and position:absolute to work the same way outside of #nav-bar. This is on file as bug 1382894. MozReview-Commit-ID: Lq20GuocMkg
8221bad3e8204d4a51137504711dd1163838f8ad: Bug 1382667 - Implement an onBeforeCommand function for CustomizableUI that will run before the command is executed. r?gijs draft
Jared Wein <jwein@mozilla.com> - Thu, 20 Jul 2017 09:35:50 -0400 - rev 612708
Push 69580 by bmo:jaws@mozilla.com at Fri, 21 Jul 2017 00:47:44 +0000
Bug 1382667 - Implement an onBeforeCommand function for CustomizableUI that will run before the command is executed. r?gijs MozReview-Commit-ID: DGR3mo01vXP
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip