fa1069596507463ef162574a7a4fe51a447ae688: Bug 1201590 - WebMIDI Content implementation; r=baku r=padenot draft
Kyle Machulis <kyle@nonpolynomial.com> - Wed, 15 Nov 2017 11:18:58 -0800 - rev 709503
Push 92671 by bmo:kyle@nonpolynomial.com at Fri, 08 Dec 2017 06:24:01 +0000
Bug 1201590 - WebMIDI Content implementation; r=baku r=padenot MozReview-Commit-ID: HmiGV9iqAeM
f4425f2b95041bb4ef25ef6d413ede94df2a3fee: Bug 1201590 - WebMIDI Utility classes; r=baku r=padenot draft
Kyle Machulis <kyle@nonpolynomial.com> - Wed, 15 Nov 2017 11:16:34 -0800 - rev 709502
Push 92671 by bmo:kyle@nonpolynomial.com at Fri, 08 Dec 2017 06:24:01 +0000
Bug 1201590 - WebMIDI Utility classes; r=baku r=padenot MozReview-Commit-ID: 8TAO1dcdK5E
286fa59210eb8673d8a09471f4190ddd4975e58f: Bug 1201590 - WebMIDI IPDL files; r=baku draft
Kyle Machulis <kyle@nonpolynomial.com> - Tue, 14 Nov 2017 22:16:18 -0800 - rev 709501
Push 92671 by bmo:kyle@nonpolynomial.com at Fri, 08 Dec 2017 06:24:01 +0000
Bug 1201590 - WebMIDI IPDL files; r=baku MozReview-Commit-ID: 1b4FSasfZJ4
43b3ac49dd50a184647d0574167ed8dd39b16b1d: Bug 1201590 - WebMIDI WebIDL files; r=baku draft
Kyle Machulis <kyle@nonpolynomial.com> - Tue, 14 Nov 2017 22:02:57 -0800 - rev 709500
Push 92671 by bmo:kyle@nonpolynomial.com at Fri, 08 Dec 2017 06:24:01 +0000
Bug 1201590 - WebMIDI WebIDL files; r=baku MozReview-Commit-ID: 8zpN6u0WmtA
ae9070ed8031da34eb96ae3eef4def7b886bb920: Bug 1388018 - [mozfile] Add support for python 3. r=davehunt draft
Vedant Chakravadhanula <vedantc98@gmail.com> - Fri, 08 Dec 2017 11:46:37 +0530 - rev 709499
Push 92670 by bmo:vedantc98@gmail.com at Fri, 08 Dec 2017 06:17:19 +0000
Bug 1388018 - [mozfile] Add support for python 3. r=davehunt MozReview-Commit-ID: FqDi4kjkjMg
7296cedb442fcbf2003758ee9ee881493813763d: Bug 1421097 - Require at least Rust 1.22.1. r?Build draft
Ralph Giles <giles@mozilla.com> - Thu, 07 Dec 2017 21:08:53 -0800 - rev 709498
Push 92669 by bmo:giles@thaumas.net at Fri, 08 Dec 2017 06:05:01 +0000
Bug 1421097 - Require at least Rust 1.22.1. r?Build Bump the minimum required Rust version now that 1.22.1 has been in stable release for more than two weeks. Version 1.22.0 works fine everywhere but macOS 10.13, but 1.22.1 was released the same day, so it's no harder to upgrade to. Also update the base-toolchain builds to ensure we continue to build with this version. MozReview-Commit-ID: GlRWUNE07G0
e7d9505b849028ae8bb064e045ee1b113092bb38: Bug 1267890 part 1 - Add @supports -moz-pref() support for stylo. r?emilio draft
Xidorn Quan <me@upsuper.org> - Thu, 07 Dec 2017 22:31:41 -0600 - rev 709497
Push 92668 by xquan@mozilla.com at Fri, 08 Dec 2017 05:56:46 +0000
Bug 1267890 part 1 - Add @supports -moz-pref() support for stylo. r?emilio MozReview-Commit-ID: C9Pq2zLLaGp
a6e16db7bf0b6a2ebac7e875806ec3e3ca37c86a: Bug 1417138 part 3 - Enable stylo-chrome by default. r?heycam draft
Xidorn Quan <me@upsuper.org> - Tue, 14 Nov 2017 09:51:14 -0800 - rev 709496
Push 92668 by xquan@mozilla.com at Fri, 08 Dec 2017 05:56:46 +0000
Bug 1417138 part 3 - Enable stylo-chrome by default. r?heycam MozReview-Commit-ID: D19QBD4nqWf
24621febe5fefe45b8828e540ee19526ff263ae2: Bug 1417138 part 2 - Disable browser_aboutURLs.js for some platforms. r?heycam draft
Xidorn Quan <me@upsuper.org> - Wed, 22 Nov 2017 16:31:54 -0600 - rev 709495
Push 92668 by xquan@mozilla.com at Fri, 08 Dec 2017 05:56:46 +0000
Bug 1417138 part 2 - Disable browser_aboutURLs.js for some platforms. r?heycam MozReview-Commit-ID: DmU2RgyRv4L
c86c8f201b26dfd8e81eb795bcf4b3462c3927d4: Bug 1417138 part 1 - Remove expectAssertions from test_bug381167.xhtml. r?heycam draft
Xidorn Quan <me@upsuper.org> - Wed, 15 Nov 2017 09:05:42 -0800 - rev 709494
Push 92668 by xquan@mozilla.com at Fri, 08 Dec 2017 05:56:46 +0000
Bug 1417138 part 1 - Remove expectAssertions from test_bug381167.xhtml. r?heycam MozReview-Commit-ID: 1OroVsf9pHo
164d269ea855d5876f377846533ea0c18310693f: mybase draft
Xidorn Quan <quanxunzhen@gmail.com> - Wed, 04 Feb 2015 08:24:16 +1100 - rev 709493
Push 92668 by xquan@mozilla.com at Fri, 08 Dec 2017 05:56:46 +0000
mybase MozReview-Commit-ID: AIse40brXhE
f481698d1fb1e49030c901844ebf567a44586228: Bug 1423405: ignore poll errors when reading from UDP sockets draft
Nils Ohlmeier [:drno] <drno@ohlmeier.org> - Thu, 07 Dec 2017 21:42:41 -0800 - rev 709492
Push 92667 by drno@ohlmeier.org at Fri, 08 Dec 2017 05:43:21 +0000
Bug 1423405: ignore poll errors when reading from UDP sockets MozReview-Commit-ID: ip88DlLRa4
0739a194e8bd9f978f63f9e34ff4f2af08106d63: Bug 1423097 - part 3: Fix new orange caused by an existing bug of EditorBase::DeleteSelectionAndCreateElement() r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 07 Dec 2017 13:57:35 +0900 - rev 709491
Push 92666 by masayuki@d-toybox.com at Fri, 08 Dec 2017 05:43:15 +0000
Bug 1423097 - part 3: Fix new orange caused by an existing bug of EditorBase::DeleteSelectionAndCreateElement() r?m_kato Even after EditorBase::DeleteSelectionAndCreateElement() creates a new element, it tries to collapse selection with |pointToInsert| which is outdated after inserting new element. So, it should recompute the caret position with new DOM tree. MozReview-Commit-ID: DKh2uhItIol
a6499c5f9b31b39e4690929bccb8c448d6821cbb: Bug 1423097 - part 2: Add overloads of nsRange::SetStart(), nsRange::SetEnd(), nsRange::IsPointInRange() and nsRange::ComparePoint() to use them with RawRangeBoundary r?smaug draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 05 Dec 2017 17:50:13 +0900 - rev 709490
Push 92666 by masayuki@d-toybox.com at Fri, 08 Dec 2017 05:43:15 +0000
Bug 1423097 - part 2: Add overloads of nsRange::SetStart(), nsRange::SetEnd(), nsRange::IsPointInRange() and nsRange::ComparePoint() to use them with RawRangeBoundary r?smaug nsRange::SetStart(), nsRange::SetEnd(), nsRange::IsPointInRange() and nsRange::ComparePoint() take a set of container node and offset in it to specifying a DOM point. However, the caller may not have computed the offset but may know the child node at the point. In such case, they can avoid computing the offset with nsINode::IndexOf() if they have overloads which take RawRangeBoundary. Therefore, this patch implements the overloads and changes the callers in editor. MozReview-Commit-ID: E4DLbAgTTCI
259db8743b7cbe245c4c641fe0a1237cf0f50737: Bug 1423097 - part 1: Implement Selection::AnchorRef() and Selection::FocusRef() r?smaug draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 05 Dec 2017 16:36:57 +0900 - rev 709489
Push 92666 by masayuki@d-toybox.com at Fri, 08 Dec 2017 05:43:15 +0000
Bug 1423097 - part 1: Implement Selection::AnchorRef() and Selection::FocusRef() r?smaug Some methods of editor retrieves anchor and focus of selection. However, there are no methods which directly access RangeBoundary of anchor and focus. This patch adds it for making editor code simpler and avoiding unnecessary child offset computation. MozReview-Commit-ID: EvepQpFMi8S
07bfcb60db5f66e97fb4c5f512da821c05a2f77e: Bug 1408125 - part 5: Redesign HTMLEditor::NormalizeEOLInsertPosition() with EditorRawDOMPoint r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 05 Dec 2017 15:36:49 +0900 - rev 709488
Push 92665 by masayuki@d-toybox.com at Fri, 08 Dec 2017 05:40:49 +0000
Bug 1408125 - part 5: Redesign HTMLEditor::NormalizeEOLInsertPosition() with EditorRawDOMPoint r?m_kato HTMLEditor::NormalizeEOLInsertPosition() takes a set of container node and offset in it for specifying insertion point. So, this should be replaced with |const EditorRawDOMPoint&| and it should return |EditorDOMPoint| rather than modifying the argument. Additionally, perhaps, GetBetterInsertionPointFor() is better name for it. MozReview-Commit-ID: IB1FhrkzK2G
63d048b4f80f1988de3fafeab84c8a6fae40d10d: Bug 1408125 - part 4: Redesign HTMLEditor::InsertNodeAtPoint() with EditorRawDOMPoint r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 28 Nov 2017 22:28:07 +0900 - rev 709487
Push 92665 by masayuki@d-toybox.com at Fri, 08 Dec 2017 05:40:49 +0000
Bug 1408125 - part 4: Redesign HTMLEditor::InsertNodeAtPoint() with EditorRawDOMPoint r?m_kato HTMLEditor::InsertNodeAtPoint() should take |const EditorRawDOMPoint&| as an argument which specifies point to insert. Additionally, it should take |EditorDOMPoint*| to return the next point of actual insertion point. Additionally, this patch renames it to InsertNodeAtProperAncestor() for explaining what it will do. MozReview-Commit-ID: HYUzSlyPxAd
c33f80ee8d81439a82251a1e34b81f18867a0263: Bug 1408125 - part 3: Redesign nsIEditActionListener::(Will|Did)InsertNode() r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 28 Nov 2017 21:26:10 +0900 - rev 709486
Push 92665 by masayuki@d-toybox.com at Fri, 08 Dec 2017 05:40:49 +0000
Bug 1408125 - part 3: Redesign nsIEditActionListener::(Will|Did)InsertNode() r?m_kato Although nsIEditActionListener::WillInsertNode() nobody implements actually, we should remove it in a follow up bug. nsIEditActionListener::DidInsertNode() is implemented only by HTMLEditRules. So, if we make it not use nsIEditActionListener, we can remove it too. However, keep it for now. On the other hand, they don't need to receive index of the insertion point. WillInsertNode() needs next sibling of the insert point, but DidInsertNode() needs nothing because listener can compute it with new inserted node. MozReview-Commit-ID: GiTKkVyZJlN
3f376606e731b4d3049c13c2dbfd6c99b3fbf942: Bug 1408125 - part 2: EditorBase::CreateTxnForInsertNode() and EditorBase::InsertNode() should take |const EditorRawDOMPoint&| as an argument specifying point to insert r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 22 Nov 2017 21:25:05 +0900 - rev 709485
Push 92665 by masayuki@d-toybox.com at Fri, 08 Dec 2017 05:40:49 +0000
Bug 1408125 - part 2: EditorBase::CreateTxnForInsertNode() and EditorBase::InsertNode() should take |const EditorRawDOMPoint&| as an argument specifying point to insert r?m_kato EditorBase::CreateTxnForInsertNode() and EditorBase::InsertNode() should take |const EditorRawDOMPoint&| as an argument specifying point to insert. MozReview-Commit-ID: KhK19xS7wXb
7c80982bb495aed75184822b78a38ba6c641f53e: Bug 1408125 - part 1: Make InsertNodeTransaction use EditorRawDOMPoint and RangeBoundary instead of pair of container node and offset in it r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 22 Nov 2017 17:29:22 +0900 - rev 709484
Push 92665 by masayuki@d-toybox.com at Fri, 08 Dec 2017 05:40:49 +0000
Bug 1408125 - part 1: Make InsertNodeTransaction use EditorRawDOMPoint and RangeBoundary instead of pair of container node and offset in it r?m_kato Like CreateNodeTransaction, InsertNodeTransaction should use EditorRawDOMPoint for temporary variable and arguments of its methods and should use RangeBoudary to store it as its member. MozReview-Commit-ID: FCGY8x97egb
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip