testing: serve multiple repositories from commonenv test server We are preparing to use mozreview in the test environment. It creates a Mercurial server that supports multiple repositories as opposed to a single repo server. This patch converts the MozReview test environment to use a server setup that supports multiple repositories. This will make the switchover to mozreview less painful.

testing: ability to replace HGRCPATH in dummyssh When using dummyssh, the HGRCPATH set from the client's environment is likely picked up and used. In complex tests, this may not be desirable, especially if we're testing differences in configurations between client and server. We change the behavior of dummyssh to allow for the existence of an alternate config file (HGSSHHGRCPATH). This allows for clearer separation between client and server configs and better simulates how things work over real SSH.

testing: separate global config in MozReview Mercurial server We refactor the configuration of the Mercurial server in MozReview instances such that the global configuration is different from the web configuration. This simulates how things work in production, which a global hgrc (typically /etc/mercurial/hgrc) provides global defaults and a web config file provides the web configuration. These don't strictly need to be separate files. But it helps keep logic sorted out. And considering Mercurial's behavior of only reading a whitelist of options from web.conf files, it makes sense to keep a wall between them to avoid ambiguity.

testing: grab mercurial URL from state, not file We recently consolidated state for MozReview instances in a JSON file. Rip out the old code utilizing a dedicated file for storing the Mercurial URL.

testing: support grabbing Docker images from environment The mozreview command will now grab Docker images from environment variables. This is groundwork to enable the mozreview command to be used from tests.

mozreview: Include the Review Board url in commits.published Pulse message (Bug 1125468). r=gps

mozreview: Properly setup the Site domain when starting Review Board (Bug 1125468). r=gps Review Board uses information stored in the Django Site domain field for a few things dealing with urls. We now properly set this to localhost:$HGPORT1 when starting the server. We'll need to modify this if we stop using localhost as the domain.

docs: document boot2docker memory

docs: refactor docs around contributing into a Developer Guide While we were here, some documentation was updated.

testing: restore http:// downloading of Review Board packages pip is choking on certificates. I suspect https://downloads.reviewboard.org/ still doesn't have their hosting figured out right.

testing: issue warning when Docker cert error is encountered This is a very weird issue that seems to reproduce in Python 2.7.9 + docker-py + boot2docker 1.4.1. mcote and I both can reproduce it. The underlying failure is within the ssl C extension. It smells like Docker isn't producing certificates properly or a regression in 2.7.9 or the inability of requests/urllib3 to set up the verification environment properly. Whatever the root cause, this is extremely annoying. We should alert the user.

testing: dump review info from review requests; r=smacleod Upcoming tests will verify that reviews and review comments are created properly. We need support for dumping the state of this in YAML. This patch adds that.

testing: convert output of rbmanage dumpreview to YAML (bug 1124764); r=smacleod We were using a custom serializer. We've switched to YAML everywhere else. Use YAML here. We use an OrderedDict and custom serialization behavior of multiline strings to make output more tolerable.

Bug 1124253. Go back to the old annotateline behavior that links to the file diff, not to the blame for the last revision that changed the line, since the latter is not as useful. r=gps

testing: rbmanage command to make a user an admin user

mozreview: Include more data in mozreview.commits.published Pulse message (Bug 1124759). r=gps In order to allow commenting on the actual commits consumers need to have the diffset revision for each review request. The new message includes the parent's diffset revision, as well as a diffset revision for each child. A mozreview.commits.published message now contrains the data: { 'parent_review_request_id': <int>, 'parent_diffset_revision': <int>, 'repository_url': <string>, 'commits': [ { 'rev': <string>, 'review_request_id': <int>, 'diffset_revision': <int> }, ... ] }

testing: prefix docker build output with container name Now that we build images concurrently, we need to prefix the output with the container name so output is attributed to an image.

testing: fix reference to possibly undefined variable

testing: remove containers faster When stopping MozReview, we first issued a graceful stop then a remove container. Since we're removing the container, we don't preserve data. So, the time it takes to allow the containers to shut down gracefully is wasted. We switch to just force remove the container, which kills the container. On my machine, stopping containers now takes ~2s instead of ~10s!

testing: use concurrent.futures to start containers We now start bmodb, bmoweb, and pulse containers concurrently when starting a MozReview instance. This appears to shave a few hundred milliseconds off start.