f37758a78776264eba4f4e8deda3005ab1461846: Bug 1251362 - Part 14 - Remove the Recent Tabs panel from the default home panel config. r=liuche draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 15 May 2016 02:22:03 +0200 - rev 370241
Push 19013 by mozilla@buttercookie.de at Tue, 24 May 2016 10:14:21 +0000
Bug 1251362 - Part 14 - Remove the Recent Tabs panel from the default home panel config. r=liuche MozReview-Commit-ID: IX6AkBoa3Mg
2035922609c2329c16e7a43bf34504af1ecff588: Bug 1251362 - Part 13 - Redirect direct loads of the Recent Tabs panel about:home URL to the Recent Tabs folder of the Combined History panel. r=liuche draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 21 May 2016 15:25:50 +0200 - rev 370240
Push 19013 by mozilla@buttercookie.de at Tue, 24 May 2016 10:14:21 +0000
Bug 1251362 - Part 13 - Redirect direct loads of the Recent Tabs panel about:home URL to the Recent Tabs folder of the Combined History panel. r=liuche After detecting multiple successive crashes in a row, we temporarily switch off automatic session restoring and display the Recent Tabs panel instead. As that panel is going to be removed, we intercept loads of the Recent Tabs panel about:home?panel=... URL and redirect them to the Combined History panel. We also use the facilities provided by bug 1060544 to jump directly to the Recent Tabs folder in that case. MozReview-Commit-ID: 7dQ7tW2dD1M
90a61c6df7ab566c2789b32b0fc46bf5c1a2990d: Bug 1251362 - Part 12 - Import OnPanelLevelChangeListener.PanelLevel. r=liuche draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 15 May 2016 01:24:13 +0200 - rev 370239
Push 19013 by mozilla@buttercookie.de at Tue, 24 May 2016 10:14:21 +0000
Bug 1251362 - Part 12 - Import OnPanelLevelChangeListener.PanelLevel. r=liuche OnPanelLevelChangeListener.PanelLevel.CHILD_SYNC really is a mouthful. MozReview-Commit-ID: 3uEHQjUlTxf
ce1ac1b0b25377905c6e68170c6563cdd955cf42: Bug 1251362 - Part 11 - Add telemetry for restoring tabs. r=liuche draft
Jan Henning <jh+bugzilla@buttercookie.de> - Wed, 18 May 2016 19:04:49 +0200 - rev 370238
Push 19013 by mozilla@buttercookie.de at Tue, 24 May 2016 10:14:21 +0000
Bug 1251362 - Part 11 - Add telemetry for restoring tabs. r=liuche This adds telemetry for clicking on a closed tab or one of the "Open all" buttons. Methods and extras strings are the same as those used for the old Recent Tabs panel. MozReview-Commit-ID: 1Kc8fACkmIc
4521611b974d3b9277c779be3e25168947c47058: Bug 1251362 - Part 10 - Only enable swipe to refresh within the Synced devices smart folder. r=liuche draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 14 May 2016 23:38:29 +0200 - rev 370237
Push 19013 by mozilla@buttercookie.de at Tue, 24 May 2016 10:14:21 +0000
Bug 1251362 - Part 10 - Only enable swipe to refresh within the Synced devices smart folder. r=liuche Recently closed tabs aren't synced, therefore being able to swipe to refresh within the Recent tabs folder isn't necessary. To avoid triggering a refresh by accident, we restrict swipe to refresh to the Synced devices folder itself. MozReview-Commit-ID: YwekSwQr2q
45ee7aba9a0310cf7d64e0197aae7a4c5c3194b0: Bug 1251362 - Part 9 - Hide Recent Tabs smart folder if there aren't any closed tabs to be shown. r=liuche draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 14 May 2016 21:55:57 +0200 - rev 370236
Push 19013 by mozilla@buttercookie.de at Tue, 24 May 2016 10:14:21 +0000
Bug 1251362 - Part 9 - Hide Recent Tabs smart folder if there aren't any closed tabs to be shown. r=liuche This involves making the number of visible smart folders dynamic, so the history adapter can properly display its contents. MozReview-Commit-ID: 6b4V6IHB7BE
55eb513c3974a281a9253944ac4616fb1700754d: Bug 1251362 - Part 8 - Directly notify the RecentTabsAdapter when clearing history. r=liuche draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 14 May 2016 21:27:23 +0200 - rev 370235
Push 19013 by mozilla@buttercookie.de at Tue, 24 May 2016 10:14:21 +0000
Bug 1251362 - Part 8 - Directly notify the RecentTabsAdapter when clearing history. r=liuche Sessionstore.bak is only read when we are initialising the home panels, so after clearing all history from the button in the Combined History panel, the "Tabs from last time" section would still linger around until the home panels have been closed and reopened. To prevent this, we now directly notify the RecentTabsAdapter when all history has been deleted, so it can immediately clear its own copy of last session's tabs. MozReview-Commit-ID: 3EFY2WbWqzh
4b7964e401ce1419ccd2c8c8f76d1e6addbdf083: Bug 1251362 - Part 7 - Display a context menu for closed tab entries. r=liuche draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 14 May 2016 19:42:00 +0200 - rev 370234
Push 19013 by mozilla@buttercookie.de at Tue, 24 May 2016 10:14:21 +0000
Bug 1251362 - Part 7 - Display a context menu for closed tab entries. r=liuche MozReview-Commit-ID: Gv2tJoNRldX
12a06fa2a575d72d05a9c8cf4f51e1fff6f059a0: Bug 1251362 - Part 6 - Handle Recent Tabs in onItemClicked(). r=liuche draft
Jan Henning <jh+bugzilla@buttercookie.de> - Wed, 18 May 2016 18:55:32 +0200 - rev 370233
Push 19013 by mozilla@buttercookie.de at Tue, 24 May 2016 10:14:21 +0000
Bug 1251362 - Part 6 - Handle Recent Tabs in onItemClicked(). r=liuche Clicking a tab in the list of recently closed tabs now sends the appropriate message back to the session store. Likewise, clicking on the "Open all" button collects and sends all tabs of the respective type ("Recently closed" or "Tabs from last time") to Gecko for restoring. MozReview-Commit-ID: KF3UJjq5zQK
d5179d21ea08178dac98725e347dd690f15403f0: Bug 1251362 - Part 5 - Update closed tabs count in the History panel main view. r=liuche draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 14 May 2016 20:35:07 +0200 - rev 370232
Push 19013 by mozilla@buttercookie.de at Tue, 24 May 2016 10:14:21 +0000
Bug 1251362 - Part 5 - Update closed tabs count in the History panel main view. r=liuche We need to update the recent tabs count displayed by the smart folder as necessary. To do this, we copy the approach used for updating the synced devices count. MozReview-Commit-ID: BFwv5bY1DWk
e1800f35ece9bed82ad5b05a7b0f55322ba767b4: Bug 1251362 - Part 4 - Update empty panel state when recent tabs count changes. r=liuche draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 15 May 2016 01:41:45 +0200 - rev 370231
Push 19013 by mozilla@buttercookie.de at Tue, 24 May 2016 10:14:21 +0000
Bug 1251362 - Part 4 - Update empty panel state when recent tabs count changes. r=liuche The recent tabs count might change while the Recent Tabs folder is open, e.g. immediately after startup, once we receive the first "ClosedTabs:Data" from the session store. Therefore, we need to hide/unhide the empty view as necessary, which is normally handled by the Combined History panel's updateEmptyView() function. Since we aren't using a cursor, we can't hinge calling that on the CursorLoader's onLoadFinished() callback, so instead, we include our own callback to the Combined History panel, modelled after the DeviceUpdateHandler used for updating the count of synced devices. MozReview-Commit-ID: GLHM9LoWk2h
3ea58a40d350616cf789de30b5160672f06247ce: Bug 1251362 - Part 3 - Actually show recently closed tabs when opening the smart folder. r=liuche draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 14 May 2016 20:38:45 +0200 - rev 370230
Push 19013 by mozilla@buttercookie.de at Tue, 24 May 2016 10:14:21 +0000
Bug 1251362 - Part 3 - Actually show recently closed tabs when opening the smart folder. r=liuche This fills the new smart folder we've previously added with life and displays the recently closed tabs as we receive them from the session store. If we can find a sessionstore.bak file, we also add a section for "Tabs from last time". Most of the code for communicating with the session store and reading sessionstore.bak is adapted from the original Recent Tabs panel, however unlike the previous implementation, I've opted for a cursor-less approach of storing and retrieving the recent tabs data, since the recent tabs data isn't actually powered by a database anyway. Instead, the RecentTabsAdapter maintains two arrays for storing "recently closed tabs" (as received through messages from the Gecko session store) and "tabs from last time" (as read from sessionstore.bak during panel initialisation). For unknown reasons, home_open_all_row.xml's background now has to be explicitly set to "@drawable/action_bar_button" in order for highlighting on click to work. TODO: Once the patch to move startup session processing to a background thread (Bug 905223) has landed, we need to update readPreviousSessionData() to explicitly check (by attempting to wait) that the startup code had a chance to move the previous session file to sessionstore.bak if necessary. MozReview-Commit-ID: IpoUr9f0JBP
d1128b419b9352f6db699b2f148f528cdc4bf4d2: Bug 1251362 - Part 2 - Add a Recent Tabs folder to the Combined History panel. r=liuche draft
Jan Henning <jh+bugzilla@buttercookie.de> - Fri, 13 May 2016 23:52:24 +0200 - rev 370229
Push 19013 by mozilla@buttercookie.de at Tue, 24 May 2016 10:14:21 +0000
Bug 1251362 - Part 2 - Add a Recent Tabs folder to the Combined History panel. r=liuche This folder can be opened and closed to get back to the history view, however it doesn't contain any actual content (closed tabs) yet. Its empty view is based on the original empty view of the Recent Tabs panel. For displaying the recently closed tabs count within the smart folder similarly to how we display the number of synced devices, two new strings need to be added. MozReview-Commit-ID: IAL0yDrc2Ld
3dc3eb396a958483a621f723151fc06aa85c9515: Bug 1274933: Reject data promise when EOS is encountered following waiting for data. r?gerald draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Tue, 24 May 2016 19:58:36 +1000 - rev 370228
Push 19012 by bmo:jyavenard@mozilla.com at Tue, 24 May 2016 10:07:52 +0000
Bug 1274933: Reject data promise when EOS is encountered following waiting for data. r?gerald MozReview-Commit-ID: 1hKplz5wFnJ
4b78ed7d7e2ba3ae198fac5dc3bed5a4d8baaed5: Bug 1274274 - Rename element store clear function to delete; r?automatedtester draft
Andreas Tolfsen <ato@mozilla.com> - Fri, 20 May 2016 16:54:42 +0100 - rev 370227
Push 19011 by bmo:ato@mozilla.com at Tue, 24 May 2016 09:50:56 +0000
Bug 1274274 - Rename element store clear function to delete; r?automatedtester This matches the Map data structure in JavaScript. MozReview-Commit-ID: 5l2xOb4W2BC
b6760488a926110e967edde2041dc091f5b9cf5e: Bug 1274274 - Update exported symbols and correct docs; r?automatedtester draft
Andreas Tolfsen <ato@mozilla.com> - Fri, 20 May 2016 16:52:01 +0100 - rev 370226
Push 19011 by bmo:ato@mozilla.com at Tue, 24 May 2016 09:50:56 +0000
Bug 1274274 - Update exported symbols and correct docs; r?automatedtester MozReview-Commit-ID: 95ikD0oyrmy
134c0c806557de22ecee250e54da70377fdbf9b1: Bug 1274274 - Rename element manager; r?automatedtester draft
Andreas Tolfsen <ato@mozilla.com> - Fri, 20 May 2016 16:49:19 +0100 - rev 370225
Push 19011 by bmo:ato@mozilla.com at Tue, 24 May 2016 09:50:56 +0000
Bug 1274274 - Rename element manager; r?automatedtester Renames instances of `elementManager' to `seenEls' for brevity. Also the word "manager" does not really explain what purpose it fulfills. MozReview-Commit-ID: 4EUN9utPoZS
f2f686151985c044af2e2846d496f377ef1b2b9b: Bug 1274274 - Disassociate wrapValue from element store; r?automatedtester draft
Andreas Tolfsen <ato@mozilla.com> - Fri, 20 May 2016 16:32:31 +0100 - rev 370224
Push 19011 by bmo:ato@mozilla.com at Tue, 24 May 2016 09:50:56 +0000
Bug 1274274 - Disassociate wrapValue from element store; r?automatedtester Moves ElementManager#wrapValue to the testing/marionette/element.js module level and renames it to toJson. MozReview-Commit-ID: GJBl2L1GRxZ
666bf338adc7d3761640fbb39439a1dedd51e76e: Bug 1274274 - Disassociate convertWrappedArguments from element store; r?automatedtester draft
Andreas Tolfsen <ato@mozilla.com> - Fri, 20 May 2016 16:16:56 +0100 - rev 370223
Push 19011 by bmo:ato@mozilla.com at Tue, 24 May 2016 09:50:56 +0000
Bug 1274274 - Disassociate convertWrappedArguments from element store; r?automatedtester Moved ElementManager#convertWrappedArguments to the testing/marionette/element.js module scope and renamed it to fromJson. MozReview-Commit-ID: JMTZcG0JSUE
25e49b846271f6569f574e37c25a9719fdea0ba1: Bug 1274274 - Remove unused method applyNamedArgs; r?automatedtester draft
Andreas Tolfsen <ato@mozilla.com> - Fri, 20 May 2016 15:13:24 +0100 - rev 370222
Push 19011 by bmo:ato@mozilla.com at Tue, 24 May 2016 09:50:56 +0000
Bug 1274274 - Remove unused method applyNamedArgs; r?automatedtester MozReview-Commit-ID: 1FeFZK4VVu2
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip