f27d1e685d54f9c882fba3891985b251a975ab3e: Bug 1315937 - Only create option menu items once. draft
Julian_Chu <walkingice0204@gmail.com> - Thu, 23 Feb 2017 18:42:18 +0800 - rev 491797
Push 47421 by bmo:walkingice0204@gmail.com at Thu, 02 Mar 2017 08:30:50 +0000
Bug 1315937 - Only create option menu items once. Menu items in CustomTabsActivity are static. Not necessary to create items several times. However `onPrepareOptionsMenu()` will be called before menu is shown. Cannot use `onCreateOptionsMenu()` due to GeckoApp overwrited `onCreatePanelMenu()` and pass different instance to sub-class. Since CustomTabsActivity does not use custom menu, just overwrite `onCreatePanelMenu()` should be safe. MozReview-Commit-ID: 2oTN85GurqS
44bd28a4e6a1d513622c20da7f5dc13d27e5ab18: Bug 1343749. Part 2 - remove the calls to SimpleTest.requestLongerTimeout() when MediaTestManager is used. draft
JW Wang <jwwang@mozilla.com> - Thu, 02 Mar 2017 15:00:04 +0800 - rev 491796
Push 47420 by jwwang@mozilla.com at Thu, 02 Mar 2017 08:13:52 +0000
Bug 1343749. Part 2 - remove the calls to SimpleTest.requestLongerTimeout() when MediaTestManager is used. MozReview-Commit-ID: 4wCoA5C70Pu
f1364848ca62be74530fa1aa7732f0f499e28872: Bug 1343749. Part 1 - Let MediaTestManager manage timeout of each test. draft
JW Wang <jwwang@mozilla.com> - Thu, 02 Mar 2017 12:44:40 +0800 - rev 491795
Push 47420 by jwwang@mozilla.com at Thu, 02 Mar 2017 08:13:52 +0000
Bug 1343749. Part 1 - Let MediaTestManager manage timeout of each test. MozReview-Commit-ID: HocDk9FCi6Q
5b0dee6769ba26b1ad8794aaf13e95135b365a4a: Bug 1341200. Part 10 - streamline DecoderData::ShutdownDecoder() so it feels like a sync function and MFR doesn't need to explicitly wait for flush/shutdown to complete before creating new decoders. draft
JW Wang <jwwang@mozilla.com> - Mon, 27 Feb 2017 09:56:36 +0800 - rev 491794
Push 47420 by jwwang@mozilla.com at Thu, 02 Mar 2017 08:13:52 +0000
Bug 1341200. Part 10 - streamline DecoderData::ShutdownDecoder() so it feels like a sync function and MFR doesn't need to explicitly wait for flush/shutdown to complete before creating new decoders. MozReview-Commit-ID: F4tf1f7O89U
a136ca5a7403c1ac92f33851174605a67a551f02: Bug 1341200. Part 9 - remove unused mShuttingDown. draft
JW Wang <jwwang@mozilla.com> - Mon, 27 Feb 2017 00:17:16 +0800 - rev 491793
Push 47420 by jwwang@mozilla.com at Thu, 02 Mar 2017 08:13:52 +0000
Bug 1341200. Part 9 - remove unused mShuttingDown. MozReview-Commit-ID: 8OWgOB07rEP
d6f60b0f7ab4de98e6053d9f2baa8ae60673641f: Bug 1341200. Part 8 - let DecoderData::ShutdownDecoder() handle shutdown in the middle of flush. draft
JW Wang <jwwang@mozilla.com> - Sun, 26 Feb 2017 22:51:22 +0800 - rev 491792
Push 47420 by jwwang@mozilla.com at Thu, 02 Mar 2017 08:13:52 +0000
Bug 1341200. Part 8 - let DecoderData::ShutdownDecoder() handle shutdown in the middle of flush. MozReview-Commit-ID: FW23TFQLStR
7020580fc4a9ba6325b0521011118d6d66da977c: Bug 1341200. Part 7 - merge ShutdownDecoderWithPromise() and ShutdownDecoder(). draft
JW Wang <jwwang@mozilla.com> - Sat, 25 Feb 2017 07:59:53 +0800 - rev 491791
Push 47420 by jwwang@mozilla.com at Thu, 02 Mar 2017 08:13:52 +0000
Bug 1341200. Part 7 - merge ShutdownDecoderWithPromise() and ShutdownDecoder(). MozReview-Commit-ID: 9YRwPJGqrhq
d113b2d5ad130b3fc4aa5a91fade6b98834c4258: Bug 1341200. Part 6 - let ShutdownDecoderWithPromise() return void by tracking the shutdown promise. draft
JW Wang <jwwang@mozilla.com> - Sat, 25 Feb 2017 07:49:29 +0800 - rev 491790
Push 47420 by jwwang@mozilla.com at Thu, 02 Mar 2017 08:13:52 +0000
Bug 1341200. Part 6 - let ShutdownDecoderWithPromise() return void by tracking the shutdown promise. MozReview-Commit-ID: GIYdLXZYEyk
e4f8498f432a71c442a0ae199a6bbd56ec0b026f: Bug 1341200. Part 5 - move the definition to .cpp as they will access ShutdownPromisePool in next patches. draft
JW Wang <jwwang@mozilla.com> - Fri, 24 Feb 2017 17:27:42 +0800 - rev 491789
Push 47420 by jwwang@mozilla.com at Thu, 02 Mar 2017 08:13:52 +0000
Bug 1341200. Part 5 - move the definition to .cpp as they will access ShutdownPromisePool in next patches. MozReview-Commit-ID: 5Tvh1t4KyoV
5ad4d4951c496610a2650eb0d09c10c83879594f: Bug 1341200. Part 4 - remove the check that is unnecessary. draft
JW Wang <jwwang@mozilla.com> - Fri, 24 Feb 2017 17:24:41 +0800 - rev 491788
Push 47420 by jwwang@mozilla.com at Thu, 02 Mar 2017 08:13:52 +0000
Bug 1341200. Part 4 - remove the check that is unnecessary. MozReview-Commit-ID: FC0IkPE4EcR
6157a99757ae73dc817801094bf643a0afe9847f: Bug 1341200. Part 3 - replace mShutdownRequest with a bool as P2. draft
JW Wang <jwwang@mozilla.com> - Fri, 24 Feb 2017 17:19:12 +0800 - rev 491787
Push 47420 by jwwang@mozilla.com at Thu, 02 Mar 2017 08:13:52 +0000
Bug 1341200. Part 3 - replace mShutdownRequest with a bool as P2. MozReview-Commit-ID: ERERt0ZyvkC
f44e180acd460e49f3093601185a3b2291460f90: Bug 1341200. Part 2 - replace mFlushRequest with a bool for mFlushRequest.Disconnect() is never used and a bool is sufficient to do the job. draft
JW Wang <jwwang@mozilla.com> - Fri, 24 Feb 2017 17:04:32 +0800 - rev 491786
Push 47420 by jwwang@mozilla.com at Thu, 02 Mar 2017 08:13:52 +0000
Bug 1341200. Part 2 - replace mFlushRequest with a bool for mFlushRequest.Disconnect() is never used and a bool is sufficient to do the job. MozReview-Commit-ID: GFnSvunqtGq
0f6ef533aa626f9e1b584de194aacc979e5bca7a: Bug 1341200. Part 1 - satisfy least privilege principle by capturing |mSamplesWaitingForKey| instead of |this|. draft
JW Wang <jwwang@mozilla.com> - Wed, 22 Feb 2017 16:06:14 +0800 - rev 491785
Push 47420 by jwwang@mozilla.com at Thu, 02 Mar 2017 08:13:52 +0000
Bug 1341200. Part 1 - satisfy least privilege principle by capturing |mSamplesWaitingForKey| instead of |this|. MozReview-Commit-ID: A12HdnP8Vbn
4d426f01b4392fd7be96d8f3f6b4ffe68024ae7f: Bug 1342178 - Pass origin attributes to isSecureURI in devtools. r=past,keeler draft
Jonathan Hao <jhao@mozilla.com> - Thu, 02 Mar 2017 15:57:34 +0800 - rev 491784
Push 47419 by bmo:jhao@mozilla.com at Thu, 02 Mar 2017 08:08:49 +0000
Bug 1342178 - Pass origin attributes to isSecureURI in devtools. r=past,keeler MozReview-Commit-ID: HIOYH8iUUkO
d5f13ac5565884aba49c2eed2a1ca308441cd64e: Bug 1334782 - Convert title to MatchGlob and title param to regex withwildcards draft
BharatR123 <bharatraghunthan9767@gmail.com> - Wed, 22 Feb 2017 19:16:04 +0530 - rev 491783
Push 47418 by bmo:bharatraghunthan9767@gmail.com at Thu, 02 Mar 2017 08:01:17 +0000
Bug 1334782 - Convert title to MatchGlob and title param to regex withwildcards Converts title to MatchGlob in order to use a function, in order to convert a glob to regex (escaping all except ? and *) to perform patternmatching of the 'title' params. MozReview-Commit-ID: sUA2hU43GM
2ce32c5587569c1780b68ebc22b1f956fc7f05f0: Bug 1343437 - TBM::OnDemuxer{Init,Reset}Done forward non-NS_OK MediaResult to HTMLMediaElement::DecodeWarning - r?jya draft
Gerald Squelart <gsquelart@mozilla.com> - Wed, 01 Mar 2017 19:22:59 +1100 - rev 491782
Push 47417 by gsquelart@mozilla.com at Thu, 02 Mar 2017 07:58:48 +0000
Bug 1343437 - TBM::OnDemuxer{Init,Reset}Done forward non-NS_OK MediaResult to HTMLMediaElement::DecodeWarning - r?jya Similarly to the MediaFormatReader, TrackBuffersManager can forward warnings from the demuxer initialization to the associated HTMLMediaElement. Note that errors (sent to OnDemuxerInitFailed) are currently *not* forwarded to the HTMLMediaElement by design. In the future, we may want to add this feature so that mediasource errors can also be reported to webcompat. MozReview-Commit-ID: GjluZbpmC9q
18a8bb9e36042de7e9b94b9d48bb4b588a00cb9d: Bug 1343437 - MFR::OnDemuxerInitDone forwards non-NS_OK MediaResult to HTMLMediaElement::DecodeWarning - r?jya draft
Gerald Squelart <gsquelart@mozilla.com> - Mon, 27 Feb 2017 10:44:42 +1100 - rev 491781
Push 47417 by gsquelart@mozilla.com at Thu, 02 Mar 2017 07:58:48 +0000
Bug 1343437 - MFR::OnDemuxerInitDone forwards non-NS_OK MediaResult to HTMLMediaElement::DecodeWarning - r?jya The MediaFormatReader now takes the MediaResult from the Demuxer::Init promise resolution, and if there are no other errors but the MediaResult is not NS_OK it will forward that warning to the decoder owner (i.e., the associated HTMLMediaElement). MozReview-Commit-ID: 5rTmzqqPLI0
23a33eaff992505a4fc311f322655359f738d357: Bug 1343437 - MP4Demuxer rejects InitPromise is there is no valid track - r?jya draft
Gerald Squelart <gsquelart@mozilla.com> - Mon, 27 Feb 2017 10:11:07 +1100 - rev 491780
Push 47417 by gsquelart@mozilla.com at Thu, 02 Mar 2017 07:58:48 +0000
Bug 1343437 - MP4Demuxer rejects InitPromise is there is no valid track - r?jya An easy check that the MP4Demuxer::Init can do, is to ensure that there is at least one valid track. Note that the caller may itself do similar checks, but they are currently only looking at the first track of each type, so this check here adds a bit more information ("*no* valid tracks" vs "no valid *first* tracks"). MozReview-Commit-ID: 7JCcGjRUQAM
eba9c52494943a2f39476d4ddcd087646ff6e326: Bug 1343437 - MP4Demuxer::Init resolves with a MediaResult - r?jya draft
Gerald Squelart <gsquelart@mozilla.com> - Mon, 27 Feb 2017 10:10:28 +1100 - rev 491779
Push 47417 by gsquelart@mozilla.com at Thu, 02 Mar 2017 07:58:48 +0000
Bug 1343437 - MP4Demuxer::Init resolves with a MediaResult - r?jya If MP4Demuxer::Init detects some recoverable error (e.g., invalid tracks when others may still be usable), it will eventually Resolve the promise with the first warning. Later on, errors/warnings from the MP4Metadata parser will also be handled, to provide even better diagnostics. MozReview-Commit-ID: E9Rly9dhXW3
44c84a67703b7946dd9d9337d4716fcfeb631cfb: Bug 1343437 - MediaDataDemuxer::InitPromise resolve-value is now a MediaResult - r?jya draft
Gerald Squelart <gsquelart@mozilla.com> - Tue, 28 Feb 2017 16:24:57 +1100 - rev 491778
Push 47417 by gsquelart@mozilla.com at Thu, 02 Mar 2017 07:58:48 +0000
Bug 1343437 - MediaDataDemuxer::InitPromise resolve-value is now a MediaResult - r?jya In case of successful initialization, there could still be some warning about a recoverable error. To carry more information about this potential warning, the resolve-value type of the promise is changed from nsresult to MediaResult. Existing code doesn't need to be changed: - In Resolve() calls, the stored MediaResult can implicitly be constructed from an nsresult -- always NS_OK at the moment anyway. - In following Then(), the promise's MediaResult can implicitly be converted to an nsresult. Future patches will modify some of the Resolve's and Then's, to forward warning details to some Decoder Doctor object... MozReview-Commit-ID: J0bXDFxXQHQ
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip