f2189a78081ad535efb59ba387ef424fe7b94d2d: Bug 1337694 - Add Language negotiation to LocaleService API draft
Zibi Braniecki <gandalf@mozilla.com> - Sun, 19 Feb 2017 18:15:27 -0800 - rev 486831
Push 46069 by zbraniecki@mozilla.com at Mon, 20 Feb 2017 02:17:11 +0000
Bug 1337694 - Add Language negotiation to LocaleService API MozReview-Commit-ID: 59zOYC8Y219
3dd2473efa260b2efcf89c399e40910f0c9c0260: Bug 1337694 - Add language negotiation heuristics to LocaleService. draft
Zibi Braniecki <gandalf@mozilla.com> - Mon, 13 Feb 2017 15:49:37 -0800 - rev 486830
Push 46069 by zbraniecki@mozilla.com at Mon, 20 Feb 2017 02:17:11 +0000
Bug 1337694 - Add language negotiation heuristics to LocaleService. MozReview-Commit-ID: Ka6ESWYqyTQ
0794c2aa6348f9df1442f261015d05acb9220f88: Bug 1323366 - Create new IconRequest to prevent ConcurrentModificationException, r?sebastian draft
Jing-wei Wu <topwu.tw@gmail.com> - Mon, 20 Feb 2017 09:45:16 +0800 - rev 486829
Push 46068 by bmo:topwu.tw@gmail.com at Mon, 20 Feb 2017 02:09:07 +0000
Bug 1323366 - Create new IconRequest to prevent ConcurrentModificationException, r?sebastian
9e5d57c24027277f6305830cde4d2d374a976dc6: Bug 1317223 (part 6) - integration tests for the bookmark repair requestor and responder. r?tcsc draft
Mark Hammond <mhammond@skippinet.com.au> - Mon, 06 Feb 2017 10:54:08 -0800 - rev 486828
Push 46067 by mhammond@skippinet.com.au at Mon, 20 Feb 2017 02:02:46 +0000
Bug 1317223 (part 6) - integration tests for the bookmark repair requestor and responder. r?tcsc This is an attempt at a true integration tests without the use of mocks. It's tricky and hacky to do such tests - I suspect this patch is probably misguided and that TPS might be a better environment for these kinds of tests - I'm flagging Thom for review here primarily to see what he things about using TPS instead of this. MozReview-Commit-ID: 8us4v6Y21oM
cfe0ab4baea54219059a0f05fcc23164f794039e: Bug 1317223 (part 5) - a bookmark repair responder. r?kitcambridge draft
Mark Hammond <mhammond@skippinet.com.au> - Mon, 20 Feb 2017 12:53:07 +1100 - rev 486827
Push 46067 by mhammond@skippinet.com.au at Mon, 20 Feb 2017 02:02:46 +0000
Bug 1317223 (part 5) - a bookmark repair responder. r?kitcambridge This is the "repair responder" - it handles a "repairRequest" command sent by another client and attempts to take the list of IDs that client lists as missing and upload whatever records are necessary such that the requesting client would then be likely to find a complete and valid tree on the server. In the simple case, the responder would just upload the listed items if they exist locally, but this isn't smart enough - we will also need to (a) walk to the root from a requested item and ensure all subsequent parents also exist (b) if the missing item is a folder ensure the entire subtree under the item exists correctly and (c) see if the item should never have been uploaded in the first place (eg, if it is a local left-pane root) and if so, issue a delete of that ID and all subsequent parents up to the root. Currently (a) is done - (b) and (c) are not. The main TODOs here are: * (b) and (c) above, including tests for those. * Any other edge cases we can think about. * See if the "tree walking" code in the patch should be moved to PlacesSyncUtils. * Formalize the concept of "track weakly" used in the patch - we don't touch the syncChangeCounter field when tracking items as the entire repair process will automatically restart when the browser does. * More tests for other edge-cases - there are some XXX comments in the test file. MozReview-Commit-ID: 4xw19nH6EfL
b3ffee0fc9f0f3fd64dfca68cb550a0732f35cf7: Bug 1317223 (part 4) -Formalize weak tracking in `BookmarksChangeset`. r=markh draft
Kit Cambridge <kit@yakshaving.ninja> - Mon, 06 Feb 2017 10:19:27 -0800 - rev 486826
Push 46067 by mhammond@skippinet.com.au at Mon, 20 Feb 2017 02:02:46 +0000
Bug 1317223 (part 4) -Formalize weak tracking in `BookmarksChangeset`. r=markh MozReview-Commit-ID: C6otrtSuhZH
92ccfc8be356153b78675e1ac156ce09f00f038d: Bug 1317223 (part 3) - A bookmark repair requestor. r=markh,tcsc draft
Mark Hammond <mhammond@skippinet.com.au> - Mon, 20 Feb 2017 12:36:08 +1100 - rev 486825
Push 46067 by mhammond@skippinet.com.au at Mon, 20 Feb 2017 02:02:46 +0000
Bug 1317223 (part 3) - A bookmark repair requestor. r=markh,tcsc This is where the fun actually starts :) The bookmark repair requestor takes the validation results, and if those results include missing children records (when the parent exists but a child doesn't) and orphans (when the child exists but the parent doesn't) it kicks off a repair request by sending a "repairRequest" command to other clients in a controlled manner (effectivly a round-robin of all suitable other devices, waiting for a period of time before giving up on that client and moving on to another) until either all requested IDs have been found or no other clients are suitable. The main TODOs in this patch are: * See if there are other obvious validation results which mean a simple "record is missing from the server". * Decide if we really do need to attempt each client twice given that part 1 changes the engine implementation such that the repairRequest command is not actually removed from the client record until a repairResponse has been written. (See XXX comment in _continueRepairs) * Possibly more tests of edge and error cases. MozReview-Commit-ID: 7rRNbBx8Vo3
2c5a78995d0dc65cad8afb82b43c89c3f079ccc6: Bug 1317223 (part 2) - add 'doctor' concept and move bookmark validation logic to it. r?tcsc draft
Mark Hammond <mhammond@skippinet.com.au> - Mon, 20 Feb 2017 12:35:28 +1100 - rev 486824
Push 46067 by mhammond@skippinet.com.au at Mon, 20 Feb 2017 02:02:46 +0000
Bug 1317223 (part 2) - add 'doctor' concept and move bookmark validation logic to it. r?tcsc This patch defines the concept of a "doctor" for collections. The doctor is responsible for running all validators and deciding whether or not to initiate a repair request based on the validation results. The bulk of this patch is moving _tryValidateEngines from enginesync.js into the new doctor, plus changes so that after running a validator it uses the collection_repair interface introduced in part 1 to possibly initiate a repair request. This patch also changes the preference names used for the validators to include the collection names. For example, the pref "services.sync.validation.enabled" has been changed to "services.sync.engine.bookmarks.validation.enabled" - there's no real reason I did this other than I felt it seemed sensible - we might decide there's no good reason for that - nothing in the patch actually relies on it. TODO: The main TODO in this patch is to work out how we should handle the last-modified time on the server. To be safe, we *might* decide that we should keep the last-modified time of the collection we used to perform the validation and use if-unmodified-since when posting any items we find. However, I'm not sure that this buys us any safety in practice, especially while we are only uploading items known to not exist on the server. MozReview-Commit-ID: 6NLRE6L0OpA
49682807294ba9d3f546f3ea91a8e1fcf04e2297: Bug 1317223 (part 1) - a collection_repair module (without any repairers) and integration with the clients engine. r?rnewman,eoger draft
Mark Hammond <mhammond@skippinet.com.au> - Mon, 20 Feb 2017 12:37:01 +1100 - rev 486823
Push 46067 by mhammond@skippinet.com.au at Mon, 20 Feb 2017 02:02:46 +0000
Bug 1317223 (part 1) - a collection_repair module (without any repairers) and integration with the clients engine. r?rnewman,eoger This creates a collection_repair module, somewhat analogous to the existing collection_validator module. This defines the public interface to request a new repair and respond to a remote repair request, and also includes changes to clients.js to call this public interface. collection_validator also defines abstract base classes for the implementation of the requestors/responders, but does not define either a requestor nor a responder - in other words, the interface exists but no concrete requestors or repairers will be found. There are also a couple of changes to client.js used by later patches, namely a way to query the command queued for a client and to get the client record itself. The main TODO here is to consider how safe the new "don't remove the repair request from the client engine until the repair is done" change and consider if there is anything else we should do to make it less likely some obscure error will cause a the command to remain pending forever (although I believe the telemetry we record here should be enough to tell us if this is actually happening) Another thing we should consider is not allowing multiple repair requests to be pending at once. MozReview-Commit-ID: 9JPpRrLgFoR
ddf25f4e6d4db8783e9bffbd21a791ab6c27bb1e: Bug 1314921 - merge events.js into constants.js;r=rickychien draft
Fred Lin <gasolin@mozilla.com> - Fri, 17 Feb 2017 11:11:18 +0800 - rev 486822
Push 46066 by bmo:gasolin@mozilla.com at Mon, 20 Feb 2017 01:56:10 +0000
Bug 1314921 - merge events.js into constants.js;r=rickychien MozReview-Commit-ID: 3tstH8uxv0B
9921c8da54317c98124f6ca3b4cd330b2af46405: Bug 1314921 - move top-level files into utils;r=honza draft
Fred Lin <gasolin@mozilla.com> - Thu, 16 Feb 2017 15:24:26 +0800 - rev 486821
Push 46066 by bmo:gasolin@mozilla.com at Mon, 20 Feb 2017 01:56:10 +0000
Bug 1314921 - move top-level files into utils;r=honza MozReview-Commit-ID: GtAe9ggiCeA
b0cbe51520865de381809966b309ecefeba78f22: Bug 1328493 - Expose CreatePBufferFromClientBuffer and EGL_ANGLE_d3d_share_handle_client_buffer. r=jrmuizel
Morris Tseng <mtseng@mozilla.com> - Mon, 20 Feb 2017 09:44:50 +0800 - rev 486820
Push 46066 by bmo:gasolin@mozilla.com at Mon, 20 Feb 2017 01:56:10 +0000
Bug 1328493 - Expose CreatePBufferFromClientBuffer and EGL_ANGLE_d3d_share_handle_client_buffer. r=jrmuizel MozReview-Commit-ID: JhFdwkCvIsO
356449a93a4c2f3262b982d3fd621d880c919ac9: Bug 1340854 - Properly report TLS handshake telemetry for 0 length reads. r=mt
EKR <ekr@rtfm.com> - Sat, 18 Feb 2017 11:27:21 -0800 - rev 486819
Push 46066 by bmo:gasolin@mozilla.com at Mon, 20 Feb 2017 01:56:10 +0000
Bug 1340854 - Properly report TLS handshake telemetry for 0 length reads. r=mt
12fae55fe512dfd640b09279821d49b5f9e03a8a: Bug 1339695 (part 11) - Remove the profiler's OS class. r=mstange.
Nicholas Nethercote <nnethercote@mozilla.com> - Mon, 20 Feb 2017 09:07:37 +1100 - rev 486818
Push 46066 by bmo:gasolin@mozilla.com at Mon, 20 Feb 2017 01:56:10 +0000
Bug 1339695 (part 11) - Remove the profiler's OS class. r=mstange. We don't need OS now that the platform-*.cpp files are in the same compilation unit as platform.cpp. The patch removes the sleep functions because they are unnecessary indirection. OS::Startup() is necessary, but the patch renames it PlatformInit() to match Platform{Start,Stop}() and profiler_init(), from which it is called.
9eed66e9369a5151a26471a0786aad6a41d96fc8: Bug 1339695 (part 10) - Rename SPS_* macros as GP_*. r=jseward.
Nicholas Nethercote <nnethercote@mozilla.com> - Sat, 18 Feb 2017 00:57:03 +1100 - rev 486817
Push 46066 by bmo:gasolin@mozilla.com at Mon, 20 Feb 2017 01:56:10 +0000
Bug 1339695 (part 10) - Rename SPS_* macros as GP_*. r=jseward. This removes the final mentions of the old "SPS" name.
ec0490c4ada57ffc53da86806021177585ab5343: Bug 1339695 (part 9) - Rename the platform-* files. r=mstange.
Nicholas Nethercote <nnethercote@mozilla.com> - Sat, 18 Feb 2017 00:56:24 +1100 - rev 486816
Push 46066 by bmo:gasolin@mozilla.com at Mon, 20 Feb 2017 01:56:10 +0000
Bug 1339695 (part 9) - Rename the platform-* files. r=mstange. Specifically: - platform-linux.cc -> platform-linux-android.cpp - platform-macos.cc -> platform-macos.cpp - platform-win32.cc -> platform-win32.cpp Adding "android" to the first one is the most important part, because it makes things clearer. The .cc to .cpp change is less important but I might as well do it while I'm in here.
33c5f636b414db151ddbb6a865878fe53b43e11b: Bug 1339695 (part 8) - Clean up platform detection throughout the profiler. r=mstange.
Nicholas Nethercote <nnethercote@mozilla.com> - Sat, 18 Feb 2017 00:56:21 +1100 - rev 486815
Push 46066 by bmo:gasolin@mozilla.com at Mon, 20 Feb 2017 01:56:10 +0000
Bug 1339695 (part 8) - Clean up platform detection throughout the profiler. r=mstange. Currently we use the SPS_* macros in some places, but also use other ones like __arm__ and ANDROID and XP_{WIN,MAC,LINUX}. This patch makes the profiler consistently use the SPS_* macros and removes the V8_HOST_ARCH_* macros. The patch also does the following. - Cleans up some header inclusions, e.g. including pthread.h directly in the files that use it, and removing some unneeded android/log.h inclusions. - Removes an unused branch in SetSampleContext() -- we don't support ARM on anything other than Android, and glibc 2.3 is ancient. - Doesn't use SPS_* in PseudoStack.h because that would require exporting PlatformMacros.h, which doesn't seem worthwhile. Some things that aid the understanding of this patch. - XP_LINUX and LINUX are both defined for Linux *and* Android. - x86/Android is the only supported platform that doesn't define HAVE_NATIVE_UNWIND. - Every platform that defines USE_LUL_STACKWALK also defines HAVE_NATIVE_UNWIND.
8cc7d383df21ee79c29dc8ab0942f676569cd1c4: Bug 1339695 (part 7) - Remove ENABLE_LEAF_DATA. r=mstange.
Nicholas Nethercote <nnethercote@mozilla.com> - Sat, 18 Feb 2017 00:55:10 +1100 - rev 486814
Push 46066 by bmo:gasolin@mozilla.com at Mon, 20 Feb 2017 01:56:10 +0000
Bug 1339695 (part 7) - Remove ENABLE_LEAF_DATA. r=mstange. It's defined if any of XP_{WIN,MAC,LINUX} are defined and the latter includes Android as well. So it's defined on all the OSes the profiler supports.
acf9b36c79170b23803d354a7fae1f89033b3e04: Bug 1340735 - Terminate process when failing to attach it to job group. r=mhowell
Kris Maglione <maglione.k@gmail.com> - Fri, 17 Feb 2017 15:30:24 -0800 - rev 486813
Push 46066 by bmo:gasolin@mozilla.com at Mon, 20 Feb 2017 01:56:10 +0000
Bug 1340735 - Terminate process when failing to attach it to job group. r=mhowell MozReview-Commit-ID: BVCPRFH6TV2
3e179eea4ffca0aad0f79c19fb9f0e02a82560a9: no bug - Fix a misleading indentation
Sylvestre Ledru <sledru@mozilla.com> - Sun, 19 Feb 2017 14:27:57 +0100 - rev 486812
Push 46066 by bmo:gasolin@mozilla.com at Mon, 20 Feb 2017 01:56:10 +0000
no bug - Fix a misleading indentation MozReview-Commit-ID: 4yvVRRxoxC8
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip