f17d05ed471e0f1b10a5bd1e53c55a7b77151b21: Bug 1419148 - Export Screenshots 25.0.0 to Firefox (except translations); r?kmag,ianbicking
draft
Jared Hirsch <ohai@6a68.net> - Mon, 20 Nov 2017 11:06:02 -0800 - rev 701679
Push
90236 by bmo:jhirsch@mozilla.com at Wed, 22 Nov 2017 04:02:13 +0000
Bug 1419148 - Export Screenshots 25.0.0 to Firefox (except translations); r?kmag,ianbicking
MozReview-Commit-ID: 2InUwTe8oPa
271297ce098224270e6b1ab829ff47d1e4f155bc: Bug 1419148 - Export Screenshots 25.0.0 to Firefox (translations only); r=ianbicking
draft
Jared Hirsch <ohai@6a68.net> - Mon, 20 Nov 2017 11:04:56 -0800 - rev 701678
Push
90236 by bmo:jhirsch@mozilla.com at Wed, 22 Nov 2017 04:02:13 +0000
Bug 1419148 - Export Screenshots 25.0.0 to Firefox (translations only); r=ianbicking
MozReview-Commit-ID: 5vscnPIGDvN
88821404648e63d7d3070a67cd1bc925f075754b: Bug 1419226 - Part 3.Wait for non-timer MozAfterPaint on an animation mochitest.r?hiro
draft
Mantaroh Yoshinaga <mantaroh@gmail.com> - Wed, 22 Nov 2017 12:59:58 +0900 - rev 701677
Push
90235 by bmo:mantaroh@gmail.com at Wed, 22 Nov 2017 04:00:18 +0000
Bug 1419226 - Part 3.Wait for non-timer MozAfterPaint on an animation mochitest.r?hiro
This patch will:
* Wait for MozAfterPaint without waiting for another event in test_deferred_start.html.
* Remove waiting for MozAfterPaint if paint process doesn't occur in test_restyles.html.
* Move advanceTimeAndRefresh() before waiting for MozAfterPaint in order to
occur painting process in test_missing-keyframe-on-compositor.html.
MozReview-Commit-ID: 4M79yTywc9k
a3c8b71431684c7281edf78084559fe08c428b35: Bug 1419226 - Part 2. Create the notify did paint timer only if view manager has a pending flush. r?mattwoodrow
draft
Mantaroh Yoshinaga <mantaroh@gmail.com> - Wed, 22 Nov 2017 12:59:18 +0900 - rev 701676
Push
90235 by bmo:mantaroh@gmail.com at Wed, 22 Nov 2017 04:00:18 +0000
Bug 1419226 - Part 2. Create the notify did paint timer only if view manager has a pending flush. r?mattwoodrow
This EnsureEventualDidPaintEvent() creates software timer. But this timer will
bring several intermittent tests fail. For example, if we want to check the
compositor animation property. If test receives MozAfterPaint of the timer,
there doesn't have animation property on compositor, as result of this, a test
will fail.
I think we don't need to create this timer each time since current painting is
happening synchronously under the refresh driver. However, we might need this
timer when display list invalidation doesn't invalidate actually[1]. So this
patch will remove this timer from NotifyInvalidat(), and create timer only if
nsPresContext::IsDOMPaintEventPending() return true due to view manager has
pending flush.
[1] https://searchfox.org/mozilla-central/rev/919dce54f43356c22d6ff6b81c07ef412b1bf933/layout/base/nsPresContext.cpp#189
MozReview-Commit-ID: BouX6RCu9jQ
6a047d549866db831f6067652da3e698c206d67c: Bug 1419226 - Part 1.Change observing target window of MozAfterPaint of the print preview. r?mconley
draft
Mantaroh Yoshinaga <mantaroh@gmail.com> - Wed, 22 Nov 2017 12:58:35 +0900 - rev 701675
Push
90235 by bmo:mantaroh@gmail.com at Wed, 22 Nov 2017 04:00:18 +0000
Bug 1419226 - Part 1.Change observing target window of MozAfterPaint of the print preview. r?mconley
Previous code, print preview waits for content window's MozAfterPaint. However
gecko prevents send MozAfterPaint to content window[1]. So this code will not
work correctly. However, software timer of firing MozAfterPaint ran this code.[2]
This patch will change the observing content to chrome content.
[1] https://searchfox.org/mozilla-central/rev/919dce54f43356c22d6ff6b81c07ef412b1bf933/layout/base/nsPresContext.cpp#2452
[2] https://searchfox.org/mozilla-central/rev/919dce54f43356c22d6ff6b81c07ef412b1bf933/layout/base/nsPresContext.cpp#3466-3472
MozReview-Commit-ID: JHcvt1pR6Xs
065ef2aeea38f6b59bfde57e7ff77aa44317ba00: Bug 1406585 - Close the autocomplete popup when the crash of a content page or Message Manager disconnection happens. r=MattN
draft
Sean Lee <selee@mozilla.com> - Fri, 10 Nov 2017 17:00:33 +0800 - rev 701674
Push
90234 by bmo:selee@mozilla.com at Wed, 22 Nov 2017 03:59:50 +0000
Bug 1406585 - Close the autocomplete popup when the crash of a content page or Message Manager disconnection happens. r=MattN
MozReview-Commit-ID: DjSc4R0WBQP
d0c5e40a4f832b9f685fabb85b4f6c1a89edb5f0: Bug 1419148 - Export Screenshots 25.0.0 to Firefox (except translations); r?kmag,ianbicking
draft
Jared Hirsch <ohai@6a68.net> - Mon, 20 Nov 2017 11:06:02 -0800 - rev 701673
Push
90233 by bmo:jhirsch@mozilla.com at Wed, 22 Nov 2017 03:58:09 +0000
Bug 1419148 - Export Screenshots 25.0.0 to Firefox (except translations); r?kmag,ianbicking
MozReview-Commit-ID: 2InUwTe8oPa
a40d9f5cdb9cf8817fd009c4bc42521cf12bf6bf: Bug 1418766 - Fix Crash in java.lang.OutOfMemoryError by making Exoplayer pause by default.
draft
James Cheng <jacheng@mozilla.com> - Tue, 21 Nov 2017 17:21:19 +0800 - rev 701672
Push
90232 by bmo:jacheng@mozilla.com at Wed, 22 Nov 2017 03:54:16 +0000
Bug 1418766 - Fix Crash in java.lang.OutOfMemoryError by making Exoplayer pause by default.
MozReview-Commit-ID: JGIRcYLXtdv
19b4ab022ab7b68b66f50e61afd313137f8baec4: Bug 1418430. P2 - simplify the if statement of "reopen on error".
draft
JW Wang <jwwang@mozilla.com> - Wed, 22 Nov 2017 11:21:57 +0800 - rev 701671
Push
90231 by jwwang@mozilla.com at Wed, 22 Nov 2017 03:44:14 +0000
Bug 1418430. P2 - simplify the if statement of "reopen on error".
A truth table is listed to illustrate all conditions of length/offset/reopen.
The original code doesn't handle the following cases correctly:
1. length == offset == 0, shouldn't reopen the channel for there is no data to download.
2. length == -1 && offset > 0, should reopen the channel if seekable.
MozReview-Commit-ID: IisnrA8hK4M
1ad9f57e48da14be376174aa2a2c3eb123b2cc03: Bug 1418430. P1 - always check "reopen on error" when a connection is closed.
draft
JW Wang <jwwang@mozilla.com> - Wed, 22 Nov 2017 10:35:48 +0800 - rev 701670
Push
90231 by jwwang@mozilla.com at Wed, 22 Nov 2017 03:44:14 +0000
Bug 1418430. P1 - always check "reopen on error" when a connection is closed.
The server might send us fewer bytes than requested. So we also need
"reopen on error" in this case as well.
MozReview-Commit-ID: Fi82x4h1TZ0
a768b2af57f80b1a91ab781f139542501dd80569: Fix clang-format.
draft
JW Wang <jwwang@mozilla.com> - Wed, 22 Nov 2017 10:51:44 +0800 - rev 701669
Push
90231 by jwwang@mozilla.com at Wed, 22 Nov 2017 03:44:14 +0000
Fix clang-format.
MozReview-Commit-ID: K8AtqkyOZpP
9a812c932798e327e87c1b110d3a5f4135a0c2d3: Bug 1417869. P2 - abort the load algorithm early if media not allowed to load.
draft
JW Wang <jwwang@mozilla.com> - Tue, 21 Nov 2017 14:02:13 +0800 - rev 701668
Push
90231 by jwwang@mozilla.com at Wed, 22 Nov 2017 03:44:14 +0000
Bug 1417869. P2 - abort the load algorithm early if media not allowed to load.
MozReview-Commit-ID: DUxyo4ywCPW
d1899a6b0d24c9d806409736d6834a144c412d2a: Bug 1417869. P1 - Backed out changeset bf0e4dd83b3b of bug 1412505.
draft
JW Wang <jwwang@mozilla.com> - Tue, 21 Nov 2017 13:54:01 +0800 - rev 701667
Push
90231 by jwwang@mozilla.com at Wed, 22 Nov 2017 03:44:14 +0000
Bug 1417869. P1 - Backed out changeset bf0e4dd83b3b of
bug 1412505.
MozReview-Commit-ID: KdxxwIsHZJS
2892f318ed1c3ecfe5f10d8c90ed04d2a85d157a: Bug 1416799 - fix crash when seek fails.
draft
JW Wang <jwwang@mozilla.com> - Tue, 14 Nov 2017 16:12:58 +0800 - rev 701666
Push
90231 by jwwang@mozilla.com at Wed, 22 Nov 2017 03:44:14 +0000
Bug 1416799 - fix crash when seek fails.
MozReview-Commit-ID: A2HWJB3x7pb
87c1d3c4559874703d0b75ff0be5901298db7c03: Bug 1416686 - Reduce the uses of IPC_FAIL_NO_REASON in GMPChild.cpp.
draft
James Cheng <jacheng@mozilla.com> - Mon, 13 Nov 2017 09:35:03 +0000 - rev 701665
Push
90230 by bmo:jacheng@mozilla.com at Wed, 22 Nov 2017 03:20:01 +0000
Bug 1416686 - Reduce the uses of IPC_FAIL_NO_REASON in GMPChild.cpp.
Originally, we use IPC_FAIL_NO_REASON to make IPC call return error and then it invokes MOZ_CRASH to kill the process itself.
By using IPC_FAIL, we can pass a descriptive reason to GMPChild::ProcessingError and
Bug 1416667 will use MOZ_CRASH_UNSAFE_PRINTF
to print the reason to the crash report. In addition, we use CrashReporter::AnnotateCrashReport to record the lib path without exposing the data publicly.
MozReview-Commit-ID: 15n1PItLgAp
6bd1f2e14e72a63c2b83250266e37bd4fe1c2ba2: Bug 1414745 - Filter out everything except STATE_IS_NETWORK in nsBrowserStatusFilter::OnStateChange. r?mconley
draft
Samael Wang <freesamael@gmail.com> - Fri, 17 Nov 2017 10:48:37 +0800 - rev 701664
Push
90229 by bmo:sawang@mozilla.com at Wed, 22 Nov 2017 03:06:12 +0000
Bug 1414745 - Filter out everything except STATE_IS_NETWORK in nsBrowserStatusFilter::OnStateChange. r?mconley
The mFinishedRequests / mTotalRequests counters in nsBrowserStatusFilter has
been known buggy for around a decade. With e10s we double filtered in both
parent and child processes which makes it worse.
There are a few problems with the counters / filter:
1. The ResetMembers() were invoked on each network request starts, which means
a iframe document loading followed by the root document loading would also
reset the members incorrectly.
2. The filter for non-network request was incorrect. The basic idea seems to be
that if `mFinishedRequests == mTotalRequests` and `!isLoadingDocument`, it
should be the STOP request right after document loading finishes, and that
STOP should be delivered so listener would get symmetric numbers of START /
STOP of STATE_IS_REQUEST. However some requests such as imgRequest can start
after document loading finishes, in this case the START would be filtered
out (since mFinishedRequests != mTotalRequests), but STOP would be delivered
to the listener. It's the reason that nsBrowserStatusFilter tend to deliver
much more STATE_STOP than STATE_START.
3. When applying the filter on both parent & child side, the above issues often
make the mFinishedRequests / mFinishedRequests be unmatched on parent side,
eseentially filtered out most non-network requests and make the
progressChange based on the counters useless.
Firefox no longer shows the ratio of progressChange on the UI (and the number
is incorrect anyway with current nsBrowserStatusFilter), and Fennec's progress
bar is based on some predefined constants [1] which doesn't rely on
progressChange either, so it not necessary to keep calculating a progress
number with request counters.
In addition, it seems tabbrowser & browser.js mostly only care about
STATE_IS_NETWORK, and Fennec has already filtered out everything else [2], it
should be safe to only pass STATE_IS_NETWORK to the listener, and we get the
benefit of reducing unused IPC messages.
[1] https://searchfox.org/mozilla-central/rev/9bab9dc5a9472e3c163ab279847d2249322c206e/mobile/android/base/java/org/mozilla/gecko/Tab.java#111-115
[2] https://searchfox.org/mozilla-central/rev/9bab9dc5a9472e3c163ab279847d2249322c206e/mobile/android/chrome/content/browser.js#4356-4357
MozReview-Commit-ID: 5tUP5SRwDoP
226764571962f735de5c2c7a6af42129feb916b0: Bug 1413310 - Part 2: Add unit tests for CSS variable swatches r?tromey
draft
Darren Hobin <darrenhobin@live.com> - Tue, 21 Nov 2017 16:05:29 -0500 - rev 701663
Push
90228 by bmo:darrenhobin@live.com at Wed, 22 Nov 2017 02:54:20 +0000
Bug 1413310 - Part 2: Add unit tests for CSS variable swatches r?tromey
MozReview-Commit-ID: reE7ctzoQd
b9db8acafaa443986670f76b90da292891b5d766: Bug 1413310 - Part 1: Add swatches for CSS variables r?tromey
draft
Darren Hobin <darrenhobin@live.com> - Sat, 23 Sep 2017 12:26:26 -0400 - rev 701662
Push
90228 by bmo:darrenhobin@live.com at Wed, 22 Nov 2017 02:54:20 +0000
Bug 1413310 - Part 1: Add swatches for CSS variables r?tromey
MozReview-Commit-ID: 6Z5vqbYiCWq
4a562aeb5eb9a054887ce6ee16b55cc8a506352a: Bug 1417639 move tests out of mochitest-chrome
draft
Shane Caraveo <scaraveo@mozilla.com> - Tue, 21 Nov 2017 18:25:19 -0800 - rev 701661
Push
90227 by mixedpuppy@gmail.com at Wed, 22 Nov 2017 02:35:28 +0000
Bug 1417639 move tests out of mochitest-chrome
MozReview-Commit-ID: 6Ot7VedwNek
8967dc3249810f26117fc74b0e263adc12df6120: Bug 1418374 - Discard blob image key when we create another new one. r=kats
draft
Ethan Lin <ethlin@mozilla.com> - Tue, 21 Nov 2017 11:49:42 +0800 - rev 701660
Push
90226 by bmo:ethlin@mozilla.com at Wed, 22 Nov 2017 02:35:12 +0000
Bug 1418374 - Discard blob image key when we create another new one. r=kats
MozReview-Commit-ID: FOa25SkYmdK