f1764396de82d583a087fe6cd27a5c11944d5121: Bug 1449746 - Make helper_hittest_backface_hidden.html more robust. r=kats draft
Botond Ballo <botond@mozilla.com> - Thu, 29 Mar 2018 23:16:31 -0400 - rev 775121
Push 104618 by bballo@mozilla.com at Fri, 30 Mar 2018 04:36:23 +0000
Bug 1449746 - Make helper_hittest_backface_hidden.html more robust. r=kats MozReview-Commit-ID: J0GH58j3X6U
0980630d01a7182f9687e1c097c7c9fd114130b0: Bug 1449629 - Install Python 3.5 in debian-base; r?glandium draft
Gregory Szorc <gps@mozilla.com> - Thu, 29 Mar 2018 21:04:00 -0700 - rev 775120
Push 104617 by bmo:gps@mozilla.com at Fri, 30 Mar 2018 04:14:53 +0000
Bug 1449629 - Install Python 3.5 in debian-base; r?glandium We want Python 3.5+ to be available everywhere so various processes can start using it. The debian-base Dockerfile is shared by Debian 7 and 9 images. Debian 9 ships with Python 3.5 and after the previous commit, we have a Python 3.5 package for Debian 7. So we simply install the "python3.5" package to get Python on all the Debian images. There /might/ be an issue with the default package declaring a libexpat dependency that conflicts with some 32-bit -dev packages. But the Try push seemed happy and I /think/ we only have a 32-bit variant image based on Debian 7 currently. So this might not be an issue. This does increase the size of the images a bit: deb7-base: 218,155,008 / 79,005,868 -> 246,023,680 / 87,370,182 (That's uncompressed / compressed.) This is a bit unfortunate. But such is the price for having Python 3 I suppose. MozReview-Commit-ID: 9ZmoSxtHWTZ
b3a85356fc1f8fe4086e00bc5d269060be36f1a8: Bug 1449629 - Install Python 3.5 in Debian 7 base image; r?glandium draft
Gregory Szorc <gps@mozilla.com> - Thu, 29 Mar 2018 20:28:29 -0700 - rev 775119
Push 104617 by bmo:gps@mozilla.com at Fri, 30 Mar 2018 04:14:53 +0000
Bug 1449629 - Install Python 3.5 in Debian 7 base image; r?glandium Debian 7 ships Python 3.2 by default. That's too old for our upcoming build requirement of Python 3.5. This commit adds a Python 3.5 package for wheezy that backports the Python 3.5 from a much later Debian version. The patch was inspired by the existing patch for Python 2.7. However, it needed additional work. The changes and reasons should all be documented in the changelog file as part of the package diff we apply. I'm a bit disappointed we had to disable PGO. But it was reliably segfaulting during the build. I didn't feel like going down that rabbit hole. MozReview-Commit-ID: ABpHW1KYFQP
c59b1535590dcbb6c49e6b426297825af36b0c01: Bug 1450134. Replace ToRelativeLayoutRect() with ToRoundedLayoutRect(). r=kats draft
Jeff Muizelaar <jmuizelaar@mozilla.com> - Thu, 29 Mar 2018 17:57:43 -0400 - rev 775118
Push 104616 by bmo:jmuizelaar@mozilla.com at Fri, 30 Mar 2018 03:45:58 +0000
Bug 1450134. Replace ToRelativeLayoutRect() with ToRoundedLayoutRect(). r=kats This function doesn't use any StackingContextHelper state anymore. We should make what it does clearer and move it to a better place.
8b1e08cde1759794afe8c432ee28b83155deb61a: Bug 1407515 - more detailed test of Open in New Tab draft
Tom Glowka <glowka.tom@gmail.com> - Fri, 30 Mar 2018 04:33:42 +0200 - rev 775117
Push 104615 by bmo:glowka.tom@gmail.com at Fri, 30 Mar 2018 03:41:14 +0000
Bug 1407515 - more detailed test of Open in New Tab MozReview-Commit-ID: Cd7HCTg3kCJ
96536ee407d6d38aa453376085a1316fb11e108a: Bug 1450134. Replace ToRelativeLayoutRect() with ToRoundedLayoutRect(). r=kats draft
Jeff Muizelaar <jmuizelaar@mozilla.com> - Thu, 29 Mar 2018 17:57:43 -0400 - rev 775116
Push 104614 by bmo:jmuizelaar@mozilla.com at Fri, 30 Mar 2018 03:29:27 +0000
Bug 1450134. Replace ToRelativeLayoutRect() with ToRoundedLayoutRect(). r=kats This function doesn't use any StackingContextHelper state anymore. We should make what it does clearer and move it to a better place.
ef5a4a80cc422cb41ed23548bbcec965fe13391a: Bug 1407515 - more detailed test of Open in New Tab draft
Tom Glowka <glowka.tom@gmail.com> - Fri, 30 Mar 2018 04:33:42 +0200 - rev 775115
Push 104613 by bmo:glowka.tom@gmail.com at Fri, 30 Mar 2018 03:20:03 +0000
Bug 1407515 - more detailed test of Open in New Tab MozReview-Commit-ID: Cd7HCTg3kCJ
82786d36dfa608a8949333c89b93f4629bfe6283: Bug 1407515 - more detailed test of Open in New Tab draft
Tom Glowka <glowka.tom@gmail.com> - Fri, 30 Mar 2018 04:33:42 +0200 - rev 775114
Push 104612 by bmo:glowka.tom@gmail.com at Fri, 30 Mar 2018 03:10:25 +0000
Bug 1407515 - more detailed test of Open in New Tab MozReview-Commit-ID: Cd7HCTg3kCJ
edf9b2a8d1d7460358445a5bf86f91cfbe73b36e: Bug 1407515 - more detailed test of Open in New Tab draft
Tom Glowka <glowka.tom@gmail.com> - Fri, 30 Mar 2018 04:33:42 +0200 - rev 775113
Push 104611 by bmo:glowka.tom@gmail.com at Fri, 30 Mar 2018 03:02:03 +0000
Bug 1407515 - more detailed test of Open in New Tab MozReview-Commit-ID: Cd7HCTg3kCJ
9ba01ea8f1450619eed970c79b7df0faa2bb0d0f: Bug 1407515 - simplify Open in New Tab in launchpad draft
Tom Glowka <glowka.tom@gmail.com> - Thu, 29 Mar 2018 13:01:30 +0200 - rev 775112
Push 104611 by bmo:glowka.tom@gmail.com at Fri, 30 Mar 2018 03:02:03 +0000
Bug 1407515 - simplify Open in New Tab in launchpad Narrow down request methods to actually working (supported by form tag) when opening new tab in launchpad. MozReview-Commit-ID: 2fE2VkH8B8l
8adf587744ccc6ed1f6cb0b76183c68a56e2ed27: Bug 1407515 - make sure post data is suplied to Open in New Tab draft
Tom Glowka <glowka.tom@gmail.com> - Thu, 29 Mar 2018 11:40:11 +0200 - rev 775111
Push 104611 by bmo:glowka.tom@gmail.com at Fri, 30 Mar 2018 03:02:03 +0000
Bug 1407515 - make sure post data is suplied to Open in New Tab MozReview-Commit-ID: JqqS7ZhLrr7
3a0e1611fd27823fbfce7cd25c82f665adee2cbd: Bug 1449532 - Part II, Use Web Animation API to animate video control transition draft
Timothy Guan-tin Chien <timdream@gmail.com> - Fri, 30 Mar 2018 00:21:03 +0800 - rev 775110
Push 104610 by timdream@gmail.com at Fri, 30 Mar 2018 02:54:37 +0000
Bug 1449532 - Part II, Use Web Animation API to animate video control transition Web Animation API should give us deterministic timing when the transition ends or aborts. Additional clean-ups: - Make sure hidden status is always set/get from the hidden property, instead of the hidden attribute. - Remove the unused isControlBarHidden property. - controlsSpacer no longer has a background color (removed in bug 1374007), therefore it no longer needs a transition and there is no need to test its state with the test added in bug 1319301. - Fix a logic error at hideByAdjustment property, revealed by the changed transition timing, in which adjustControlSize() would show the controlBar set hidden by the transition. MozReview-Commit-ID: DB2cgQcUEXi
257938e730564a8fce79319846f4a479fb5a8dc4: Bug 1450170 - Add Nightly-only observer notification that fires anytime a tab switch spinner is displayed. r?dthayer draft
Mike Conley <mconley@mozilla.com> - Thu, 29 Mar 2018 22:37:07 -0400 - rev 775109
Push 104609 by mconley@mozilla.com at Fri, 30 Mar 2018 02:50:27 +0000
Bug 1450170 - Add Nightly-only observer notification that fires anytime a tab switch spinner is displayed. r?dthayer MozReview-Commit-ID: 3S34IVb9BEf
acb05962d6172ab26b7b22e4a79011eba9d68264: Bug 1450170 - Add Nightly-only observer notification that fires anytime a tab switch spinner is displayed. r?dthayer draft
Mike Conley <mconley@mozilla.com> - Thu, 29 Mar 2018 22:37:07 -0400 - rev 775108
Push 104608 by mconley@mozilla.com at Fri, 30 Mar 2018 02:37:41 +0000
Bug 1450170 - Add Nightly-only observer notification that fires anytime a tab switch spinner is displayed. r?dthayer MozReview-Commit-ID: 3S34IVb9BEf
86461e44e0025b81dc4382588c59cbf03140e695: Bug 1442296 - Adapt input and button styling inside popups to look better with themes. r?ntim, jaws, mconley draft
Dylan Stokes <stokesdy@msu.edu> - Thu, 29 Mar 2018 22:13:44 -0400 - rev 775107
Push 104607 by bmo:stokesdy@msu.edu at Fri, 30 Mar 2018 02:26:45 +0000
Bug 1442296 - Adapt input and button styling inside popups to look better with themes. r?ntim, jaws, mconley MozReview-Commit-ID: 5gVCkhQ91Q3
e77a95724850975bf23fc4266ac560dc87027ff8: Bug 1450154: Part 2 - Make test_install.js a bit less insane. r?aswan draft
Kris Maglione <maglione.k@gmail.com> - Thu, 29 Mar 2018 18:25:44 -0700 - rev 775106
Push 104606 by maglione.k@gmail.com at Fri, 30 Mar 2018 01:28:42 +0000
Bug 1450154: Part 2 - Make test_install.js a bit less insane. r?aswan MozReview-Commit-ID: I1ttVRYRavH
5479f783fead20223aa61581055b5809bbe10529: Bug 1450154: Part 2 - Make test_install.js a bit less insane. ?aswan draft
Kris Maglione <maglione.k@gmail.com> - Thu, 29 Mar 2018 18:25:44 -0700 - rev 775105
Push 104605 by maglione.k@gmail.com at Fri, 30 Mar 2018 01:27:08 +0000
Bug 1450154: Part 2 - Make test_install.js a bit less insane. ?aswan MozReview-Commit-ID: I1ttVRYRavH
45d62e0156ad646373fc4c8d2cafc27f755b0b3c: Bug 1303605: Make LazyFC assertions actually hold. r?bz draft
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 29 Mar 2018 14:04:40 +0200 - rev 775104
Push 104604 by bmo:emilio@crisal.io at Fri, 30 Mar 2018 00:41:57 +0000
Bug 1303605: Make LazyFC assertions actually hold. r?bz So while removing that wallpaper I started hitting the !noPrimaryFrame assertions on XBL + HMTL stuff in display-contents-xbl-3.xbl. The code was trying to assert that we had frames constructed for all the nodes in the parent chain, but we don't bail out in the !GetContentInsertionFrameFor(aContainer) in the case that it's a children element, because they actually have no insertion frame, though their children do. Move the LazyFC check after the insertion point check. That makes the previous check work on the insertion point of the child, which makes it sound. This also fixes bug 1410020, and with it a Shadow DOM test-case that was failing because the content other slot wasn't getting properly flagged, and thus the slotted content never got a frame. The other two test failures in this test are an event dispatch failure, where the position of the target is not what the test expects (we don't account for margin and padding). Filed that as bug 1450027. Also, added a test for which we have wrong layout without these patches, and that crashes with "Called Servo_Element_IsDisplayNone" with the first applied but not this one, due to the bogus check mentioned above. MozReview-Commit-ID: 6OeaVrZhTDv
c4ffef54eb8fe82e6f697c219bfbe6df322edb93: Bug 1303605: Remove the undisplayed maps. r?bz,mats draft
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 29 Mar 2018 03:49:26 +0200 - rev 775103
Push 104604 by bmo:emilio@crisal.io at Fri, 30 Mar 2018 00:41:57 +0000
Bug 1303605: Remove the undisplayed maps. r?bz,mats This is mostly code removal, changing GetDisplayContentsStyle(..) checks by an FFI call to Servo. The tricky parts are: * MaybeCreateLazily, which I fixed to avoid setting bits under display: none stuff. This was a pre-existing problem, which was wallpapered by the sc->IsInDisplayNoneSubtree() check, which effectively made the whole assertion useless. * ContentRemoved, where we can no longer know for sure whether the element is actually display: contents if we're removing it as a response to a style change. See the comment there. That kinda sucks, but that case is relatively weird, and it's better than adding tons of complexity to handle that. * GetParentComputedStyle, which also has a comment there. Also, this function has only one caller now, so we should maybe try to remove it. The different assertions after DestroyFramesForAndRestyle are changed for a single assertion in the function itself, and the node bit used as an optimization to avoid hashtable lookups is taken back. MozReview-Commit-ID: AZm822QnhF9
e7513ed056434f7bd9120ae16b166415769aee0f: Bug 1450154: Clone file objects before checking lastModifiedTime. r?aswan draft
Kris Maglione <maglione.k@gmail.com> - Thu, 29 Mar 2018 17:23:14 -0700 - rev 775102
Push 104603 by maglione.k@gmail.com at Fri, 30 Mar 2018 00:38:48 +0000
Bug 1450154: Clone file objects before checking lastModifiedTime. r?aswan MozReview-Commit-ID: CnIT0bqUaPZ
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip