ef5109eaeea5954a9adf20d1d5eb37ce9717465b: Bug 1351739 - Part -1 - Housekeeping. r?sebastian draft
Jan Henning <jh+bugzilla@buttercookie.de> - Fri, 07 Apr 2017 20:51:41 +0200 - rev 559297
Push 53051 by mozilla@buttercookie.de at Sun, 09 Apr 2017 17:35:56 +0000
Bug 1351739 - Part -1 - Housekeeping. r?sebastian MozReview-Commit-ID: Ev6jl4N3K0g
907f1341f18d4110fa34386c27d90bdbcecf2e2d: Local Gradle tweaks draft
Jan Henning <jh+bugzilla@buttercookie.de> - Thu, 28 Jul 2016 20:04:34 +0200 - rev 559296
Push 53051 by mozilla@buttercookie.de at Sun, 09 Apr 2017 17:35:56 +0000
Local Gradle tweaks MozReview-Commit-ID: H5pdKja8p2a
6023932c57e7323cd632bb2d2a03db0d8c3894b5: Bug 1354445 - Migrate Intl.DateTimeFormat to mozIntl.DateTimeFormat in chrome. r?jfkthame draft
Zibi Braniecki <gandalf@mozilla.com> - Sat, 08 Apr 2017 23:04:32 -0700 - rev 559295
Push 53050 by zbraniecki@mozilla.com at Sun, 09 Apr 2017 17:11:46 +0000
Bug 1354445 - Migrate Intl.DateTimeFormat to mozIntl.DateTimeFormat in chrome. r?jfkthame MozReview-Commit-ID: 4z13lcLXN9T
91e217701e43cc78fd638c09f889ca16e81af35f: Bug 1041895 - Add support for different flags with text filtering. r=rickychien draft
Tim Nguyen <ntim.bugs@gmail.com> - Sun, 09 Apr 2017 17:42:00 +0200 - rev 559294
Push 53049 by bmo:ntim.bugs@gmail.com at Sun, 09 Apr 2017 15:42:29 +0000
Bug 1041895 - Add support for different flags with text filtering. r=rickychien MozReview-Commit-ID: GvHXYIxwFrM
c7cdda686f880666b879cd5297e81bed9c07bc79: Bug 1041895 - Add support for different flags with text filtering. r=Honza, gerv draft
Tim Nguyen <ntim.bugs@gmail.com> - Sun, 09 Apr 2017 17:20:20 +0200 - rev 559293
Push 53048 by bmo:ntim.bugs@gmail.com at Sun, 09 Apr 2017 15:41:31 +0000
Bug 1041895 - Add support for different flags with text filtering. r=Honza, gerv MozReview-Commit-ID: LmytJLJ1cou
65d880e06216065dbb69a9c5dccf846e93c8f737: Bug 1345529 - fix inspector walker children() method;r=pbro draft
Julian Descottes <jdescottes@mozilla.com> - Thu, 06 Apr 2017 23:17:03 +0200 - rev 559292
Push 53047 by jdescottes@mozilla.com at Sun, 09 Apr 2017 15:07:45 +0000
Bug 1345529 - fix inspector walker children() method;r=pbro The inspector actor walker had several issues when trying to retrieve children for a given node. If the starting node was provided by options.center or options.start and if this starting node was filtered out by the walker's filter then the walker would fallback to the first valid parent of this node. eg with parent1 > parent2 > [valid-node, invalid-node, valid-node] When asking for the children of parent2, if the walker started on "invalid-node", then the walker would instead use parent2 and in turn we would retrieve the children of parent 1 To fix that we can either tell the walker wether it should fallback to a sibling of the starting node or to a parent, or make sure that the nodes provided to the walker are valid. A second issue was with the utility methods _readForward and _readBackward. They both use the next/previousSibling() methods of a walker in order to collect all the valid siblings of the walker's current node. But they were always including the current node of the walker in their return array. And there is no guarantee that the walker's currentNode is actually valid for it's filter. eg with a walker containing [invalid-node-1, invalid-node-2, valid-node]. Let's say the walker is currently on valid-node and we call previousSibling The walker will do 3 steps: - this.walker.previousSibling() > returns invalid-node-2, fails filtering - this.walker.previousSibling() > returns invalid-node-1, fails filtering - this.walker.previousSibling() > returns null, stop looping and return null But at this stage the internal walker still points to the last visited node (invalid-node-1). So if _readForward/Backward blindly add the current node of the walker, we might be returning invalid nodes. MozReview-Commit-ID: 72Be7DP5ky6
9854712ccc339ec28bd10cb3769fb224b9818e93: Bug 1345529 - fix inspector walker children() method;r=pbro draft
Julian Descottes <jdescottes@mozilla.com> - Thu, 06 Apr 2017 23:17:03 +0200 - rev 559291
Push 53046 by jdescottes@mozilla.com at Sun, 09 Apr 2017 14:18:59 +0000
Bug 1345529 - fix inspector walker children() method;r=pbro The inspector actor walker had several issues when trying to retrieve children for a given node. If the starting node was provided by options.center or options.start and if this starting node was filtered out by the walker's filter then the walker would fallback to the first valid parent of this node. eg with parent1 > parent2 > [valid-node, invalid-node, valid-node] When asking for the children of parent2, if the walker started on "invalid-node", then the walker would instead use parent2 and in turn we would retrieve the children of parent 1 To fix that we can either tell the walker wether it should fallback to a sibling of the starting node or to a parent, or make sure that the nodes provided to the walker are valid. A second issue was with the utility methods _readForward and _readBackward. They both use the next/previousSibling() methods of a walker in order to collect all the valid siblings of the walker's current node. But they were always including the current node of the walker in their return array. And there is no guarantee that the walker's currentNode is actually valid for it's filter. eg with a walker containing [invalid-node-1, invalid-node-2, valid-node]. Let's say the walker is currently on valid-node and we call previousSibling The walker will do 3 steps: - this.walker.previousSibling() > returns invalid-node-2, fails filtering - this.walker.previousSibling() > returns invalid-node-1, fails filtering - this.walker.previousSibling() > returns null, stop looping and return null But at this stage the internal walker still points to the last visited node (invalid-node-1). So if _readForward/Backward blindly add the current node of the walker, we might be returning invalid nodes. MozReview-Commit-ID: 72Be7DP5ky6
7044c1dfd98fc9c1d0c97ff22deaa815ba728e35: Bug 1345529 - fix inspector walker children() method;r=gl draft
Julian Descottes <jdescottes@mozilla.com> - Thu, 06 Apr 2017 23:17:03 +0200 - rev 559290
Push 53045 by jdescottes@mozilla.com at Sun, 09 Apr 2017 14:14:55 +0000
Bug 1345529 - fix inspector walker children() method;r=gl The inspector actor walker had several issues when trying to retrieve children for a given node. If the starting node was provided by options.center or options.start and if this starting node was filtered out by the walker's filter then the walker would fallback to the first valid parent of this node. eg with parent1 > parent2 > [valid-node, invalid-node, valid-node] When asking for the children of parent2, if the walker started on "invalid-node", then the walker would instead use parent2 and in turn we would retrieve the children of parent 1 To fix that we can either tell the walker wether it should fallback to a sibling of the starting node or to a parent, or make sure that the nodes provided to the walker are valid. A second issue was with the utility methods _readForward and _readBackward. They both use the next/previousSibling() methods of a walker in order to collect all the valid siblings of the walker's current node. But they were always including the current node of the walker in their return array. And there is no guarantee that the walker's currentNode is actually valid for it's filter. eg with a walker containing [invalid-node-1, invalid-node-2, valid-node]. Let's say the walker is currently on valid-node and we call previousSibling The walker will do 3 steps: - this.walker.previousSibling() > returns invalid-node-2, fails filtering - this.walker.previousSibling() > returns invalid-node-1, fails filtering - this.walker.previousSibling() > returns null, stop looping and return null But at this stage the internal walker still points to the last visited node (invalid-node-1). So if _readForward/Backward blindly add the current node of the walker, we might be returning invalid nodes. MozReview-Commit-ID: 72Be7DP5ky6
2c1cad12ea007b4a300defb9cc89ce7fd9a66b7a: Bug 1341761 - stylo: Update test expectations for -moz-element draft
Nazım Can Altınova <canaltinova@gmail.com> - Sat, 08 Apr 2017 17:40:18 +0300 - rev 559289
Push 53044 by bmo:canaltinova@gmail.com at Sun, 09 Apr 2017 14:04:50 +0000
Bug 1341761 - stylo: Update test expectations for -moz-element MozReview-Commit-ID: 3bKWDW2bJ9V
0e782d2bf1f7dcd5e2a07bb47e9c8c53f12735dc: Bug 1341761 - stylo: Add -moz-element support r?xidorn draft
Nazım Can Altınova <canaltinova@gmail.com> - Sun, 09 Apr 2017 17:02:35 +0300 - rev 559288
Push 53044 by bmo:canaltinova@gmail.com at Sun, 09 Apr 2017 14:04:50 +0000
Bug 1341761 - stylo: Add -moz-element support r?xidorn MozReview-Commit-ID: I9gxAoFJH9C
1728f86afb57d415c814af930f1d01ae9a8b3204: Bug 1341761 - stylo: Update test expectations for -moz-element draft
Nazım Can Altınova <canaltinova@gmail.com> - Sat, 08 Apr 2017 17:40:18 +0300 - rev 559287
Push 53043 by bmo:canaltinova@gmail.com at Sun, 09 Apr 2017 13:50:52 +0000
Bug 1341761 - stylo: Update test expectations for -moz-element MozReview-Commit-ID: 3bKWDW2bJ9V
f8f82a305be92d8629679f1338991999cfff50b1: Bug 1341761 - stylo: Add -moz-element support r?xidorn draft
Nazım Can Altınova <canaltinova@gmail.com> - Thu, 06 Apr 2017 20:25:34 +0300 - rev 559286
Push 53043 by bmo:canaltinova@gmail.com at Sun, 09 Apr 2017 13:50:52 +0000
Bug 1341761 - stylo: Add -moz-element support r?xidorn MozReview-Commit-ID: I9gxAoFJH9C
94de1ab52757e9ed4c37dda605cf8b57d63ee646: Bug 1341761 - Convert nsStyleImage::mElementId to use nsIAtom r?xidorn draft
Nazım Can Altınova <canaltinova@gmail.com> - Sun, 09 Apr 2017 16:44:36 +0300 - rev 559285
Push 53043 by bmo:canaltinova@gmail.com at Sun, 09 Apr 2017 13:50:52 +0000
Bug 1341761 - Convert nsStyleImage::mElementId to use nsIAtom r?xidorn MozReview-Commit-ID: 9YcbhMmXYoi
7c5670cfe60f7c5567f65b092135cd45f97dfdab: Bug 1345225 - Check if webRequest filters overlap with host permissions draft
Tomislav Jovanovic <tomica@gmail.com> - Sun, 26 Mar 2017 20:53:28 +0200 - rev 559284
Push 53042 by bmo:tomica@gmail.com at Sun, 09 Apr 2017 12:51:07 +0000
Bug 1345225 - Check if webRequest filters overlap with host permissions MozReview-Commit-ID: 1tMHynv9FBO
4a6138cf5792900ef8cc772944f34d6d3df9688b: Bug 1354890 - convert uses of 'defer' to 'new Promise' in client/commandline/ draft
Michael Kohler <mkohler@picobudget.com> - Sun, 09 Apr 2017 14:27:48 +0200 - rev 559283
Push 53041 by bmo:me@michaelkohler.info at Sun, 09 Apr 2017 12:28:55 +0000
Bug 1354890 - convert uses of 'defer' to 'new Promise' in client/commandline/ MozReview-Commit-ID: GictLEiBqT3
602dcd2d985655d12b0c15f17f0a6fdf4b48eb1a: Bug 1341724 - Part 4: stylo: Make font metrics usage threadsafe; r?heycam draft
Manish Goregaokar <manishearth@gmail.com> - Fri, 07 Apr 2017 15:49:44 -0700 - rev 559282
Push 53040 by bmo:manishearth@gmail.com at Sun, 09 Apr 2017 11:25:17 +0000
Bug 1341724 - Part 4: stylo: Make font metrics usage threadsafe; r?heycam MozReview-Commit-ID: 3EqpUy09UuI
29428d3e8b16759dd59c6e1cc01c39b11a40c4fd: Bug 1341724 - Part 3: stylo: Use gecko's font metrics; r?heycam draft
Manish Goregaokar <manishearth@gmail.com> - Fri, 07 Apr 2017 15:49:44 -0700 - rev 559281
Push 53040 by bmo:manishearth@gmail.com at Sun, 09 Apr 2017 11:25:17 +0000
Bug 1341724 - Part 3: stylo: Use gecko's font metrics; r?heycam MozReview-Commit-ID: 6yYYauqCJHq
9872818523b2b9d3ca0fd42845526b7ef000588e: Bug 1341724 - Part 2: stylo: Add bindings for fetching font metrics from Gecko; r?heycam draft
Manish Goregaokar <manishearth@gmail.com> - Fri, 07 Apr 2017 15:49:44 -0700 - rev 559280
Push 53040 by bmo:manishearth@gmail.com at Sun, 09 Apr 2017 11:25:17 +0000
Bug 1341724 - Part 2: stylo: Add bindings for fetching font metrics from Gecko; r?heycam MozReview-Commit-ID: BkPNq22ruwU
339b114784e0c4efea528954922b0cf099a7c2fa: Bug 1354883 - convert uses of 'defer' to 'new Promise' in client/canvasdebugger draft
Michael Kohler <mkohler@picobudget.com> - Sun, 09 Apr 2017 13:21:07 +0200 - rev 559279
Push 53039 by bmo:me@michaelkohler.info at Sun, 09 Apr 2017 11:21:48 +0000
Bug 1354883 - convert uses of 'defer' to 'new Promise' in client/canvasdebugger MozReview-Commit-ID: 8mVRs0v6CKu
a345e462bc12c72d06c7f5a3ab05dee95ae3149e: Bug 1333532 - Changed the permissions.js file to make the Page Info dialog work. r?johannh draft
Prathiksha <prathikshaprasadsuman@gmail.com> - Sun, 09 Apr 2017 16:50:02 +0530 - rev 559278
Push 53038 by bmo:prathikshaprasadsuman@gmail.com at Sun, 09 Apr 2017 11:20:29 +0000
Bug 1333532 - Changed the permissions.js file to make the Page Info dialog work. r?johannh MozReview-Commit-ID: 2zJeMhtYEds
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip