eeb0169abe8a490ae0598866a964d80f85b8c94e: Bug 1257759 part.7 Add new internal events which represent key events on plugin r?smaug draft
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 11 Apr 2016 17:31:18 +0900 - rev 350796
Push 15419 by masayuki@d-toybox.com at Thu, 14 Apr 2016 08:57:08 +0000
Bug 1257759 part.7 Add new internal events which represent key events on plugin r?smaug If a plugin process posts native key events to the widget, it needs to check if the key combination is reserved by chrome because if it's reserved by chrome, the reserved shortcut key handler should be executed and the event shouldn't be handled by the focused plugin. This patches add eKeyDownOnPlugin and eKeyUpOnPlugin. nsXBLWindowKeyHandler will listen to them and handle them as normal keydown and keypress or keyup event. Note that these events won't be fired on content in the default event group and won't be sent to the remote process. MozReview-Commit-ID: H5OKPLtVdr6
8eb3f68f466ad8b96d3ff3870ab9695a67321937: Bug 1257759 part.6 Keep event order between keyboard events and IME events in a plugin process r?jimm draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 14 Apr 2016 17:28:49 +0900 - rev 350795
Push 15419 by masayuki@d-toybox.com at Thu, 14 Apr 2016 08:57:08 +0000
Bug 1257759 part.6 Keep event order between keyboard events and IME events in a plugin process r?jimm On Windows, applications cannot handle IME messages asynchronously. Therefore, we cannot put off to send IME messages to plugin even if there are some pending keyboard events which were posted to the parent process. This patch makes PluginInstanceChild consume all key events which are returned from the parent process during IME composition. And when an IME composition is committed, mark pending key events as outdated. MozReview-Commit-ID: 7P3LEJ6pDir
d115f0ab87f3e056f959e7e29107459c96b9558e: Bug 1257759 part.5 PluginInstanceChild should post received native key event to chrome process if the key combination may be a shortcut key r?jimm draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 14 Apr 2016 17:25:32 +0900 - rev 350794
Push 15419 by masayuki@d-toybox.com at Thu, 14 Apr 2016 08:57:08 +0000
Bug 1257759 part.5 PluginInstanceChild should post received native key event to chrome process if the key combination may be a shortcut key r?jimm When PluginInstanceChild receives native key events, it should post the events to the chrome process first for checking if the key combination is reserved. However, posting all key events to the chrome process may make damage to the performance of text input. Therefore, this patch starts to post a key event whose key combination may be a shortcut key. However, for avoiding to shuffle the event order, it posts following key events until all posted key events are handled by the chrome process. For receiving response from widget, this patch defines nsIKeyEventInPluginCallback. It's specified by nsIWidget::OnKeyEventInPluginProcess() for ensuring the caller will receive the reply. Basically, the caller of nsIWidget::OnKeyEventInPluginProcess() should reply to the child process. However, if the widget is a PuppetWidget, it cannot return the result synchronously. Therefore, PuppetWidget::OnKeyEventInPluginProcess() returns NS_SUCCESS_EVENT_HANDLED_ASYNCHRONOUSLY and stores the callback to mKeyEventInPluginCallbacks. Then, TabParent::HandledKeyEventBeforePlugin() will call PuppetWidget::HandledKeyEventBeforePlugin(). MozReview-Commit-ID: G6brOU26NwQ
817699505d0f1a3ad8796eb08b5c34495cce02e6: bug 1234158 add support for GTK 3.20 scrollbars draft
Martin Stransky <stransky@redhat.com> and Karl Tomlinson <karlt+@karlt.net> - Thu, 14 Apr 2016 17:46:07 +1200 - rev 350793
Push 15418 by ktomlinson@mozilla.com at Thu, 14 Apr 2016 08:52:36 +0000
bug 1234158 add support for GTK 3.20 scrollbars MozReview-Commit-ID: 69amrMoCEbj
93f1cf1c81aeda5b48e459881d7913cacf5c0f41: bug 1234158 rename GtkThemeWidgetType enum to WidgetNodeType as it will differentiate GTK CSS nodes r?stransky draft
Karl Tomlinson <karlt+@karlt.net> - Thu, 14 Apr 2016 17:47:20 +1200 - rev 350792
Push 15418 by ktomlinson@mozilla.com at Thu, 14 Apr 2016 08:52:36 +0000
bug 1234158 rename GtkThemeWidgetType enum to WidgetNodeType as it will differentiate GTK CSS nodes r?stransky MozReview-Commit-ID: s83gCp4Iu1
613bddd86a5a532c47098472cedb82e0d758d54a: Add tests for notifications and set the BaseNotification as the default in wait_for_notification r?sydpolk, maja_zf draft
Dave Hunt <dhunt@mozilla.com> - Thu, 14 Apr 2016 09:00:30 +0100 - rev 350791
Push 15417 by dhunt@mozilla.com at Thu, 14 Apr 2016 08:52:08 +0000
Add tests for notifications and set the BaseNotification as the default in wait_for_notification r?sydpolk, maja_zf MozReview-Commit-ID: 7XnM6bjOYbk
ea8d6275454cf841ed54f5f2f0c52f44977c3228: Add tests for notifications and set the BaseNotification as the default in wait_for_notification draft
Dave Hunt <dhunt@mozilla.com> - Thu, 14 Apr 2016 09:00:30 +0100 - rev 350790
Push 15416 by dhunt@mozilla.com at Thu, 14 Apr 2016 08:49:10 +0000
Add tests for notifications and set the BaseNotification as the default in wait_for_notification MozReview-Commit-ID: 7XnM6bjOYbk
450dbf5323cb10934b900146d9e6c1e7c11d9deb: Bug 1260084 - Part3.Remove unnecessary css animation mochitest. r?birtles draft
Mantaroh Yoshinaga <mantaroh@gmail.com> - Thu, 14 Apr 2016 17:42:39 +0900 - rev 350789
Push 15415 by mantaroh@gmail.com at Thu, 14 Apr 2016 08:44:59 +0000
Bug 1260084 - Part3.Remove unnecessary css animation mochitest. r?birtles MozReview-Commit-ID: CXI6ryeXjdW
3765b77f2bc6be31687785919b095bb2532206ef: Bug 1260084 - Part2.Copy css animation mochitest to web-platform tests. r?birtles draft
Mantaroh Yoshinaga <mantaroh@gmail.com> - Thu, 14 Apr 2016 17:42:01 +0900 - rev 350788
Push 15415 by mantaroh@gmail.com at Thu, 14 Apr 2016 08:44:59 +0000
Bug 1260084 - Part2.Copy css animation mochitest to web-platform tests. r?birtles MozReview-Commit-ID: IMcH5yYPun2
a1302a3e865dfd515636e7c70f9dcb3e425caa8c: Bug 1260084 - Part1.Use promise_test instead of async_test. r?birtles draft
Mantaroh Yoshinaga <mantaroh@gmail.com> - Thu, 14 Apr 2016 16:17:48 +0900 - rev 350787
Push 15415 by mantaroh@gmail.com at Thu, 14 Apr 2016 08:44:59 +0000
Bug 1260084 - Part1.Use promise_test instead of async_test. r?birtles MozReview-Commit-ID: 3N7y1HQzqGJ
d361e64d6f3b242d2579111a4dd95a45e1cb40c1: Bug 1244643 - Part 3: move common test cases to a new file. r=hiro draft
Daisuke Akatsuka <daisuke@mozilla-japan.org> - Thu, 14 Apr 2016 17:30:59 +0900 - rev 350786
Push 15414 by bmo:daisuke@mozilla-japan.org at Thu, 14 Apr 2016 08:31:22 +0000
Bug 1244643 - Part 3: move common test cases to a new file. r=hiro MozReview-Commit-ID: G65kDIoGqVK
8538e124d0a2fa7f8d7bae58bb952dbb7f0042e2: Bug 1244643 - Part 2: append tests for easing. r?hiro draft
Daisuke Akatsuka <daisuke@mozilla-japan.org> - Thu, 14 Apr 2016 17:27:12 +0900 - rev 350785
Push 15414 by bmo:daisuke@mozilla-japan.org at Thu, 14 Apr 2016 08:31:22 +0000
Bug 1244643 - Part 2: append tests for easing. r?hiro MozReview-Commit-ID: 3RYWjsViwJZ
3e0003fb799593566e18e968e684d817a375dc47: Bug 1260451 - AndroidManifest: Handle configuration changes for smallestScreenSize and screenLayout. r?snorp draft
Sebastian Kaspari <s.kaspari@gmail.com> - Thu, 14 Apr 2016 10:26:36 +0200 - rev 350784
Push 15413 by s.kaspari@gmail.com at Thu, 14 Apr 2016 08:27:25 +0000
Bug 1260451 - AndroidManifest: Handle configuration changes for smallestScreenSize and screenLayout. r?snorp MozReview-Commit-ID: 1X4sQDotnSG
75ecf03c80d64e80fe68cd22ac156421e5419fc4: Bug 1257759 part.10 PluginInstanceChild should consume WM_*CHAR messages which follow consumed WM_*KEYDOWN or WM_*KEYUP message r?jimm draft
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 13 Apr 2016 20:44:16 +0900 - rev 350783
Push 15412 by masayuki@d-toybox.com at Thu, 14 Apr 2016 08:17:29 +0000
Bug 1257759 part.10 PluginInstanceChild should consume WM_*CHAR messages which follow consumed WM_*KEYDOWN or WM_*KEYUP message r?jimm nsWindow for Windows cannot decide if a preceding WM_*KEYDOWN or WM_*KEYUP which is a preceding message of WM_*CHAR is consumed because nsWindow cannot know if WM_*CHAR message came from same window which received the preceding WM_*KEYDOWN or WM_*KEYUP. Therefore, PluginInstanceChild should do that. MozReview-Commit-ID: 1uuZ0nTJ5Xb
8b697badb36397e4b9fa483bee4486e3ed9eefcc: Bug 1257759 part.9 Implement nsWindow::OnKeyEventInPluginProcess() on Windows r?jimm draft
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 13 Apr 2016 18:43:20 +0900 - rev 350782
Push 15412 by masayuki@d-toybox.com at Thu, 14 Apr 2016 08:17:29 +0000
Bug 1257759 part.9 Implement nsWindow::OnKeyEventInPluginProcess() on Windows r?jimm Implementing nsWindow::OnKeyEventInPluginProcess() on Windows. This patch makes NativeKey class dispatches eKeyDownOnPlugin and eKeyUpOnPlugin when the method is called. MozReview-Commit-ID: L8yRZvDaQKR
4fd45a4154e89124c30b2bd804ff895f758ea232: Bug 1257759 part.8 nsXBLWindowKeyHandler should handle eKeyDownOnPlugin and eKeyUpOnPlugin events only with reserved shortcut key handlers r?smaug draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 14 Apr 2016 16:00:00 +0900 - rev 350781
Push 15412 by masayuki@d-toybox.com at Thu, 14 Apr 2016 08:17:29 +0000
Bug 1257759 part.8 nsXBLWindowKeyHandler should handle eKeyDownOnPlugin and eKeyUpOnPlugin events only with reserved shortcut key handlers r?smaug eKeyDownOnPlugin (mozkeydownonplugin) and eKeyUpOnPlugin (mozkeyuponplugin) should execute if the key combination is reserved by the linked <command> element. Note that there is no eKeyPressOnPlugin. Therefore, eKeyDownOnPlugin may execute shortcut key handler which is registered as a keypress event handler. MozReview-Commit-ID: CpjsFW02y26
3efb613aa49dc1250136092391256631b744a8c4: Bug 1257759 part.7 Add new internal events which represent key events on plugin r?smaug draft
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 11 Apr 2016 17:31:18 +0900 - rev 350780
Push 15412 by masayuki@d-toybox.com at Thu, 14 Apr 2016 08:17:29 +0000
Bug 1257759 part.7 Add new internal events which represent key events on plugin r?smaug If a plugin process posts native key events to the widget, it needs to check if the key combination is reserved by chrome because if it's reserved by chrome, the reserved shortcut key handler should be executed and the event shouldn't be handled by the focused plugin. This patches add eKeyDownOnPlugin and eKeyUpOnPlugin. nsXBLWindowKeyHandler will listen to them and handle them as normal keydown and keypress or keyup event. Note that these events won't be fired on content in the default event group and won't be sent to the remote process. MozReview-Commit-ID: H5OKPLtVdr6
7e15a675efe6640588d796018a55a2ec89ec48e4: Bug 1257759 part.6 Keep event order between keyboard events and IME events in a plugin process r?jimm draft
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 11 Apr 2016 20:20:53 +0900 - rev 350779
Push 15412 by masayuki@d-toybox.com at Thu, 14 Apr 2016 08:17:29 +0000
Bug 1257759 part.6 Keep event order between keyboard events and IME events in a plugin process r?jimm On Windows, applications cannot handle IME messages asynchronously. Therefore, we cannot put off to send IME messages to plugin even if there are some pending keyboard events which were posted to the parent process. This patch makes PluginInstanceChild consume all key events which are returned from the parent process during IME composition. And when an IME composition is committed, mark pending key events as outdated. MozReview-Commit-ID: 7P3LEJ6pDir
1371b5852bc806a2df4afe8bf3b64d624ee7b3f9: Bug 1257759 part.5 PluginInstanceChild should post received native key event to chrome process if the key combination may be a shortcut key r?jimm draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 14 Apr 2016 17:08:11 +0900 - rev 350778
Push 15412 by masayuki@d-toybox.com at Thu, 14 Apr 2016 08:17:29 +0000
Bug 1257759 part.5 PluginInstanceChild should post received native key event to chrome process if the key combination may be a shortcut key r?jimm When PluginInstanceChild receives native key events, it should post the events to the chrome process first for checking if the key combination is reserved. However, posting all key events to the chrome process may make damage to the performance of text input. Therefore, this patch starts to post a key event whose key combination may be a shortcut key. However, for avoiding to shuffle the event order, it posts following key events until all posted key events are handled by the chrome process. For receiving response from widget, this patch defines nsIKeyEventInPluginCallback. It's specified by nsIWidget::OnKeyEventInPluginProcess() for ensuring the caller will receive the reply. Basically, the caller of nsIWidget::OnKeyEventInPluginProcess() should reply to the child process. However, if the widget is a PuppetWidget, it cannot return the result synchronously. Therefore, PuppetWidget::OnKeyEventInPluginProcess() returns NS_SUCCESS_EVENT_HANDLED_ASYNCHRONOUSLY and stores the callback to mKeyEventInPluginCallbacks. Then, TabParent::HandledKeyEventBeforePlugin() will call PuppetWidget::HandledKeyEventBeforePlugin(). MozReview-Commit-ID: G6brOU26NwQ
5219da31ca02b1e2202ad8229220108956ea9c1e: Bug 1259355 - MozReview practice; r?chunmin draft
Chun-Min Chang <chun.m.chang@gmail.com> - Wed, 13 Apr 2016 13:59:38 +0800 - rev 350777
Push 15411 by bmo:cchang@mozilla.com at Thu, 14 Apr 2016 08:15:35 +0000
Bug 1259355 - MozReview practice; r?chunmin
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip