ee3418d4f7dbd6f52766a4f66c9911ac7c3e48d3: Bug 1380301 - Add missing "#ifdef MOZ_ENABLE_SKIA_PDF" to nsDeviceContextSpecWin.h draft
Farmer Tseng <fatseng@mozilla.com> - Thu, 13 Jul 2017 13:07:18 +0800 - rev 608064
Push 68170 by bmo:fatseng@mozilla.com at Thu, 13 Jul 2017 05:37:40 +0000
Bug 1380301 - Add missing "#ifdef MOZ_ENABLE_SKIA_PDF" to nsDeviceContextSpecWin.h MozReview-Commit-ID: YxvOID7Xbp
3d7cea6274afe55413f35ffe8237aa25caea4780: Bug 1380558 - Take viewport into account when aligning grid line numbers. r?gl draft
Micah Tigley <tigleym@gmail.com> - Wed, 12 Jul 2017 23:22:41 -0600 - rev 608063
Push 68169 by bmo:tigleym@gmail.com at Thu, 13 Jul 2017 05:25:33 +0000
Bug 1380558 - Take viewport into account when aligning grid line numbers. r?gl MozReview-Commit-ID: HdG4NHnVxUw
50b98c3ff6caf331344f1e84512e341a6e44d00d: Bug 1377523 - Part 6: fix in webconsole/. r=pbro
Yoshi Huang <allstars.chh@mozilla.com> - Mon, 10 Jul 2017 15:18:53 +0800 - rev 608062
Push 68169 by bmo:tigleym@gmail.com at Thu, 13 Jul 2017 05:25:33 +0000
Bug 1377523 - Part 6: fix in webconsole/. r=pbro Use srcdoc for iframe.
b09f9523c66fca85bef460036899265cee6d86e4: Bug 1377523 : Part 5: fix styleeditor/. r=pbro
Yoshi Huang <allstars.chh@mozilla.com> - Mon, 10 Jul 2017 14:49:25 +0800 - rev 608061
Push 68169 by bmo:tigleym@gmail.com at Thu, 13 Jul 2017 05:25:33 +0000
Bug 1377523 : Part 5: fix styleeditor/. r=pbro Fixed browser_styleeditor_highlight-selector.js
e836466814de9d3ff3ca2f7bc6ef5316cafdb134: Bug 1377523 - Part 4: fix devtools/client/shared/test. r=pbro
Yoshi Huang <allstars.chh@mozilla.com> - Mon, 10 Jul 2017 14:46:23 +0800 - rev 608060
Push 68169 by bmo:tigleym@gmail.com at Thu, 13 Jul 2017 05:25:33 +0000
Bug 1377523 - Part 4: fix devtools/client/shared/test. r=pbro Move data: URIs in devtools/client/shared/test to seperate files.
e29e8a32baf4f77b79ea54424c82cad5cd4a5741: Bug 1377523 - Part 3: fix failure in sourceeditor/. r=pbro
Yoshi Huang <allstars.chh@mozilla.com> - Mon, 10 Jul 2017 17:41:43 +0800 - rev 608059
Push 68169 by bmo:tigleym@gmail.com at Thu, 13 Jul 2017 05:25:33 +0000
Bug 1377523 - Part 3: fix failure in sourceeditor/. r=pbro Don't use data: URI in sourceeditor/
cbfb8a4915441bbd91643e759137f644a10b8d57: Bug 1377523 - Part 2: fix for browser_toolbox_*. r=pbro
Yoshi Huang <allstars.chh@mozilla.com> - Mon, 10 Jul 2017 12:30:10 +0800 - rev 608058
Push 68169 by bmo:tigleym@gmail.com at Thu, 13 Jul 2017 05:25:33 +0000
Bug 1377523 - Part 2: fix for browser_toolbox_*. r=pbro fixed the tests in devtools/client/framework/test/ to not to use data: URI.
a790d8b9abb134def8432afa20d45ae75df9511e: Bug 1377523 - Part 1: add dummy.xul. r=smaug
Yoshi Huang <allstars.chh@mozilla.com> - Fri, 30 Jun 2017 14:11:34 -0700 - rev 608057
Push 68169 by bmo:tigleym@gmail.com at Thu, 13 Jul 2017 05:25:33 +0000
Bug 1377523 - Part 1: add dummy.xul. r=smaug ExtensionParent.jsm uses a data: URI window, and will cause this XUL window as a cross-origin window, so we replace it with a dummy.xul
3fe4adc63baf237235f439667af42cc5f9d460f9: Bug 1379933 (part 5) - Tweak ProfileBuffer arguments. r=mstange.
Nicholas Nethercote <nnethercote@mozilla.com> - Thu, 13 Jul 2017 11:05:34 +1000 - rev 608056
Push 68169 by bmo:tigleym@gmail.com at Thu, 13 Jul 2017 05:25:33 +0000
Bug 1379933 (part 5) - Tweak ProfileBuffer arguments. r=mstange. This patch changes ProfileBuffer arguments from pointers to references. For functions that modify the ProfileBuffer, it also moves the argument to the end.
f7e6d96eb514e1f50933cc5ff8064afb0e5830da: Bug 1379933 (part 4) - Start all ProfilerBuffer methods with an upper case letter. r=mstange.
Nicholas Nethercote <nnethercote@mozilla.com> - Thu, 13 Jul 2017 11:05:31 +1000 - rev 608055
Push 68169 by bmo:tigleym@gmail.com at Thu, 13 Jul 2017 05:25:33 +0000
Bug 1379933 (part 4) - Start all ProfilerBuffer methods with an upper case letter. r=mstange.
158b7d6d7ea6c5f4e5e6093eb2be51da1bf590ab: Bug 1379933 (part 3) - Start all ProfilerBufferEntry methods with an upper case letter. r=mstange.
Nicholas Nethercote <nnethercote@mozilla.com> - Thu, 13 Jul 2017 11:05:29 +1000 - rev 608054
Push 68169 by bmo:tigleym@gmail.com at Thu, 13 Jul 2017 05:25:33 +0000
Bug 1379933 (part 3) - Start all ProfilerBufferEntry methods with an upper case letter. r=mstange. Also, hasKind() can be removed.
00674f36f7904356b5bf2aba2779fe0cfad445cc: Bug 1379933 (part 2) - Improve ProfileBuffer's handling of labels and dynamic strings. r=mstange.
Nicholas Nethercote <nnethercote@mozilla.com> - Thu, 13 Jul 2017 11:05:27 +1000 - rev 608053
Push 68169 by bmo:tigleym@gmail.com at Thu, 13 Jul 2017 05:25:33 +0000
Bug 1379933 (part 2) - Improve ProfileBuffer's handling of labels and dynamic strings. r=mstange. When a sample with a label and a dynamic string is written to the ProfileBuffer, the profiler currently joins them together (up to a max length of 512, omitting any that exceed this) and then writes a CodeLocation entry with an empty string followed by a sequence of EmbeddedString entries. When parsing those entries, we allow a length up to 8192, but that limit is never reached due to the prior limit of 512. This patch makes the following changes. - Removes the joining at write time. Labels and dynamic strings are now written separately into the ProfileBuffer. The 512 limit still applies, but just for dynamic strings; dynamic strings longer than that are replaced with "(too long)". (Labels also always take up one entry, because they only require a single pointer, because they are always static strings.) The joining is now done when the ProfileBuffer is parsed, and the max length for the joined string is still 512; any strings exceeding 512 at that point are truncated, rather than omitted. (This also happens to be outside the profier's critical section.) - Renames CodeLocation as Label and EmbeddedString as DynamicStringFragment. This makes the ProfileBuffer entry names better match the names used in GeckoProfiler.h. - Moves AddDynamicCodeLocation(), now called addDynamicStringEntry(), into ProfileBuffer. - Adds some testing of long and overly-long dynamic strings to the GTest.
d4d99d47b9fa2166105b03cb7cb86c18930f6e6b: Bug 1379933 (part 1) - Remove Sample entries from the ProfileBuffer. r=mstange.
Nicholas Nethercote <nnethercote@mozilla.com> - Tue, 11 Jul 2017 20:12:24 +1000 - rev 608052
Push 68169 by bmo:tigleym@gmail.com at Thu, 13 Jul 2017 05:25:33 +0000
Bug 1379933 (part 1) - Remove Sample entries from the ProfileBuffer. r=mstange. They serve no useful purpose.
bf8fee7089b41586de21735f0af564295ef27ca7: Bug 1380431 - fix DrawTargetCairo::Snapshot error note to check for surface before accessing status. r=mchang
Lee Salzman <lsalzman@mozilla.com> - Wed, 12 Jul 2017 23:38:36 -0400 - rev 608051
Push 68169 by bmo:tigleym@gmail.com at Thu, 13 Jul 2017 05:25:33 +0000
Bug 1380431 - fix DrawTargetCairo::Snapshot error note to check for surface before accessing status. r=mchang MozReview-Commit-ID: DNTHv4NKjzq
eb39f860d7b33cf3506677734268d26d1f9e757c: Bug 1380083 - Pull in upstream ICU patch that changes '\' to '/' in #include. r=andre,m_kato
Tom Ritter <tom@mozilla.com> - Wed, 12 Jul 2017 12:34:50 -0500 - rev 608050
Push 68169 by bmo:tigleym@gmail.com at Thu, 13 Jul 2017 05:25:33 +0000
Bug 1380083 - Pull in upstream ICU patch that changes '\' to '/' in #include. r=andre,m_kato Upstream: http://bugs.icu-project.org/trac/changeset/40102 MozReview-Commit-ID: 88aECdijOxr
ff468ed8e5a4aa2fb44b9583ea1adb7e68d2a5ba: Bug 1379108 - (followup) Fix localization notes for FormValidationDateTimeRangeOverflow/Underflow strings. comment-only, DONTBUILD
Jessica Jong <jjong@mozilla.com> - Thu, 13 Jul 2017 11:19:40 +0800 - rev 608049
Push 68169 by bmo:tigleym@gmail.com at Thu, 13 Jul 2017 05:25:33 +0000
Bug 1379108 - (followup) Fix localization notes for FormValidationDateTimeRangeOverflow/Underflow strings. comment-only, DONTBUILD
d6bf703c5deaf1e328babd03d5e68ff2a4ffe10e: Bug 1308876 - Add crashtest that used to hang Firefox. r=dholbert
Xidorn Quan <me@upsuper.org> - Wed, 12 Jul 2017 19:37:13 -0700 - rev 608048
Push 68169 by bmo:tigleym@gmail.com at Thu, 13 Jul 2017 05:25:33 +0000
Bug 1308876 - Add crashtest that used to hang Firefox. r=dholbert MozReview-Commit-ID: 2ZCrhcV5i2G
7d4d90362c1f80efff9e674f0d9962d1aa13ef37: Bug 1308876 - Preserve behavior of ignoring parent dirty bit for column groups. r=dholbert
L. David Baron <dbaron@dbaron.org> - Wed, 12 Jul 2017 19:37:12 -0700 - rev 608047
Push 68169 by bmo:tigleym@gmail.com at Thu, 13 Jul 2017 05:25:33 +0000
Bug 1308876 - Preserve behavior of ignoring parent dirty bit for column groups. r=dholbert In the existing code, the parent having NS_FRAME_IS_DIRTY is not propagated to column groups because nsTableFrame::ReflowColGroups checks the child dirty bit before constructing the reflow state for the child. This preserves that behavior in the presence of the primary patch in bug 1308876. I noticed this while debugging the assertion count failure of layout/base/crashtests/470851-1.xhtml . It doesn't help that failure, but it still seems like the safe thing to do. MozReview-Commit-ID: EhfIQQkeaJx
1e3130e96f03b7e3bff220e05c5e06b54f0c285f: Bug 1308876 - Mark child frames as dirty before starting reflow of the parent, so that if we reflow a child twice, it's only dirty the first time. r=dholbert
L. David Baron <dbaron@dbaron.org> - Wed, 12 Jul 2017 19:37:12 -0700 - rev 608046
Push 68169 by bmo:tigleym@gmail.com at Thu, 13 Jul 2017 05:25:33 +0000
Bug 1308876 - Mark child frames as dirty before starting reflow of the parent, so that if we reflow a child twice, it's only dirty the first time. r=dholbert This is the primary patch in this bug, and makes the performance improvement that fixes this bug. The assertion count increase for layout/generic/crashtests/1015844.html is accompanied by a layout change in the testcase as well. However, I'm not planning to fix it in this sequence; fundamentally columnsets with specified heights inside a paginated context (like another columnset) do not work in any reasonable way, and changing the number of times we reflow them can change the layout. At least, assuming I didn't lose something in the process of simplifying the testcase. ISSUES: - may make block inside XUL worse in performance by marking dirty more (see subdoc in Firefox UI, or text control innards?) MozReview-Commit-ID: GdOvPynqcFP
395b6c53e42b064c4463d5156df5baa23d98dc5d: Bug 1308876 - Avoid initiating special-height reflow as a result of new paginated non-dirty reflows. r=dholbert
L. David Baron <dbaron@dbaron.org> - Wed, 12 Jul 2017 19:37:12 -0700 - rev 608045
Push 68169 by bmo:tigleym@gmail.com at Thu, 13 Jul 2017 05:25:33 +0000
Bug 1308876 - Avoid initiating special-height reflow as a result of new paginated non-dirty reflows. r=dholbert Previously, in paginated mode, all reflows were dirty reflows, since tables do not split outside of printing, and prior to the primary patch in bug 1308876, all reflows during printing are dirty reflows. (The isPaginated test here is actually for real pages, not fragmentation in general. However, the use here is appropriate for the meaning of whether it's possible for the table to fragment.) The fact that all reflows were dirty reflows meant that the NS_FRAME_CONTAINS_RELATIVE_BSIZE flag was always cleared immediately before reflow in ReflowInput::InitResizeFlags (which might also have set the flag on *ancestors*). This meant that, prior to the primary patch in bug 1308876, the initial value of needToInitiateSpecialReflow that was initialized from the presence of the NS_FRAME_CONTAINS_RELATIVE_BSIZE flag was always false. This patch preserves that initialization in the presence of the change in the primary patch in bug 1308876. This caused a failure in a single test in our test suite, and in a rather complicated way. The test was layout/base/crashtests/470851-1.xhtml, in which there was both a difference in assertion count (due to the bogus assertion "data loss - incomplete row needed more height than available, on top of page" in nsTableRowGroupFrame::SplitRowGroup, whose companion assertion "data loss - complete row needed more height than available, on top of page" is already just an NS_WARNING) that caused a test failure, and a difference in layout (the test split across 3 pages rather than 2) that did not cause a test failure. This patch fixes the difference in layout. The immediate cause of the layout difference was that a cell (the second outermost) on the second page had a height, computed in CalcUnpaginatedBSize, that was large enough to cause it to need to continue onto the third page. This height came (via nsTableRowFrame::GetUnpaginatedBSize) from the UnpaginatedHeightProperty stored on the first-in-flow of its row, on the first page, stored by CacheRowBSizesForPrinting called in nsTableRowGroupFrame::ReflowChildren during the reflow of its row group on the first page, in a special height reflow initiated during the second-pass constrained-height reflow of the table (still, second-outermost) on the first page, due to the change being fixed in this patch. MozReview-Commit-ID: 3E84VwdXuPs
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip