eb6c2abb687140a1290b1a3b36fab56dd5f6cf93: Bug 1463919 - Call Play() when activating attribute based autoplay. r?jya draft
Chris Pearce <cpearce@mozilla.com> - Tue, 26 Jun 2018 14:16:13 +1200 - rev 811174
Push 114217 by bmo:cpearce@mozilla.com at Wed, 27 Jun 2018 04:21:06 +0000
Bug 1463919 - Call Play() when activating attribute based autoplay. r?jya When autoplay is requested by setting the "autoplay" attribute, we should check whether autoplay is allowed in HTMLMediaElement::CheckAutoplayDataReady() and if not we should prompt for user consent. This ensures that <video ... autoplay/> will prompt for consent when used on a page without a pre-existing allow/block permission. MozReview-Commit-ID: 77pJR2Ybn2i
119857f8cfcbae4791e6832b91ea86a5bac914f8: Bug 1463919 - Have HTMLMediaElement ask for autoplay permission when playback otherwise blocked. r?jya draft
Chris Pearce <cpearce@mozilla.com> - Fri, 22 Jun 2018 10:14:33 +1200 - rev 811173
Push 114217 by bmo:cpearce@mozilla.com at Wed, 27 Jun 2018 04:21:06 +0000
Bug 1463919 - Have HTMLMediaElement ask for autoplay permission when playback otherwise blocked. r?jya MozReview-Commit-ID: Ejv0UKBjSVf
abefff91d90a16a37c8038b66dffdd16031564e7: Bug 1463919 - Add AutoplayRequest to encapsulate asking for autoplay permission. r?smaug draft
Chris Pearce <cpearce@mozilla.com> - Fri, 22 Jun 2018 11:57:24 +1200 - rev 811172
Push 114217 by bmo:cpearce@mozilla.com at Wed, 27 Jun 2018 04:21:06 +0000
Bug 1463919 - Add AutoplayRequest to encapsulate asking for autoplay permission. r?smaug Add an implementation of nsIContentPermissionRequest to encapsulate requesting permission from the user to autoplay audible media. All documents in the tab request permission using the top level document's origin, so the AutoplayRequest instance for a tab is stored on the top level content window of the tab. AutoplayRequest ensures that there's only a single prompt shown at once. MozReview-Commit-ID: 2u3aLnEa21z
13b71ced6f0cf08eef3ba7796e5912dbfd2aa69b: Bug 1463919 - Remove dead code in browser_block_autoplay_media.js test. r?mconley draft
Chris Pearce <cpearce@mozilla.com> - Wed, 27 Jun 2018 15:24:00 +1200 - rev 811171
Push 114216 by bmo:cpearce@mozilla.com at Wed, 27 Jun 2018 03:52:23 +0000
Bug 1463919 - Remove dead code in browser_block_autoplay_media.js test. r?mconley eslint pointed failed with an error: browser_block_autoplay_media.js:25:7 | 'audio' is not defined. (no-undef) It turns out, the function this line resides in is never called, so we can remove it. MozReview-Commit-ID: EUe5cRwGhfA
9261e2232aa934944c01a59fe9a1ba62fd303c69: Bug 1463919 - Adjust mochitests to pass after changes. r?jya draft
Chris Pearce <cpearce@mozilla.com> - Tue, 26 Jun 2018 15:57:17 +1200 - rev 811170
Push 114216 by bmo:cpearce@mozilla.com at Wed, 27 Jun 2018 03:52:23 +0000
Bug 1463919 - Adjust mochitests to pass after changes. r?jya Prior to the changes in this bug, a document would request autoplay permission for its own origin, and not use the top level document's origin for the permission check. Since now we use the top level document's origin for requesting autoplay permission, some mochitests need to change, namely: * test_autoplay_policy_permission.html can use file_autoplay_policy_activation_frame.html directly. The test was failing because its helper page was loaded same origin and the helper page was testing if cross origins iframes could play; since we use the top level document's permission request, this no longer effectively tests whether the cross origin child can autoplay, as the cross origin child just uses the top level window's origin for requests. So we can instead load the helper window cross orgin instead, and remove one layers of helpers. Also an issue here is the way I was waiting for a new window to load was racy, so now we wait for loading windows to send us a "ready" message. * test_autoplay_policy_activation.html; this test's helper needs to wait for loading windows to send it a "ready" message, as its helper is shared with the above test. MozReview-Commit-ID: LvRa4G7tqFw
5ec30d2124368165db67415e56a78f1a5aca3dd9: Bug 1463919 - Call Play() when activating attribute based autoplay. r?jya draft
Chris Pearce <cpearce@mozilla.com> - Tue, 26 Jun 2018 14:16:13 +1200 - rev 811169
Push 114216 by bmo:cpearce@mozilla.com at Wed, 27 Jun 2018 03:52:23 +0000
Bug 1463919 - Call Play() when activating attribute based autoplay. r?jya When autoplay is requested by setting the "autoplay" attribute, we should check whether autoplay is allowed in HTMLMediaElement::CheckAutoplayDataReady() and if not we should prompt for user consent. This ensures that <video ... autoplay/> will prompt for consent when used on a page without a pre-existing allow/block permission. MozReview-Commit-ID: 77pJR2Ybn2i
e09e70e18c2c96ff027eb9a65f0f0c6ec4e8a282: Bug 1463919 - Tests for prompting for permission to autoplay. r?jya,r?mconley draft
Chris Pearce <cpearce@mozilla.com> - Mon, 25 Jun 2018 15:35:33 +1200 - rev 811168
Push 114216 by bmo:cpearce@mozilla.com at Wed, 27 Jun 2018 03:52:23 +0000
Bug 1463919 - Tests for prompting for permission to autoplay. r?jya,r?mconley Test that video that autoplays via a play() call or via autoplay attribute plays or is blocked or prompts with a doorhanger for approval and plays when "allow" clicked and doesn't when "block" clicked. MozReview-Commit-ID: CpftV6RQbtU
a0cedd4adabb59ddad2c06e8d254136db1ed987f: Bug 1463919 - Test that starting play from tab audio indicator overrides block autoplay. r?mconley draft
Chris Pearce <cpearce@mozilla.com> - Mon, 25 Jun 2018 13:25:34 +1200 - rev 811167
Push 114216 by bmo:cpearce@mozilla.com at Wed, 27 Jun 2018 03:52:23 +0000
Bug 1463919 - Test that starting play from tab audio indicator overrides block autoplay. r?mconley MozReview-Commit-ID: 4k7c7qw6cCq
10df89785583a4edb2607b765b4dd56e3369376f: Bug 1463919 - Ensure resuming via audio tab indicator bypasses autoplay permission check. r?mconley draft
Chris Pearce <cpearce@mozilla.com> - Thu, 21 Jun 2018 14:14:20 +1200 - rev 811166
Push 114216 by bmo:cpearce@mozilla.com at Wed, 27 Jun 2018 03:52:23 +0000
Bug 1463919 - Ensure resuming via audio tab indicator bypasses autoplay permission check. r?mconley If the user opens a tab in the background, and that tab tries to play media, we'll delay playing that media until the tab is brought to the foreground. But the user can explicitly start playback of such delayed media by clicking the "play" icon we show in the tab indicator. Then if autoplay is disabled, we'll block the play (unless the origin is whitelisted). This is bad, as the user has clearly indicated intent to play media in this tab. So this patch adds an override flag that we set when the user starts playback via the audio tab indicator that short-circuits the autoplay blocking logic, ensuring we play in this case. MozReview-Commit-ID: Koir3xhF696
12de3d9868f0920a25a45164485b906d38fa40d9: Bug 1463919 - Have HTMLMediaElement ask for autoplay permission when playback otherwise blocked. r?jya draft
Chris Pearce <cpearce@mozilla.com> - Fri, 22 Jun 2018 10:14:33 +1200 - rev 811165
Push 114216 by bmo:cpearce@mozilla.com at Wed, 27 Jun 2018 03:52:23 +0000
Bug 1463919 - Have HTMLMediaElement ask for autoplay permission when playback otherwise blocked. r?jya MozReview-Commit-ID: Ejv0UKBjSVf
14558402124c3c2fdb0c67adab89b35f4d5ac3e4: Bug 1463919 - Add AutoplayRequest to encapsulate asking for autoplay permission. r?smaug draft
Chris Pearce <cpearce@mozilla.com> - Fri, 22 Jun 2018 11:57:24 +1200 - rev 811164
Push 114216 by bmo:cpearce@mozilla.com at Wed, 27 Jun 2018 03:52:23 +0000
Bug 1463919 - Add AutoplayRequest to encapsulate asking for autoplay permission. r?smaug Add an implementation of nsIContentPermissionRequest to encapsulate requesting permission from the user to autoplay audible media. All documents in the tab request permission using the top level document's origin, so the AutoplayRequest instance for a tab is stored on the top level content window of the tab. AutoplayRequest ensures that there's only a single prompt shown at once. MozReview-Commit-ID: 2u3aLnEa21z
b7accec9d206a6150ff7400f9c229e000856d043: Bug 1471425 - Require rustc 1.28 in configure when building with Tup. draft
Chris Manchester <cmanchester@mozilla.com> - Tue, 26 Jun 2018 20:32:16 -0700 - rev 811163
Push 114215 by bmo:cmanchester@mozilla.com at Wed, 27 Jun 2018 03:32:43 +0000
Bug 1471425 - Require rustc 1.28 in configure when building with Tup. MozReview-Commit-ID: 9FCs5FPcchC
53398269672a901ce66ea920c91dd2bd46c4e495: Bug 1471425 - Print output of cargo if it fails when run as a part of the Tup backend. draft
Chris Manchester <cmanchester@mozilla.com> - Tue, 26 Jun 2018 18:17:45 -0700 - rev 811162
Push 114215 by bmo:cmanchester@mozilla.com at Wed, 27 Jun 2018 03:32:43 +0000
Bug 1471425 - Print output of cargo if it fails when run as a part of the Tup backend. MozReview-Commit-ID: BRVSLE83WMH
1558bed8298b8d10251ac18ba1219155c4665941: Bug 1471066 - Convert browser_startup_content.js to a whitelist. r=florian draft
Felipe Gomes <felipc@gmail.com> - Wed, 27 Jun 2018 00:10:42 -0300 - rev 811161
Push 114214 by felipc@gmail.com at Wed, 27 Jun 2018 03:11:34 +0000
Bug 1471066 - Convert browser_startup_content.js to a whitelist. r=florian This should prevent new files from being added in the startup path for content processes MozReview-Commit-ID: GrZ0dmslUyl
ee45612a92c2a5561e0ad05313de63df978a1057: Bug 1471452 - Remove any remaining fail expectations for contain:paint tests'. r=dholbert draft
Yusuf Sermet <ysermet@mozilla.com> - Tue, 26 Jun 2018 19:46:23 -0700 - rev 811160
Push 114213 by bmo:ysermet@mozilla.com at Wed, 27 Jun 2018 02:47:00 +0000
Bug 1471452 - Remove any remaining fail expectations for contain:paint tests'. r=dholbert MozReview-Commit-ID: JTG4q8mkEt1
f6259dc5eb894eb4f1dd7aa372c3298ae2f74e68: Bug 1465046 - Remove ProcessHandler.waitForFinish(). r=whimboo draft
Akshay Chiwhane <achiwhane@gmail.com> - Sun, 24 Jun 2018 14:06:29 -0400 - rev 811159
Push 114212 by bmo:achiwhane@gmail.com at Wed, 27 Jun 2018 02:30:20 +0000
Bug 1465046 - Remove ProcessHandler.waitForFinish(). r=whimboo MozReview-Commit-ID: JQnHZrLLDLv *** Bug 1465046 - Remove depricated function call in unit-nsinstall tests. r=whimboo MozReview-Commit-ID: DFAMmN8CFiH
619afb2eec650572c13e48ff094e34fd856391bb: Bug 1471437 - Part 2: Reset mPaintRect only when the new building rect is different, and update mPaintRectValid when it is. r=mattwoodrow draft
Bas Schouten <bschouten@mozilla.com> - Wed, 27 Jun 2018 03:46:26 +0200 - rev 811158
Push 114211 by bschouten@mozilla.com at Wed, 27 Jun 2018 02:24:46 +0000
Bug 1471437 - Part 2: Reset mPaintRect only when the new building rect is different, and update mPaintRectValid when it is. r=mattwoodrow MozReview-Commit-ID: 5djSr7eNk8W
7b2a786caf13ce4ec0122b8f53abc75c1daafb82: Bug 1469790 - Build for NEON by default when targetting Android arm. r?build draft
Mike Hommey <mh+mozilla@glandium.org> - Wed, 27 Jun 2018 08:07:27 +0900 - rev 811157
Push 114210 by bmo:mh+mozilla@glandium.org at Wed, 27 Jun 2018 01:53:50 +0000
Bug 1469790 - Build for NEON by default when targetting Android arm. r?build The media/libpng/moz.build file overrides the C standard used via -std=c89, per bug 1371266, which conflicts with the use of the arm_neon.h header: compilation fails on the inline keyword, which didn't exist in C89. We thus "bump" to the GNU89 standard, which is C89+GNU extensions, including inline.
a23427916397d1adf10ceca4ee56d128d78c58e2: Bug 1471437 - Part 1: Store the previous paint rect before occlusion culling. r=mattwoodrow draft
Bas Schouten <bschouten@mozilla.com> - Wed, 27 Jun 2018 03:41:31 +0200 - rev 811156
Push 114209 by bschouten@mozilla.com at Wed, 27 Jun 2018 01:43:13 +0000
Bug 1471437 - Part 1: Store the previous paint rect before occlusion culling. r=mattwoodrow MozReview-Commit-ID: 8Bw9hsPcipZ
6fc117a391539ee4a15b13da4de7dffe10cf60fa: Bug 1471437 - Part 1: Store the previous paint rect before occlusion culling. r=mattwoodrow draft
Bas Schouten <bschouten@mozilla.com> - Wed, 27 Jun 2018 03:38:23 +0200 - rev 811155
Push 114208 by bschouten@mozilla.com at Wed, 27 Jun 2018 01:38:52 +0000
Bug 1471437 - Part 1: Store the previous paint rect before occlusion culling. r=mattwoodrow MozReview-Commit-ID: 8Bw9hsPcipZ
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 tip