e7b783653f009b996cbac8178cf27ae8c36c65cc: Bug 1351739 - Part 4 - Handle selected tab temporarily being undefined. r?sebastian draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 01 Apr 2017 17:07:16 +0200 - rev 558377
Push 52870 by mozilla@buttercookie.de at Fri, 07 Apr 2017 14:56:19 +0000
Bug 1351739 - Part 4 - Handle selected tab temporarily being undefined. r?sebastian I think this can happen if closing a tab (via the back button) simultaneously also triggered an activity switch (by selecting the parent tab). In that case the tab is closed, but formal selection of the new tab only completes after we've switched activities. At the moment activity switching might trigger an application-background/foreground cycle, which means we could hit the selected tab temporarily being undefined in Gecko. MozReview-Commit-ID: 6p4cOqj29HX
dff4624391ab358dea8d72fd385a938b102123a8: Bug 1351739 - Part 3 - Switch activities when a custom tab is selected/unselected. r?sebastian draft
Jan Henning <jh+bugzilla@buttercookie.de> - Wed, 05 Apr 2017 21:37:57 +0200 - rev 558376
Push 52870 by mozilla@buttercookie.de at Fri, 07 Apr 2017 14:56:19 +0000
Bug 1351739 - Part 3 - Switch activities when a custom tab is selected/unselected. r?sebastian On tab selection, the Tabs instance now checks whether the type of the tab to be selected matches the currently selected activity. If it doesn't, the tab switching is aborted and instead, an intent for the correct activity is sent. When the new activity launches, it finds that the intent also includes a tab ID, which means that instead of opening a new tab we retry the tab selection, which will then succeed now that we're in the correct activity. Because for custom tabs the launch intent can contain all sorts of customisations, we now have to save the intent when a custom tab is opened for the first time, so that later on, when switching e.g. from BrowserApp back to a custom tab we can use the correct intent to launch the custom tab activity. We also have to modify the intent handling when GeckoApp is starting up - the intent handling of the GeckoApp + BrowserApp combo requires "nulling" out (by setting it to ACTION_MAIN) the current intent if it's not a fresh intent (e.g. the activity is recreated after having been destroyed or relaunched from the task switcher). For custom tabs/web apps on the other hand we want to keep the intent around even in those cases, as - especially for custom tabs - it contains state we need even later on. Additionally, we want to make use of GeckoApp's startup code for either selecting the tab from the intent or loading a new tab. Therefore we save the launch intent and restore it once GeckoApp's onCreate() has run. Note that this solution is not entirely correct either, because with this each onCreate() call will open a new tab, even when this is not necessary when only the activity (but not Firefox and Gecko as a whole) had been destroyed. This behaviour will be fixed as part of bug 1352997. MozReview-Commit-ID: KWdkweKBocz
912dfe93109783be1165933d2eb521a682873fc8: Bug 1351739 - Part 2 - Convert CustomTabsActivity to SafeIntents. r?sebastian draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 02 Apr 2017 14:09:36 +0200 - rev 558375
Push 52870 by mozilla@buttercookie.de at Fri, 07 Apr 2017 14:56:19 +0000
Bug 1351739 - Part 2 - Convert CustomTabsActivity to SafeIntents. r?sebastian These are potentially untrusted external intents, so we should use SafeIntents for interacting with them. MozReview-Commit-ID: 3nmjg85wbr1
f3958803c28010b73703775756ed5581f378e3aa: Bug 1351739 - Part 1 - Track the currently active activity. r?sebastian draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 02 Apr 2017 11:22:12 +0200 - rev 558374
Push 52870 by mozilla@buttercookie.de at Fri, 07 Apr 2017 14:56:19 +0000
Bug 1351739 - Part 1 - Track the currently active activity. r?sebastian Required because later on, we'll need to know if we're in the correct activity for a tab or need to switch activities. As a follow-up, we can later also hook up our current manual activity tracking from GeckoApplication to this. MozReview-Commit-ID: 5lZrAMsB9Gy
d3ee3f135bc0b6885da6cdad1e7057edf6e4645e: Bug 1352997 - Part 0 - Use INVALID_TAB_ID more. r?sebastian draft
Jan Henning <jh+bugzilla@buttercookie.de> - Thu, 06 Apr 2017 21:30:55 +0200 - rev 558373
Push 52870 by mozilla@buttercookie.de at Fri, 07 Apr 2017 14:56:19 +0000
Bug 1352997 - Part 0 - Use INVALID_TAB_ID more. r?sebastian -1 is probably not all that mysterious as far as magic numbers go, but still... MozReview-Commit-ID: zK3P6HeWzK
9a66c995e3935a6a8486667d94700739c411f8a0: Bug 1351739 - Part -1 - Remove unneeded imports. r?sebastian draft
Jan Henning <jh+bugzilla@buttercookie.de> - Thu, 06 Apr 2017 21:24:09 +0200 - rev 558372
Push 52870 by mozilla@buttercookie.de at Fri, 07 Apr 2017 14:56:19 +0000
Bug 1351739 - Part -1 - Remove unneeded imports. r?sebastian MozReview-Commit-ID: Ev6jl4N3K0g
7610da714354a888bc356a832d4c7ad5d8552fd7: Bug 1354560 - Fix IONFLAGS=help message draft
Ted Campbell <tcampbell@mozilla.com> - Fri, 07 Apr 2017 10:51:28 -0400 - rev 558371
Push 52869 by bmo:tcampbell@mozilla.com at Fri, 07 Apr 2017 14:51:52 +0000
Bug 1354560 - Fix IONFLAGS=help message MozReview-Commit-ID: 8O5vDfuxpaa
e6b957cbba4dc8dc16403423560d441ae49c1ef4: Bug 1345225 - Check if webRequest filters overlap with host permissions draft
Tomislav Jovanovic <tomica@gmail.com> - Sun, 26 Mar 2017 20:53:28 +0200 - rev 558370
Push 52868 by bmo:tomica@gmail.com at Fri, 07 Apr 2017 14:50:01 +0000
Bug 1345225 - Check if webRequest filters overlap with host permissions MozReview-Commit-ID: 1tMHynv9FBO
c577195b5e9677ad14f931813215d45f9ace216a: Bug 1341761 - stylo: Add -moz-element support r?xidorn draft
Nazım Can Altınova <canaltinova@gmail.com> - Thu, 06 Apr 2017 20:25:34 +0300 - rev 558369
Push 52867 by bmo:canaltinova@gmail.com at Fri, 07 Apr 2017 14:48:00 +0000
Bug 1341761 - stylo: Add -moz-element support r?xidorn MozReview-Commit-ID: I9gxAoFJH9C
f3193c380476727d5324c92af0dca7069809d824: Bug 1341761 - Convert nsStyleImage::mElementId to use nsIAtom r?xidorn draft
Nazım Can Altınova <canaltinova@gmail.com> - Fri, 07 Apr 2017 17:32:59 +0300 - rev 558368
Push 52867 by bmo:canaltinova@gmail.com at Fri, 07 Apr 2017 14:48:00 +0000
Bug 1341761 - Convert nsStyleImage::mElementId to use nsIAtom r?xidorn MozReview-Commit-ID: 9YcbhMmXYoi
9fa8d463a876bb644da43aadb6f34d0fd0ff2278: Bug 1349787 - Make sure browser_tabCloseProbes.js waits for tabs to be fully open before closing them. r?Mossop draft
Mike Conley <mconley@mozilla.com> - Fri, 07 Apr 2017 10:45:56 -0400 - rev 558367
Push 52866 by mconley@mozilla.com at Fri, 07 Apr 2017 14:46:37 +0000
Bug 1349787 - Make sure browser_tabCloseProbes.js waits for tabs to be fully open before closing them. r?Mossop The tests in browser_tabCloseProbes.js were closing tabs without waiting for them to be fully open, and when they're not fully open, closing occurs without animation. This was intermittently breaking the test for the probe that checks that we add a count to the right histogram when closing with animation. MozReview-Commit-ID: 5Qz7mZvtbkB
ee2fb7f6cecc4d81c57f50690df8ea1eaeb88b32: Bug 1346256 Part 3: Modify GetCSSStyleRules to collect ServoStyleRules. draft
Brad Werth <bwerth@mozilla.com> - Thu, 06 Apr 2017 13:47:36 -0700 - rev 558366
Push 52865 by bwerth@mozilla.com at Fri, 07 Apr 2017 14:40:44 +0000
Bug 1346256 Part 3: Modify GetCSSStyleRules to collect ServoStyleRules. MozReview-Commit-ID: IMQLykuXjfL
2eb62d9ccb34138e93db2b29ae3b33086977ec61: Bug 1346256 Part 2: Define methods in ServoCSSRuleList to fill a hash of RawServoStyleRule to ServoStyleRule. draft
Brad Werth <bwerth@mozilla.com> - Fri, 07 Apr 2017 07:33:37 -0700 - rev 558365
Push 52865 by bwerth@mozilla.com at Fri, 07 Apr 2017 14:40:44 +0000
Bug 1346256 Part 2: Define methods in ServoCSSRuleList to fill a hash of RawServoStyleRule to ServoStyleRule. MozReview-Commit-ID: 4Swb9KwV0uO
940260a476de5e13a68bec8a62f5d91e4c442d95: Bug 1346256 Part 1: Add FFI interfaces for exposing style sources. draft
Brad Werth <bwerth@mozilla.com> - Thu, 06 Apr 2017 10:19:00 -0700 - rev 558364
Push 52865 by bwerth@mozilla.com at Fri, 07 Apr 2017 14:40:44 +0000
Bug 1346256 Part 1: Add FFI interfaces for exposing style sources. MozReview-Commit-ID: FOQCgXD68E9
804f24c9a51beb029321a9aa9652bc2cb79ef3a0: Bug 1333328 - Refactor cache miss handling mechanism for V2. r?francois draft
Dimi Lee <dlee@mozilla.com> - Fri, 07 Apr 2017 22:36:52 +0800 - rev 558363
Push 52864 by dlee@mozilla.com at Fri, 07 Apr 2017 14:39:24 +0000
Bug 1333328 - Refactor cache miss handling mechanism for V2. r?francois The safebrowsing caching behavior should still be the same after this patch is introduced. Refactor is done by passing cache miss information from nsUrlClassifierDBService to LookupCache. V2 and V4 now both check if a prefix hit negative cache in LookupCache::Has function. MozReview-Commit-ID: DxyAwd6z7US
db2f0bc92dec0408ab9e09949e3b0f0f700e4796: Caching draft
"dlee@" <dlee@mozilla.com> - Fri, 07 Apr 2017 22:07:52 +0800 - rev 558362
Push 52864 by dlee@mozilla.com at Fri, 07 Apr 2017 14:39:24 +0000
Caching MozReview-Commit-ID: JWp9CpxCJfE
e75accd1cb6ee7fe9a1b495626a8d1f5e33e8d05: Bug 1278531 - Disallow adding new "scalar" histograms to Histograms.json. r?gfritzsche draft
Alessio Placitelli <alessio.placitelli@gmail.com> - Fri, 07 Apr 2017 14:56:35 +0200 - rev 558361
Push 52863 by alessio.placitelli@gmail.com at Fri, 07 Apr 2017 13:52:09 +0000
Bug 1278531 - Disallow adding new "scalar" histograms to Histograms.json. r?gfritzsche MozReview-Commit-ID: 1cYpF6N99Zi
1645ec4da160d876dacf43df7617d1f4cda2e2e6: Bug 1341761 - stylo: Add -moz-element support r?xidorn draft
Nazım Can Altınova <canaltinova@gmail.com> - Thu, 06 Apr 2017 20:25:34 +0300 - rev 558360
Push 52862 by bmo:canaltinova@gmail.com at Fri, 07 Apr 2017 13:43:44 +0000
Bug 1341761 - stylo: Add -moz-element support r?xidorn MozReview-Commit-ID: I9gxAoFJH9C
2f2c32262e552a4d8524caf9a550712a14d651d8: Bug 1341761 - Convert nsStyleImage::mElementId to use nsIAtom r?xidorn draft
Nazım Can Altınova <canaltinova@gmail.com> - Fri, 07 Apr 2017 16:38:04 +0300 - rev 558359
Push 52862 by bmo:canaltinova@gmail.com at Fri, 07 Apr 2017 13:43:44 +0000
Bug 1341761 - Convert nsStyleImage::mElementId to use nsIAtom r?xidorn MozReview-Commit-ID: 9YcbhMmXYoi
5be8717b46a26b4b267c86d7b790baafe1088d6f: Bug 1354090: P4. Only assume we have an init segment with moov box. r?gerald draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 07 Apr 2017 15:37:18 +0200 - rev 558358
Push 52861 by bmo:jyavenard@mozilla.com at Fri, 07 Apr 2017 13:38:19 +0000
Bug 1354090: P4. Only assume we have an init segment with moov box. r?gerald By ISOBMFF spec, an init segment is made of an ftyp and a moov box. However the ftyp box serve little purpose as such and only the moov atom contains essential information. Some streams incorrectly add ftyp box all accross the content, despite the ISOBMFF spec stating (4.3.1): Box Type: `ftyp’ Container: File Mandatory: Yes Quantity: Exactly one (but see below) Additionally, with this change the ftyp box may not be present in content following earlier spec. So we will now be able to play them. MozReview-Commit-ID: KijlV5pPLby
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip