e71263c7310982457d97a130cda5e7488c71cc6f: Bug 1455496 - Part 2. Add test of existence of scratchpad's menu bar. r?jdescottes draft
Mantaroh Yoshinaga <mantaroh@gmail.com> - Fri, 20 Apr 2018 18:36:18 +0900 - rev 785529
Push 107248 by bmo:mantaroh@gmail.com at Fri, 20 Apr 2018 09:36:46 +0000
Bug 1455496 - Part 2. Add test of existence of scratchpad's menu bar. r?jdescottes MozReview-Commit-ID: Fn708f10aht
92001b5c4cd16e12d053ac28b6810e92eb2c9953: Bug 1455496 - Part 1. Hide toolbar of scratchpad panel. r?dao draft
Mantaroh Yoshinaga <mantaroh@gmail.com> - Fri, 20 Apr 2018 18:35:53 +0900 - rev 785528
Push 107248 by bmo:mantaroh@gmail.com at Fri, 20 Apr 2018 09:36:46 +0000
Bug 1455496 - Part 1. Hide toolbar of scratchpad panel. r?dao The scratchpad panel(in the toolbox) should not display menu bar. This patch will hide this menu bar if target is toolbox. MozReview-Commit-ID: LEzRPVgPeNs
cc7543678eee70244403b44d7fc66278eff5d5bf: Bug 1455496 - Add test of existence of scratchpad's menu bar. r?jdescottes draft
Mantaroh Yoshinaga <mantaroh@gmail.com> - Fri, 20 Apr 2018 18:34:22 +0900 - rev 785527
Push 107247 by bmo:mantaroh@gmail.com at Fri, 20 Apr 2018 09:34:56 +0000
Bug 1455496 - Add test of existence of scratchpad's menu bar. r?jdescottes MozReview-Commit-ID: JRrCSpbPJsg
019a1ec58da346cb8b647c5cb8c0795f0f928ac9: Bug 1455496 - Hide toolbar of scratchpad panel. r?dao draft
Mantaroh Yoshinaga <mantaroh@gmail.com> - Fri, 20 Apr 2018 18:29:04 +0900 - rev 785526
Push 107247 by bmo:mantaroh@gmail.com at Fri, 20 Apr 2018 09:34:56 +0000
Bug 1455496 - Hide toolbar of scratchpad panel. r?dao The scratchpad panel(in the toolbox) should not display menu bar. This patch will hide this menu bar if target is toolbox. MozReview-Commit-ID: 36UxhMfisXh
e770c5302cabc86e17e10f2c16eabe09517cc3a3: Bug 1371294 - Add a basic test for the follow-on search add-on. r?mikedeboer draft
Mark Banner <standard8@mozilla.com> - Fri, 13 Apr 2018 07:28:54 +0100 - rev 785525
Push 107246 by bmo:standard8@mozilla.com at Fri, 20 Apr 2018 09:34:34 +0000
Bug 1371294 - Add a basic test for the follow-on search add-on. r?mikedeboer MozReview-Commit-ID: Do1msiPVtWZ
d36ca0599a726be1ba97a8ae64e1c76a466615c3: Bug 1371294 - Add a SearchTestUtils.jsm file and stop duplicating promiseNewSearchEngine. r?mikedeboer draft
Mark Banner <standard8@mozilla.com> - Thu, 12 Apr 2018 20:09:01 +0100 - rev 785524
Push 107246 by bmo:standard8@mozilla.com at Fri, 20 Apr 2018 09:34:34 +0000
Bug 1371294 - Add a SearchTestUtils.jsm file and stop duplicating promiseNewSearchEngine. r?mikedeboer MozReview-Commit-ID: IP5iRstshrM
818c9f52bfe85ec61b3c5b34eef264f6c178bc6f: Bug 1448757 part 3 - Remove nsDOMWindowUtils::GetAnimationTypeForLonghand and nsStyleAnimType. r?hiro draft
Xidorn Quan <me@upsuper.org> - Fri, 20 Apr 2018 14:38:46 +1000 - rev 785523
Push 107245 by xquan@mozilla.com at Fri, 20 Apr 2018 09:18:04 +0000
Bug 1448757 part 3 - Remove nsDOMWindowUtils::GetAnimationTypeForLonghand and nsStyleAnimType. r?hiro MozReview-Commit-ID: 8KsNSaDfsbN
021704f4bf40b086d1dfc5988c33644574937a8e: Bug 1448757 part 2 - Move longhand animation type table into devtools. r?daisuke draft
Xidorn Quan <me@upsuper.org> - Fri, 20 Apr 2018 14:06:47 +1000 - rev 785522
Push 107245 by xquan@mozilla.com at Fri, 20 Apr 2018 09:18:04 +0000
Bug 1448757 part 2 - Move longhand animation type table into devtools. r?daisuke After switching to Stylo, animation is handled by Servo, and thus it no longer relies on the animation type recorded in nsCSSPropList.h, and devtools become the only consumer of that information. This patch puts a map of longhands to animation types into devtools instead. The map is extracted from nsCSSPropList.h by the script below based on the logic of nsDOMWindowUtils::GetAnimationTypeForLonghand. There are two reasons that I don't port this into Servo: First, Servo doesn't have a concept of property-level animation type. Animation change in Servo is directly encoded into value types. It means porting this to Servo would require creating a new concept purely for devtools. It's not great because that data doesn't reflect how animation is handled in the engine, and people may keep forgetting to give proper animation type to new animatable types they add. Second, the handling of animation type in devtools also looks rather arbitrary to me. For example, eStyleAnimType_Corner_* types are actually two coordinate values, bug GetAnimationTypeForLonghand returns "coord" for them, and devtools just parses the first value and uses it. This means the animation type here is really more closely related to how devtools handles the value, rather than how the style engine does so. Given above, I decided to put the list into devtools rather than encode the information into Servo code. To encourage people to think about animation handling in devtools for new properties, there is also a new test added to ensure every property has a devtools animation type. The content of ANIMATION_TYPE_FOR_LONGHANDS is generated via running the following script in layout/style: ```python #!/usr/bin/env python3 import subprocess from collections import defaultdict ANIMTYPE_MAPPING = { "Custom": "custom", "Coord": "coord", "Sides_Top": "coord", "Sides_Right": "coord", "Sides_Bottom": "coord", "Sides_Left": "coord", "Corner_TopLeft": "coord", "Corner_TopRight": "coord", "Corner_BottomRight": "coord", "Corner_BottomLeft": "coord", "nscoord": "length", "float": "float", "Color": "color", "ComplexColor": "color", "PaintServer": "paintServer", "Shadow": "shadow", "Discrete": "discrete", "None": "none", } input = b""" #define CSS_PROP(name, id, method, flags, pref, \\ variant, kwtable, animtype) name, flags, animtype #include "nsCSSPropList.h" """ props = subprocess.check_output(["clang", "-E", "-P", "-"], input=input) props = props.decode("ascii") result = defaultdict(list) for line in props.splitlines(): line = line.strip() if not line: continue name, flags, animtype = line.split(", ") assert animtype.startswith("eStyleAnimType_") if "CSS_PROPERTY_PARSE_INACCESSIBLE" in flags: continue animtype = ANIMTYPE_MAPPING[animtype[15:]] result[animtype].append(name) print("[") for animtype, names in result.items(): print(' ["{}", new Set(['.format(animtype)) for name in names: print(' "{}",'.format(name)) print(" ])],") print("]") ``` MozReview-Commit-ID: BGiGq0jUgG5
1eeb2128a0981b852ddc6e655b5e0d17870306ff: Bug 1455282 - [wdspec] Add tests for Close Window command. draft
Henrik Skupin <mail@hskupin.info> - Fri, 20 Apr 2018 10:50:14 +0200 - rev 785521
Push 107244 by bmo:hskupin@gmail.com at Fri, 20 Apr 2018 09:17:50 +0000
Bug 1455282 - [wdspec] Add tests for Close Window command. MozReview-Commit-ID: 13j69lZhr1G
97b8fcc613b60fa0971e8f7010ff741ea9fb5b03: Bug 1453274 - Make ModernMozillaVersion support ESR r=bhearsum draft
Johan Lorenzo <jlorenzo@mozilla.com> - Fri, 20 Apr 2018 11:02:29 +0200 - rev 785520
Push 107243 by bmo:jlorenzo@mozilla.com at Fri, 20 Apr 2018 09:14:32 +0000
Bug 1453274 - Make ModernMozillaVersion support ESR r=bhearsum MozReview-Commit-ID: LKs32b67GFL
069f3c5892fef8ce3dd6f89546a3f2d3194c0e07: Bug 1455559: Make FromNode work for references. r?bz,nika draft
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 20 Apr 2018 11:10:12 +0200 - rev 785519
Push 107242 by bmo:emilio@crisal.io at Fri, 20 Apr 2018 09:11:38 +0000
Bug 1455559: Make FromNode work for references. r?bz,nika MozReview-Commit-ID: 1ldU1aKeMzs
8bbf106fb8cedf80b3be4c9e07e9297bc9c804ae: Bug 1449608 - Avoid calling ComputeScrollMetadata repeatedly for same scroll frame and clip. r?mstange draft
Jamie Nicol <jnicol@mozilla.com> - Thu, 19 Apr 2018 14:48:04 +0100 - rev 785518
Push 107241 by bmo:jnicol@mozilla.com at Fri, 20 Apr 2018 09:05:50 +0000
Bug 1449608 - Avoid calling ComputeScrollMetadata repeatedly for same scroll frame and clip. r?mstange Currently in ContainerState::SetupScrollingMetadata we call ComputeScrollMetadata for every layer and for each ASR in the layer's clip chain. If there are many sibling layers with the same clip then this is largely wasted work. This change makes us cache the most recently calculated result, and only recalculate if the ASR or clip is different. There was a small portion of ComputeScrollMetadata that must actually be executed for every layer and ASR in its clip chain. This has been moved to a separate function, ClipLayerToDisplayPort, that is still called every time. MozReview-Commit-ID: 7Zzblmimtc5
6f615862cf064bc578485c0ade5678b5cf50ced3: Bug 1453274 - Make ModernMozillaVersion support ESR r=bhearsum draft
Johan Lorenzo <jlorenzo@mozilla.com> - Fri, 20 Apr 2018 11:02:29 +0200 - rev 785517
Push 107240 by bmo:jlorenzo@mozilla.com at Fri, 20 Apr 2018 09:04:09 +0000
Bug 1453274 - Make ModernMozillaVersion support ESR r=bhearsum MozReview-Commit-ID: LKs32b67GFL
552e98bc27ca5a706ea75913956da20f4481d233: Bug 478035 - Remove the now unnecessary code that attempts to fix a missing places root. r?mak draft
Mark Banner <standard8@mozilla.com> - Thu, 19 Apr 2018 11:17:36 +0100 - rev 785516
Push 107239 by bmo:standard8@mozilla.com at Fri, 20 Apr 2018 09:03:13 +0000
Bug 478035 - Remove the now unnecessary code that attempts to fix a missing places root. r?mak MozReview-Commit-ID: LP3O1JX9V0d
3377c5191b9e75a6467dcb33e810e62862655206: Bug 478035 - Re-create the built-in root folders if they are missing in the places database. r?mak draft
Mark Banner <standard8@mozilla.com> - Wed, 18 Apr 2018 18:29:19 +0100 - rev 785515
Push 107239 by bmo:standard8@mozilla.com at Fri, 20 Apr 2018 09:03:13 +0000
Bug 478035 - Re-create the built-in root folders if they are missing in the places database. r?mak MozReview-Commit-ID: FU7o6q5NpdR
ec3d79d74c1785a7ff95f5fd10cbe0559d81b09a: Bug 478035 - Move the code for obtaining the places built-in folder ids from nsNavBookmarks to Database. r?mak draft
Mark Banner <standard8@mozilla.com> - Wed, 18 Apr 2018 15:53:07 +0100 - rev 785514
Push 107239 by bmo:standard8@mozilla.com at Fri, 20 Apr 2018 09:03:13 +0000
Bug 478035 - Move the code for obtaining the places built-in folder ids from nsNavBookmarks to Database. r?mak MozReview-Commit-ID: 74we2Z47xY
c7ef2aafcd46f10398e57def666c35d899c0a4ab: Bug 1455282 - [wdspec] Add tests for Close Window command. draft
Henrik Skupin <mail@hskupin.info> - Fri, 20 Apr 2018 10:50:14 +0200 - rev 785513
Push 107238 by bmo:hskupin@gmail.com at Fri, 20 Apr 2018 08:52:33 +0000
Bug 1455282 - [wdspec] Add tests for Close Window command. MozReview-Commit-ID: 13j69lZhr1G
2aedc53d71d872b2248336ec14bf19d1cbc222b8: Bug 1455282 - Port Marionette Close Window tests to wdspec. draft
Henrik Skupin <mail@hskupin.info> - Fri, 20 Apr 2018 10:50:14 +0200 - rev 785512
Push 107237 by bmo:hskupin@gmail.com at Fri, 20 Apr 2018 08:50:59 +0000
Bug 1455282 - Port Marionette Close Window tests to wdspec. MozReview-Commit-ID: 13j69lZhr1G
679084c3a88c283a8d5494f3d9e998a9a399b7fc: Bug 1455282 - [wdclient] End session if no more windows are open. draft
Henrik Skupin <mail@hskupin.info> - Thu, 19 Apr 2018 22:40:07 +0200 - rev 785511
Push 107237 by bmo:hskupin@gmail.com at Fri, 20 Apr 2018 08:50:59 +0000
Bug 1455282 - [wdclient] End session if no more windows are open. After closing the last top-level browsing context, the session will be closed too. MozReview-Commit-ID: CVsJpHO34BM
23978b7f3a070edfe2b2b952b6536e0fdf1fb0be: Bug 1455551: Move NS_IMPL_FROMNODE_HELPER and friends to nsINode.h. r?bz draft
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 20 Apr 2018 10:29:25 +0200 - rev 785510
Push 107236 by bmo:emilio@crisal.io at Fri, 20 Apr 2018 08:31:50 +0000
Bug 1455551: Move NS_IMPL_FROMNODE_HELPER and friends to nsINode.h. r?bz MozReview-Commit-ID: 5PajqKEyFEW
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip