e53a1cb59fd67c40304bd568da3d3a7e2569b87f: Bug 1460509 - part 11: Make TextEditRules::CollapseSelectionToTrailingBRIfNeeded() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 11 May 2018 18:40:47 +0900 - rev 798729
Push 110840 by masayuki@d-toybox.com at Wed, 23 May 2018 13:41:58 +0000
Bug 1460509 - part 11: Make TextEditRules::CollapseSelectionToTrailingBRIfNeeded() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato MozReview-Commit-ID: 3ulGUfu1af1
8c820293c9b1e29b8f170c001f985920de16a060: Bug 1460509 - part 10: Make TextEditRules::WillInsertText() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 11 May 2018 18:29:54 +0900 - rev 798728
Push 110840 by masayuki@d-toybox.com at Wed, 23 May 2018 13:41:58 +0000
Bug 1460509 - part 10: Make TextEditRules::WillInsertText() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato MozReview-Commit-ID: RT0Bi9TBwt
36e927743abd7e646870751ac4126c5edc1d7bc6: Bug 1460509 - part 9: Make TextEditRules::WillSetText() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 11 May 2018 17:33:55 +0900 - rev 798727
Push 110840 by masayuki@d-toybox.com at Wed, 23 May 2018 13:41:58 +0000
Bug 1460509 - part 9: Make TextEditRules::WillSetText() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato MozReview-Commit-ID: 9ksPugTVVqh
9271e9273e1af33f91eb4b0d731d022883927f21: Bug 1460509 - part 8: Make TextEditRules::WillDeleteSelection() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 11 May 2018 17:15:53 +0900 - rev 798726
Push 110840 by masayuki@d-toybox.com at Wed, 23 May 2018 13:41:58 +0000
Bug 1460509 - part 8: Make TextEditRules::WillDeleteSelection() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato This patch creates internal method for it as DeleteSelectionWithTransaction() because it needs to create SelectionBatcher and destruction of it may cause destroying the editor. Therefore, unfortunately, all callers of DeleteSelectionWithTransaction() needs to check CanHandleEditAction() manually. If we could use try-catch, we could make it safer, though. MozReview-Commit-ID: 13enOQjEzNn
848da409dcf41cd4c3e4299565b6a4a07f44a5ed: Bug 1460509 - part 7: Make TextEditRules::DidDeleteSelection() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 11 May 2018 16:48:29 +0900 - rev 798725
Push 110840 by masayuki@d-toybox.com at Wed, 23 May 2018 13:41:58 +0000
Bug 1460509 - part 7: Make TextEditRules::DidDeleteSelection() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato And also this patch removes unnecessary arguments from the method. MozReview-Commit-ID: UKscK4vFVX
456816b935ea0e2bc8052cdeaba65d2186928248: Bug 1460509 - part 6: Make TextEditRules::RemoveRedundantTrailingBR() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 11 May 2018 16:36:07 +0900 - rev 798724
Push 110840 by masayuki@d-toybox.com at Wed, 23 May 2018 13:41:58 +0000
Bug 1460509 - part 6: Make TextEditRules::RemoveRedundantTrailingBR() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato MozReview-Commit-ID: HpFo0SiTBWJ
284b619f2e968cb81ccd55b941a5d85bd63c3f48: Bug 1460509 - part 5: Make TextEditRules::CreateTrailingBRIfNeeded() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 11 May 2018 16:31:53 +0900 - rev 798723
Push 110840 by masayuki@d-toybox.com at Wed, 23 May 2018 13:41:58 +0000
Bug 1460509 - part 5: Make TextEditRules::CreateTrailingBRIfNeeded() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato MozReview-Commit-ID: CNTgECam862
5ccf7ab97dc41b8a5df61c8af929d318aaf94046: Bug 1460509 - part 4: Make TextEditRules::CreateBogusNodeIfNeeded() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 11 May 2018 16:24:15 +0900 - rev 798722
Push 110840 by masayuki@d-toybox.com at Wed, 23 May 2018 13:41:58 +0000
Bug 1460509 - part 4: Make TextEditRules::CreateBogusNodeIfNeeded() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato Note that HTMLEditRules::DocumentModifiedWorker() is a runnable method. So, it cannot return nsresult. Therefore, it just checks the result only with NS_WARNING_ASSERTION(). MozReview-Commit-ID: KBSpv5H5KGU
7b2ba37b4f038296072318633aa749a9435962a1: Bug 1460509 - part 3: Make TextEditRules::HideLastPWInput() return NS_ERROR_EDITOR_DESTROYED when it causes destroying the editor r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 11 May 2018 16:08:47 +0900 - rev 798721
Push 110840 by masayuki@d-toybox.com at Wed, 23 May 2018 13:41:58 +0000
Bug 1460509 - part 3: Make TextEditRules::HideLastPWInput() return NS_ERROR_EDITOR_DESTROYED when it causes destroying the editor r?m_kato And also this patch marks it as MOZ_MUST_USE. All callers have to check if the result is NS_ERROR_EDITOR_DESTROYED at least. MozReview-Commit-ID: H4DfU1asPpe
6aec242133f1f4385c0832b5bcb486b221145588: Bug 1460509 - part 2: Make TextEditRules::CreateBR() and TextEditRules::CreateMozBR() return both new <br> element node and error code since if they cause destroying the editor, each caller needs NS_ERROR_EDITOR_DESTROYED result r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 11 May 2018 15:52:24 +0900 - rev 798720
Push 110840 by masayuki@d-toybox.com at Wed, 23 May 2018 13:41:58 +0000
Bug 1460509 - part 2: Make TextEditRules::CreateBR() and TextEditRules::CreateMozBR() return both new <br> element node and error code since if they cause destroying the editor, each caller needs NS_ERROR_EDITOR_DESTROYED result r?m_kato First, this patch changes TextEditRules::CreateBRInternal() to a private method for making any callers use CreateBR() or CreateMozBR() instead. Then, this patch makes TextEditRules::CreateBRInternal() return both nsresult and created <br> element with CreateElementResult class. Finally, this patch makes all callers of them check if they don't return an error code including NS_ERROR_EDITOR_DESTROYED. MozReview-Commit-ID: 18OvPmbDVHK
f035a55c225ed4ecc730daf466d7ee2392314b49: Bug 1460509 - part 1: Declare NS_ERROR_EDITOR_DESTROYED error code and add a check method to TextEditRules whether it can keep handling edit action at a moment r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 24 Apr 2018 15:23:01 +0900 - rev 798719
Push 110840 by masayuki@d-toybox.com at Wed, 23 May 2018 13:41:58 +0000
Bug 1460509 - part 1: Declare NS_ERROR_EDITOR_DESTROYED error code and add a check method to TextEditRules whether it can keep handling edit action at a moment r?m_kato This patch defines NS_ERROR_EDITOR_DESTROYED error code as an editor module specific error code. And creates TextEditRules::CanHandleEditAction() to check if the instance can keep handling edit action. MozReview-Commit-ID: 4qECwNBO0yz
082e633c3669b73600421b8d1ffcf3928510dd07: Bug 1149357: Properly update responsive images for density changes. r?dholbert draft
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 23 May 2018 11:19:49 +0200 - rev 798718
Push 110839 by bmo:emilio@crisal.io at Wed, 23 May 2018 13:21:20 +0000
Bug 1149357: Properly update responsive images for density changes. r?dholbert Before that we were relying on the reflow the viewport resize caused to get the new density. Also mCurrentDensity got out of sync as well. This was generally unsound, since you can stash random media in a sizes attribute. MozReview-Commit-ID: Eqy16ygHRLo
980a8bb1af7e1e4a5274017bd8d319e25ad50038: Bug 1149357: Make nsImageFrame::mIntrinsicSize account for density. r?dholbert draft
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 16 May 2018 19:39:16 +0200 - rev 798717
Push 110839 by bmo:emilio@crisal.io at Wed, 23 May 2018 13:21:20 +0000
Bug 1149357: Make nsImageFrame::mIntrinsicSize account for density. r?dholbert Only doing it in ComputeSize (via GetNaturalSize) is unsound, and the rest of the users of mIntrinsicSize definitely do need scaling accounted for. Move the adjustment to nsImageFrame for two reasons: * Prevents adding more dependencies from nsIImageLoadingContent, which otherwise would need to go away anyway in bug 215083. * Avoids having to duplicate the image orientation logic, since mImage is already an OrientedImage if needed. MozReview-Commit-ID: EA0n0TctZhN
a8dd6aa3bb334f73bc8fef499b48245e9f0fc843: Bug 1463730 - Changes to wpt manifest upload task, r?jgraham draft
Ahilya Sinha <asinha@mozilla.com> - Wed, 23 May 2018 02:25:23 +0530 - rev 798716
Push 110838 by bmo:asinha@mozilla.com at Wed, 23 May 2018 13:15:01 +0000
Bug 1463730 - Changes to wpt manifest upload task, r?jgraham MozReview-Commit-ID: J6Ywh2UsfHd
fa0ab2c27d74f56bcbed39413cf7aa351f88e4d9: Bug 1452666 - Simplify SessionHistory serialization code and test expanded principals are serialized and can restore tabs. r?bz r?mikedeboer draft
Jonathan Kingston <jkt@mozilla.com> - Sat, 19 May 2018 14:42:52 +0100 - rev 798715
Push 110837 by bmo:jkt@mozilla.com at Wed, 23 May 2018 12:55:38 +0000
Bug 1452666 - Simplify SessionHistory serialization code and test expanded principals are serialized and can restore tabs. r?bz r?mikedeboer MozReview-Commit-ID: EV39wz2TFlj
a19a6133cf9705c0603540c5f987fe42370ff224: Bug 1452666 - Using principalToInherit to serialize to SessionHistory when the principal is expanded. r?bz r?mikedeboer draft
Jonathan Kingston <jkt@mozilla.com> - Sat, 19 May 2018 14:42:52 +0100 - rev 798714
Push 110836 by bmo:jkt@mozilla.com at Wed, 23 May 2018 12:53:27 +0000
Bug 1452666 - Using principalToInherit to serialize to SessionHistory when the principal is expanded. r?bz r?mikedeboer MozReview-Commit-ID: EV39wz2TFlj
8b09e35601be1bd6a962afea06bf33d2c0c663a8: Bug 1452666. Implement nsISerializable on expanded principals. r=kmag draft
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 23 May 2018 00:15:05 -0400 - rev 798713
Push 110836 by bmo:jkt@mozilla.com at Wed, 23 May 2018 12:53:27 +0000
Bug 1452666. Implement nsISerializable on expanded principals. r=kmag
d07823bb277a06687967ecbc8ca967c57943945e: Bug 1457110: Restore behavior of maintaining width/height when one of the two is exactly zero. r=jrmuizel draft
Bas Schouten <bschouten@mozilla.com> - Wed, 23 May 2018 14:35:57 +0200 - rev 798712
Push 110835 by bschouten@mozilla.com at Wed, 23 May 2018 12:37:27 +0000
Bug 1457110: Restore behavior of maintaining width/height when one of the two is exactly zero. r=jrmuizel MozReview-Commit-ID: FQBVJhSU0CJ
a032dee1eddc84c4da3500a6be6dc7b036be27b4: bug 1460595 - Test the 'event' ping r?Dexter draft
Chris H-C <chutten@mozilla.com> - Tue, 15 May 2018 16:43:28 -0400 - rev 798711
Push 110834 by bmo:chutten@mozilla.com at Wed, 23 May 2018 12:25:06 +0000
bug 1460595 - Test the 'event' ping r?Dexter MozReview-Commit-ID: 2SJCgXOQNEW
666dc0a8d4f067ed9d774c3c63ecb8ac8af446fe: bug 1460595 - Add meta-telemetry to record how many event pings we're sending r?Dexter draft
Chris H-C <chutten@mozilla.com> - Mon, 14 May 2018 10:43:18 -0400 - rev 798710
Push 110834 by bmo:chutten@mozilla.com at Wed, 23 May 2018 12:25:06 +0000
bug 1460595 - Add meta-telemetry to record how many event pings we're sending r?Dexter MozReview-Commit-ID: 7kxmvItSzEU
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip