e3ef641e67fc134aa7a09d72fa3ca79cf67dce5a: bug 1421084 - part 4/4 - remove nsNSSShutDown.h and (hopefully) all references to it r?ttaubert,mt draft
David Keeler <dkeeler@mozilla.com> - Wed, 24 Jan 2018 14:44:01 -0800 - rev 749623
Push 97464 by bmo:dkeeler@mozilla.com at Wed, 31 Jan 2018 21:01:00 +0000
bug 1421084 - part 4/4 - remove nsNSSShutDown.h and (hopefully) all references to it r?ttaubert,mt MozReview-Commit-ID: 2mhvHsC5Nil
53b72e499e2c2631e1ead8d5c93c2355f1de1d34: bug 1421084 - part 3/4 - remove nsNSSShutDownObject::shutdown and virtualDestroyNSSReference r?ttaubert,mt draft
David Keeler <dkeeler@mozilla.com> - Wed, 24 Jan 2018 14:29:08 -0800 - rev 749622
Push 97464 by bmo:dkeeler@mozilla.com at Wed, 31 Jan 2018 21:01:00 +0000
bug 1421084 - part 3/4 - remove nsNSSShutDownObject::shutdown and virtualDestroyNSSReference r?ttaubert,mt MozReview-Commit-ID: ErL7ZjAGVVC
360b0196c4949cd1e77880458dcb46f5c82d6d83: bug 1421084 - part 2/4 - remove nsNSSShutDownObject::isAlreadyShutDown() r?ttaubert,mt draft
David Keeler <dkeeler@mozilla.com> - Tue, 23 Jan 2018 12:22:56 -0800 - rev 749621
Push 97464 by bmo:dkeeler@mozilla.com at Wed, 31 Jan 2018 21:01:00 +0000
bug 1421084 - part 2/4 - remove nsNSSShutDownObject::isAlreadyShutDown() r?ttaubert,mt MozReview-Commit-ID: DlS16pHE0Ik
270812bffa3d60d56fededdd1ca51d5212aafeb7: bug 1421084 - part 1/4 - remove now-unnecessary nsNSSShutDownPreventionLock r?ttaubert,mt draft
David Keeler <dkeeler@mozilla.com> - Tue, 23 Jan 2018 10:37:47 -0800 - rev 749620
Push 97464 by bmo:dkeeler@mozilla.com at Wed, 31 Jan 2018 21:01:00 +0000
bug 1421084 - part 1/4 - remove now-unnecessary nsNSSShutDownPreventionLock r?ttaubert,mt As of bug 1417680, the NSS shutdown tracking infrastructure is unnecessary (and does nothing anyway). This series of changesets removes the remaining pieces in a way that is hopefully easy to confirm is correct. MozReview-Commit-ID: 8Y5wpsyNlGc
31e3f4d9e8a79525a5cbdacecc71ede516bc25ed: Bug 1424648 - Provide proper face index to FreeType FontDescriptorOutput; r?lsalzman draft
Jan Steffens <jan.steffens@gmail.com> - Wed, 31 Jan 2018 21:42:18 +0100 - rev 749619
Push 97463 by bmo:jan.steffens@gmail.com at Wed, 31 Jan 2018 20:43:29 +0000
Bug 1424648 - Provide proper face index to FreeType FontDescriptorOutput; r?lsalzman OpenType font collections (*.ttc) contain multiple faces in a single file, identified via index. When creating a font descriptor for a FreeType or Fontconfig font, we mistakenly set the index to zero, always. This bug became visible when layout and WebRender would disagree on the face in use, rendering text with the metrics from the proper face but the outlines of another. Unless, of course, the selected face was the first (or only) in the font file. MozReview-Commit-ID: 73qcPOD0HIr
ae0c2ce35aaca45149af26eb2649a79305bde2e3: Bug 1391268 - 4. Display message when APK is corrupt; r?snorp draft
Jim Chen <nchen@mozilla.com> - Wed, 31 Jan 2018 15:34:18 -0500 - rev 749618
Push 97462 by bmo:nchen@mozilla.com at Wed, 31 Jan 2018 20:35:46 +0000
Bug 1391268 - 4. Display message when APK is corrupt; r?snorp Display a message on startup when the APK is corrupt. Right now the "wrong SDK" message is displayed. I think we can potentially reuse that message for Beta, but we need a different message for Nightly. MozReview-Commit-ID: 9NEw252Ytkc
9e0791e673e47a159b07ddd15062682a5dde8181: Bug 1391268 - 3. Detect corrupt APK when loading libs; r?snorp draft
Jim Chen <nchen@mozilla.com> - Wed, 31 Jan 2018 15:34:18 -0500 - rev 749617
Push 97462 by bmo:nchen@mozilla.com at Wed, 31 Jan 2018 20:35:46 +0000
Bug 1391268 - 3. Detect corrupt APK when loading libs; r?snorp On the second pass after failing the first time to load libraries, enable CRC verification and detect if the APK is corrupt. In that case, instead of crashing, we send out an event to the application. MozReview-Commit-ID: 4b97Z8EUHZe
20f0a95273efb12bd58c36a11691e0890e53c03a: Bug 1391268 - 2. Expose mozglue linker error message to Java code; r?glandium draft
Jim Chen <nchen@mozilla.com> - Wed, 31 Jan 2018 15:34:18 -0500 - rev 749616
Push 97462 by bmo:nchen@mozilla.com at Wed, 31 Jan 2018 20:35:46 +0000
Bug 1391268 - 2. Expose mozglue linker error message to Java code; r?glandium This patch makes us save the last message from an ERROR() statement, and use that message when throwing an exception to Java code, in order to make lib loading crash messages a lot more useful. This does make ERROR() not thread-safe, but I think that is okay since it's only used by the single-threaded linker. MozReview-Commit-ID: fEXTYNKUUA
2d18a06806fdbf37822fe1450719175ad91c5813: Bug 1391268 - 1. Add call to verify CRC; r?glandium draft
Jim Chen <nchen@mozilla.com> - Wed, 31 Jan 2018 15:34:17 -0500 - rev 749615
Push 97462 by bmo:nchen@mozilla.com at Wed, 31 Jan 2018 20:35:46 +0000
Bug 1391268 - 1. Add call to verify CRC; r?glandium To reliably detect corrupt APK, this patch adds a GeckoLoader.verifyCRC call to enable verification of CRC before extracting libs. MozReview-Commit-ID: 5EpIfwREGIv
bbb264296e2ea31df801fddea4b955c39117b1f4: Bug 1434430 - [flake8] Upgrade version of flake8 used by |mach lint| to 3.5.0 draft
Andrew Halberstadt <ahalberstadt@mozilla.com> - Tue, 30 Jan 2018 16:43:10 -0500 - rev 749614
Push 97461 by ahalberstadt@mozilla.com at Wed, 31 Jan 2018 20:29:14 +0000
Bug 1434430 - [flake8] Upgrade version of flake8 used by |mach lint| to 3.5.0 MozReview-Commit-ID: BBtM4TEl4Ve
e4a52b0ee03ae2f9edc9114aa2b6e3b8245b582b: Bug 1434430 - [flake8] Fix blank 'except' statements draft
Andrew Halberstadt <ahalberstadt@mozilla.com> - Wed, 31 Jan 2018 14:32:08 -0500 - rev 749613
Push 97461 by ahalberstadt@mozilla.com at Wed, 31 Jan 2018 20:29:14 +0000
Bug 1434430 - [flake8] Fix blank 'except' statements This is a new issue that gets linted with flake8 3.5.0. Basically you should never use: try: ... stuff ... except: ... stuff ... This will catch all exceptions, including KeyboardInterrupt and SystemExit (which is likely not intended). If a catch all is needed, use `except: Exception`. If you *really* mean to also catch KeyboardInterrupt et al, use `except: BaseException`. Of course, being specific is often better than a catch all. MozReview-Commit-ID: FKx80MLO4RN
a9390ee3c81b0739e35c1816f1e6512b69dc4e62: Bug 1434430 - [flake8] Drop support for the FLAKE8 environment variable draft
Andrew Halberstadt <ahalberstadt@mozilla.com> - Wed, 31 Jan 2018 14:05:52 -0500 - rev 749612
Push 97461 by ahalberstadt@mozilla.com at Wed, 31 Jan 2018 20:29:14 +0000
Bug 1434430 - [flake8] Drop support for the FLAKE8 environment variable The flake8 linter requires a specific version of flake8, so that running it locally vs in CI vs in mozreview will all produce the same results. Allowing consumers to specify a custom flake8 binary via the FLAKE8 environment variable, subverts that goal and can result in unexplained errors showing up in some configurations but not others. MozReview-Commit-ID: 1s0nC8ZO6Qi
efb4ea0b7e86e96bebdfb1a183ca2fb0be225fc2: Bug 633062 p8 - Add Async observers. r?markh, kitcambridge, tcsc draft
Edouard Oger <eoger@fastmail.com> - Thu, 04 Jan 2018 18:07:10 -0500 - rev 749611
Push 97460 by bmo:eoger@fastmail.com at Wed, 31 Jan 2018 20:23:24 +0000
Bug 633062 p8 - Add Async observers. r?markh, kitcambridge, tcsc MozReview-Commit-ID: IvwyleXBcNH
746bbe5c6f1555e8b729cbbbc1f8ca57110ae9ba: Bug 1386040 - Write .purgecaches sentinels during |mach watch|. r=gps draft
Nick Alexander <nalexander@mozilla.com> - Fri, 19 Jan 2018 14:40:51 -0800 - rev 749610
Push 97459 by nalexander@mozilla.com at Wed, 31 Jan 2018 20:08:09 +0000
Bug 1386040 - Write .purgecaches sentinels during |mach watch|. r=gps Right now, the "restart flow" that combines |mach watch| with the Quick-Restart Firefox for Desktop shortcut key is frustrated by inconsistencies writing the .purgecaches sentinels for the application. This commit uses recent work from https://bugzilla.mozilla.org/show_bug.cgi?id=1368699 to write the sentinels each time |mach watch| updates the object directory. MozReview-Commit-ID: 62Aa85oT1SE
2a5b67e723f8e1654627e6e6f26704f6a4e57706: Bug 1368699 - Post: Remove PURGECACHES from Make and now-unused app-rules.mk. r=gps draft
Nick Alexander <nalexander@mozilla.com> - Fri, 19 Jan 2018 10:50:42 -0800 - rev 749609
Push 97458 by nalexander@mozilla.com at Wed, 31 Jan 2018 20:06:51 +0000
Bug 1368699 - Post: Remove PURGECACHES from Make and now-unused app-rules.mk. r=gps Now that writing the .purgecaches sentinel is done by |mach build|, we can remove it from Make. In addition, we can cull the now-unused app-rules.mk \o/ MozReview-Commit-ID: 6CnAqLeZwzB
e973d065cd91e965f4103ed2732858e2e7a9c546: Bug 1368699 - Write .purgecaches sentinels every |mach build|. r=gps draft
Nick Alexander <nalexander@mozilla.com> - Wed, 31 Jan 2018 09:25:12 -0800 - rev 749608
Push 97458 by nalexander@mozilla.com at Wed, 31 Jan 2018 20:06:51 +0000
Bug 1368699 - Write .purgecaches sentinels every |mach build|. r=gps This adds a new `post_build` step to each `BuildBackend` implementation, and uses it to write .purgecaches after every |mach build| invocation -- including after |mach build TARGET| invocations. This approach should be more robust than the existing recursive-Make based solution, which seems to not write the .purgecaches files in some situations. In addition, the recursive-Make solution does not generalize to other backends, in particular Tup. It is possible that the Tup backend will handle writing the .purgecaches sentinel as part of its regular build process, but discussions with mshal suggest that there's no convenient way for Tup to write .purgecaches only when something *changes* during the build. That is, Tup can achieve the behaviour implemented by this patch, but it's not easier to do better by not writing .purgecaches when the caches do not in fact need to be purged. I elected to bake in the special knowledge of --enable-application=browser and macOS here since this whole process is special. If we need to generalize, we could add a moz.configure option specifying the purgecaches directories, but it doesn't seem worth it right now. The ideal approach would be to determine FINAL_TARGET from the application directory, but that is determined by DIST_SUBDIR. In addition, it's not clear how to present that information to the post-build step in a build-backend agnostic manner. This will require tweaking as we migrate the macOS bundle handling to moz.build, especially in browser/app. See https://bugzilla.mozilla.org/show_bug.cgi?id=1223748, which could improve this significantly. MozReview-Commit-ID: 63KZy18D23i
3bc8e651c03517edb797032db6ce60ed8852d9fa: Bug 1368699 - Pre: Remove MY_{CONFIG,RULES} Makefile customization hooks. r=gps draft
Nick Alexander <nalexander@mozilla.com> - Fri, 19 Jan 2018 10:43:51 -0800 - rev 749607
Push 97458 by nalexander@mozilla.com at Wed, 31 Jan 2018 20:06:51 +0000
Bug 1368699 - Pre: Remove MY_{CONFIG,RULES} Makefile customization hooks. r=gps I very much doubt these are used, but even if we are -- we shouldn't support this type of local customization, since it doesn't extend to non-Make-based backends. With the customization point removed, there's no way to set ETAGS, so we remove what little support there was for generating Emacs tags. MozReview-Commit-ID: IEF2Q4tISEn
bac123126aa892fbfd42db4b59e32389537feb84: Bug 1429425 - contentScripts.register runAt option should be set to document_idle when missing. draft
Luca Greco <lgreco@mozilla.com> - Wed, 31 Jan 2018 20:55:39 +0100 - rev 749606
Push 97457 by luca.greco@alcacoop.it at Wed, 31 Jan 2018 19:59:52 +0000
Bug 1429425 - contentScripts.register runAt option should be set to document_idle when missing. MozReview-Commit-ID: 1D1J8zmVWqC
b42551eb54a04370aeda30af2828fcc16b816efc: Bug 1429425 - contentScripts.register runAt option should be set to document_idle when missing. draft
Luca Greco <lgreco@mozilla.com> - Wed, 31 Jan 2018 20:55:39 +0100 - rev 749605
Push 97456 by luca.greco@alcacoop.it at Wed, 31 Jan 2018 19:57:09 +0000
Bug 1429425 - contentScripts.register runAt option should be set to document_idle when missing. MozReview-Commit-ID: 1D1J8zmVWqC
3804441e575c9f46fcb03894de3c780eeae7197f: No bug, Automated HPKP preload list update from host bld-linux64-spot-302 - a=hpkp-update
ffxbld - Wed, 31 Jan 2018 11:29:14 -0800 - rev 749604
Push 97456 by luca.greco@alcacoop.it at Wed, 31 Jan 2018 19:57:09 +0000
No bug, Automated HPKP preload list update from host bld-linux64-spot-302 - a=hpkp-update
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip