bug 1421084 - part 4/4 - remove nsNSSShutDown.h and (hopefully) all references to it r?ttaubert,mt MozReview-Commit-ID: 2mhvHsC5Nil

bug 1421084 - part 3/4 - remove nsNSSShutDownObject::shutdown and virtualDestroyNSSReference r?ttaubert,mt MozReview-Commit-ID: ErL7ZjAGVVC

bug 1421084 - part 2/4 - remove nsNSSShutDownObject::isAlreadyShutDown() r?ttaubert,mt MozReview-Commit-ID: DlS16pHE0Ik

bug 1421084 - part 1/4 - remove now-unnecessary nsNSSShutDownPreventionLock r?ttaubert,mt As of bug 1417680, the NSS shutdown tracking infrastructure is unnecessary (and does nothing anyway). This series of changesets removes the remaining pieces in a way that is hopefully easy to confirm is correct. MozReview-Commit-ID: 8Y5wpsyNlGc

Bug 1424648 - Provide proper face index to FreeType FontDescriptorOutput; r?lsalzman OpenType font collections (*.ttc) contain multiple faces in a single file, identified via index. When creating a font descriptor for a FreeType or Fontconfig font, we mistakenly set the index to zero, always. This bug became visible when layout and WebRender would disagree on the face in use, rendering text with the metrics from the proper face but the outlines of another. Unless, of course, the selected face was the first (or only) in the font file. MozReview-Commit-ID: 73qcPOD0HIr

Bug 1391268 - 4. Display message when APK is corrupt; r?snorp Display a message on startup when the APK is corrupt. Right now the "wrong SDK" message is displayed. I think we can potentially reuse that message for Beta, but we need a different message for Nightly. MozReview-Commit-ID: 9NEw252Ytkc

Bug 1391268 - 3. Detect corrupt APK when loading libs; r?snorp On the second pass after failing the first time to load libraries, enable CRC verification and detect if the APK is corrupt. In that case, instead of crashing, we send out an event to the application. MozReview-Commit-ID: 4b97Z8EUHZe

Bug 1391268 - 2. Expose mozglue linker error message to Java code; r?glandium This patch makes us save the last message from an ERROR() statement, and use that message when throwing an exception to Java code, in order to make lib loading crash messages a lot more useful. This does make ERROR() not thread-safe, but I think that is okay since it's only used by the single-threaded linker. MozReview-Commit-ID: fEXTYNKUUA

Bug 1391268 - 1. Add call to verify CRC; r?glandium To reliably detect corrupt APK, this patch adds a GeckoLoader.verifyCRC call to enable verification of CRC before extracting libs. MozReview-Commit-ID: 5EpIfwREGIv

Bug 1434430 - [flake8] Upgrade version of flake8 used by |mach lint| to 3.5.0 MozReview-Commit-ID: BBtM4TEl4Ve

Bug 1434430 - [flake8] Fix blank 'except' statements This is a new issue that gets linted with flake8 3.5.0. Basically you should never use: try: ... stuff ... except: ... stuff ... This will catch all exceptions, including KeyboardInterrupt and SystemExit (which is likely not intended). If a catch all is needed, use `except: Exception`. If you *really* mean to also catch KeyboardInterrupt et al, use `except: BaseException`. Of course, being specific is often better than a catch all. MozReview-Commit-ID: FKx80MLO4RN

Bug 1434430 - [flake8] Drop support for the FLAKE8 environment variable The flake8 linter requires a specific version of flake8, so that running it locally vs in CI vs in mozreview will all produce the same results. Allowing consumers to specify a custom flake8 binary via the FLAKE8 environment variable, subverts that goal and can result in unexplained errors showing up in some configurations but not others. MozReview-Commit-ID: 1s0nC8ZO6Qi

Bug 633062 p8 - Add Async observers. r?markh, kitcambridge, tcsc MozReview-Commit-ID: IvwyleXBcNH

Bug 1386040 - Write .purgecaches sentinels during |mach watch|. r=gps Right now, the "restart flow" that combines |mach watch| with the Quick-Restart Firefox for Desktop shortcut key is frustrated by inconsistencies writing the .purgecaches sentinels for the application. This commit uses recent work from https://bugzilla.mozilla.org/show_bug.cgi?id=1368699 to write the sentinels each time |mach watch| updates the object directory. MozReview-Commit-ID: 62Aa85oT1SE

Bug 1368699 - Post: Remove PURGECACHES from Make and now-unused app-rules.mk. r=gps Now that writing the .purgecaches sentinel is done by |mach build|, we can remove it from Make. In addition, we can cull the now-unused app-rules.mk \o/ MozReview-Commit-ID: 6CnAqLeZwzB

Bug 1368699 - Write .purgecaches sentinels every |mach build|. r=gps This adds a new `post_build` step to each `BuildBackend` implementation, and uses it to write .purgecaches after every |mach build| invocation -- including after |mach build TARGET| invocations. This approach should be more robust than the existing recursive-Make based solution, which seems to not write the .purgecaches files in some situations. In addition, the recursive-Make solution does not generalize to other backends, in particular Tup. It is possible that the Tup backend will handle writing the .purgecaches sentinel as part of its regular build process, but discussions with mshal suggest that there's no convenient way for Tup to write .purgecaches only when something *changes* during the build. That is, Tup can achieve the behaviour implemented by this patch, but it's not easier to do better by not writing .purgecaches when the caches do not in fact need to be purged. I elected to bake in the special knowledge of --enable-application=browser and macOS here since this whole process is special. If we need to generalize, we could add a moz.configure option specifying the purgecaches directories, but it doesn't seem worth it right now. The ideal approach would be to determine FINAL_TARGET from the application directory, but that is determined by DIST_SUBDIR. In addition, it's not clear how to present that information to the post-build step in a build-backend agnostic manner. This will require tweaking as we migrate the macOS bundle handling to moz.build, especially in browser/app. See https://bugzilla.mozilla.org/show_bug.cgi?id=1223748, which could improve this significantly. MozReview-Commit-ID: 63KZy18D23i

Bug 1368699 - Pre: Remove MY_{CONFIG,RULES} Makefile customization hooks. r=gps I very much doubt these are used, but even if we are -- we shouldn't support this type of local customization, since it doesn't extend to non-Make-based backends. With the customization point removed, there's no way to set ETAGS, so we remove what little support there was for generating Emacs tags. MozReview-Commit-ID: IEF2Q4tISEn

Bug 1429425 - contentScripts.register runAt option should be set to document_idle when missing. MozReview-Commit-ID: 1D1J8zmVWqC

Bug 1429425 - contentScripts.register runAt option should be set to document_idle when missing. MozReview-Commit-ID: 1D1J8zmVWqC

No bug, Automated HPKP preload list update from host bld-linux64-spot-302 - a=hpkp-update