e34ebe783cf5ec67155a28fa7af18f27a5232670: Bug 1368318 Call TSFTextStore::ThinksHavingFocus() before clearing sEnabledTextStore since the method refers it r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 29 May 2017 12:18:11 +0900 - rev 586280
Push 61355 by masayuki@d-toybox.com at Tue, 30 May 2017 04:35:58 +0000
Bug 1368318 Call TSFTextStore::ThinksHavingFocus() before clearing sEnabledTextStore since the method refers it r?m_kato MozReview-Commit-ID: GdALZTWioNW
e469250590d6db83ff75b314c6c72d4970b8a449: Bug 1356386 - Support for FxA sign-in deep links r=nechen draft
Grigory Kruglov <gkruglov@mozilla.com> - Tue, 30 May 2017 00:16:21 -0400 - rev 586279
Push 61354 by bmo:gkruglov@mozilla.com at Tue, 30 May 2017 04:18:36 +0000
Bug 1356386 - Support for FxA sign-in deep links r=nechen Adds support for opening FxA deep links, a la firefox://fxa-signin Whitelisted set of query parameters:: - signin - expected to be the "magic token" - entrypoint - for internal tracking purposes - utm_* - all query parameters with utm_ prefix are allowed Deep links are opened as: about:accounts?signin=<token>&entrypoint=<entrypoint>&utm_one=<utm1>.... MozReview-Commit-ID: LfGi1ChPvUr
d797b263377f2fa0b02bf49349e978034b448dd3: Bug 1368596 - Add telemetry to track how often deprecated configs are passed to navigator.requestMediaKeySystemAccess(). r?gerald,r?francois draft
Chris Pearce <cpearce@mozilla.com> - Tue, 30 May 2017 14:26:15 +1200 - rev 586278
Push 61353 by bmo:cpearce@mozilla.com at Tue, 30 May 2017 04:13:44 +0000
Bug 1368596 - Add telemetry to track how often deprecated configs are passed to navigator.requestMediaKeySystemAccess(). r?gerald,r?francois MozReview-Commit-ID: IQ6zRRb31Vc
c87eb1bbf5f0b14cf0a8d67948a7e3ebf94fa2a2: Bug 1296442 - Avoid sync layout and style flush when positioning the arrow for arrow panels. r?dao draft
Mike Conley <mconley@mozilla.com> - Mon, 29 May 2017 17:46:13 -0400 - rev 586277
Push 61352 by mconley@mozilla.com at Tue, 30 May 2017 03:56:35 +0000
Bug 1296442 - Avoid sync layout and style flush when positioning the arrow for arrow panels. r?dao MozReview-Commit-ID: CT0yalTHRgV
293013d970095a2ffcd8af3933e9b246c69fe1eb: Bug 1367028 part 3 - Add tests for the new serialization code. r?dholbert draft
Xidorn Quan <me@upsuper.org> - Tue, 30 May 2017 13:44:44 +1000 - rev 586276
Push 61351 by xquan@mozilla.com at Tue, 30 May 2017 03:53:14 +0000
Bug 1367028 part 3 - Add tests for the new serialization code. r?dholbert MozReview-Commit-ID: GuoOCAKTUuB
2e16a99e38508a12140c2377c0c3c1df93d18f48: Bug 1367028 part 2 - Simplify serialization of computed value of rect values in border-image props when possible. r?dholbert draft
Xidorn Quan <me@upsuper.org> - Tue, 30 May 2017 13:27:46 +1000 - rev 586275
Push 61351 by xquan@mozilla.com at Tue, 30 May 2017 03:53:14 +0000
Bug 1367028 part 2 - Simplify serialization of computed value of rect values in border-image props when possible. r?dholbert MozReview-Commit-ID: s6TP7oB9l3
16fb9aaaf334386f343636071d3e6fb716b03ce7: Bug 1367028 part 1 - Simplify serialization of specified rect values in border-image props when possible. r?dholbert draft
Xidorn Quan <me@upsuper.org> - Mon, 29 May 2017 14:53:58 +1000 - rev 586274
Push 61351 by xquan@mozilla.com at Tue, 30 May 2017 03:53:14 +0000
Bug 1367028 part 1 - Simplify serialization of specified rect values in border-image props when possible. r?dholbert MozReview-Commit-ID: C4mNCHqeIoX
9d94d8b53bdfa6dc5f11e2e4b1ca3f77703bb3ae: Bug 1308337 - Post: Remove old background telemetry code r=nalexander draft
Grigory Kruglov <gkruglov@mozilla.com> - Tue, 11 Apr 2017 22:31:18 -0400 - rev 586273
Push 61350 by bmo:gkruglov@mozilla.com at Tue, 30 May 2017 03:45:10 +0000
Bug 1308337 - Post: Remove old background telemetry code r=nalexander MozReview-Commit-ID: CONHqQWzB6c
4edd3d4d7e0300b82206359adeb293442e3a5540: Bug 1308337 - Part 8: Receive sync telemetry, construct and upload sync pings r=nalexander draft
Grigory Kruglov <gkruglov@mozilla.com> - Mon, 29 May 2017 23:39:35 -0400 - rev 586272
Push 61350 by bmo:gkruglov@mozilla.com at Tue, 30 May 2017 03:45:10 +0000
Bug 1308337 - Part 8: Receive sync telemetry, construct and upload sync pings r=nalexander This patch includes some "pre" work, which should have been a separate patch (my apologies!): - telemetry ping is (needlessly) coupled with information about where it should be uploaded. It wasn't a problem before, since core pings are "upload right away", and are never bundled together during an upload. However, for sync ping, we need to bundle a bunch of "syncs" and "events" (down the road) into one single "sync ping", and as such we need separate representation for a "ping that is not meant to be uploaded directly". - instead of dealing with the coupling directly, a simpler approach is taken: - a "ping" is split into two types of pings: local and outgoing - outgoing ping is what the old "ping" was - a data bundle that is ready to be uploaded - local ping is not meant to be uploaded directly, but is intended to be a part of an outgoing ping, along with other local pings - the main difference between local and outgoing pings is the URL: local pings don't have it while outgoing pings do have it. As background telemetry is received via LocalBroadcastManager, it is processed as follows: - telemetry data is processed into "local pings" which are stored on disk - as enough telemetry is gathered, or we hit one of "let's upload now" conditions, the persisted local pings are gathered into an "outgoing ping" via a SyncPingBundleBuilder, which is persisted on disk. - upload of the bundled "sync ping" is attempted - as individual "local pings" are processed into outgoing "Sync ping" bundles, they are removed from disk Hooks for the upcoming event telemetry data are established, to make that work easier. MozReview-Commit-ID: 4TAT2fKrAYZ
aea89829332e915ef57e2f01d1f644bdc50aa7e3: Bug 1308337 - Post: Remove old background telemetry code r=nalexander draft
Grigory Kruglov <gkruglov@mozilla.com> - Tue, 11 Apr 2017 22:31:18 -0400 - rev 586271
Push 61349 by bmo:gkruglov@mozilla.com at Tue, 30 May 2017 03:40:25 +0000
Bug 1308337 - Post: Remove old background telemetry code r=nalexander MozReview-Commit-ID: CONHqQWzB6c
5985b3ead05b75a4d8b832bdae45f1fb3a85deb0: Bug 1308337 - Part 8: Receive sync telemetry, construct and upload sync pings r=nalexander draft
Grigory Kruglov <gkruglov@mozilla.com> - Mon, 29 May 2017 23:39:35 -0400 - rev 586270
Push 61349 by bmo:gkruglov@mozilla.com at Tue, 30 May 2017 03:40:25 +0000
Bug 1308337 - Part 8: Receive sync telemetry, construct and upload sync pings r=nalexander This patch includes some "pre" work, which should have been a separate patch (my apologies!): - telemetry ping is (needlessly) coupled with information about where it should be upload. It wasn't a problem before, since core pings are "upload right away", and are never bundled together. However, for sync ping, we need to bundle a bunch of "syncs" and "events" (down the road) into one single "sync ping", and as such we need separate representation for a "ping that is not meant to be uploaded directly". - instead of dealing with the coupling directly, a simpler approach is taken: - a "ping" is split into two types of pings: local and outgoing - outgoing ping is what the old "ping" was - a data bundle that is ready to be uploaded - local ping is not meant to be uploaded directly, but is intended to be a part of an outgoing ping, along with other local pings As background telemetry is received via LocalBroadcastManager, it is processed as follows: - telemetry data is processed into "local pings" which are stored on disk - as enough telemetry is gathered, or we hit one of "let's upload now" conditions, the persisted local pings are gathered into an "outgoing ping" via a SyncPingBundleBuilder, which is persisted on disk. - upload of the bundled "sync ping" is attempted - as individual "local pings" are processed into outgoing "Sync ping" bundles, they are removed from disk Hooks for the upcoming event telemtry data are established, to make that work easier. MozReview-Commit-ID: 4TAT2fKrAYZ
c616eb4980cac429febd685165dc5cda37527051: Bug 1308337 - Part 7: Instrument Crypto Keys stage r=nalexander draft
Grigory Kruglov <gkruglov@mozilla.com> - Mon, 29 May 2017 17:20:20 -0400 - rev 586269
Push 61349 by bmo:gkruglov@mozilla.com at Tue, 30 May 2017 03:40:25 +0000
Bug 1308337 - Part 7: Instrument Crypto Keys stage r=nalexander MozReview-Commit-ID: 8a9zKsdhkbv
b5bf02527c4007eb1a387bc768a29e095cbef45e: Bug 1308337 - Part 6: Instrument FetchInfoConfiguration stage r=nalexander draft
Grigory Kruglov <gkruglov@mozilla.com> - Mon, 29 May 2017 21:49:57 -0400 - rev 586268
Push 61349 by bmo:gkruglov@mozilla.com at Tue, 30 May 2017 03:40:25 +0000
Bug 1308337 - Part 6: Instrument FetchInfoConfiguration stage r=nalexander MozReview-Commit-ID: HvDWBVBxb5I
aab5fd5b60e3ae55d0f14907e0157a9c3e91e5d5: Bug 1308337 - Part 5: Instrument FetchInfoCollectionsStage r=nalexander draft
Grigory Kruglov <gkruglov@mozilla.com> - Mon, 29 May 2017 17:18:42 -0400 - rev 586267
Push 61349 by bmo:gkruglov@mozilla.com at Tue, 30 May 2017 03:40:25 +0000
Bug 1308337 - Part 5: Instrument FetchInfoCollectionsStage r=nalexander MozReview-Commit-ID: 64jTO81tDpK
5735b1ccb778f7816bc97305d5c5fbd1cf81ff6c: Bug 1308337 - Part 4: Instrument FetchMetaGlobal stage r=nalexander draft
Grigory Kruglov <gkruglov@mozilla.com> - Mon, 29 May 2017 21:48:05 -0400 - rev 586266
Push 61349 by bmo:gkruglov@mozilla.com at Tue, 30 May 2017 03:40:25 +0000
Bug 1308337 - Part 4: Instrument FetchMetaGlobal stage r=nalexander MozReview-Commit-ID: 6zXqgsAIajN
856c222ceebdda0e3066bc5345926033c230632d: Bug 1308337 - Part 3: Handle sync restarts during telemetry collection r=nalexander draft
Grigory Kruglov <gkruglov@mozilla.com> - Mon, 29 May 2017 21:44:01 -0400 - rev 586265
Push 61349 by bmo:gkruglov@mozilla.com at Tue, 30 May 2017 03:40:25 +0000
Bug 1308337 - Part 3: Handle sync restarts during telemetry collection r=nalexander The approach here is to simply mark current TelemetryCollector as having restarted. The downside of this approach is that two technically separate syncs are combined into one telemetry ping. However, the the two syncs are logically connected to each other, and combining their telemetry will make it easier to figure out why a restart have occurred, as well as what happened after the restart. MozReview-Commit-ID: AtJbge2ulMz
45e9a5d36199ac7ba16c853e783fe2a8825ea90d: Bug 1308337 - Part 2: Instrument Clients engine r=nalexander draft
Grigory Kruglov <gkruglov@mozilla.com> - Mon, 29 May 2017 17:19:29 -0400 - rev 586264
Push 61349 by bmo:gkruglov@mozilla.com at Tue, 30 May 2017 03:40:25 +0000
Bug 1308337 - Part 2: Instrument Clients engine r=nalexander While this is a "named" stage, it doesn't follow the Repository<->Repository semantics of other named stages, and so it needs to be instrumented separately. MozReview-Commit-ID: IKrc5Fb1bYm
a404d2a3e6195417504bbd48e6d5a376a99c7d6a: Bug 1308337 - Part 1: Instrument named sync stages and broadcast collected telemetry r=nalexander draft
Grigory Kruglov <gkruglov@mozilla.com> - Mon, 29 May 2017 17:15:47 -0400 - rev 586263
Push 61349 by bmo:gkruglov@mozilla.com at Tue, 30 May 2017 03:40:25 +0000
Bug 1308337 - Part 1: Instrument named sync stages and broadcast collected telemetry r=nalexander SyncAdapter owns a TelemetryCollector, which is passed into GlobalSession to be "filled up" with telemtry data. GlobalSession obtains instances of TelemetryStageCollector from the TelemetryCollector, and passes them into individual stages. They are filled up with telemetry as stages are executed. Stage errors are recorded in TelemetryStageCollector. Various global errors are recorded in TelemetryCollector itself. On completion (success, failure, abort), telemetry is "built" and broadcasted via LocalBroadcastManager. TelemetryContract is used to establish a key convention between the "broadcaster" and whoever is on the receiving end of this telemetry. This patch instruments stages which follow the Repository<->Repository flow semantics. Other stages, such as the clients stage, meta/globa, info/* and crypto/keys are instrumented separately in follow-up patches. MozReview-Commit-ID: 5VLRc96GLdV
87260a0f43d0adbe70ed5a9a0ed29a6921dcfbb5: Bug 1308337 - Pre: Read hashedFxaUid from the token server r=nalexander draft
Grigory Kruglov <gkruglov@mozilla.com> - Fri, 26 May 2017 17:44:42 -0400 - rev 586262
Push 61349 by bmo:gkruglov@mozilla.com at Tue, 30 May 2017 03:40:25 +0000
Bug 1308337 - Pre: Read hashedFxaUid from the token server r=nalexander This is what we (and other platforms) use as part of telemetry payloads in place of either our local FxA Device ID or the sync client ID. Note that this server API is currently undocumented. Parameter introduced in https://github.com/mozilla-services/tokenserver/commit/2021994ca4682acde83242ee0b96140a05c7c4f5 MozReview-Commit-ID: 64sY5RZ2ZxK
4a59fa49950a05b70b70c307b55d60b0fc768caa: Bug 1308337 - Pre: Don't throw away store and fetch exceptions as they're encountered r=nalexander draft
Grigory Kruglov <gkruglov@mozilla.com> - Fri, 26 May 2017 17:44:27 -0400 - rev 586261
Push 61349 by bmo:gkruglov@mozilla.com at Tue, 30 May 2017 03:40:25 +0000
Bug 1308337 - Pre: Don't throw away store and fetch exceptions as they're encountered r=nalexander We will need them later for telemetry reporting. For now we're just keeping the last exception which we encountered, and Bug 1362208 explores follow-up work to aggregate and count the exceptions as we see them. MozReview-Commit-ID: 8yKkZVGJZ9e
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip