Bug 1312244 - Autocomplete popup does not close when anchor clicked a second time. r?Enn The popuphiding / popuphidden events are fired synchronously when the popup manager decides we're doing a "rollup" (closing the popups due to "outside" events). In the case of this bug, the "outside" event is a click on the input element in content. Here's the kicker though: we handle that popuphidden event and queue a message to content _before_ the mouse event that caused the roll-up is dispatched to content. This means that browser-content.js hears that the popup closed due to popuphidden first, sets its internal state of popupClosed to true, and then the MouseDown on the input field is processed. The nsFormFillController then queries browser-content's AutoCompletePopup, sees its closed, and tells the parent to open it again. This patch adds the norolluponanchor attribute to the panel, which causes us to ignore the rollup event if it happens to be targeted within the anchor rect. This means that we need to trust content to tell us to close the autocomplete popup if the input is clicked when the popup is open (and this is what bug 1183037, which this bug depends on, does). MozReview-Commit-ID: 4A9qVfTYIUz

Bug 1183037: Ensure that autocomplete popups can be displayed again after being dismissed the first time. r=mconley MozReview-Commit-ID: 1MTGIgcWeh4

Bug 1311606 Rename |result| of nsresult variants to |rv| in editor r=smaug For conforming to our coding rules, |result| of nsresult variants should be renamed to |rv|. MozReview-Commit-ID: Bk8CyLAnvXQ

Bug 1312244 - Autocomplete popup does not close when anchor clicked a second time. r?Enn The popuphiding / popuphidden events are fired synchronously when the popup manager decides we're doing a "rollup" (closing the popups due to "outside" events). In the case of this bug, the "outside" event is a click on the input element in content. Here's the kicker though: we handle that popuphidden event and queue a message to content _before_ the mouse event that caused the roll-up is dispatched to content. This means that browser-content.js hears that the popup closed due to popuphidden first, sets its internal state of popupClosed to true, and then the MouseDown on the input field is processed. The nsFormFillController then queries browser-content's AutoCompletePopup, sees its closed, and tells the parent to open it again. This patch adds the norolluponanchor attribute to the panel, which causes us to ignore the rollup event if it happens to be targeted within the anchor rect. This means that we need to trust content to tell us to close the autocomplete popup if the input is clicked when the popup is open (and this is what bug 1183037, which this bug depends on, does). MozReview-Commit-ID: 4A9qVfTYIUz

Bug 1285555 - [flake8] Automatically install/update flake8 package to correct version r?ahal Changed flake8 installation strategy, try to update it using testings/lint/flake8_requirements.txt moved flake8_requirements to tools/lint/flake8 directory extracted common pip invocations to _run_pip function minor fixes fixed calls to check_process (concatenating list to tuple) removed update_pip function and its error message variable if flake8 installation reports and error print pip command output MozReview-Commit-ID: Fmq22aL8dMq

Bug 1311606 Rename |result| of nsresult variants to |rv| in editor r=smaug For conforming to our coding rules, |result| of nsresult variants should be renamed to |rv|. MozReview-Commit-ID: Bk8CyLAnvXQ

Bug 1311606 Rename |result| of nsresult variants to |rv| in editor r=smaug For conforming to our coding rules, |result| of nsresult variants should be renamed to |rv|. MozReview-Commit-ID: Bk8CyLAnvXQ

Bug 1312304: Don't MOZ_CRASH when we use ICE policy "none". r?drno MozReview-Commit-ID: CmRk7o4GdLc

merge mozilla-inbound to mozilla-central a=merge

Bug 1308440 - fix related contextMenu tests; r=Tomcat MozReview-Commit-ID: BXBm42C1Xu

Bug 1287007 - Fix timing issue in browser_ext_windows_create_tabId.js r=billm When tabs.onUpdated is called before the promise of windows.create resolves, the test fails. This test failure was observed on almost every try run with non-e10s, and sometimes (rarely) with e10s. MozReview-Commit-ID: 3znCP1uAUSB

Bug 1287007 - Work-around for test failure in test_ext_cookies.html r=billm There is a timing-sensitive bug in window.create and/or cookies API. I haven't figured out the exact details, but created a minimal test case and reported it at bugzil.la/1309637 Without this patch, the test will fail as described in that bug report. MozReview-Commit-ID: DiJOao8h8Q7

Bug 1287007 - Fix timing issue in browser_ext_contextMenus.js r=billm MozReview-Commit-ID: D7No2zFUWjf

Bug 1287007 - Adjust state test in browser_ext_windows_update.js on Linux r=kmag The test/browser/browser_ext_windows_update.js test fails on Linux. The window ID is not expected to change, add assertion for it to eliminate causes for test failures. Ultimately, it turns out that the test failure is caused by a defect in the implementation, not the test itself, see bugzil.la/1307759 MozReview-Commit-ID: Lo8IIvcfYQ2

Bug 1287007 - Fix timing issue in browser_ext_tabs_onUpdated.js r=billm Reload about:blank tab after opening it and registering the `tabs.onUpdated` event. This is needed because about:blank loads very fast, before the callback of `tabs.create` is invoked. This effect is amplified by the fact that the APIs are now proxied. MozReview-Commit-ID: DgPtIqHSUDx

Bug 1287007 - Remove contextMenusInternal.onClicked r=billm contextMenusInternal.onClicked is already inlined in context_menus.json. It should be removed because otherwise the `browser.contextMenusInternal.onClicked` API would be generated. MozReview-Commit-ID: LAKd2IGM5GU

Bug 1287007 - Fix timing issue in test_delay_update_webextension.js r=rhelmer The onUpdateAvailable listener is asynchronously notified, so the caller (i.e. the test) cannot assume that a message sent immediately after triggering an update would trigger the `browser.test.onMessage` listener that was added in the onUpdateAvailable event handler. MozReview-Commit-ID: 12n64f5l3RA

Bug 1287007 - Make browser_ext_tabs_executeScript.js reliable r=billm The ProxyMessenger registers a listener whenever the first addon starts. Although the map does not have any listeners any more at the end of the test, the listener itself is not removed because the message-manager-close notification is not sent for them. So do not count these persistent message managers in the test. The actual message managers of interest are those associated with the (closed) tab. Note: When the test is run in isolation, it may still fail due to bugzil.la/1293583. See bug for work-around if you want to test. MozReview-Commit-ID: IiDHhmvQPcv

Bug 1287007 - Make window.close in extension pages async r=billm Test coverage by tabs.onRemoved + window.close() in: toolkit/components/extensions/test/mochitest/test_ext_tab_teardown.html MozReview-Commit-ID: 7asg2XGrTaQ

Bug 1287007 - Remove .contentWindow from ProxyContext r=billm MozReview-Commit-ID: ASNigrM07yz