e0d30a6716f7ef4a8679b8a748c704cb27724b69: Bug 1446116 Disable timer jitter on test_ext_alarms.js r?gbrown draft
Tom Ritter <tom@mozilla.com> - Fri, 23 Mar 2018 11:20:20 -0500 - rev 772572
Push 103963 by bmo:tom@mozilla.com at Mon, 26 Mar 2018 13:27:19 +0000
Bug 1446116 Disable timer jitter on test_ext_alarms.js r?gbrown MozReview-Commit-ID: 27Z3vIejv8y
bd96e98837350c2d34fea50990a36d4fd04fdb73: Bug 1448853 - Remove preferencesCloseButton and preferencesDefaultTitle from toolkits preferences.dtd. r?jaws draft
Zibi Braniecki <zbraniecki@mozilla.com> - Mon, 26 Mar 2018 15:16:42 +0200 - rev 772571
Push 103962 by bmo:gandalf@aviary.pl at Mon, 26 Mar 2018 13:17:11 +0000
Bug 1448853 - Remove preferencesCloseButton and preferencesDefaultTitle from toolkits preferences.dtd. r?jaws MozReview-Commit-ID: EwaRXBIbV60
5d1f48fe3b58348d2568d374c1f4eed1766d4a1c: Bug 1447563 - Clear video outputs during shutdown. r?padenot draft
Andreas Pehrson <pehrsons@mozilla.com> - Mon, 26 Mar 2018 14:58:06 +0200 - rev 772570
Push 103961 by bmo:apehrson@mozilla.com at Mon, 26 Mar 2018 13:13:36 +0000
Bug 1447563 - Clear video outputs during shutdown. r?padenot MozReview-Commit-ID: L1ZnhmxrPqa
63fe1df343fcf6dc34fab7c4c0c340fc31394e65: Bug 1448118 - Test for the storage inspector when running inside the browser toolbox r?nchevobbe draft
Mike Ratcliffe <mratcliffe@mozilla.com> - Fri, 23 Mar 2018 15:36:08 +0000 - rev 772569
Push 103960 by bmo:mratcliffe@mozilla.com at Mon, 26 Mar 2018 12:59:50 +0000
Bug 1448118 - Test for the storage inspector when running inside the browser toolbox r?nchevobbe MozReview-Commit-ID: DrNrHwYVo8U
3aff87047aed7f109566cd83786a22ce6871ffda: Bug 1445160 - Enable inspect indexedDBs inside JSMs via Storage Inspector in browser toolbox r?nchevobbe draft
Michael Ratcliffe <mratcliffe@mozilla.com> - Wed, 21 Mar 2018 16:09:57 +0000 - rev 772568
Push 103959 by bmo:mratcliffe@mozilla.com at Mon, 26 Mar 2018 12:59:06 +0000
Bug 1445160 - Enable inspect indexedDBs inside JSMs via Storage Inspector in browser toolbox r?nchevobbe Fixed added file: and moz-extension: to prefix regex. MozReview-Commit-ID: JtCgzquybA4
1df1f1fd2658e428fa60bc26764168564cc82108: Bug 1448786 - Avoid UTF8ToUnicodeBuffer in OSPreferences_win.cpp. draft
Henri Sivonen <hsivonen@hsivonen.fi> - Mon, 26 Mar 2018 15:42:27 +0300 - rev 772567
Push 103958 by bmo:hsivonen@hsivonen.fi at Mon, 26 Mar 2018 12:50:17 +0000
Bug 1448786 - Avoid UTF8ToUnicodeBuffer in OSPreferences_win.cpp. MozReview-Commit-ID: 7a11ogGXo8E
4a9ec19a90261d4f9ffe50bc124a386755296cea: Bug 1402247 - Use encoding_rs for XPCOM string encoding conversions. draft
Henri Sivonen <hsivonen@hsivonen.fi> - Mon, 26 Mar 2018 15:44:50 +0300 - rev 772566
Push 103957 by bmo:hsivonen@hsivonen.fi at Mon, 26 Mar 2018 12:45:43 +0000
Bug 1402247 - Use encoding_rs for XPCOM string encoding conversions. MozReview-Commit-ID: JaJuExfILM9
9a140790298de6d0dadf50ddb9cd9530727e6f1b: Bug 1448786 - Avoid UTF8ToUnicodeBuffer in OSPreferences_win.cpp. draft
Henri Sivonen <hsivonen@hsivonen.fi> - Mon, 26 Mar 2018 15:42:27 +0300 - rev 772565
Push 103957 by bmo:hsivonen@hsivonen.fi at Mon, 26 Mar 2018 12:45:43 +0000
Bug 1448786 - Avoid UTF8ToUnicodeBuffer in OSPreferences_win.cpp. MozReview-Commit-ID: 7a11ogGXo8E
fd00eef060bec1e5abef80184f3c421d6770d404: Bug 1402247 - Use encoding_rs for XPCOM string encoding conversions. draft
Henri Sivonen <hsivonen@hsivonen.fi> - Mon, 26 Mar 2018 09:22:18 +0300 - rev 772564
Push 103956 by bmo:hsivonen@hsivonen.fi at Mon, 26 Mar 2018 12:41:08 +0000
Bug 1402247 - Use encoding_rs for XPCOM string encoding conversions. MozReview-Commit-ID: JaJuExfILM9
69df5599a01bb11d8ea3331d1029d8ca556f3f99: Bug 1437302 - Fix width of textbox[type=number] consumers. r=Paolo draft
Tim Nguyen <ntim.bugs@gmail.com> - Mon, 26 Mar 2018 14:34:39 +0200 - rev 772563
Push 103955 by bmo:ntim.bugs@gmail.com at Mon, 26 Mar 2018 12:36:13 +0000
Bug 1437302 - Fix width of textbox[type=number] consumers. r=Paolo MozReview-Commit-ID: FDLTBoJgZLT
67827a5165321a5a5039e35f7565dfe1f9582e58: Bug 1448282 - TSFTextStore should append a pending action for dispatching keyboard event into the queue if OnUpdateComposition() is called without new range r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 26 Mar 2018 15:07:59 +0900 - rev 772562
Push 103954 by masayuki@d-toybox.com at Mon, 26 Mar 2018 12:27:55 +0000
Bug 1448282 - TSFTextStore should append a pending action for dispatching keyboard event into the queue if OnUpdateComposition() is called without new range r?m_kato OnUpdateComposition() may be called without new range instance by some TIPs when they starts to modify composition string. At this timing, TSFTextStore should append a pending action for dispatching keyboard event into the queue. Without this patch, OnUpdateComposition() creates incomplete pending action for composition update and then, MaybeDispatchKeyboardEventAsProcessedByIME() appends pending action for dispatching keyboard event from another point immediately (e.g., from SetText()), then, finally, the caller of MaybeDispatchKeyboardEventAsProcessedByIME() appends another pending action for composition update with proper composition string. Therefore, the first pending action for composition update clears composition string before actually updating it with new composition string. In other words, new pending action for dispatching keyboard event splits a pending composition update. So, this patch prevents the splitting. MozReview-Commit-ID: 9pYO9pm3Vh9
d561c3d1e96db4c9e861ff4a1097397979e017af: Bug 1447924 - part 7: Implement AddTransactionListener() and RemoveTransactionListener() in EditorBase and TransactionManager r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 23 Mar 2018 18:55:56 +0900 - rev 772561
Push 103954 by masayuki@d-toybox.com at Mon, 26 Mar 2018 12:27:55 +0000
Bug 1447924 - part 7: Implement AddTransactionListener() and RemoveTransactionListener() in EditorBase and TransactionManager r?m_kato nsITransactionListener::AddListener() and nsITransactionListener::RemoveListener() are of course virtual methods. Additionally, they are safe to call without grabbing the TransactionManager's instance with local variable. Therefore, if EditorBase has methods to add/remove transaction listener to/from its transaction manager, we don't need EditorBase::GetTransactionManager() anymore. So, this patch adds AddTransactionListener() and RemoveTransactionListener() to EditorBase and TransactionManager, and remove EditorBase::GetTransactionManager() (not nsIEditor's one). MozReview-Commit-ID: FkPa1YgfagD
35e3fd425510001a14b21aaf7aa12169627b7558: Bug 1447924 - part 6: Implement EnableUndoRedo(), DisableUndoRedo() and ClearUndoRedo() in EditorBase and TransactionManager r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 23 Mar 2018 15:25:13 +0900 - rev 772560
Push 103954 by masayuki@d-toybox.com at Mon, 26 Mar 2018 12:27:55 +0000
Bug 1447924 - part 6: Implement EnableUndoRedo(), DisableUndoRedo() and ClearUndoRedo() in EditorBase and TransactionManager r?m_kato nsIEditor::EnableUndo() and nsITransactionManager::Clear(), nsITransactionManager::SetMaxTransactionCount() are called a lot but they are virtual and some of or all of them are called once. There should be each non-virtual method to do what each root caller wants. Therefore, this patch adds EditorBase::EnableUndoRedo(), EditorBase::DisableUndoRedo(), EditorBase::ClearUndoRedo(), TransactionManager::EnableUndoRedo(), TransactionManager::DisableUndoRedo() and TransactionManager::ClearUndoRedo(). Note that this patch makes TransactionManager won't clear mUndoStack nor mRedoStack if mDoStack is not empty. This is checked only by TransactionManager::SetMaxTransactionCount() but according to the comment, TransactionManager::Clear(), TransactionManager::UndoStack() and TransactionManager::RedoStack() should check it too. MozReview-Commit-ID: 6qBZOQNwdhw
18c264d581294e2880ed442b574eff02655de53d: Bug 1447924 - part 5: Merge TextEditor::Undo()/Redo() with EditorBase::Undo()/Redo() r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 23 Mar 2018 01:21:17 +0900 - rev 772559
Push 103954 by masayuki@d-toybox.com at Mon, 26 Mar 2018 12:27:55 +0000
Bug 1447924 - part 5: Merge TextEditor::Undo()/Redo() with EditorBase::Undo()/Redo() r?m_kato EditorBase::Undo() and EditorBase::Redo() implement only undo/redo function. TextEditor::Undo() and TextEditor::Redo() call them with calling some notification methods. However, this causes redundant AutoRules instance creation and doesn't make sense to separate them under current design. Therefore this patch merges them into TextEditor. Unfortunately, they are XPCOM methods but we cannot implement proper overloads of non-virtual since they are already minimized design. Fortunately, reducing only one virtual call per undo/redo isn't so effective. So, let's keep simpler design. Additionally, this patch makes them stop committing composition because Chrome does not commit composition even if "undo"/"redo" is requested with execCommand() during composition and it doesn't make sense to try to undo/redo after committing composition since first undoable transaction becomes the committing composition and committing composition causes removing all transactions from redo transaction queue. MozReview-Commit-ID: 78qlV2I9Lzk
743920396add88666b3daa7db83e944c6e230221: Bug 1447924 - part 4: Optimize NumbeOfUndoItems(), NumbeOfRedoItems(), CanUndo() and CanRedo() of EditorBase r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 23 Mar 2018 00:08:38 +0900 - rev 772558
Push 103954 by masayuki@d-toybox.com at Mon, 26 Mar 2018 12:27:55 +0000
Bug 1447924 - part 4: Optimize NumbeOfUndoItems(), NumbeOfRedoItems(), CanUndo() and CanRedo() of EditorBase r?m_kato Now, both TransactionManager.h and TransactionStack.h are exposed. So, TransactionManager::GetNumberOfUndoItems() and TransactionManager::GetNumberOfRedoItems() can be rewritten with non-virtual inline methods because they just return mUndoStack.GetSize() and mRedoStack.GetSize(). Then, we can implement EditorBase::NumbeOfUndoItems(), EditorBase::NumberOfRedoItems(), EditorBase::CanUndo() and EditorBase::CanRedo() as inline methods. MozReview-Commit-ID: 3CJd0VrlvFY
61111bbbbc88aa31ba411f9a20e01673c1f93bf0: Bug 1447924 - part 3: Rename nsTransactionStack to mozilla::TransactionStack r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 22 Mar 2018 23:30:48 +0900 - rev 772557
Push 103954 by masayuki@d-toybox.com at Mon, 26 Mar 2018 12:27:55 +0000
Bug 1447924 - part 3: Rename nsTransactionStack to mozilla::TransactionStack r?m_kato Then, all classes in editor/txmgr is now in mozilla namespace and all headers which are included by other directory are now exposed. So, we can remote local includes from other directories now. MozReview-Commit-ID: Kdb1c4Hp9Sy
da42d6df744337b22d8681d95a52681877882343: Bug 1447924 - part 2: Rename nsTransactionItem to mozilla::TransactionItem r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 22 Mar 2018 23:07:36 +0900 - rev 772556
Push 103954 by masayuki@d-toybox.com at Mon, 26 Mar 2018 12:27:55 +0000
Bug 1447924 - part 2: Rename nsTransactionItem to mozilla::TransactionItem r?m_kato MozReview-Commit-ID: 5EmFPCaRYWm
07e519237781310077e821650a45d8297b583b0c: Bug 1447924 - part 1: Rename nsTransactionManager to mozilla::TransactionManager r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 22 Mar 2018 22:15:54 +0900 - rev 772555
Push 103954 by masayuki@d-toybox.com at Mon, 26 Mar 2018 12:27:55 +0000
Bug 1447924 - part 1: Rename nsTransactionManager to mozilla::TransactionManager r?m_kato We should rename nsTransactionManager to mozilla::TransactionManager before adding new non-virtual methods. MozReview-Commit-ID: JsivNVfDhex
84b49cb782620428e404bbc6477c83e1b8363275: Bug 1445825: Enable new animation inspector in nightly. r?gl draft
Daisuke Akatsuka <dakatsuka@mozilla.com> - Mon, 26 Mar 2018 17:00:39 +0900 - rev 772554
Push 103953 by bmo:dakatsuka@mozilla.com at Mon, 26 Mar 2018 12:25:26 +0000
Bug 1445825: Enable new animation inspector in nightly. r?gl MozReview-Commit-ID: LrjeVNrzsGe
402d03840c0c41294401b7b53371eef9d5438dad: Bug 1447599: Make duration of animations to be longer. r?pbro draft
Daisuke Akatsuka <dakatsuka@mozilla.com> - Mon, 26 Mar 2018 16:58:28 +0900 - rev 772553
Push 103953 by bmo:dakatsuka@mozilla.com at Mon, 26 Mar 2018 12:25:26 +0000
Bug 1447599: Make duration of animations to be longer. r?pbro
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip