df021e4d919062d889b0cc323e9824c7aa67228a: Bug 1143575. Convert SetCurrentImage(nullptr) callers to call ClearAllImages instead. r=nical draft
Robert O'Callahan <robert@ocallahan.org> - Thu, 26 Mar 2015 11:40:36 +1300 - rev 275568
Push 3189 by rocallahan@mozilla.com at Fri, 03 Jul 2015 11:12:01 +0000
Bug 1143575. Convert SetCurrentImage(nullptr) callers to call ClearAllImages instead. r=nical
a4d9efef6b2937a831b83c8e937161b14b588d6e: Bug 1143575. Move mLayer from ImageClientBridge up into its superclass ImageClient. r=nical draft
Robert O'Callahan <robert@ocallahan.org> - Wed, 25 Mar 2015 22:02:04 +1300 - rev 275567
Push 3189 by rocallahan@mozilla.com at Fri, 03 Jul 2015 11:12:01 +0000
Bug 1143575. Move mLayer from ImageClientBridge up into its superclass ImageClient. r=nical This simplifies code slightly.
6c9e81f36463d2b9b0f137fbe81cc7323d8d23c4: Bug 1143575. Remove unused CompositableClient::OnTransaction. r=nical draft
Robert O'Callahan <robert@ocallahan.org> - Wed, 25 Mar 2015 21:30:25 +1300 - rev 275566
Push 3189 by rocallahan@mozilla.com at Fri, 03 Jul 2015 11:12:01 +0000
Bug 1143575. Remove unused CompositableClient::OnTransaction. r=nical
5e34aee5440a2989b1bf48d092fdc16de7aa2d05: Bug 1143575. Remove unused AttachAsyncCompositable overload. r=nical draft
Robert O'Callahan <robert@ocallahan.org> - Fri, 08 May 2015 15:58:17 +1200 - rev 275565
Push 3189 by rocallahan@mozilla.com at Fri, 03 Jul 2015 11:12:01 +0000
Bug 1143575. Remove unused AttachAsyncCompositable overload. r=nical
1c67c9e9a17806fdaf8b394e91964b377f728655: Bug 1143575. LayerManagerComposite can't get END_NO_COMPOSITE. r=mattwoodrow draft
Robert O'Callahan <robert@ocallahan.org> - Fri, 15 May 2015 18:33:20 +1200 - rev 275564
Push 3189 by rocallahan@mozilla.com at Fri, 03 Jul 2015 11:12:01 +0000
Bug 1143575. LayerManagerComposite can't get END_NO_COMPOSITE. r=mattwoodrow
e60e5c72e0edcaccfe24dfd66ccfdbc2433a5bf3: Bug 1143575. Remove unused ReturnReleaseFence. r=nical draft
Robert O'Callahan <robert@ocallahan.org> - Tue, 12 May 2015 09:53:22 +1200 - rev 275563
Push 3189 by rocallahan@mozilla.com at Fri, 03 Jul 2015 11:12:01 +0000
Bug 1143575. Remove unused ReturnReleaseFence. r=nical
e3606c50b115fee0e02e58c23842ae0e96536717: Bug 1143575. Remove unused VideoFrameContainer::ClearCurrentFrame aResetSize parameter. r=nical draft
Robert O'Callahan <robert@ocallahan.org> - Mon, 23 Mar 2015 23:45:35 +1300 - rev 275562
Push 3189 by rocallahan@mozilla.com at Fri, 03 Jul 2015 11:12:01 +0000
Bug 1143575. Remove unused VideoFrameContainer::ClearCurrentFrame aResetSize parameter. r=nical
0c78aeea6ef35a7d3cdd0ab288d4834eada099a1: Bug 1143575. Remove unused ImageContainer::ResetPaintCount. r=nical draft
Robert O'Callahan <robert@ocallahan.org> - Mon, 23 Mar 2015 23:39:28 +1300 - rev 275561
Push 3189 by rocallahan@mozilla.com at Fri, 03 Jul 2015 11:12:01 +0000
Bug 1143575. Remove unused ImageContainer::ResetPaintCount. r=nical
a7a344212f6b5e4bc563e07f37cd314f7209d61f: Bug 1143575. Rename mAsyncTransactionTrackeres to mAsyncTransactionTrackers. r=nical draft
Robert O'Callahan <robert@ocallahan.org> - Mon, 23 Mar 2015 23:34:41 +1300 - rev 275560
Push 3189 by rocallahan@mozilla.com at Fri, 03 Jul 2015 11:12:01 +0000
Bug 1143575. Rename mAsyncTransactionTrackeres to mAsyncTransactionTrackers. r=nical
891d6d7afa996c2b073ab34b7d9ac57d60d7b5a3: Bug 1143575. Remove unused VideoFrameContainer::Reset. r=nical draft
Robert O'Callahan <robert@ocallahan.org> - Mon, 23 Mar 2015 23:33:51 +1300 - rev 275559
Push 3189 by rocallahan@mozilla.com at Fri, 03 Jul 2015 11:12:01 +0000
Bug 1143575. Remove unused VideoFrameContainer::Reset. r=nical
7d4d78b27f935ea7d32006d84cc54551d0839844: Bug 1143575. Remove unused CompositionNotifySink. r=nical draft
Robert O'Callahan <robert@ocallahan.org> - Sun, 22 Mar 2015 01:02:25 +1300 - rev 275558
Push 3189 by rocallahan@mozilla.com at Fri, 03 Jul 2015 11:12:01 +0000
Bug 1143575. Remove unused CompositionNotifySink. r=nical
faa827249fb1d4abde3acfb02016ab6f39230d06: Bug 1143575. Remove unused Image::IsSentToCompositor tracking. r=nical draft
Robert O'Callahan <robert@ocallahan.org> - Fri, 20 Mar 2015 16:13:46 +1300 - rev 275557
Push 3189 by rocallahan@mozilla.com at Fri, 03 Jul 2015 11:12:01 +0000
Bug 1143575. Remove unused Image::IsSentToCompositor tracking. r=nical
f6b4fe7fd004f61dc5834f8530d93826d919f595: Bug 1143575. Android's screenshotting code should invalidate the LayerManagerComposite to ensure composition will actually happen. r=nical draft
Robert O'Callahan <robert@ocallahan.org> - Fri, 12 Jun 2015 03:20:04 +1200 - rev 275556
Push 3189 by rocallahan@mozilla.com at Fri, 03 Jul 2015 11:12:01 +0000
Bug 1143575. Android's screenshotting code should invalidate the LayerManagerComposite to ensure composition will actually happen. r=nical There is some ambiguity about whether ScheduleComposite will necessarily trigger a composite all the way to nsWindow::DrawWindowUnderlay. Android robocop tests assume it will, because they rely on DrawWindowOverlay being called so they can take a screenshot and make progress, but this is a very fragile assumption. They also rely on the entire window being painted, which is also a fragile assumption. This patch improves the situation by explicitly invalidating the current window area when Android Java code needs to trigger a composite. This avoids regressions from future patches in this series which make composition bail out when there is nothing invalid. The resulting setup is still a bit fragile for my taste but I'm not sure what the ideal solution would be.
4b3f3c86fa1901fe73df9cc7a757a92e63dba811: Bug 1143575. Make GL context current before cleaning up programs. r=nical draft
Robert O'Callahan <robert@ocallahan.org> - Fri, 12 Jun 2015 03:18:46 +1200 - rev 275555
Push 3189 by rocallahan@mozilla.com at Fri, 03 Jul 2015 11:12:01 +0000
Bug 1143575. Make GL context current before cleaning up programs. r=nical Otherwise we can get a crash with the following stack: Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 14711] 0x5d99974e in mozilla::gl::GLContext::BeforeGLCall (this=0x6dbf0800, funcName=0x60f251a4 <mozilla::gl::GLContext::raw_fDeleteProgram(unsigned int)::__PRETTY_FUNCTION__> "void mozilla::gl::GLContext::raw_fDeleteProgram(GLuint)") at /home/roc/mozilla-inbound/gfx/gl/GLContext.h:683 683 MOZ_ASSERT(IsCurrent()); (gdb) where #0 0x5d99974e in mozilla::gl::GLContext::BeforeGLCall (this=0x6dbf0800, funcName=0x60f251a4 <mozilla::gl::GLContext::raw_fDeleteProgram(unsigned int)::__PRETTY_FUNCTION__> "void mozilla::gl::GLContext::raw_fDeleteProgram(GLuint)") at /home/roc/mozilla-inbound/gfx/gl/GLContext.h:683 #1 0x5d99bed6 in mozilla::gl::GLContext::raw_fDeleteProgram (this=0x6dbf0800, program=210003) at /home/roc/mozilla-inbound/gfx/gl/GLContext.h:2232 #2 0x5d99c10a in mozilla::gl::GLContext::fDeleteProgram (this=0x6dbf0800, program=210003) at /home/roc/mozilla-inbound/gfx/gl/GLContext.h:2270 #3 0x5daa0ae6 in mozilla::layers::ShaderProgramOGL::~ShaderProgramOGL (this=0x6d7df000, __in_chrg=<optimized out>) at /home/roc/mozilla-inbound/gfx/layers/opengl/OGLShaderProgram.cpp:491 #4 0x5da86bdc in mozilla::layers::CompositorOGL::CleanupResources (this=0x67ae4d70) at /home/roc/mozilla-inbound/gfx/layers/opengl/CompositorOGL.cpp:177
8f2cb7a4f0831deb641bc1c3c7263268a577aee0: Bug 1143575. test_HaveMetadataUnbufferedSeek should not wait for canplay since preload='metadata' elements may not fire canplay. r=cpearce draft
Robert O'Callahan <robert@ocallahan.org> - Wed, 10 Jun 2015 15:56:27 +1200 - rev 275554
Push 3189 by rocallahan@mozilla.com at Fri, 03 Jul 2015 11:12:01 +0000
Bug 1143575. test_HaveMetadataUnbufferedSeek should not wait for canplay since preload='metadata' elements may not fire canplay. r=cpearce
c452ab92903d40e2aa113519060f8ca1f6e67141: Bug 1143575. Add some #includes to avoid more unified-build issues on Windows. r=nical draft
Robert O'Callahan <robert@ocallahan.org> - Tue, 09 Jun 2015 14:35:04 +1200 - rev 275553
Push 3189 by rocallahan@mozilla.com at Fri, 03 Jul 2015 11:12:01 +0000
Bug 1143575. Add some #includes to avoid more unified-build issues on Windows. r=nical
8bfd7bbb21fbcdb72a4fc821d632518c3cd1efd8: Bug 1143575. Add some #includes to avoid unified-build issues on Windows. r=nical draft
Robert O'Callahan <robert@ocallahan.org> - Tue, 09 Jun 2015 05:27:37 +1200 - rev 275552
Push 3189 by rocallahan@mozilla.com at Fri, 03 Jul 2015 11:12:01 +0000
Bug 1143575. Add some #includes to avoid unified-build issues on Windows. r=nical
645ea390a7ae708011796d7ecf6369bdb1f62df2: Bug 1143575. Add RefBase #include to stagefright stubs. r=cpearce draft
Robert O'Callahan <robert@ocallahan.org> - Tue, 12 May 2015 15:36:19 +1200 - rev 275551
Push 3189 by rocallahan@mozilla.com at Fri, 03 Jul 2015 11:12:01 +0000
Bug 1143575. Add RefBase #include to stagefright stubs. r=cpearce
cfe55292fe4efda1016d43699e9fbf1e8388d0ac: Bug 1143575. Avoid use of COMPARE macro which can clash with Android headers. r=bent draft
Robert O'Callahan <robert@ocallahan.org> - Sun, 07 Jun 2015 12:26:40 +0300 - rev 275550
Push 3189 by rocallahan@mozilla.com at Fri, 03 Jul 2015 11:12:01 +0000
Bug 1143575. Avoid use of COMPARE macro which can clash with Android headers. r=bent
8567e4ad05e182b2563ba72ceb8cc2aefe3d9f28: Bug 1143575. Avoid including Android's GraphicBuffer.h from LayersTypes.h. r=nical draft
Robert O'Callahan <robert@ocallahan.org> - Mon, 08 Jun 2015 21:27:23 +1200 - rev 275549
Push 3189 by rocallahan@mozilla.com at Fri, 03 Jul 2015 11:12:01 +0000
Bug 1143575. Avoid including Android's GraphicBuffer.h from LayersTypes.h. r=nical On some Android versions, GraphicBuffer.h ends up including libui's hardware.h, which #defines the symbols version_minor and version_major, which are used as field names in Ogg Theora's th_info struct. Later patches will require some files to include both Theora headers and LayerTypes.h.
(0) -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip