dc807c9a35ab2cadf0680eb9eb03a141e65e27e9: Bug 1434777 - Re-enabled test_ext_contentscript_devtools_metadata.html test on Windows. draft
Luca Greco <lgreco@mozilla.com> - Fri, 02 Mar 2018 13:28:00 +0100 - rev 762470
Push 101169 by luca.greco@alcacoop.it at Fri, 02 Mar 2018 12:32:00 +0000
Bug 1434777 - Re-enabled test_ext_contentscript_devtools_metadata.html test on Windows. This test has been disabled because it was failing intermittently with a pretty high frequency on the Windows platform, the reasons behind the failures have been fixed in Bug 1435100. MozReview-Commit-ID: 6Dxm8nTVXgq
b2a9a4bb5c94de179ae7a3f52fde58c0e2897498: Merge inbound to mozilla-central. a=merge
Ciure Andrei <aciure@mozilla.com> - Fri, 02 Mar 2018 12:16:06 +0200 - rev 762469
Push 101169 by luca.greco@alcacoop.it at Fri, 02 Mar 2018 12:32:00 +0000
Merge inbound to mozilla-central. a=merge
2e11c53b5a51948e8afb845e2c1603cc2ecd8b9f: Bug 1441333: Follow-up: Fix OS-X failure due to extra console warning. r=bustage
Kris Maglione <maglione.k@gmail.com> - Thu, 01 Mar 2018 23:24:35 -0800 - rev 762468
Push 101169 by luca.greco@alcacoop.it at Fri, 02 Mar 2018 12:32:00 +0000
Bug 1441333: Follow-up: Fix OS-X failure due to extra console warning. r=bustage On OS-X, this test sees an extra 'No chrome package registered for chrome://branding/locale/brand.properties"' console warning, which causes it to inspect the wrong error when checking for location information.
930b44b7adc7e26e0b76cb46178489fc2e6704dc: Bug 1441333: Part 6 - Use caller location in error reports for StrongPromise errors. r=zombie
Kris Maglione <maglione.k@gmail.com> - Thu, 01 Mar 2018 16:41:21 -0800 - rev 762467
Push 101169 by luca.greco@alcacoop.it at Fri, 02 Mar 2018 12:32:00 +0000
Bug 1441333: Part 6 - Use caller location in error reports for StrongPromise errors. r=zombie We currently report a useful location in error reports when extensions fail to resolve a promise or call a response callback, but in some slightly less-than-ideal ways. We currently generate a complete stack and parse its string value (which is expensive), and then report the caller location as part of the message, rather than as the error's location and stack. This patch changes that behavior to store a single SavedStack frame, and to properly report that as the location of the error. MozReview-Commit-ID: Jmtf4C1O6pW
cf87433f501d755e6cde616a6ec77a4f37c69a00: Bug 1441333: Part 5 - Use proper async caller location in normalizeError. r=zombie
Kris Maglione <maglione.k@gmail.com> - Thu, 01 Mar 2018 16:39:08 -0800 - rev 762466
Push 101169 by luca.greco@alcacoop.it at Fri, 02 Mar 2018 12:32:00 +0000
Bug 1441333: Part 5 - Use proper async caller location in normalizeError. r=zombie Currently, when we create an error object at the end of an aysnc operation, we only get a useful caller location if async stacks are enabled. This patch changes our behavior to use the saved caller location we've already stored when creating an Error object based on a plain string message. MozReview-Commit-ID: DDO0lAUHYRO
47c2e679000ff75affdb8314a7ee83726411806e: Bug 1441333: Part 4 - Add caller location to async API errors. r=zombie
Kris Maglione <maglione.k@gmail.com> - Mon, 26 Feb 2018 15:25:03 -0800 - rev 762465
Push 101169 by luca.greco@alcacoop.it at Fri, 02 Mar 2018 12:32:00 +0000
Bug 1441333: Part 4 - Add caller location to async API errors. r=zombie When we report errors generated by async API operations, they are currently not tied to any relevant extension source location. Instead, the locations in the error reports point to the location in the framework code which reported the error, which makes things extremely difficult to diagnose. This change saves the extension caller location at the beginning of async API operations, and adds it to the error reports genearted by that operation. This should give extension developers a useful starting point for debugging them. MozReview-Commit-ID: AkknkKEosFt
c21a778bab3dac0c4c436f7473e80c4fa751d491: Bug 1441333: Part 3 - Add helper to create a JS error with a saved stack. r=bz
Kris Maglione <maglione.k@gmail.com> - Thu, 01 Mar 2018 14:00:00 -0800 - rev 762464
Push 101169 by luca.greco@alcacoop.it at Fri, 02 Mar 2018 12:32:00 +0000
Bug 1441333: Part 3 - Add helper to create a JS error with a saved stack. r=bz There's no standard way to create a JS error with full stack and location information from a saved stack. Since we need this functionality in order to reject promises with useful Error objects, this patch adds a simple helper to make that possible. MozReview-Commit-ID: FyGuo4UjfsQ
61f204267373b1806950985a5b5abd4933f15009: Bug 1441333: Part 2 - Allow passing an error stack to reportError. r=bz
Kris Maglione <maglione.k@gmail.com> - Thu, 01 Mar 2018 13:57:27 -0800 - rev 762463
Push 101169 by luca.greco@alcacoop.it at Fri, 02 Mar 2018 12:32:00 +0000
Bug 1441333: Part 2 - Allow passing an error stack to reportError. r=bz Building on top of part 1, we need a way to link a saved caller location to a reported error message. This change allows us to pass a stack to `reportError` when called with a string. This part was written before part 3, and could probably be removed in favor of using createError in every call. But this method also has the advantage of being more consise and somewhate more efficient. MozReview-Commit-ID: 39jfCg9AerY
f9eb113f179f94145a575f602e359186d71b2b34: Bug 1441333: Part 1 - Add helper to retrieve closest stack frame with a given principal. r=bz
Kris Maglione <maglione.k@gmail.com> - Sat, 11 Nov 2017 17:39:16 -0800 - rev 762462
Push 101169 by luca.greco@alcacoop.it at Fri, 02 Mar 2018 12:32:00 +0000
Bug 1441333: Part 1 - Add helper to retrieve closest stack frame with a given principal. r=bz Most WebExtension APIs are async, and have fairly complicated error reporting semantics. As a result, when we report an error, the current JS stack has very little to do with the JS caller that triggered the error, which makes it difficult to diagnose. In order to improve the situation, we need to store the location of the caller at the start of an async operation, so we can tie the error to some marginally useful location. We don't have a reasonable way to do that now other than proactively creating an error object when the API is called, or creating a promise with a full async stack, both of which are too expensive. This helper instead returns a single SavedStack frame with a given principal, which should be considerably cheaper, and likely good enough to give a starting point for debugging cryptic errors. MozReview-Commit-ID: BTxhpZK9Fdz
4e681b986b5cdd36dbb8b50c232b8b5d4db8e4f3: Bug 1440816: Part 1 - Set readPrincipals callback on JS context. r=fitzgen
Kris Maglione <maglione.k@gmail.com> - Fri, 23 Feb 2018 17:20:32 -0800 - rev 762461
Push 101169 by luca.greco@alcacoop.it at Fri, 02 Mar 2018 12:32:00 +0000
Bug 1440816: Part 1 - Set readPrincipals callback on JS context. r=fitzgen MozReview-Commit-ID: L9SQ5tiHkl5
f8688efe482431851107b74a1dd9815f3292a8b7: Bug 1441424 - Fix autoplay activation test. r=kamidphish
Chris Pearce <cpearce@mozilla.com> - Thu, 01 Mar 2018 17:21:09 +1300 - rev 762460
Push 101169 by luca.greco@alcacoop.it at Fri, 02 Mar 2018 12:32:00 +0000
Bug 1441424 - Fix autoplay activation test. r=kamidphish Post landing of bug 1193394 test_autoplay_policy_activation was failing. This is because we weren't clicking the child frame properly in the test. Fix the test, and re-enable. MozReview-Commit-ID: Ius4GWIX8Ng
b59a2fcd3435ec59ceaea010324db3761edb596e: Bug 1440867 - Only poison nursery chunks that were used when clearing, r=jonco
Steve Fink <sfink@mozilla.com> - Fri, 23 Feb 2018 19:55:08 -0800 - rev 762459
Push 101169 by luca.greco@alcacoop.it at Fri, 02 Mar 2018 12:32:00 +0000
Bug 1440867 - Only poison nursery chunks that were used when clearing, r=jonco
4000e7883aefcc7886a7eabb43ac6b9e592a0066: Backed out changeset 8ac015e40755 (bug 1441153) for web platform tests failre on media files
Dorel Luca <dluca@mozilla.com> - Fri, 02 Mar 2018 04:06:22 +0200 - rev 762458
Push 101169 by luca.greco@alcacoop.it at Fri, 02 Mar 2018 12:32:00 +0000
Backed out changeset 8ac015e40755 (bug 1441153) for web platform tests failre on media files
eec4330cfdb35bd38ce21fd78e7ba04af3a5e4a7: Backed out 6 changesets (bug 1425462) for XPCShell failure on multiple files
Dorel Luca <dluca@mozilla.com> - Fri, 02 Mar 2018 03:33:17 +0200 - rev 762457
Push 101169 by luca.greco@alcacoop.it at Fri, 02 Mar 2018 12:32:00 +0000
Backed out 6 changesets (bug 1425462) for XPCShell failure on multiple files Backed out changeset 9ace3811f525 (bug 1425462) Backed out changeset 7d440e52e3a4 (bug 1425462) Backed out changeset 85896ea96faf (bug 1425462) Backed out changeset 127b5d2e6779 (bug 1425462) Backed out changeset 95ce64d3a29a (bug 1425462) Backed out changeset ddd2c4da4ba4 (bug 1425462)
bd9a72daf25192fca6365a616566f91a21c19daa: Backed out changeset 45ae173a1348 (bug 1418749) for widget leaks on Mochitests
Dorel Luca <dluca@mozilla.com> - Fri, 02 Mar 2018 02:50:08 +0200 - rev 762456
Push 101169 by luca.greco@alcacoop.it at Fri, 02 Mar 2018 12:32:00 +0000
Backed out changeset 45ae173a1348 (bug 1418749) for widget leaks on Mochitests
9ace3811f52568b96352e578099a79e8732f177f: Bug 1425462 Refactor the static members into static globals to avoid leakchecks r=ckerschb
Tom Ritter <tom@mozilla.com> - Thu, 01 Mar 2018 05:24:36 -0600 - rev 762455
Push 101169 by luca.greco@alcacoop.it at Fri, 02 Mar 2018 12:32:00 +0000
Bug 1425462 Refactor the static members into static globals to avoid leakchecks r=ckerschb MozReview-Commit-ID: 2lm1Skf3KEH
7d440e52e3a4862bfd981c0f0d09d13d03689581: Bug 1425462 Turn jitter on by default r=luke
Tom Ritter <tom@mozilla.com> - Thu, 15 Feb 2018 15:35:42 -0600 - rev 762454
Push 101169 by luca.greco@alcacoop.it at Fri, 02 Mar 2018 12:32:00 +0000
Bug 1425462 Turn jitter on by default r=luke MozReview-Commit-ID: 9u0rJ8FoteG
85896ea96faf2f55b4401674b1c469c7d9be513d: Bug 1425462 Sprinkle some thread safety on the LRU Cache r=handyman
Tom Ritter <tom@mozilla.com> - Sat, 24 Feb 2018 08:21:15 -0600 - rev 762453
Push 101169 by luca.greco@alcacoop.it at Fri, 02 Mar 2018 12:32:00 +0000
Bug 1425462 Sprinkle some thread safety on the LRU Cache r=handyman We use a mozilla:Mutex to avoid race conditions in the LRU Cache MozReview-Commit-ID: DyeK4RUnGhP
127b5d2e6779a4e94f7e939210a99b12e0c32f5f: Bug 1425462 Normalize the JavaScript Engine behavior by adding a callback r=luke
Tom Ritter <tom@mozilla.com> - Thu, 22 Feb 2018 16:05:50 -0600 - rev 762452
Push 101169 by luca.greco@alcacoop.it at Fri, 02 Mar 2018 12:32:00 +0000
Bug 1425462 Normalize the JavaScript Engine behavior by adding a callback r=luke Time Precision Reduction in the JS Engine was handled by a small bit of duplicated logic. With Time Jittering, and general improvements to the logic due to float fuzziness, we want to unify the logic for the JS Engine and the browser into one location. This patch does that. Note that this will leave the JS Shell without a time jittering implementation. It currently has a time clamping implementation - but I'm not actually sure if the shell is doing anything with it, because it's probably not calling SetTimeResolutionUsec to set it up. In Bug 1440539 we will add a jitter implementation for the shell. (And probably turn time rounding and jittering on for it too.) MozReview-Commit-ID: 2BTIMzE8MjW
95ce64d3a29a9a50de86bf713b69f43b8e05230c: Bug 1425462 Address tests for Time Jittering r=bkelly
Tom Ritter <tom@mozilla.com> - Thu, 15 Feb 2018 15:34:05 -0600 - rev 762451
Push 101169 by luca.greco@alcacoop.it at Fri, 02 Mar 2018 12:32:00 +0000
Bug 1425462 Address tests for Time Jittering r=bkelly The following tests all hardcoded a special value for Timer Precision Reduction. browser/components/extensions/test/xpcshell/test_ext_browsingData_cookies_cache.js browser/components/resistfingerprinting/test/browser/browser_performanceAPI.js browser/components/resistfingerprinting/test/mochitest/test_animation_api.html browser/components/resistfingerprinting/test/mochitest/test_reduce_time_precision.html devtools/client/sourceeditor/test/browser_codemirror.js dom/animation/test/css-animations/test_animation-currenttime.html dom/animation/test/mozilla/test_transition_finish_on_compositor.html dom/media/test/test_video_stats_resistfingerprinting.html dom/tests/mochitest/ajax/jquery/test_jQuery.html netwerk/test/unit/test_race_cache_with_network.js Of these, only test_video_stats_resistfingerprinting.html begins failing when Jitter is enabled. So disable jitter for that test. Additionally, dom/midi/tests/test_midi_packet_timing_sorting.html began failing with Jitter, so we disable it there. (We could easily modify the test so it began passing, but this would reduce the effectiveness of the test.) MozReview-Commit-ID: 2kipxV6wYv9
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip