dc203200e659482ea14de71cd5fa67728132c5fd: Bug 1416316 - 1. Move overscroll to LayerSession; r?rbarker
draft
Jim Chen <nchen@mozilla.com> - Thu, 30 Nov 2017 13:25:50 -0500 - rev 705810
Push
91595 by bmo:nchen@mozilla.com at Thu, 30 Nov 2017 18:26:05 +0000
Bug 1416316 - 1. Move overscroll to LayerSession; r?rbarker
There is some overscroll handling code in NativePanZoomController that
should be moved, along with other overscroll code in LayerView, to
LayerSession. LayerSession now provides a getter for
OverscrollEdgeEffect, which is cleaned up to have a public API with
documentation.
MozReview-Commit-ID: LkKHFS8OkR7
c818bd963028886ddca5e14dba3e7f2e3f13cf46: Bug 1406936 - Add unittests for re-configuring VideoConduit; r?pehrsons
draft
Dan Minor <dminor@mozilla.com> - Tue, 28 Nov 2017 14:50:05 -0500 - rev 705809
Push
91594 by bmo:dminor@mozilla.com at Thu, 30 Nov 2017 18:17:35 +0000
Bug 1406936 - Add unittests for re-configuring VideoConduit; r?pehrsons
This adds new tests that are a subset of the existing tests for configuration.
Another option would be to use parameterized tests to get coverage of all existing
tests during reconfiguration, but I don't think the additional complexity is
justified at this point.
MozReview-Commit-ID: F28KRYaVe1B
2f0cd840fd3b170db0c6cd9186260a37d261db58: Bug 1406936 - Copy state when reusing SendStream in ConfigureSendMediaCodecs; r?pehrsons
draft
Dan Minor <dminor@mozilla.com> - Tue, 28 Nov 2017 14:51:53 -0500 - rev 705808
Push
91594 by bmo:dminor@mozilla.com at Thu, 30 Nov 2017 18:17:35 +0000
Bug 1406936 - Copy state when reusing SendStream in ConfigureSendMediaCodecs; r?pehrsons
This is necessary for changes to encoding constraints and simulcast encodings to
be picked up.
MozReview-Commit-ID: JpVN0ST70Cn
c2b495b76f87f4d83b4b92fa790f1cc2cebbbb10: Bug 1406936 - Reset FEC payloads in ConfigureRecvMediaCodecs; r?mjf
draft
Dan Minor <dminor@mozilla.com> - Thu, 30 Nov 2017 10:59:54 -0500 - rev 705807
Push
91594 by bmo:dminor@mozilla.com at Thu, 30 Nov 2017 18:17:35 +0000
Bug 1406936 - Reset FEC payloads in ConfigureRecvMediaCodecs; r?mjf
MozReview-Commit-ID: CAyDUry0Ekr
d6adf63f27d0f9fc668ab84c8efcee6e77932db7: Bug 1406936 - Clean up unused variables; r?pehrsons
draft
Dan Minor <dminor@mozilla.com> - Thu, 30 Nov 2017 13:13:26 -0500 - rev 705806
Push
91594 by bmo:dminor@mozilla.com at Thu, 30 Nov 2017 18:17:35 +0000
Bug 1406936 - Clean up unused variables; r?pehrsons
MozReview-Commit-ID: DZtmnViblGS
7cd3124d9ff06c0746a7af606fcdf42973dc049f: Bug 1417827: Convert internal char* to nsCString in DNS.h
draft
Jeff Hemphill <jthemphill@gmail.com> - Wed, 29 Nov 2017 23:30:27 -0800 - rev 705805
Push
91593 by bmo:jthemphill@gmail.com at Thu, 30 Nov 2017 18:17:11 +0000
Bug 1417827: Convert internal char* to nsCString in DNS.h
MozReview-Commit-ID: Js1mXiKaKnt
ee84da77d589b6f1071b5d9e638aea3319de6de4: Bug 1391044 - Add wpt reftests for multiline placeholders in <textarea> and <input>. r?
draft
Ian Moody <moz-ian@perix.co.uk> - Mon, 27 Nov 2017 23:54:52 +0000 - rev 705804
Push
91592 by moz-ian@perix.co.uk at Thu, 30 Nov 2017 18:16:49 +0000
Bug 1391044 - Add wpt reftests for multiline placeholders in <textarea> and <input>. r?
MozReview-Commit-ID: IXjqOQAGQU5
3dad7a54acf14fd1e74d0566926c5e859b76c289: Bug 1241131 - Remove DevTools reload addon histograms;r=francois
draft
Julian Descottes <jdescottes@mozilla.com> - Thu, 30 Nov 2017 19:09:24 +0100 - rev 705803
Push
91591 by jdescottes@mozilla.com at Thu, 30 Nov 2017 18:15:02 +0000
Bug 1241131 - Remove DevTools reload addon histograms;r=francois
MozReview-Commit-ID: oq7SVGPI2t
cad44d2d9273d9c21b5706a41c51ae8376a0da7b: Bug 1241131 - Remove DevTools reload addon;r=ochameau
draft
Julian Descottes <jdescottes@mozilla.com> - Thu, 30 Nov 2017 19:08:44 +0100 - rev 705802
Push
91591 by jdescottes@mozilla.com at Thu, 30 Nov 2017 18:15:02 +0000
Bug 1241131 - Remove DevTools reload addon;r=ochameau
In the end I prefer to remove the addon completely, if
we need it for go faster we can simply reintroduce it.
MozReview-Commit-ID: GCS4ZRvwUcs
71570e1c68b46e30dce95d85de7d4d9fa486220d: Bug 1376044 - Remove dead code left over from layers-full WR implementation. r?jrmuizel
draft
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 30 Nov 2017 13:09:06 -0500 - rev 705801
Push
91590 by kgupta@mozilla.com at Thu, 30 Nov 2017 18:09:47 +0000
Bug 1376044 - Remove dead code left over from layers-full WR implementation. r?jrmuizel
MozReview-Commit-ID: FBTm1EgJ70T
e351f3000a1dec48270d785ac902cce77a19d02d: Bug 1422063 - Cannot start snap on Wayland r=rail
draft
Johan Lorenzo <jlorenzo@mozilla.com> - Thu, 30 Nov 2017 18:58:08 +0100 - rev 705800
Push
91588 by bmo:jlorenzo@mozilla.com at Thu, 30 Nov 2017 17:59:03 +0000
Bug 1422063 - Cannot start snap on Wayland r=rail
MozReview-Commit-ID: 1GyQUqJZFra
6b16f54433a90700bcc4405597f450c852d514bf: Bug 1415665 - Very long domain names overflow from the Highlight borders. r=r1cky
draft
Andrei Oprea <andrei.br92@gmail.com> - Thu, 30 Nov 2017 18:45:03 +0100 - rev 705799
Push
91587 by bmo:andrei.br92@gmail.com at Thu, 30 Nov 2017 17:45:33 +0000
Bug 1415665 - Very long domain names overflow from the Highlight borders. r=r1cky
MozReview-Commit-ID: 5C1tHZm4gJ
92e2d0a1ac146e21fee2a060a6b0884282ffae92: Bug 1418466 - Add Connect Another Device button to relevant Sync UI. r?markh, dao
draft
Edouard Oger <eoger@fastmail.com> - Fri, 17 Nov 2017 16:48:17 -0500 - rev 705798
Push
91586 by bmo:eoger@fastmail.com at Thu, 30 Nov 2017 17:40:42 +0000
Bug 1418466 - Add Connect Another Device button to relevant Sync UI. r?markh, dao
MozReview-Commit-ID: 5vBKH9NejVV
17be77b67e8201241167d14b1a9d95a67b7346b5: Bug 1412265 - Font issues in the messages displayed for empty Highlights and Top Stories sections. r=ursula
draft
Andrei Oprea <andrei.br92@gmail.com> - Thu, 30 Nov 2017 18:35:15 +0100 - rev 705797
Push
91585 by bmo:andrei.br92@gmail.com at Thu, 30 Nov 2017 17:36:28 +0000
Bug 1412265 - Font issues in the messages displayed for empty Highlights and Top Stories sections. r=ursula
MozReview-Commit-ID: B3t1wrXPTvG
e1cfaaeea4beb21e32decc7d448bb70e546f0256: Bug 1411867 - Linux repacks detected as unofficial builds. r=k88hudson
draft
Andrei Oprea <andrei.br92@gmail.com> - Thu, 30 Nov 2017 18:24:12 +0100 - rev 705796
Push
91584 by bmo:andrei.br92@gmail.com at Thu, 30 Nov 2017 17:24:52 +0000
Bug 1411867 - Linux repacks detected as unofficial builds. r=k88hudson
MozReview-Commit-ID: 7itcGkDxKZx
1be770da2a77484c539ec061ca8a00ab5fa36ad3: Bug 1419538 - Marionette log entries should show object details.
draft
Henrik Skupin <mail@hskupin.info> - Thu, 30 Nov 2017 15:09:32 +0100 - rev 705795
Push
91583 by bmo:hskupin@gmail.com at Thu, 30 Nov 2017 17:18:46 +0000
Bug 1419538 - Marionette log entries should show object details.
By missing to convert a Javascript object to a packet and serializing
it, no details were printed eg for session capabilities for the call
to "start_session()".
MozReview-Commit-ID: HdcehGpBvdA
51897fcb5943baccfc2cfe825259a79e6217543c: Bug 1408227 - part 6: WSRunObject::CheckTrailingNBSP() should take |const EditorRawDOMPoint&| instead of a set of container node and offset in it r?m_kato
draft
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 22 Nov 2017 02:45:08 +0900 - rev 705794
Push
91582 by masayuki@d-toybox.com at Thu, 30 Nov 2017 17:12:13 +0000
Bug 1408227 - part 6: WSRunObject::CheckTrailingNBSP() should take |const EditorRawDOMPoint&| instead of a set of container node and offset in it r?m_kato
The name, WSRunObject::CheckTrailingNBSP(), is unclear what it does. It
replaces previous character of specified point with ASCII space if it is NBSP
and it's not necessary.
So, it should be renamed to ReplacePreviousNBSPIfUnncessary().
Additionally, it should take |const EditorRawDOMPoint&| instead of a set of
container node and offset in it.
MozReview-Commit-ID: 2vq46OiAzo6
4a4cb0e4bd788f979a0bece8316c95096ad239e2: Bug 1408227 - part 5: Redesign GetCharAfter(), GetCharBefore(), GetWSPointAfter() and GetWSPointBefore() of WSRunObject r?m_kato
draft
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 22 Nov 2017 02:12:27 +0900 - rev 705793
Push
91582 by masayuki@d-toybox.com at Thu, 30 Nov 2017 17:12:13 +0000
Bug 1408227 - part 5: Redesign GetCharAfter(), GetCharBefore(), GetWSPointAfter() and GetWSPointBefore() of WSRunObject r?m_kato
WSRunObject::GetChar(After|Before)(nsINode*, int32_t) returns next/previous
character's DOM point as WSPoint. If the container node is a text node in
mNodeArray, it calls WSRunObject::GetChar(After|Before)(const WSPoint&) which
returns next/previous offset if the point isn't end/start of the text node.
If the point is at end/start of the text node, it returns start/end of
next/previous text node in mNodeArray. If the container node is not a text
node in mNodeArray, it calls WSRunObject::GetWSPoint(After|Before)(). It looks
for next/previous text node in mNodeArray from the point. Then, it calls
WSRunObject::GetChar(After|Before)(const WSPoint&) and returns the result.
So, we should rename GetCharAfter() to GetNextCharPoint(), GetCharBefore() to
GetPreviousCharPoint(), GetWSPointAfter() to GetNextCharPointInternal() and
GetWSPointBefore() to GetPreviousCharPointInternal().
Then, they should take |const EditorRawDOMPoint&| instead of a set of container
node and offset in it.
So, looks like that "WS"RunObject is not good name for this class, perhaps,
AutoTextRunManager or something? But I'm still not sure.
MozReview-Commit-ID: 85cX3MdlFwz
f8f8f89a11294ca1933208d52aed4ed51d28072d: Bug 1408227 - part 4: WSRunObject::DeleteChars() should take two |const EditorRawDOMPoint&| arguments to specify a range to remove r?m_kato
draft
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 22 Nov 2017 01:00:35 +0900 - rev 705792
Push
91582 by masayuki@d-toybox.com at Thu, 30 Nov 2017 17:12:13 +0000
Bug 1408227 - part 4: WSRunObject::DeleteChars() should take two |const EditorRawDOMPoint&| arguments to specify a range to remove r?m_kato
WSRunObject::DeleteChars() should take two |const EditorRawDOMPoint&| arguments
to represent a range to remove.
Additionally, this renames it to DeleteRange() because it also removes any
nodes in the range. So, "Chars" isn't good word for this method's name.
MozReview-Commit-ID: 5Dmxnia1JPO
530aa71155091861d3e400bdfde0568ba7bbb9fb: Bug 1408227 - part 3: Redesign WSRunObject::FindRun() with EditorRawDOMPoint r?m_kato
draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 21 Nov 2017 19:03:03 +0900 - rev 705791
Push
91582 by masayuki@d-toybox.com at Thu, 30 Nov 2017 17:12:13 +0000
Bug 1408227 - part 3: Redesign WSRunObject::FindRun() with EditorRawDOMPoint r?m_kato
WSRunObject::FindRun() finds the nearest run from aPoint to specified direction.
So, it uses nsContentUtils::ComparePoints() a lot. Therefore, it should use
an overload which takes RawRangeBoundary. Although, it's not optimized for
RawRangeBoundary, but if it'd be optimized, this method becomes faster.
And this patch renames it to FindNearestRun().
MozReview-Commit-ID: 2NkR5E1st6d