da73ea2a49ccf82a3efe28083c3aaec7940812b1: Bug 1397406 - Use BuildReader helper in `mach test`; r?dustin draft
Gregory Szorc <gps@mozilla.com> - Wed, 06 Sep 2017 12:26:15 -0700 - rev 660269
Push 78341 by gszorc@mozilla.com at Wed, 06 Sep 2017 19:34:49 +0000
Bug 1397406 - Use BuildReader helper in `mach test`; r?dustin Now that we have a helper function to obtain a BuildReader, let's put it to use. MozReview-Commit-ID: 7V3RsWs5TPu
30f638f3ca496580e66761645a6144d4885e99ab: Bug 1397406 - Add a helper function to retrieve a BuildReader; r?dustin draft
Gregory Szorc <gps@mozilla.com> - Wed, 06 Sep 2017 12:18:51 -0700 - rev 660268
Push 78341 by gszorc@mozilla.com at Wed, 06 Sep 2017 19:34:49 +0000
Bug 1397406 - Add a helper function to retrieve a BuildReader; r?dustin The code for obtaining a BuildReader for evaluating moz.build files is generic and non-trivial. We already had a custom implementation for `mach file-info` that implemented support for Mercurial integration. Bug 1383880 will introduce a second consumer. So this commit factors out the "obtain a BuildReader" logic into a reusable function on our base MozbuildObject class. This makes it easily available to various parts of the build system and mach commands. As part of the change, we detect when ``.`` is being used as the revision and verify the working directory is clean. This behavior can be disabled via argument if unwanted. But it's useful by default to ensure consumers aren't expecting to read uncommitted changes. MozReview-Commit-ID: LeYFqAb3HAe
1386e7b02a6032b8b4b68b5272313095478a6d70: Bug 1397390 - Support better thumbnails for image urls draft
ahillier <ahillier@mozilla.com> - Wed, 06 Sep 2017 15:17:46 -0400 - rev 660267
Push 78340 by bmo:ahillier@mozilla.com at Wed, 06 Sep 2017 19:32:23 +0000
Bug 1397390 - Support better thumbnails for image urls MozReview-Commit-ID: Ksxo6Gj2rIO
73b6bd6386ee8cdbe959675c4fd03827b31ddd44: Bug 902825 - Remove MOZ_CALLGRIND from mozilla-config.h; r?glandium draft
Mike Shal <mshal@mozilla.com> - Tue, 17 Jan 2017 11:17:03 -0500 - rev 660266
Push 78339 by bmo:mshal@mozilla.com at Wed, 06 Sep 2017 19:27:41 +0000
Bug 902825 - Remove MOZ_CALLGRIND from mozilla-config.h; r?glandium MozReview-Commit-ID: 4FxAcPq2bao
ab24d6830aa0e47506ecd661e2456db5c77c4c1e: Bug 902825 - Add some hacks to avoid rebuilding world; r?glandium draft
Mike Shal <mshal@mozilla.com> - Tue, 18 Apr 2017 09:54:48 -0400 - rev 660265
Push 78339 by bmo:mshal@mozilla.com at Wed, 06 Sep 2017 19:27:41 +0000
Bug 902825 - Add some hacks to avoid rebuilding world; r?glandium Since MOZ_CONFIGURE_OPTIONS changes every time you enable or disable a configure option, we have to remove that from autoconf.mk in order to avoid rebuilding the world whenever it changes. This works around the fact that everything depends on autoconf.mk in the RecursiveMake backend. We also remove any mozconfig_defines from ALLSUBSTS to avoid modifying that file for the same reason, in case the define is also a subst. This means that any relevant Makefile.in code that uses a subst from autoconf.mk must be converted to moz.build before a define can be created as a mozconfig_define. As of this commit, it is possible to set a define with mozconfig_header=True in moz.configure, and add corresponding #includes in C++ code. Doing so will no longer change the globally included mozilla-config.h when the flag is toggled. Instead, only the C++ code that uses the define will be recompiled. MozReview-Commit-ID: 5r8q4yfTeK3
708f03b583866a48522092819fa6ab33809ac7b6: Bug 902825 - Allow generating dist/include/mozconfig/*.h; r?glandium draft
Mike Shal <mshal@mozilla.com> - Wed, 14 Dec 2016 16:03:49 -0500 - rev 660264
Push 78339 by bmo:mshal@mozilla.com at Wed, 06 Sep 2017 19:27:41 +0000
Bug 902825 - Allow generating dist/include/mozconfig/*.h; r?glandium Using the defines from the config environment, we can generate a set of header files in dist/include/mozconfig/ so that source files can include them to get access to specific configure values. Instead of rebuilding the whole world when a single define changes (due to its presence in mozilla-config.h), we can recompile only the set of files that actually depend on its value. This begins the process by generating the individual headers from all of the mozconfig_defines in moz.configure, as well as providing an easy way to declare a mozconfig_defines in set_define(). mozconfig_defines are essentially non_global_defines that have the following properties: 1) They are used in C/C++ code by doing #include "mozconfig/DEFINE_NAME.h" And if the define is also a subst, then: 2) They are used in Python code with buildconfig.get_subst() 3) They are not used in Makefile.in's or included .mk files, because the values are not exported to autoconf.mk We have to use a new structure for mozconfig_defines, because not all non_global_defines can be removed from ALLSUBSTS since some values are still used in Makefile.in's (for example, NECKO_WIFI is used in an ifdef in browser/installer/Makefile.in). MozReview-Commit-ID: 22jiYaamSo2
9f01f4c82fc8c3d18fa7da12798f2e9cedfdd185: Bug 902825 - Update buildconfig.py to use PartialConfigEnvironment; r?glandium draft
Mike Shal <mshal@mozilla.com> - Thu, 24 Aug 2017 22:52:01 -0400 - rev 660263
Push 78339 by bmo:mshal@mozilla.com at Wed, 06 Sep 2017 19:27:41 +0000
Bug 902825 - Update buildconfig.py to use PartialConfigEnvironment; r?glandium By using the PartialConfigEnvironment, the clients of buildconfig will depend on config.statusd/ files instead of config.status directly. Clients can access substs and defines using buildconfig.get_subst() or buildconfig.get_define(), and then collect file-level dependencies for make using buildconfig.get_dependencies(). Things that still need the full config can use buildconfig.config.defines to access the original config.status structures. Doing so does create a dependency on the config.status file, which is always updated during configure, so use of this for build-time code is discouraged. However, it is acceptable to use buildconfig.config during packaging or other post-build automation steps. As a result of this commit, re-running configure will no longer cause the world to be rebuilt. Although config.status is updated, no build steps use config.status directly and instead depend on values in config.statusd/, which are written with FileAvoidWrite. Since those files are not official targets according to the make backend, make won't try to continually rebuild the backend when those files are out of date. And since they are FileAvoidWrite, make will only re-run dependent steps if the actual configure value has changed. MozReview-Commit-ID: 2pJ4s3TVeS8
3baad954cd75d5ff50dc2b26ba74e2e78abf0ca4: Bug 902825 - Use PartialConfigEnvironment in process_define_files.py; r?glandium draft
Mike Shal <mshal@mozilla.com> - Mon, 21 Aug 2017 15:34:07 -0400 - rev 660262
Push 78339 by bmo:mshal@mozilla.com at Wed, 06 Sep 2017 19:27:41 +0000
Bug 902825 - Use PartialConfigEnvironment in process_define_files.py; r?glandium This removes the dependency on config.status for CONFIGURE_DEFINE_FILES. Instead, each file depends on the specific configure values that it uses. MozReview-Commit-ID: H4oLmJei1KR
eabb373fab7954726a29da8c087a783f877c9c00: Bug 902825 - Create config.statusd directory; r?glandium draft
Mike Shal <mshal@mozilla.com> - Fri, 18 Aug 2017 10:41:50 -0400 - rev 660261
Push 78339 by bmo:mshal@mozilla.com at Wed, 06 Sep 2017 19:27:41 +0000
Bug 902825 - Create config.statusd directory; r?glandium The config.statusd directory is created alongside config.status, which contains the same information but is split across many files instead of all in a single file. This allows the build system to track dependencies on individual configure values. MozReview-Commit-ID: 2DbwKCJuNSX
77495b5e90f62d3bb309cc64d6ced8114719eccb: Bug 1397406 - Add a helper function to retrieve a BuildReader; r?dustin draft
Gregory Szorc <gps@mozilla.com> - Wed, 06 Sep 2017 12:18:51 -0700 - rev 660260
Push 78338 by gszorc@mozilla.com at Wed, 06 Sep 2017 19:21:56 +0000
Bug 1397406 - Add a helper function to retrieve a BuildReader; r?dustin The code for obtaining a BuildReader for evaluating moz.build files is generic and non-trivial. We already had a custom implementation for `mach file-info` that implemented support for Mercurial integration. Bug 1383880 will introduce a second consumer. So this commit factors out the "obtain a BuildReader" logic into a reusable function on our base MozbuildObject class. This makes it easily available to various parts of the build system and mach commands. As part of the change, we detect when ``.`` is being used as the revision and verify the working directory is clean. This behavior can be disabled via argument if unwanted. But it's useful by default to ensure consumers aren't expecting to read uncommitted changes. MozReview-Commit-ID: LeYFqAb3HAe
8ca48411de46e2d1d67f93c7a2a0703542e3a4e5: Bug 1397406 - Add Repository method to determine if working directory clean; r?dustin draft
Gregory Szorc <gps@mozilla.com> - Wed, 06 Sep 2017 12:15:12 -0700 - rev 660259
Push 78338 by gszorc@mozilla.com at Wed, 06 Sep 2017 19:21:56 +0000
Bug 1397406 - Add Repository method to determine if working directory clean; r?dustin This is generally useful functionality to have. A consume will be introduced in an upcoming commit. MozReview-Commit-ID: 4arTMfJSiEC
94c02703f07c931bfb9796611403859b07c3a2c0: Bug 1397406 - Don't mark finder as a protected attribute; r?dustin draft
Gregory Szorc <gps@mozilla.com> - Wed, 06 Sep 2017 12:13:38 -0700 - rev 660258
Push 78338 by gszorc@mozilla.com at Wed, 06 Sep 2017 19:21:56 +0000
Bug 1397406 - Don't mark finder as a protected attribute; r?dustin It seems reasonable to expose this outside of the BuildReader. MozReview-Commit-ID: 4paDbYl9dEd
19b1b28c3f272b0d7a7a72a4ca44e94c26aa73a0: Bug 1397390 - Support better thumbnails for image urls draft
ahillier <ahillier@mozilla.com> - Wed, 06 Sep 2017 15:17:46 -0400 - rev 660257
Push 78337 by bmo:ahillier@mozilla.com at Wed, 06 Sep 2017 19:18:49 +0000
Bug 1397390 - Support better thumbnails for image urls MozReview-Commit-ID: Ksxo6Gj2rIO
2458cd098c7d8f0eb5df7e87fa77925aa29b9a98: Bug 1393924 - Collect description and preview image and store it into moz_places draft
Ursula Sarracini - Wed, 06 Sep 2017 15:11:22 -0400 - rev 660256
Push 78336 by usarracini@mozilla.com at Wed, 06 Sep 2017 19:11:42 +0000
Bug 1393924 - Collect description and preview image and store it into moz_places MozReview-Commit-ID: 5HHIcGQbYM6
030280d306d3c3726f563d0946efd07ad297ccda: Bug 1390455 - regression test for CSS rule columns; r?gl draft
Tom Tromey <tom@tromey.com> - Tue, 05 Sep 2017 11:39:45 -0600 - rev 660255
Push 78335 by bmo:ttromey@mozilla.com at Wed, 06 Sep 2017 19:07:50 +0000
Bug 1390455 - regression test for CSS rule columns; r?gl This adds an integration test for the CSS rule column issue from bug 1390455. The fix was landed in upstream rust-cssparser. MozReview-Commit-ID: 34rLhe3BCqx
bd57caf8071f645e8e447ae97bc8c7efd00d2294: Bug 1396205 - Show the Go button only when the user started typing in the location bar. ui-r=shorlander r?daleharvey draft
Dão Gottwald <dao@mozilla.com> - Wed, 06 Sep 2017 21:01:08 +0200 - rev 660254
Push 78334 by dgottwald@mozilla.com at Wed, 06 Sep 2017 19:01:38 +0000
Bug 1396205 - Show the Go button only when the user started typing in the location bar. ui-r=shorlander r?daleharvey MozReview-Commit-ID: JnZSBypyUYk
7f050bcb8b3b22e413cfcc9cde862c2d54d0cd1a: Bug 1392705 - part 5: Assert in ~nsBaseWidget on Android if the compositor session has not been destroyed r=jchen draft
Randall Barker <rbarker@mozilla.com> - Tue, 05 Sep 2017 16:42:10 -0700 - rev 660253
Push 78333 by bmo:rbarker@mozilla.com at Wed, 06 Sep 2017 19:00:54 +0000
Bug 1392705 - part 5: Assert in ~nsBaseWidget on Android if the compositor session has not been destroyed r=jchen MozReview-Commit-ID: IsLj3AWu0ZO
487b3b70fca3e657bbcdb9d4791c2739924a3c93: Bug 1392705 - part 4: Have WidgetShutdownObserver keep a ref pointer to nsBaseWidget until after XPCOM shuts down to ensure nsBaseWidget::Shutdown is called before the nsBaseWidget destructor is called r=jchen draft
Randall Barker <rbarker@mozilla.com> - Tue, 05 Sep 2017 13:00:06 -0700 - rev 660252
Push 78333 by bmo:rbarker@mozilla.com at Wed, 06 Sep 2017 19:00:54 +0000
Bug 1392705 - part 4: Have WidgetShutdownObserver keep a ref pointer to nsBaseWidget until after XPCOM shuts down to ensure nsBaseWidget::Shutdown is called before the nsBaseWidget destructor is called r=jchen Due to the indeterminate nature of Gecko shutdown, the ref count of the nsWindow on Android would sometime go to zero before the XPCOM shutdown observer was called in nsBaseWindow which is where the compositor thread IPC is shutdown. If nsBaseWindow::Shutdown does not get called, then the compositor thread IPC is shutdown in the nsBaseWindow destructor. Unfortunately while the nsWindow is being deleted, it can be accessed in the compositor thread and cause a crash in LayerManagerComposite::RenderToPresentationSurface. By having the WidgetShutdownObserver maintain a reference to the nsBaseWindow, it ensures that the XPCOM shutdown is observed before the nsWindow is deleted. MozReview-Commit-ID: KCv8SCmEjnb
1c603ed8ac32b65a92cd9c1aac77365bb723a1c6: Bug 1392705 - part 3: Ensure mWidget is valid in AndroidCompositorWidget r=jchen draft
Randall Barker <rbarker@mozilla.com> - Fri, 01 Sep 2017 15:05:36 -0700 - rev 660251
Push 78333 by bmo:rbarker@mozilla.com at Wed, 06 Sep 2017 19:00:54 +0000
Bug 1392705 - part 3: Ensure mWidget is valid in AndroidCompositorWidget r=jchen MozReview-Commit-ID: FmkhC2jBleC
421f1cc92201f8bf8627e4789a403dabb100603b: Bug 1392705 - part 2: Ensure LayerManagerComposite::RenderToPresentationSurface checks the compositor widget before using it r=kats draft
Randall Barker <rbarker@mozilla.com> - Fri, 01 Sep 2017 11:17:12 -0700 - rev 660250
Push 78333 by bmo:rbarker@mozilla.com at Wed, 06 Sep 2017 19:00:54 +0000
Bug 1392705 - part 2: Ensure LayerManagerComposite::RenderToPresentationSurface checks the compositor widget before using it r=kats MozReview-Commit-ID: 6EP9Pp4h5cP
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip