d8a32c4811e957d65ae832c2f9e3a45694399ca4: Bug 1404997 - P9. Remove unnecessary const_cast. r?pehrsons
draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Tue, 05 Dec 2017 00:07:52 +0100 - rev 712227
Push
93280 by bmo:jyavenard@mozilla.com at Fri, 15 Dec 2017 20:49:10 +0000
Bug 1404997 - P9. Remove unnecessary const_cast. r?pehrsons
MozReview-Commit-ID: 1XkHmGgPqRM
8a47c2cb3ee76070c536d2d0636dffc9a3842c5c: Bug 1404997 - P8. Follow coding style for members and methods. r?pehrsons,r?drno
draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 08 Dec 2017 21:32:38 +0100 - rev 712226
Push
93280 by bmo:jyavenard@mozilla.com at Fri, 15 Dec 2017 20:49:10 +0000
Bug 1404997 - P8. Follow coding style for members and methods. r?pehrsons,r?drno
It allows to more easily distinguish between methods from upstream webrtc.org and our code.
MozReview-Commit-ID: ILQhEAYbSmc
cdad4fb6c3ac13149eb3b1e3dc0ebe08fd97ca70: Bug 1404997 - P7. Simplify played time calculations. r?pehrsons
draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 08 Dec 2017 20:58:09 +0100 - rev 712225
Push
93280 by bmo:jyavenard@mozilla.com at Fri, 15 Dec 2017 20:49:10 +0000
Bug 1404997 - P7. Simplify played time calculations. r?pehrsons
Now that the graph rate match the one out of NetEQ, we can remove an unecessary conversion.
Additionally, move a member from the base case to the only one where it's used.
MozReview-Commit-ID: II5mdcl0vhK
91735b4aca2e4eeeb6b413637dbf6f9f9e88bcf8: Bug 1404997 - P6. Fix constness were applicable. r?pehrsons
draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 30 Nov 2017 20:48:48 +0100 - rev 712224
Push
93280 by bmo:jyavenard@mozilla.com at Fri, 15 Dec 2017 20:49:10 +0000
Bug 1404997 - P6. Fix constness were applicable. r?pehrsons
MozReview-Commit-ID: JPlZpRz4A9w
f9b7f8a94482f01209c9aad28c92c1b26ca9456f: Bug 1404997 - P5. Fix constness and remove redundant virtual keyword. r?mattwoodrow
draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 30 Nov 2017 19:03:02 +0100 - rev 712223
Push
93280 by bmo:jyavenard@mozilla.com at Fri, 15 Dec 2017 20:49:10 +0000
Bug 1404997 - P5. Fix constness and remove redundant virtual keyword. r?mattwoodrow
Additionally, various C++ code and style cleanup
MozReview-Commit-ID: 7BCtQzFGaOc
5c90ec2f2639f43bf9202778fa80d00e138bfccb: Bug 1404997 - P4. Make AudioProxyThread use AutoTaskQueue. r?pehrsons
draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 30 Nov 2017 16:27:37 +0100 - rev 712222
Push
93280 by bmo:jyavenard@mozilla.com at Fri, 15 Dec 2017 20:49:10 +0000
Bug 1404997 - P4. Make AudioProxyThread use AutoTaskQueue. r?pehrsons
Also, pass arguments are const reference.
We also rename class members as per coding style.
MozReview-Commit-ID: 9IkV8wCMpz7
6c8fe669e9478d568278750884b655e7fa58e7b2: Bug 1404997 - P3. Rename some VideoFrameConverter members per coding style. r?pehrsons
draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 30 Nov 2017 16:25:52 +0100 - rev 712221
Push
93280 by bmo:jyavenard@mozilla.com at Fri, 15 Dec 2017 20:49:10 +0000
Bug 1404997 - P3. Rename some VideoFrameConverter members per coding style. r?pehrsons
MozReview-Commit-ID: Dsi5ZdD3Tay
05a88f395a01f3293a586a6b7942cadc6280480d: Bug 1404997 - P2. Use AutoTaskQueue in VideoFrameConverter. r?pehrsons
draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 30 Nov 2017 16:23:28 +0100 - rev 712220
Push
93280 by bmo:jyavenard@mozilla.com at Fri, 15 Dec 2017 20:49:10 +0000
Bug 1404997 - P2. Use AutoTaskQueue in VideoFrameConverter. r?pehrsons
It removes the need to explicitly shutdown the taskqueue and wait on the taskqueue to have run all dispatched task.
We do want to enforce that no listeners are being called once the VideoFrameConverter's owner has been destroyed as it could potentially lead to a UAF.
For now, access is okay as all operations are performed on the MSG's thread.
However, this will change in follow up patches.
The SourceMediaStream keeps a raw pointer to the MSG, and check if it's value isn't null to determine if the MSG has been shutdown or not, however SourceMediaStream::mGraph isn't thread safe as its access isn't protected by a mutex/monitor.
MozReview-Commit-ID: 1QsJAzPuE6L
1543e75330b464e1c49b56b5e0cd45bc26ccbef2: Bug 1404997 - P1. clang-format MediaPipeline.{cpp,h}. r?pehrsons
draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 30 Nov 2017 13:47:27 +0100 - rev 712219
Push
93280 by bmo:jyavenard@mozilla.com at Fri, 15 Dec 2017 20:49:10 +0000
Bug 1404997 - P1. clang-format MediaPipeline.{cpp,h}. r?pehrsons
It's bound to be done automatically, makes it easier to modify later.
MozReview-Commit-ID: IQ5TBtS8Z3v
901cbc46df41ed0aafaff2c1affdbbe2deda5c38: Bug 1424417 - Use dry-run flag for backend.mk files; r?glandium
draft
Mike Shal <mshal@mozilla.com> - Wed, 13 Dec 2017 11:31:16 -0500 - rev 712218
Push
93279 by bmo:mshal@mozilla.com at Fri, 15 Dec 2017 20:45:15 +0000
Bug 1424417 - Use dry-run flag for backend.mk files; r?glandium
For cases like BackendMakefile where we don't have access to
BuildBackend._write_file(), we need to make sure that FileAvoidWrite
uses the dry-run flag in order to avoid writing out files during a
config.status --dry-run.
MozReview-Commit-ID: ApsSQPySImt
6ca9583d868e966a0fccc8b4e50a5ad1e406dc8c: Bug 1425544 - Allow sync tests to turn on all of sync's logging r?markh
draft
Thom Chiovoloni <tchiovoloni@mozilla.com> - Fri, 15 Dec 2017 14:44:10 -0600 - rev 712217
Push
93278 by bmo:tchiovoloni@mozilla.com at Fri, 15 Dec 2017 20:44:25 +0000
Bug 1425544 - Allow sync tests to turn on all of sync's logging r?markh
MozReview-Commit-ID: EmtELNMAt5P
a931b990028d2d54e9612ccbe259f37fa8b951ee: Bug 1424417 - Use dry-run flag for backend.mk files; r?Build
draft
Mike Shal <mshal@mozilla.com> - Wed, 13 Dec 2017 11:31:16 -0500 - rev 712216
Push
93277 by bmo:mshal@mozilla.com at Fri, 15 Dec 2017 20:43:44 +0000
Bug 1424417 - Use dry-run flag for backend.mk files; r?Build
For cases like BackendMakefile where we don't have access to
BuildBackend._write_file(), we need to make sure that FileAvoidWrite
uses the dry-run flag in order to avoid writing out files during a
config.status --dry-run.
MozReview-Commit-ID: ApsSQPySImt
41d0aa7cec4c6759c4cbd7276af0b3d2bde49da3: Bug 1424146: Refactor taskcluster l10n mozharness config; r?Callek
draft
Tom Prince <mozilla@hocat.ca> - Fri, 15 Dec 2017 10:43:08 -0700 - rev 712215
Push
93276 by bmo:mozilla@hocat.ca at Fri, 15 Dec 2017 20:19:17 +0000
Bug 1424146: Refactor taskcluster l10n mozharness config; r?Callek
MozReview-Commit-ID: HrbI9grmjud
d9d49d5cd925b49a9f4dd34b1ca9bed784b3c445: Bug 1425358 - Wait for all tab titles to be displayed in Tabs.jsm before taking screenshots. r?mattn
draft
Jared Wein <jwein@mozilla.com> - Thu, 14 Dec 2017 16:59:46 -0600 - rev 712214
Push
93275 by bmo:jaws@mozilla.com at Fri, 15 Dec 2017 20:16:18 +0000
Bug 1425358 - Wait for all tab titles to be displayed in Tabs.jsm before taking screenshots. r?mattn
MozReview-Commit-ID: G4gDBezgdEd
f036a98572868caf0482c108ad8d1e3f73a07c0b: Bug 1425462 Add gaussian prefs to all the tests, but do not do any testing of them
draft
Tom Ritter <tom@mozilla.com> - Fri, 15 Dec 2017 14:07:55 -0600 - rev 712213
Push
93274 by bmo:tom@mozilla.com at Fri, 15 Dec 2017 20:10:40 +0000
Bug 1425462 Add gaussian prefs to all the tests, but do not do any testing of them
MozReview-Commit-ID: DzkXp8ugLdc
abe4382d41703de1cc575096b387346f11937547: Bug 1425462 Add the Gaussian prefs
draft
Tom Ritter <tom@mozilla.com> - Fri, 15 Dec 2017 11:31:33 -0600 - rev 712212
Push
93274 by bmo:tom@mozilla.com at Fri, 15 Dec 2017 20:10:40 +0000
Bug 1425462 Add the Gaussian prefs
MozReview-Commit-ID: Ewh3lkcW2tX
e881d52d89b5503933a41fe163f4c0fc59cdc9ed: Bug 1424341 Add tests for dynamically tuning the timer precision
draft
Tom Ritter <tom@mozilla.com> - Thu, 14 Dec 2017 15:18:35 -0600 - rev 712211
Push
93274 by bmo:tom@mozilla.com at Fri, 15 Dec 2017 20:10:40 +0000
Bug 1424341 Add tests for dynamically tuning the timer precision
MozReview-Commit-ID: Cqce1dZLkFE
b8637f0f131eaa7c67462f6ace2f6d8b5982b1db: Bug 1425527 - Remove duplicate instances of a support file. r?kmckinley
draft
Kartikaya Gupta <kgupta@mozilla.com> - Fri, 15 Dec 2017 15:10:17 -0500 - rev 712210
Push
93273 by kgupta@mozilla.com at Fri, 15 Dec 2017 20:10:36 +0000
Bug 1425527 - Remove duplicate instances of a support file. r?kmckinley
MozReview-Commit-ID: 8Wf8iRFdRvM
e96c668357c1a56dcc5ebc5ed8c2a3f7dbec0de9: Bug 1424341 Add tests for dynamically tuning the timer precision
draft
Tom Ritter <tom@mozilla.com> - Thu, 14 Dec 2017 15:18:35 -0600 - rev 712209
Push
93272 by bmo:tom@mozilla.com at Fri, 15 Dec 2017 20:09:29 +0000
Bug 1424341 Add tests for dynamically tuning the timer precision
MozReview-Commit-ID: Cqce1dZLkFE
dddafdd3a82d1579073d2abea6e0bfef77a2be8e: Bug 1419478 Enable S3 caching for binary diff patch files in partial update tasks r=rail
draft
Simon Fraser <sfraser@mozilla.com> - Fri, 15 Dec 2017 14:07:31 -0600 - rev 712208
Push
93271 by sfraser@mozilla.com at Fri, 15 Dec 2017 20:08:07 +0000
Bug 1419478 Enable S3 caching for binary diff patch files in partial update tasks r=rail
MozReview-Commit-ID: 23vwFcBkqKd