d83a7b09bde85b2a66d36d2af500281f4a9b4a84: Bug 1256509 - Disable C4577 to unblock compilation on VS2015; r?poiru draft
Gregory Szorc <gps@mozilla.com> - Mon, 14 Mar 2016 18:03:39 -0700 - rev 340184
Push 12913 by gszorc@mozilla.com at Tue, 15 Mar 2016 01:03:59 +0000
Bug 1256509 - Disable C4577 to unblock compilation on VS2015; r?poiru As part of unblocking building with VS2015u1 in automation, I'm mass disabling compiler warnings that are turned into errors. This is not the preferred mechanism to fix compilation warnings. So hopefully this patch never lands because someone insists of fixing the underlying problem instead. But if it does land, hopefully the workaround is only temporary. That being said, the warning occurs in 3rd party ICU code. So I'm not sure what my options are for fixing this. MozReview-Commit-ID: 2MIqvI3qCsZ
40070b35e02aca4ceb58d1d05229b065dc22c2bf: Bug 1186060 - Build with Visual Studio 2015 Update 1; r?ted, ehsan draft
Gregory Szorc <gps@mozilla.com> - Mon, 14 Mar 2016 17:25:59 -0700 - rev 340183
Push 12913 by gszorc@mozilla.com at Tue, 15 Mar 2016 01:03:59 +0000
Bug 1186060 - Build with Visual Studio 2015 Update 1; r?ted, ehsan This commit switches Windows builds from Visual Studio 2013 to Visual Studio 2015 Update 1. Previously, Visual Studio was installed on the builers as part of the base system image. Starting with this commit, we obtain Visual Studio from a pre-generated, self-contained archive containing the executables, Windows SDK, and other support files. This means that new Windows toolchains can be installed without having to modify configuration of machines in automation! The mozconfigs for Visual Studio 2015 are a bit different from existing mozconfigs. Because it appears to be completely redundant and not necessary, the LIBPATH variable has been dropped. The order of paths in PATH, LIB, and INCLUDE has changed. The new order more accurately reflects what would be defined by vcvarsall.bat. As part of switching to Visual Studio 2015, the Universal CRT is now required. So, the 2015 mozconfigs export WIN_UCRT_REDIST_DIR to define the location to those files. The switch to Visual Studio 2015 also involves the switch from the Windows 8.1 SDK to the Windows 10 SDK. However, we still target an old version of Windows, so this hopefully shouldn't have any significant fallout. It's worth noting that switching to Visual Studio 2015 makes builds - especially PGO builds - significantly faster. Our PGO build times in automation are ~1 hour faster. Our regular builds appear to be a few minutes faster. MozReview-Commit-ID: Pa5GW8V87Q
0791eea65fcc544a04b0ed82dfb316ef5fe51d91: Bug 1253707 - Script to generate visual studio toolchain archive; r?ted draft
Gregory Szorc <gps@mozilla.com> - Fri, 11 Mar 2016 15:00:02 -0800 - rev 340182
Push 12913 by gszorc@mozilla.com at Tue, 15 Mar 2016 01:03:59 +0000
Bug 1253707 - Script to generate visual studio toolchain archive; r?ted Previously, Windows toolchains and related dependencies (SDKs, etc) were installed on Windows builders by people responsible for maintaining those machines. This commit takes a step in a new direction. We introduce a script (complete with documentation) that can produce a zip archive (or any archive format if people want to implement support) of the toolchain files. Basically, you install Visual Studio 2015 Community, run the script, and produce a self-contained zip file containing everything from Microsoft you need to build Firefox. With a copy of this archive and an installation of MozillaBuild, it is possible to build Firefox on a fresh Windows installation. No time-consuming Visual Studio installation needed. The goal is to upload these archives to tooltool and have our Windows builders download and extract them at run-time. At which time, we can remove all the other Visual Studio and SDK files from builders because they don't need to be baked into the image. We may find tooltool's caching isn't good enough and we have to more aggressively caching the standalone toolchain files. But that is a problem for another day. Whatever happens, we'll need the functionality in this script to produce a self-contained archive of the toolchain. There are certainly files in the produced archive that aren't needed. I think perfect is the enemy of done and we can prune the archive over time, if wanted. MozReview-Commit-ID: EckEK1a6vA3
484a82a92ce3650cac361f08373483e5bd646c6d: Bug 1124033 - Replace blanket disabling of VS2015 warnings with C5026 and C5027; r?ehsan draft
Gregory Szorc <gps@mozilla.com> - Mon, 14 Mar 2016 14:38:12 -0700 - rev 340181
Push 12913 by gszorc@mozilla.com at Tue, 15 Mar 2016 01:03:59 +0000
Bug 1124033 - Replace blanket disabling of VS2015 warnings with C5026 and C5027; r?ehsan Wv:18 was added in bug 1119072 as a quick way to get the tree building with VS2015. Now that we're closer to rolling out VS2015 support, we want to expose its new warnings. This patch replaces the blanket disabling of new warnings in VS2015 with just disabling C5026 and C5027, which relate to symbols being implicitly defined as deleted. MozReview-Commit-ID: 8uniydfNJns
ce6dec9f21a21ce337412c59c99f7bc9b227b2eb: Bug 1256505 - Disable C4312 to unblock compilation on VS2015; r?poiru draft
Gregory Szorc <gps@mozilla.com> - Mon, 14 Mar 2016 17:56:28 -0700 - rev 340180
Push 12913 by gszorc@mozilla.com at Tue, 15 Mar 2016 01:03:59 +0000
Bug 1256505 - Disable C4312 to unblock compilation on VS2015; r?poiru As part of unblocking building with VS2015u1 in automation, I'm mass disabling compiler warnings that are turned into errors. This is not the preferred mechanism to fix compilation warnings. So hopefully this patch never lands because someone insists of fixing the underlying problem instead. But if it does land, hopefully the workaround is only temporary. MozReview-Commit-ID: 70QwT9y6eb2
3fae539fe3e21488f0b685f96072e639614d933a: Bug 1256507 - Remove --enable-xterm-updates draft
Mike Hommey <mh+mozilla@glandium.org> - Tue, 15 Mar 2016 09:59:12 +0900 - rev 340179
Push 12912 by bmo:mh+mozilla@glandium.org at Tue, 15 Mar 2016 01:01:59 +0000
Bug 1256507 - Remove --enable-xterm-updates It's an opt-in flag that allows to display where the build is in terminal window titles. The fact that it's opt-in and likely unknown makes it very low-value, and the fact that it was added in an era where builds were not very well parallelized made it have a meaning, but now that builds are parallelized, its meaningfulness is diminished. Let's just remove it.
a960fa1bfffdc42f7e536a88918806b61660677c: Bug 1255813 - Remove build system support for Solaris, HPUX and AIX. r=ted
Mike Hommey <mh+mozilla@glandium.org> - Fri, 11 Mar 2016 23:37:36 +0900 - rev 340178
Push 12912 by bmo:mh+mozilla@glandium.org at Tue, 15 Mar 2016 01:01:59 +0000
Bug 1255813 - Remove build system support for Solaris, HPUX and AIX. r=ted
08c0e38543e746eff8ab537b5aa2eb3dd597a16f: Bug 1255305 - Move --host and --target to moz.configure. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Fri, 11 Mar 2016 22:57:15 +0900 - rev 340177
Push 12912 by bmo:mh+mozilla@glandium.org at Tue, 15 Mar 2016 01:01:59 +0000
Bug 1255305 - Move --host and --target to moz.configure. r=chmanchester With all the things that still depend on all the variables derived from --host and --target in both old-configure and moz.build, we still need to keep variables such as OS_ARCH, OS_TARGET, CPU_ARCH, OS_TEST, etc. Eventually, we'd settle on the output of split_triplet. This /tries/ to preserve the current values for all these variables, while also trying to make things a little more consistent. It also effectively rejects OSes such as HPUX or AIX, because it is unclear the decades old accumulated scripts related to them still do anything useful, and we might as well have them start again from scratch, which, in the coming weeks, will be even easier.
3e4385286eb106034afed28a43bad15134dee2d2: Bug 1255305 - Generalize adding arguments to old-configure. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Fri, 11 Mar 2016 22:53:48 +0900 - rev 340176
Push 12912 by bmo:mh+mozilla@glandium.org at Tue, 15 Mar 2016 01:01:59 +0000
Bug 1255305 - Generalize adding arguments to old-configure. r=chmanchester
fc98436187af3e5b75fadfd1acd31fbcce9cd839: Bug 1255305 - Move the function finding a shell from old.configure to init.configure. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Fri, 11 Mar 2016 22:52:40 +0900 - rev 340175
Push 12912 by bmo:mh+mozilla@glandium.org at Tue, 15 Mar 2016 01:01:59 +0000
Bug 1255305 - Move the function finding a shell from old.configure to init.configure. r=chmanchester
0f34a2f4714e35f077029bd7883fdc3dd38af9a8: Bug 1255305 - Uniformize CPU_ARCH between old-configure.in and js/src/old-configure.in. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Fri, 11 Mar 2016 22:35:12 +0900 - rev 340174
Push 12912 by bmo:mh+mozilla@glandium.org at Tue, 15 Mar 2016 01:01:59 +0000
Bug 1255305 - Uniformize CPU_ARCH between old-configure.in and js/src/old-configure.in. r=chmanchester
7b559b11d4d1a07ba987fe5a2ec7b036a73185ef: Bug 1242005 - Disable C4359 to allow compilation on VS2015; r=kip
Gregory Szorc <gps@mozilla.com> - Mon, 14 Mar 2016 14:11:40 -0700 - rev 340173
Push 12912 by bmo:mh+mozilla@glandium.org at Tue, 15 Mar 2016 01:01:59 +0000
Bug 1242005 - Disable C4359 to allow compilation on VS2015; r=kip The proper fix is to fix the underlying problem. However, I haven't touched C++ in months and I'm lazy. So I'm going for the quick fix so Visual Studio 2015 rollout is unblocked. MozReview-Commit-ID: 14cZCGPkx0V
e6092e439db9d332d8f62d0cfcf10b6e13379ad4: bug 1255153 - (re)move redundant xpcshell name constraint tests to gtests r=Cykesiopka,jcj
David Keeler <dkeeler@mozilla.com> - Wed, 09 Mar 2016 14:33:31 -0800 - rev 340172
Push 12912 by bmo:mh+mozilla@glandium.org at Tue, 15 Mar 2016 01:01:59 +0000
bug 1255153 - (re)move redundant xpcshell name constraint tests to gtests r=Cykesiopka,jcj MozReview-Commit-ID: 8eFSIhB1RId
9ccaec771922f823a5e006ccaff6fc177dd2ee4f: Backed out changeset 66fdeb1acce5 (bug 1229220) for M-e10s failure in test_fullscreen-api.html. r=backout on a CLOSED TREE
Sebastian Hengst <archaeopteryx@coole-files.de> - Mon, 14 Mar 2016 23:03:37 +0100 - rev 340171
Push 12912 by bmo:mh+mozilla@glandium.org at Tue, 15 Mar 2016 01:01:59 +0000
Backed out changeset 66fdeb1acce5 (bug 1229220) for M-e10s failure in test_fullscreen-api.html. r=backout on a CLOSED TREE
4dceeab3d7c52c946dfe5d06f443710b5ea718eb: Backed out changeset cc8b02b24319 (bug 1255919) for failing e.g. bc3's browser_bug629172.js. r=backout on a CLOSED TREE
Sebastian Hengst <archaeopteryx@coole-files.de> - Mon, 14 Mar 2016 22:54:57 +0100 - rev 340170
Push 12912 by bmo:mh+mozilla@glandium.org at Tue, 15 Mar 2016 01:01:59 +0000
Backed out changeset cc8b02b24319 (bug 1255919) for failing e.g. bc3's browser_bug629172.js. r=backout on a CLOSED TREE
e79cc51e486ceae0084e34ee3918e54e2942cf7e: Bug 837192 followup: In js::FunctionToString, fold variable into its only remaining usage-site (an assertion) to fix opt Werror build failures. rs=Waldo
Daniel Holbert <dholbert@cs.stanford.edu> - Mon, 14 Mar 2016 14:43:14 -0700 - rev 340169
Push 12912 by bmo:mh+mozilla@glandium.org at Tue, 15 Mar 2016 01:01:59 +0000
Bug 837192 followup: In js::FunctionToString, fold variable into its only remaining usage-site (an assertion) to fix opt Werror build failures. rs=Waldo CLOSED TREE
9d99253b3e008d7fad83a89f51002ee07f5220a2: Bug 1251921 - Do not call debugger hooks with half-initialized frame if InterpeterFrame::prologue fails. (r=jorendorff)
Eric Faust <efaustbmo@gmail.com> - Mon, 14 Mar 2016 14:29:12 -0700 - rev 340168
Push 12912 by bmo:mh+mozilla@glandium.org at Tue, 15 Mar 2016 01:01:59 +0000
Bug 1251921 - Do not call debugger hooks with half-initialized frame if InterpeterFrame::prologue fails. (r=jorendorff)
14092b3cacbeaab373eb88792f90800e21d2f1f3: Bug 1255614 - make ProcessInvalidationList to insert accessibles instead the recaching, r=yzen
Alexander Surkov <surkov.alexander@gmail.com> - Mon, 14 Mar 2016 17:28:08 -0400 - rev 340167
Push 12912 by bmo:mh+mozilla@glandium.org at Tue, 15 Mar 2016 01:01:59 +0000
Bug 1255614 - make ProcessInvalidationList to insert accessibles instead the recaching, r=yzen
2f4dc776c043e58c34762e0d463c7d91af0f4471: Bug 956899 - Teach check_spidermonkey_style.py about mozglue; r=njn
Terrence Cole <terrence@mozilla.com> - Thu, 10 Mar 2016 09:07:59 -0800 - rev 340166
Push 12912 by bmo:mh+mozilla@glandium.org at Tue, 15 Mar 2016 01:01:59 +0000
Bug 956899 - Teach check_spidermonkey_style.py about mozglue; r=njn
a0b4612ed03d61bb3f51a41c253528dabc3efaa3: Bug 956899 - Implement an RAII unlocking primitive to compliment LockGuard; r=froydnj
Terrence Cole <terrence@mozilla.com> - Thu, 10 Mar 2016 09:07:59 -0800 - rev 340165
Push 12912 by bmo:mh+mozilla@glandium.org at Tue, 15 Mar 2016 01:01:59 +0000
Bug 956899 - Implement an RAII unlocking primitive to compliment LockGuard; r=froydnj
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip