d801b445f0c9ebafa28c321c9a63da1f197c013f: Bug 1343442 - Re-enable browser_decoderDoctor.js on Mac - r?gijs draft
Gerald Squelart <gsquelart@mozilla.com> - Tue, 11 Apr 2017 08:18:22 +1200 - rev 560099
Push 53322 by gsquelart@mozilla.com at Tue, 11 Apr 2017 04:02:44 +0000
Bug 1343442 - Re-enable browser_decoderDoctor.js on Mac - r?gijs Thanks to the previous patch, these tests can now be run on Mac, though they don't do anything useful there just yet. MozReview-Commit-ID: 3HyN7ms1EPl
96e305f67ee200a97920e6053d4ef1a512f3ec34: Bug 1343442 - Refactored DecDoc browser tests for extensibility - r?gijs draft
Gerald Squelart <gsquelart@mozilla.com> - Mon, 10 Apr 2017 16:31:44 +1200 - rev 560098
Push 53322 by gsquelart@mozilla.com at Tue, 11 Apr 2017 04:02:44 +0000
Bug 1343442 - Refactored DecDoc browser tests for extensibility - r?gijs Mostly moved things around to make future tests (using different parameter sets) easier to write. Also, all tests are now run on all platforms, but we're expecting nothing to happen in those cases that were previously skipped. It will be useful when we add tests that actually need to run on all platforms. MozReview-Commit-ID: AZTz9lr2eIJ
4c3cdeabf783713832b89e7e45cd9589c043469b: Bug 1343442 - Analyze eDecodeError/Warning issues - r?jya draft
Gerald Squelart <gsquelart@mozilla.com> - Fri, 24 Mar 2017 17:09:41 +1100 - rev 560097
Push 53322 by gsquelart@mozilla.com at Tue, 11 Apr 2017 04:02:44 +0000
Bug 1343442 - Analyze eDecodeError/Warning issues - r?jya MozReview-Commit-ID: 97AhQz2Hgmi
2f63424e03445b0d933f4de543fdb270412b1444: Bug 1343442 - Provide appropriate params to console message - r?jya draft
Gerald Squelart <gsquelart@mozilla.com> - Thu, 23 Mar 2017 10:21:27 +1100 - rev 560096
Push 53322 by gsquelart@mozilla.com at Tue, 11 Apr 2017 04:02:44 +0000
Bug 1343442 - Provide appropriate params to console message - r?jya MozReview-Commit-ID: HiaY20UqksU
101a922a0646c46eb20c26c41b585c0af3b0806c: Bug 1343442 - Move NotificationAndReportStringId closer to first use - r?jya draft
Gerald Squelart <gsquelart@mozilla.com> - Wed, 22 Mar 2017 15:37:41 +1100 - rev 560095
Push 53322 by gsquelart@mozilla.com at Tue, 11 Apr 2017 04:02:44 +0000
Bug 1343442 - Move NotificationAndReportStringId closer to first use - r?jya MozReview-Commit-ID: IBn5jsHTsKx
fe7b63799f0b07977ccb25253a5cf5db366e7016: Bug 1343442 - Allow MediaDecodeError/Warning user notifications in Nightly - r?jya draft
Gerald Squelart <gsquelart@mozilla.com> - Fri, 24 Mar 2017 16:37:45 +1100 - rev 560094
Push 53322 by gsquelart@mozilla.com at Tue, 11 Apr 2017 04:02:44 +0000
Bug 1343442 - Allow MediaDecodeError/Warning user notifications in Nightly - r?jya We want the new MediaDecodeError messages to be forwarded to the front-end in browser-media.js (even though they won't be handled just yet; an upcoming patch will add the handling code). This is limited to Nightly for now, like the "Report Site Issues" button, because we forward URLs to webcompat.com (at the user's request). And MediaDecodeWarning was not added, as it may cause too much annoyance, but it is available for testers to get more diagnostics information if needed. MozReview-Commit-ID: HPDpA1mg4HX
d8a11b2876ad0b0be905cce54f381224394a3160: Bug 1343442 - MediaDecodeError/Warning user notification messages - r?jya draft
Gerald Squelart <gsquelart@mozilla.com> - Fri, 24 Mar 2017 16:47:23 +1100 - rev 560093
Push 53322 by gsquelart@mozilla.com at Tue, 11 Apr 2017 04:02:44 +0000
Bug 1343442 - MediaDecodeError/Warning user notification messages - r?jya These messages will be displayed in the Decoder Doctor drop-down notification bar. The message ids are also used internally to identify corresponding issues. MozReview-Commit-ID: MmKxCEoTok
446598ebb91c488f59d22b80d95f1c77bb0204f9: Bug 1343442 - Decode-error/warning webidl notification types and data - r?smaug draft
Gerald Squelart <gsquelart@mozilla.com> - Wed, 22 Mar 2017 16:13:41 +1100 - rev 560092
Push 53322 by gsquelart@mozilla.com at Tue, 11 Apr 2017 04:02:44 +0000
Bug 1343442 - Decode-error/warning webidl notification types and data - r?smaug Decoder Doctor webidl additions: DecoderDoctorNotificationType.decode-error and decode-warning DecoderDoctorNotification.decodeIssue, docURL and resourceURL MozReview-Commit-ID: FK0YOCeuQMX
33eb4d4a65673bb48230606238ec4f5c9a498fbe: Bug 1341483 - MP4Metadata::GetTrackIndice() now also returns a success/error code - r?kinetik draft
Gerald Squelart <gsquelart@mozilla.com> - Wed, 15 Mar 2017 16:55:50 +1100 - rev 560091
Push 53322 by gsquelart@mozilla.com at Tue, 11 Apr 2017 04:02:44 +0000
Bug 1341483 - MP4Metadata::GetTrackIndice() now also returns a success/error code - r?kinetik MozReview-Commit-ID: BIgvy5eKNJl
3ff411af961f07012fb286b3f59ad0b9c875b0d6: Bug 1341483 - MP4Metadata::Crypto() now also returns a success/error code - r?kinetik draft
Gerald Squelart <gsquelart@mozilla.com> - Mon, 27 Feb 2017 21:32:03 +1100 - rev 560090
Push 53322 by gsquelart@mozilla.com at Tue, 11 Apr 2017 04:02:44 +0000
Bug 1341483 - MP4Metadata::Crypto() now also returns a success/error code - r?kinetik MozReview-Commit-ID: EywDv5JuDK6
0b2e33e080587323f1aa04de1006e6a5e8505954: Bug 1341483 - MP4Metadata::GetTrackInfo() now also returns a success/error code - r?kinetik draft
Gerald Squelart <gsquelart@mozilla.com> - Mon, 27 Feb 2017 17:05:41 +1100 - rev 560089
Push 53322 by gsquelart@mozilla.com at Tue, 11 Apr 2017 04:02:44 +0000
Bug 1341483 - MP4Metadata::GetTrackInfo() now also returns a success/error code - r?kinetik MozReview-Commit-ID: KQ3fJzZkrGW
85459b41ea0118fb42846ff723a2e570574e19b2: Bug 1341483 - MP4Metadata::GetNumberTracks() now also returns a success/error code - r?kinetik draft
Gerald Squelart <gsquelart@mozilla.com> - Mon, 27 Feb 2017 13:36:59 +1100 - rev 560088
Push 53322 by gsquelart@mozilla.com at Tue, 11 Apr 2017 04:02:44 +0000
Bug 1341483 - MP4Metadata::GetNumberTracks() now also returns a success/error code - r?kinetik In addition to the returned MediaResult, a special number-of-tracks value (not just 0) indicates an unrecoverable error. For Rust-vs-Stagefright comparison purposes, an error is considered the same as 0 (because Stagefright never returns errors, but Rust may, so complaining about that would be too noisy, and useless to us.) MozReview-Commit-ID: IwadWSOIWr4
0d8e3ff55a2620c028579b39f2d168cc674f0c6d: Bug 1341483 - MP4Metadata::Metadata() now also returns a success/error code - r?kinetik draft
Gerald Squelart <gsquelart@mozilla.com> - Mon, 27 Feb 2017 13:01:11 +1100 - rev 560087
Push 53322 by gsquelart@mozilla.com at Tue, 11 Apr 2017 04:02:44 +0000
Bug 1341483 - MP4Metadata::Metadata() now also returns a success/error code - r?kinetik The returned MediaResult is used as error or warning in MP4Demuxer::Init(). MozReview-Commit-ID: Bnv4xG8bCJ4
c9ed914ae16c428edd915220f92e76a781b8fa42: Bug 1343437 - 'media.playback.warnings-as-errors' pref - r?jya draft
Gerald Squelart <gsquelart@mozilla.com> - Fri, 03 Mar 2017 16:10:48 +1100 - rev 560086
Push 53322 by gsquelart@mozilla.com at Tue, 11 Apr 2017 04:02:44 +0000
Bug 1343437 - 'media.playback.warnings-as-errors' pref - r?jya If 'media.playback.warnings-as-errors' is true, demuxing and decoding warnings (i.e., non-fatal errors) will be treated as errors, causing playback to fail. Currently set to false by default. This could be later changed to catch and diagnose more issues. MozReview-Commit-ID: BTaZ6TbIbNG
7445459f5ed2149c1a5e41b5ef04df1a16b3aff6: Bug 1343437 - TBM::OnDemuxer{Init,Reset}Done forward non-NS_OK MediaResult to HTMLMediaElement::DecodeWarning - r?jya draft
Gerald Squelart <gsquelart@mozilla.com> - Tue, 14 Mar 2017 01:08:39 +1100 - rev 560085
Push 53322 by gsquelart@mozilla.com at Tue, 11 Apr 2017 04:02:44 +0000
Bug 1343437 - TBM::OnDemuxer{Init,Reset}Done forward non-NS_OK MediaResult to HTMLMediaElement::DecodeWarning - r?jya Similarly to the MediaFormatReader, TrackBuffersManager can forward warnings from the demuxer initialization to the associated HTMLMediaElement. Note that errors (sent to OnDemuxerInitFailed) are currently *not* forwarded to the HTMLMediaElement by design. In the future, we may want to add this feature so that mediasource errors can also be reported to webcompat. MozReview-Commit-ID: GjluZbpmC9q
e4762d6d7c54c96657e9caebfd9d3724864ce519: Bug 1343437 - MFR::OnDemuxerInitDone forwards non-NS_OK MediaResult to HTMLMediaElement::DecodeWarning - r?jya draft
Gerald Squelart <gsquelart@mozilla.com> - Mon, 06 Mar 2017 15:22:17 +1100 - rev 560084
Push 53322 by gsquelart@mozilla.com at Tue, 11 Apr 2017 04:02:44 +0000
Bug 1343437 - MFR::OnDemuxerInitDone forwards non-NS_OK MediaResult to HTMLMediaElement::DecodeWarning - r?jya The MediaFormatReader now takes the MediaResult from the Demuxer::Init promise resolution, and if there are no other errors but the MediaResult is not NS_OK it will forward that warning to the decoder owner (i.e., the associated HTMLMediaElement). MozReview-Commit-ID: 5rTmzqqPLI0
dfc2b2f26e0e2ed74ea84f9cfbac258838302cbf: Bug 1343437 - MP4Demuxer::Init resolves with a MediaResult - r?jya draft
Gerald Squelart <gsquelart@mozilla.com> - Mon, 27 Feb 2017 10:10:28 +1100 - rev 560083
Push 53322 by gsquelart@mozilla.com at Tue, 11 Apr 2017 04:02:44 +0000
Bug 1343437 - MP4Demuxer::Init resolves with a MediaResult - r?jya If MP4Demuxer::Init detects some recoverable error (e.g., invalid tracks when others may still be usable), it will eventually Resolve the promise with the first warning. Later on, errors/warnings from the MP4Metadata parser will also be handled, to provide even better diagnostics. MozReview-Commit-ID: E9Rly9dhXW3
4f004faecf5cecf12567009871b3772265201626: Bug 1343437 - MediaDataDemuxer::InitPromise resolve-value is now a MediaResult - r?jya draft
Gerald Squelart <gsquelart@mozilla.com> - Tue, 28 Feb 2017 16:24:57 +1100 - rev 560082
Push 53322 by gsquelart@mozilla.com at Tue, 11 Apr 2017 04:02:44 +0000
Bug 1343437 - MediaDataDemuxer::InitPromise resolve-value is now a MediaResult - r?jya In case of successful initialization, there could still be some warning about a recoverable error. To carry more information about this potential warning, the resolve-value type of the promise is changed from nsresult to MediaResult. Existing code doesn't need to be changed: - In Resolve() calls, the stored MediaResult can implicitly be constructed from an nsresult -- always NS_OK at the moment anyway. - In following Then(), the promise's MediaResult can implicitly be converted to an nsresult. Future patches will modify some of the Resolve's and Then's, to forward warning details to some Decoder Doctor object... MozReview-Commit-ID: J0bXDFxXQHQ
34deed76a7932f1735501c81b270a6944fddfe24: Bug 1343437 - HTMLMediaElement::DecodeWarning() should store a warning instead of an error - r?jya draft
Gerald Squelart <gsquelart@mozilla.com> - Tue, 14 Mar 2017 01:12:20 +1100 - rev 560081
Push 53322 by gsquelart@mozilla.com at Tue, 11 Apr 2017 04:02:44 +0000
Bug 1343437 - HTMLMediaElement::DecodeWarning() should store a warning instead of an error - r?jya MozReview-Commit-ID: 47hURppxH5H
43a239d6aec70db372f53363019d1153d3761aa7: Bug 1311935 - P4. GTest for safebrowsing v4 caching. r?francois draft
DimiL <dlee@mozilla.com> - Fri, 07 Apr 2017 14:31:04 +0800 - rev 560080
Push 53321 by dlee@mozilla.com at Tue, 11 Apr 2017 03:51:38 +0000
Bug 1311935 - P4. GTest for safebrowsing v4 caching. r?francois MozReview-Commit-ID: ExR5NJUvzNg
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip