d6e63e110b3f36fd11022d96479b604cec5cf5fc: Bug 1409972 - Part 6. Remove printingui implementation of each platform. r?mconley draft
Mantaroh Yoshinaga <mantaroh@gmail.com> - Fri, 10 Nov 2017 11:07:34 +0900 - rev 695958
Push 88595 by mantaroh@gmail.com at Fri, 10 Nov 2017 02:11:26 +0000
Bug 1409972 - Part 6. Remove printingui implementation of each platform. r?mconley MozReview-Commit-ID: BXocuT9zV0E
c53ae014cbd20f83332891c9f80b7b1da9bb8d55: Bug 1409972 - Part 5. Use the common printingui implementation. r?mshal draft
Mantaroh Yoshinaga <mantaroh@gmail.com> - Fri, 10 Nov 2017 11:03:43 +0900 - rev 695957
Push 88595 by mantaroh@gmail.com at Fri, 10 Nov 2017 02:11:26 +0000
Bug 1409972 - Part 5. Use the common printingui implementation. r?mshal This patch will change moz.build of printingui and xre to use common printingui implementation. Memo of merging printingui: * The nsProgress / nsProgressParam is used by Windows and GTK, macOS doesn't have this implementation. * The merged implementation located toolkit/components/printingui/ directory. MozReview-Commit-ID: 3Z5MAzGVo1b
617649c5a48309ff213c80bc74318276f18acadc: Bug 1409972 - Part 4. Merge mac printingui. r?mconley draft
Mantaroh Yoshinaga <mantaroh@gmail.com> - Fri, 10 Nov 2017 11:00:54 +0900 - rev 695956
Push 88595 by mantaroh@gmail.com at Fri, 10 Nov 2017 02:11:26 +0000
Bug 1409972 - Part 4. Merge mac printingui. r?mconley This patch will merge mac printingui implementation to common code. Primary differences are: * Remove progress implementation if build target is macOS. MozReview-Commit-ID: 8qoxgmzhqnM
3e8c2888e0bc606be2ccc8fe3a1fff93d2c5e6d7: Bug 1409972 - Part 3. Merge windows printingui. r?mconley draft
Mantaroh Yoshinaga <mantaroh@gmail.com> - Fri, 10 Nov 2017 10:58:10 +0900 - rev 695955
Push 88595 by mantaroh@gmail.com at Fri, 10 Nov 2017 02:11:26 +0000
Bug 1409972 - Part 3. Merge windows printingui. r?mconley This patch will merge windows printingui implementation to common code. Primary differences are: * Use nsCOMPtr on nsPIDOMWindowOuter. * Return NS_ERROR_FAILURE if nsPrintingPromptService doesn't have the nsPrintProgress member when calling ShowProgress(). This is the unexpected case. Original windows implementation has following difference, but this patch will not copy it: * Windows has own NS_IMPL_ADDREF / NS_IMPL_RELEASE implementation, however this implementation isn't different from XPCOM implementation. Bug 156318 doesn't show this reason. * Windows implementation lacks some function parameter checks. But unixshared code covers these checks. * Windows implementation doesn't have the nsIPrintSettings member into nsPrintProgress, but this is necessary in order to make printing cancelable. MozReview-Commit-ID: 8ja40rAaXBo
7309c9dc64f570d494eaaa289592674e93708d83: Bug 1409972 - Part 2. Copy printingui implementation from unixshared. r?mconley draft
Mantaroh Yoshinaga <mantaroh@gmail.com> - Fri, 10 Nov 2017 10:55:48 +0900 - rev 695954
Push 88595 by mantaroh@gmail.com at Fri, 10 Nov 2017 02:11:26 +0000
Bug 1409972 - Part 2. Copy printingui implementation from unixshared. r?mconley This patch will copy printingui implementation from unixshared in order to merge other platform implementation. This unixshared implementation has much common code hence using unixshared code is reasonable for merging. MozReview-Commit-ID: 4VManmNcbdc
90186a0277d163a43518b960e3ffaaa16c708f98: Bug 1409972 - Part 1. Apply clang-format to nsPrintingPromptService. r?mconley draft
Mantaroh Yoshinaga <mantaroh@gmail.com> - Fri, 10 Nov 2017 10:53:08 +0900 - rev 695953
Push 88595 by mantaroh@gmail.com at Fri, 10 Nov 2017 02:11:26 +0000
Bug 1409972 - Part 1. Apply clang-format to nsPrintingPromptService. r?mconley Apply following the clang-format: ./mach clang-format --path toolkit/components/printingui/mac/nsPrintingPromptService.* ./mach clang-format --path toolkit/components/printingui/unixshared/nsPrintingPromptService.* ./mach clang-format --path toolkit/components/printingui/win/nsPrintingPromptService.* MozReview-Commit-ID: 8JGuyqiuKNX
be7bb417132a5c7d7e14e02c7da83288cd0fde84: Bug 1414623: Make state_callback synchronous. r?kinetik draft
Dan Glastonbury <dan.glastonbury@gmail.com> - Fri, 10 Nov 2017 12:03:45 +1000 - rev 695952
Push 88594 by bmo:dglastonbury@mozilla.com at Fri, 10 Nov 2017 02:11:20 +0000
Bug 1414623: Make state_callback synchronous. r?kinetik MozReview-Commit-ID: EvgJiPQAYO6
cf0b0687a3c1ec690fffe1e81bd84447db38fe4f: Don't do PaintThebes after PaintOffMainThread. (bug 1399692 part 10, r=dvander) draft
Ryan Hunt <rhunt@eqrion.net> - Thu, 09 Nov 2017 15:44:21 -0500 - rev 695951
Push 88593 by bmo:rhunt@eqrion.net at Fri, 10 Nov 2017 01:41:10 +0000
Don't do PaintThebes after PaintOffMainThread. (bug 1399692 part 10, r=dvander) MozReview-Commit-ID: J0IOzqIGRtz
e46827626f63ba84547fc191cde05d40a23e5249: Don't reuse a back buffer after a swap if the content or surface changed (bug 1399692 part 9, r=bas) draft
Ryan Hunt <rhunt@eqrion.net> - Sun, 05 Nov 2017 10:38:47 -0500 - rev 695950
Push 88593 by bmo:rhunt@eqrion.net at Fri, 10 Nov 2017 01:41:10 +0000
Don't reuse a back buffer after a swap if the content or surface changed (bug 1399692 part 9, r=bas) MozReview-Commit-ID: HGAxkeyESbc
3e2d7d0481465fd2ed588f7b36fe49a7ec2c7a9f: Don't copy over regions that will be painted in this frame (bug 1399692 part 8, r=bas) draft
Ryan Hunt <rhunt@eqrion.net> - Sat, 04 Nov 2017 14:52:31 -0400 - rev 695949
Push 88593 by bmo:rhunt@eqrion.net at Fri, 10 Nov 2017 01:41:10 +0000
Don't copy over regions that will be painted in this frame (bug 1399692 part 8, r=bas) We do the same in FinalizeFrame, so we should do it here. MozReview-Commit-ID: JTKDj8yrtI2
10a55540d515c4654071d35388a9b681425e9c6e: Replay buffer commands on paint thread when OMTP is enabled (bug 1399692 part 7, r=bas) draft
Ryan Hunt <rhunt@eqrion.net> - Thu, 26 Oct 2017 00:47:17 -0400 - rev 695948
Push 88593 by bmo:rhunt@eqrion.net at Fri, 10 Nov 2017 01:41:10 +0000
Replay buffer commands on paint thread when OMTP is enabled (bug 1399692 part 7, r=bas) This commit does the work of actually dispatching the recorded buffer operations to the paint thread, and removing some main thread asserts from TextureClient. MozReview-Commit-ID: CN3RoQPz9fP
c0b28ba4fbcd0d28e5cc94b5b36dfc59fd249c4b: Record buffer operations to a struct for replaying on paint thread (bug 1399692 part 6, r=bas) draft
Ryan Hunt <rhunt@eqrion.net> - Wed, 25 Oct 2017 10:20:49 -0400 - rev 695947
Push 88593 by bmo:rhunt@eqrion.net at Fri, 10 Nov 2017 01:41:10 +0000
Record buffer operations to a struct for replaying on paint thread (bug 1399692 part 6, r=bas) This commit adds a CapturedBufferState which is used to record all the operations that are necessary for preparing the buffers. The commands are then instantly executed to preserve the same behavior, but in the following commit they will be dispatched to the paint thread. Note: RotatedBuffer's aren't thread safe and so a shallow copy needs to be made for sending to the paint thread. This complicates the code for AdjustTo as it can fail naturally and the buffer parameter changes are needed later in BeginPaint. So the code for AdjustTo is split up a bit to accomodate that. MozReview-Commit-ID: FwSwFay887o
f3f76c0a394d30ddb01e0e63ff992a80f967a25a: Simplify copying the front buffer to the back buffer (bug 1399692 part 5, r=bas) draft
Ryan Hunt <rhunt@eqrion.net> - Mon, 23 Oct 2017 18:27:53 -0400 - rev 695946
Push 88593 by bmo:rhunt@eqrion.net at Fri, 10 Nov 2017 01:41:10 +0000
Simplify copying the front buffer to the back buffer (bug 1399692 part 5, r=bas) To sync the back buffer with the front buffer, we set the back buffer rect and rotation to the front buffer's, and then copy over the pixels that different. We used to do the updating of the rect and rotation before BeginPaint, but that isn't necessary and we can move it to be with the copying of pixels. MozReview-Commit-ID: HzBKvMZkn1
1e7f2e8659f332ad5a691dd36dc1fc626f83a540: Don't create back buffer for front buffer until we know what type to create. (bug 1399692 part 4, r=bas) draft
Ryan Hunt <rhunt@eqrion.net> - Mon, 23 Oct 2017 15:33:40 -0400 - rev 695945
Push 88593 by bmo:rhunt@eqrion.net at Fri, 10 Nov 2017 01:41:10 +0000
Don't create back buffer for front buffer until we know what type to create. (bug 1399692 part 4, r=bas) This commit is an optimization for double buffering that delays the creation of a back buffer until we know what kind of content type it needs to be. Before this commit, we would EnsureBackBufferIfFrontBuffer before BeginPaint, then in BeginPaint we could determine that we actually needed a different kind of buffer because the content changed type, and recreate it. This was needed because BeginPaint would copy the old front buffer to the buffer created by EnsureBackBufferIfFrontBuffer, and then if anything failed or we had determined we couldn't reuse the buffer, we would create a new one and copy that "temporary" back buffer over, and use the new one. This is unnecessary because we only need read access on that "temporary" back buffer, and so we can just use the current front buffer instead. This optimization only affects the double buffered case, and the single buffered or basic cases should remain the same. Note: Because we now need the front buffer for copying into the new back buffer, we cannot Clear() it away in some error cases. Note: The code in FinalizeFrame assumes that the back and front buffer have the same size. This was implicitly enforced before, and now needs to be explicitly enforced. This commit tries to preserve the exact same behavior, although the restriction should be removed as long as the back buffer is large enough for the visible region. MozReview-Commit-ID: 2hyrrUhA4zO
d84c721a7e2672d499bc532fa46f08795c965d88: Remove BufferContentType and add ValidBufferSize (bug 1399692 part 3, r=bas) draft
Ryan Hunt <rhunt@eqrion.net> - Mon, 23 Oct 2017 14:56:13 -0400 - rev 695944
Push 88593 by bmo:rhunt@eqrion.net at Fri, 10 Nov 2017 01:41:10 +0000
Remove BufferContentType and add ValidBufferSize (bug 1399692 part 3, r=bas) BufferContentType and BufferSizeOkFor make more sense as general functions for any RotatedBuffer, and this helps out in a later patch. MozReview-Commit-ID: EAVodvl4WTu
539277660662c7f359c2ccfc93767a07158f3366: Simplify the code for creating a new back buffer (bug 1399692 part 2, r=bas) draft
Ryan Hunt <rhunt@eqrion.net> - Mon, 23 Oct 2017 12:40:01 -0400 - rev 695943
Push 88593 by bmo:rhunt@eqrion.net at Fri, 10 Nov 2017 01:41:10 +0000
Simplify the code for creating a new back buffer (bug 1399692 part 2, r=bas) MozReview-Commit-ID: D28JNYWD9Uc
4c9771547b0f288a637af8878683297f1eceedc1: Remove unneeded lambda capture in paint thread (bug 1399692 part 1, r=bas) draft
Ryan Hunt <rhunt@eqrion.net> - Tue, 31 Oct 2017 01:55:24 -0400 - rev 695942
Push 88593 by bmo:rhunt@eqrion.net at Fri, 10 Nov 2017 01:41:10 +0000
Remove unneeded lambda capture in paint thread (bug 1399692 part 1, r=bas) MozReview-Commit-ID: 71X22PHRTRz
54c1c660af767fcbf0b2ebecfbe4b126b4bd0081: Bug 1415807 - remove 'chan' box becuase it could exist with other codec types. r?kinetik draft
Alfredo.Yang <ayang@mozilla.com> - Fri, 10 Nov 2017 09:30:30 +0800 - rev 695941
Push 88592 by bmo:ayang@mozilla.com at Fri, 10 Nov 2017 01:35:01 +0000
Bug 1415807 - remove 'chan' box becuase it could exist with other codec types. r?kinetik MozReview-Commit-ID: EGjjIZQHgYO
ed94dc665071d8d510688ff50bbedad2c7cb33ee: Bug 1416070 - Snooze time bomb in test_validators.js for 80 years or until a devtools peer fixes it. r=me on a CLOSED TREE
Sebastian Hengst <archaeopteryx@coole-files.de> - Fri, 10 Nov 2017 02:40:53 +0200 - rev 695940
Push 88592 by bmo:ayang@mozilla.com at Fri, 10 Nov 2017 01:35:01 +0000
Bug 1416070 - Snooze time bomb in test_validators.js for 80 years or until a devtools peer fixes it. r=me on a CLOSED TREE
7596b2ed5e60e924d193f75c01e6822194a81e3f: Bug 1416074: Remove obsolete extensionNameFromURI helper. r?mixedpuppy draft
Kris Maglione <maglione.k@gmail.com> - Thu, 09 Nov 2017 17:18:59 -0800 - rev 695939
Push 88591 by maglione.k@gmail.com at Fri, 10 Nov 2017 01:19:36 +0000
Bug 1416074: Remove obsolete extensionNameFromURI helper. r?mixedpuppy MozReview-Commit-ID: IzaqUZV03rG
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip