d314faca06c9c60c3792032be1ab5453f0a964d6: Bug 1415470 - build: Enable VS2017 C5038 initializer list order warnings (like gcc -Wreorder). r?glandium draft
Chris Peterson <cpeterson@mozilla.com> - Tue, 07 Nov 2017 19:52:10 -0800 - rev 694784
Push 88247 by cpeterson@mozilla.com at Wed, 08 Nov 2017 08:39:14 +0000
Bug 1415470 - build: Enable VS2017 C5038 initializer list order warnings (like gcc -Wreorder). r?glandium C5038 is a new warning in VS2017, similar to gcc and clang's -Wreorder, which is enabled by -Wall. We should enable C5038 so Windows developers can see these warnings locally instead of when gcc and clang fail with warnings-as-errors on Try. https://blogs.msdn.microsoft.com/vcblog/2017/07/21/diagnostic-improvements-in-vs2017-15-3-0/ We need to suppress C5038 warnings from Windows Runtime Library header files (wrl.h) included in ANGLE and widget/windows: z:\build\build\src\vs2017_15.4.2\SDK\Include\10.0.15063.0\winrt\wrl\wrappers\corewrappers.h(515): error C5038: data member 'Microsoft::WRL::Wrappers::Details::SyncLockWithStatusT<Microsoft::WRL::Wrappers::HandleTraits::SemaphoreTraits>::sync_' will be initialized after data member 'Microsoft::WRL::Wrappers::Details::SyncLockWithStatusT<Microsoft::WRL::Wrappers::HandleTraits::SemaphoreTraits>::status_' ... And suppress C5038 warnings in upstream webrtc code: media/webrtc/trunk/webrtc/modules/video_capture/windows/BaseFilter.cpp(176): error C5038: data member 'mozilla::media::BaseFilter::mClsId' will be initialized after data member 'mozilla::media::BaseFilter::mState' media/webrtc/trunk/webrtc/modules/video_capture/windows/BasePin.cpp(169): error C5038: data member 'mozilla::media::BasePin::mFilter' will be initialized after data member 'mozilla::media::BasePin::mLock' media/webrtc/trunk/webrtc/modules/video_capture/windows/BasePin.cpp(170): error C5038: data member 'mozilla::media::BasePin::mLock' will be initialized after data member 'mozilla::media::BasePin::mName' media/webrtc/trunk/webrtc/modules/video_capture/windows/BasePin.cpp(172): error C5038: data member 'mozilla::media::BasePin::mDirection' will be initialized after data member 'mozilla::media::BasePin::mQualitySink' MozReview-Commit-ID: BMDVkvQXNoq
09db8663bd92a186f5c136a5714eafc675242ffa: Bug 1415466 - diff content_decryption_module.h, content_decryption_module_ext.h and content_decryption_module_export.h draft
James Cheng <jacheng@mozilla.com> - Wed, 08 Nov 2017 16:36:03 +0800 - rev 694783
Push 88246 by bmo:jacheng@mozilla.com at Wed, 08 Nov 2017 08:36:31 +0000
Bug 1415466 - diff content_decryption_module.h, content_decryption_module_ext.h and content_decryption_module_export.h MozReview-Commit-ID: IapV1JVtoKx
f49e45390e8acdd36e6df6c40a0deb3b4891c0ca: Bug 1413480 - Check mCDM in ChromiumCDMChild::RecvXXX before dereferencing it. draft
James Cheng <jacheng@mozilla.com> - Wed, 08 Nov 2017 15:44:34 +0800 - rev 694782
Push 88246 by bmo:jacheng@mozilla.com at Wed, 08 Nov 2017 08:36:31 +0000
Bug 1413480 - Check mCDM in ChromiumCDMChild::RecvXXX before dereferencing it. MozReview-Commit-ID: Dp4FOtZ8Yok
dd1a57ae085634eae2c5010fc957f9a745173ff1: Bug 1415451 - [Form Autofill] Storage should avoid saving an empty record. r=steveck draft
Luke Chang <lchang@mozilla.com> - Tue, 07 Nov 2017 20:07:32 +0800 - rev 694781
Push 88245 by bmo:lchang@mozilla.com at Wed, 08 Nov 2017 08:28:22 +0000
Bug 1415451 - [Form Autofill] Storage should avoid saving an empty record. r=steveck MozReview-Commit-ID: BFomE2mTG84
58c402637a48dc2266aab248ecc5b6057a03236c: Bug 1402963 - Part 2: Merge the credit card record into existing data. r=lchang draft
steveck-chung <schung@mozilla.com> - Wed, 25 Oct 2017 17:46:56 +0800 - rev 694780
Push 88245 by bmo:lchang@mozilla.com at Wed, 08 Nov 2017 08:28:22 +0000
Bug 1402963 - Part 2: Merge the credit card record into existing data. r=lchang MozReview-Commit-ID: 3Hkqvo2rK9R
3f05fdfcb9edb47135d0637c271f1d4c166b7b04: Bug 1402963 - Part 1: Deduplicate credit card by checking credit card storage and untouched fields. r=lchang draft
steveck-chung <schung@mozilla.com> - Wed, 27 Sep 2017 18:38:13 +0800 - rev 694779
Push 88245 by bmo:lchang@mozilla.com at Wed, 08 Nov 2017 08:28:22 +0000
Bug 1402963 - Part 1: Deduplicate credit card by checking credit card storage and untouched fields. r=lchang MozReview-Commit-ID: tuw36eyQnl
bb81bba7fea4e412706851b198f4c26d80a97121: Bug 1413480 - Check mCDM in ChromiumCDMChild::RecvXXX before dereferencing it. draft
James Cheng <jacheng@mozilla.com> - Wed, 08 Nov 2017 15:44:34 +0800 - rev 694778
Push 88244 by bmo:jacheng@mozilla.com at Wed, 08 Nov 2017 08:18:34 +0000
Bug 1413480 - Check mCDM in ChromiumCDMChild::RecvXXX before dereferencing it. MozReview-Commit-ID: Dp4FOtZ8Yok
9dcc511abb0f28974eda261c93d4780adfa5c0f0: Bug 1414438 - Use `getBatched` instead of `get` to backfill records r?kitcambridge draft
tfe <tfeserver@gmail.com> - Wed, 08 Nov 2017 09:05:11 +0100 - rev 694777
Push 88243 by bmo:tfeserver@gmail.com at Wed, 08 Nov 2017 08:06:30 +0000
Bug 1414438 - Use `getBatched` instead of `get` to backfill records r?kitcambridge MozReview-Commit-ID: LLTg0ae5BbW *** Bug 1414438 - Use `getBatched` instead of `get` in sync
870d8ea54afe38f849c2caab201c209873428974: Bug 1402707 - Rewrite browser_library_*_middleclick.js to use Places' async APIs. r?mak draft
Mark Banner <standard8@mozilla.com> - Sun, 24 Sep 2017 19:34:41 +0100 - rev 694776
Push 88242 by bmo:standard8@mozilla.com at Wed, 08 Nov 2017 08:05:06 +0000
Bug 1402707 - Rewrite browser_library_*_middleclick.js to use Places' async APIs. r?mak MozReview-Commit-ID: 8PtFO00yqJv
0f3e0eb8aa264244f254cfc07f6b85719c1ba34a: Bug 1402707 - Change BrowserTestUtils.waitForNewTab to allow waiting for tabs to open a new URL when the tab might not be the next one opened. r?mak draft
Mark Banner <standard8@mozilla.com> - Sun, 24 Sep 2017 19:34:34 +0100 - rev 694775
Push 88242 by bmo:standard8@mozilla.com at Wed, 08 Nov 2017 08:05:06 +0000
Bug 1402707 - Change BrowserTestUtils.waitForNewTab to allow waiting for tabs to open a new URL when the tab might not be the next one opened. r?mak MozReview-Commit-ID: HNFEC6BuBit
b8e390b8c7bedfd5eb687c225789d4ad2aebea04: Bug 1415214 - Fix the bound of the clip rect for drawing decoration lines draft
KuoE0 <kuoe0.tw@gmail.com> - Wed, 08 Nov 2017 15:57:43 +0800 - rev 694774
Push 88241 by bmo:kuoe0@mozilla.com at Wed, 08 Nov 2017 08:01:42 +0000
Bug 1415214 - Fix the bound of the clip rect for drawing decoration lines MozReview-Commit-ID: 6nUBwEtsJbs
54e0adfcde968dfebd3e960f22064b3bfe2bd52f: Bug 1415399 - Wait for a frame instead of waiting Animation.ready Promise. r?birtles draft
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Wed, 08 Nov 2017 17:00:20 +0900 - rev 694773
Push 88240 by hikezoe@mozilla.com at Wed, 08 Nov 2017 08:00:46 +0000
Bug 1415399 - Wait for a frame instead of waiting Animation.ready Promise. r?birtles The problematic situation here is pretty similar to the previous commit, but this time it's caused by Animation.ready. Animation.ready is normally fulfilled in Animation::Tick() which is called at the very beginning of refresh driver's tick (just before animation event handling), so the same thing in the previous commit happens here too. Note that I did intentionally leave other Animation.ready(s) that did not break with conformant Promise handling (bug 1193394) since waiting for a frame makes this test much slower (we did actually split the files due to the slowness in bug 1283754). Hopefully once we have the conformant Promise handling, we will know this kind of mistakes on our CI if someone tries to add it (actually that someone should know the mistakes locally though). MozReview-Commit-ID: 3c95vjPnWVb
f009efc967f42d7075fcc5eb85d0412689a34286: Bug 1415399 - Advance the time to right after requestAnimationFrame was processed when we received animation events. r?birtles draft
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Wed, 08 Nov 2017 17:00:17 +0900 - rev 694772
Push 88240 by hikezoe@mozilla.com at Wed, 08 Nov 2017 08:00:46 +0000
Bug 1415399 - Advance the time to right after requestAnimationFrame was processed when we received animation events. r?birtles Some test cases in test_animation_observers_async.html are not supposed to process their code between styling and requestAnimationFrame. For example; target.style = 'animation: none'; yield waitForFrame(); If we processed the first line in the example inside the callback of an animation event, the new style would have not been processed after the second line (i.e. after a requestAnimationFrame) since requestAnimationFrame is processed soon after the animation event's callback. To mitigate this, we wait for a requestAnimationFrame in the event callback here. Though we can't use this mitigating way for timing-specific test cases (e.g. test_restyles.html), we can safely use it in test_animation_observers_async.html since we don't check animation records frame by frame. MozReview-Commit-ID: 8zpUasUPvKd
9866270e360e1fa10149373f99c0f0564098a430: Fix Bug#1381459 draft
Nathaniel Nebel <me@nathanielnebel.com> - Tue, 07 Nov 2017 23:54:23 -0800 - rev 694771
Push 88239 by bmo:me@nathanielnebel.com at Wed, 08 Nov 2017 07:55:12 +0000
Fix Bug#1381459 MozReview-Commit-ID: 8X0hsSOf2b3
ae84cf6a20163c27d4497b0fb8801f8ba2af5d18: Fix Bug#1381459 draft
Nathaniel Nebel <me@nathanielnebel.com> - Mon, 06 Nov 2017 01:31:48 -0800 - rev 694770
Push 88239 by bmo:me@nathanielnebel.com at Wed, 08 Nov 2017 07:55:12 +0000
Fix Bug#1381459 MozReview-Commit-ID: DMcQgz1vDYW
c873cb28d82a40376fcf450e63efbd7dc5090dfb: Bug 1415409 - Make == operator of RangeBoundaryBase compare mRef and mOffset more carefully r?catalinb draft
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 08 Nov 2017 13:35:00 +0900 - rev 694769
Push 88238 by masayuki@d-toybox.com at Wed, 08 Nov 2017 07:54:53 +0000
Bug 1415409 - Make == operator of RangeBoundaryBase compare mRef and mOffset more carefully r?catalinb Currently, RangeBoundaryBase can store either only mRef or mOffset. However, == operator of RangeBoudaryBase still compares mRef simply. However, if one has only mRef and the other has only mOffset, it returns false. This patch makes == operator checks if both mOffset have been set. If so, this checks both mOffset.value() and mRef are matched. However, if mRef of only one of them is nullptr, this doesn't make it check mRef because computing mRef needs some cost and initializing mRef from the other fixes the referring child stronger. If the user of the operator sets only mOffset and wait DOM tree changes, computing mRef may break such callers. If one has only mRef and the other has only mOffset, this patch makes it compute mRef. This is not the best behavior, perhaps. However, there is no way to compare these instances. If this becomes a problem, we should make it create temporary instance, but it'll waste runtime cost. So, let's avoid using this approach for now. Finally, making it check both mRef simply. MozReview-Commit-ID: 4nsW5SYDTiZ
3db7b72f306429326c289bd4a6c96ff79da23c3f: Bug 1415454 - Replace RedBlackTree::Init with a constructor. r?njn draft
Mike Hommey <mh+mozilla@glandium.org> - Wed, 08 Nov 2017 16:43:31 +0900 - rev 694768
Push 88237 by bmo:mh+mozilla@glandium.org at Wed, 08 Nov 2017 07:48:15 +0000
Bug 1415454 - Replace RedBlackTree::Init with a constructor. r?njn Before 1412722, RedBlackTree actually needed a constructor to fill the sentinel, but now, all it contains is a pointer to a root node, and an empty tree just has a null root node. So we can use a constexpr constructor for the class, which in most cases removes the need for manual initialization/construction (being used as member of constructed classes, or globals), except in the case of arena_bin_t, which is never constructed.
56e877f9e8d2da2ad6741bc25fe529c78fb85c77: Bug 1413480 - Check mCDM in ChromiumCDMChild::RecvXXX before dereferencing it. draft
James Cheng <jacheng@mozilla.com> - Wed, 08 Nov 2017 15:44:34 +0800 - rev 694767
Push 88236 by bmo:jacheng@mozilla.com at Wed, 08 Nov 2017 07:45:04 +0000
Bug 1413480 - Check mCDM in ChromiumCDMChild::RecvXXX before dereferencing it. MozReview-Commit-ID: Dp4FOtZ8Yok
76a0d71852707680cc8d3233c740b78c224f6c2d: Revert "Hack code to allow testing with clearkey keysystem." draft
James Cheng <jacheng@mozilla.com> - Wed, 08 Nov 2017 13:25:44 +0800 - rev 694766
Push 88236 by bmo:jacheng@mozilla.com at Wed, 08 Nov 2017 07:45:04 +0000
Revert "Hack code to allow testing with clearkey keysystem." This reverts commit 4eef87e7c7a55bc4f7f1f9a8f402a5ee3c39fece.
040164bb0e736a4e7aa80fb800e8349f143f7b97: Revert "pretend supporting hdcp policy." draft
James Cheng <jacheng@mozilla.com> - Wed, 08 Nov 2017 13:03:17 +0800 - rev 694765
Push 88236 by bmo:jacheng@mozilla.com at Wed, 08 Nov 2017 07:45:04 +0000
Revert "pretend supporting hdcp policy." This reverts commit de3d2767b930fd0ee2adab313e0295288c0d14d6.
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip