d1a6e488a164235a86ed03d8de003e31709fe0e6: bug 1384701 get system fonts in EnsureInit() which is on main thread even with servo r?manishearth draft
Karl Tomlinson <karlt+@karlt.net> - Mon, 04 Sep 2017 18:29:04 +1200 - rev 658903
Push 77927 by ktomlinson@mozilla.com at Tue, 05 Sep 2017 05:44:06 +0000
bug 1384701 get system fonts in EnsureInit() which is on main thread even with servo r?manishearth GTK should be used only from the main thread, but the specific symptom before this change was that creating a GtkEntry causes pango_cairo_font_map_get_default() to be called. This function returns a different font map on each thread. The font map is leaked when StyleThreads are leaked at exit. Font caches are usually expensive and so using the existing font map on the main thread is preferable. A GtkEntry already exists on the main thread, as well as style contexts for most other system fonts, and so it is more efficient to create these on the main thread while the style contexts exist. Doing this also avoids the need for Gecko_nsFont_InitSystem() to hold a global lock to avoid concurrently calling into GTK through LookAndFeel::GetColor(). MozReview-Commit-ID: DSOwEUeYmtV
9ae5fc31ecf1873039e111949f22734e6fdf944b: bug 1384701 get system font name and size from widget style context instead of GtkSettings r?manishearth draft
Karl Tomlinson <karlt+@karlt.net> - Mon, 04 Sep 2017 21:33:21 +1200 - rev 658902
Push 77927 by ktomlinson@mozilla.com at Tue, 05 Sep 2017 05:44:06 +0000
bug 1384701 get system font name and size from widget style context instead of GtkSettings r?manishearth gtk_widget_get_settings() returns the same settings for all widgets [1] but GTK actually uses specific fonts for each widget [2]. [1] https://git.gnome.org/browse/gtk+/tree/gtk/gtkwidget.c?h=3.22.19#n11637 [2] https://git.gnome.org/browse/gtk+/tree/gtk/gtkwidget.c?h=3.22.19#n10334 Changing to GtkStyleContext* will also make this easier to use from code where the GtkStyleContext exists but not the GtkWidget, such as EnsureInit() in a future patch. MozReview-Commit-ID: 3NuTL5wRzm5
750b4d22f7c6638ec0dd2354a6f71df6f2adfc18: bug 1384701 remove MOZ_WIDGET_GTK == 2 code from nsLookAndFeel r?manishearth draft
Karl Tomlinson <karlt+@karlt.net> - Mon, 04 Sep 2017 17:36:17 +1200 - rev 658901
Push 77927 by ktomlinson@mozilla.com at Tue, 05 Sep 2017 05:44:06 +0000
bug 1384701 remove MOZ_WIDGET_GTK == 2 code from nsLookAndFeel r?manishearth This old code no longer builds and is superseded by the GTK3 port. See also bug 1278282. MozReview-Commit-ID: 9KyrPuNAluv
c4de3ec210ffcbeed6aa64550676853cbbcf8260: Bug 1396714 Remove Gecko pref 'mma.enabled' r?maliu draft
Nevin Chen <cnevinchen@gmail.com> - Tue, 05 Sep 2017 13:36:49 +0800 - rev 658900
Push 77926 by bmo:cnevinchen@gmail.com at Tue, 05 Sep 2017 05:37:41 +0000
Bug 1396714 Remove Gecko pref 'mma.enabled' r?maliu MozReview-Commit-ID: 8CG11OS1XlL
2db53c4dadcb3f9b9c5844fe5a6db3c5e42bdf45: Bug 1396093 - Add a missing leading zero byte to a test case that uses UTF-16BE. draft
Henri Sivonen <hsivonen@hsivonen.fi> - Mon, 04 Sep 2017 16:50:39 +0300 - rev 658899
Push 77925 by bmo:hsivonen@hsivonen.fi at Tue, 05 Sep 2017 05:36:14 +0000
Bug 1396093 - Add a missing leading zero byte to a test case that uses UTF-16BE. The old style system uses nsUnicharStreamLoader, which never signals the end of the stream to mozilla::Decoder, which caused the input to be truncated instead of the error in the input being detected. Stylo uses mozilla::css::StreamLoader, which correctly signals the end of the stream, so the an odd number of bytes in UTF-16BE resulted in the output ending with U+FFFD, which ran into the keyword "green" making it not a valid keyword. MozReview-Commit-ID: uSaCIfrAOF
b2c0011d41259ffb6648fd3ee6974b06d0da4efd: Bug 1396085 - ensure the sync widget is always initialized and animate the sync spinner. r?Gijs draft
Mark Hammond <mhammond@skippinet.com.au> - Tue, 05 Sep 2017 15:08:17 +1000 - rev 658898
Push 77924 by bmo:markh@mozilla.com at Tue, 05 Sep 2017 05:10:01 +0000
Bug 1396085 - ensure the sync widget is always initialized and animate the sync spinner. r?Gijs MozReview-Commit-ID: HcAuLZQ95EH
f9accee967431ecc5edae96625f642ab9ad2f808: Bug 1352238 Part 8 - Make fuzzy and unexpected tests passed. r?mats draft
Louis Chang <lochang@mozilla.com> - Tue, 05 Sep 2017 10:48:15 +0800 - rev 658897
Push 77923 by lochang@mozilla.com at Tue, 05 Sep 2017 04:56:29 +0000
Bug 1352238 Part 8 - Make fuzzy and unexpected tests passed. r?mats MozReview-Commit-ID: 5j2xeZ0VHW6
173aa7a1865f2722c1d1baacc6efd15889fda501: Bug 1352238 Part 7 - Check if native theme supports the widget before using it. r?mats draft
Louis Chang <lochang@mozilla.com> - Tue, 05 Sep 2017 10:47:34 +0800 - rev 658896
Push 77923 by lochang@mozilla.com at Tue, 05 Sep 2017 04:56:29 +0000
Bug 1352238 Part 7 - Check if native theme supports the widget before using it. r?mats MozReview-Commit-ID: IKoYDzNCVx4
29435b28326edced3518af0d91fa3ca0fd16643c: Bug 1352238 Part 6 - Enable reftests for checkbox/radio form controls on Android. r?mats draft
Louis Chang <lochang@mozilla.com> - Tue, 05 Sep 2017 10:10:53 +0800 - rev 658895
Push 77923 by lochang@mozilla.com at Tue, 05 Sep 2017 04:56:29 +0000
Bug 1352238 Part 6 - Enable reftests for checkbox/radio form controls on Android. r?mats MozReview-Commit-ID: 7R1V3LK03cr
27c06cd721e1f4d398187e866133a027bedfdd59: Bug 1396548 - Handle Push Notification when app is not running. r?maliu draft
Nevin Chen <cnevinchen@gmail.com> - Mon, 04 Sep 2017 19:15:32 +0800 - rev 658894
Push 77922 by bmo:cnevinchen@gmail.com at Tue, 05 Sep 2017 04:56:09 +0000
Bug 1396548 - Handle Push Notification when app is not running. r?maliu When app is not runing, Gecko is not running. Thus we can't get Gecko pref. We should skip Gecko pref check and show notifications when we recieve push messages and while app is not running. Other checks (ie. Switchboard, Health Report...etc) remain the same. MozReview-Commit-ID: H2X18VI0cnW
00d2b3cd4e6d28351f1f5bbd6d62737574f36945: Bug 1392476 - Add dropframe telemetry for WebVR; r?kip draft
Daosheng Mu <daoshengmu@gmail.com> - Mon, 28 Aug 2017 18:43:25 +0800 - rev 658893
Push 77921 by bmo:dmu@mozilla.com at Tue, 05 Sep 2017 04:18:28 +0000
Bug 1392476 - Add dropframe telemetry for WebVR; r?kip MozReview-Commit-ID: IPVnPBkY8CN
8ede5394d12b6583817bd07af255045183d97e0c: Bug 1390367 - Pass SMIL mochitests of stroke-* even if a computed value has no px unit. r?birtles draft
Mantaroh Yoshinaga <mantaroh@gmail.com> - Tue, 05 Sep 2017 13:15:32 +0900 - rev 658892
Push 77920 by bmo:mantaroh@gmail.com at Tue, 05 Sep 2017 04:15:45 +0000
Bug 1390367 - Pass SMIL mochitests of stroke-* even if a computed value has no px unit. r?birtles Currently, Gecko converts lengths in stroke-* properties to numbers when creating animation values and hence the result of animation is always a unitless value for these properties. Servo, on the other hand, converts lengths for these properties to numbers during interpolation and hence sometimes the result of animation is a unitless value, and other times (such as when skipping interpolation) it is not. Other browsers produce lengths with px units and ultimately we should align with that behavior. As a result, this patch updates various SMIL mochitests to: * Expect animation values with px unit * Compare values by stripping px units as a temporary measure until we correctly serialize these values with px (bug 1379908). MozReview-Commit-ID: IsT26DKkgiP
539454bc519a6b7166affa0388181501ed270bdc: Bug 1396700 - Add a method to ServoStyleSet for creating XBL style set. draft
Ting-Yu Lin <tlin@mozilla.com> - Fri, 01 Sep 2017 16:45:39 +0800 - rev 658891
Push 77919 by bmo:tlin@mozilla.com at Tue, 05 Sep 2017 04:13:26 +0000
Bug 1396700 - Add a method to ServoStyleSet for creating XBL style set. The motivation of this patch is that clearing mPresContext should be an implementation detail of XBL style set, so I create a method for that, and remove ClearPresContext(). MozReview-Commit-ID: Ftta0rcAqu6
0997bf92390ac90b9dce2ae70f89cc9e0565c350: Bug 1395519 - [Form Autofill] Keep the original data when record updated via submission. r=lchang draft
steveck-chung <schung@mozilla.com> - Fri, 01 Sep 2017 10:11:19 +0800 - rev 658890
Push 77918 by bmo:schung@mozilla.com at Tue, 05 Sep 2017 04:09:33 +0000
Bug 1395519 - [Form Autofill] Keep the original data when record updated via submission. r=lchang MozReview-Commit-ID: DkVgOlTqVhH
0ac2a1e269419d3bdb3fa1a0184a89eee11f4b5c: Bug 1387357 - IMContextWrapper::DispatchCompositionStart() should stop dispatching eCompositionStart if dispatching preceding eKeyDown event causes changing active IM context r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 04 Sep 2017 20:18:43 +0900 - rev 658889
Push 77917 by masayuki@d-toybox.com at Tue, 05 Sep 2017 04:03:30 +0000
Bug 1387357 - IMContextWrapper::DispatchCompositionStart() should stop dispatching eCompositionStart if dispatching preceding eKeyDown event causes changing active IM context r?m_kato If a keydown event handler moves focus like Ctrl+PageDown handler, IM context may be changed to DISABLED or something. In such case, native IME would stop current composition because focus moving in Gecko causes making IME blurred. However, IMContextWrapper::DispatchCompositionStart() always dispatches eCompositionStart even in such case. So, it should stop dispatching eCompositionStart if IME enabled state is changed during dispatching the preceding keydown event. Note that this patch moves the setter of mComposingContext from OnStartCompositionNative() which is a signal listener of "preedit_start" to DispatchCompositionStart() because if IME starts composition without "preedit_start" signal, DispatchCompositionStart() will be called but OnStartCompositionNative() isn't called. However, this fix needs mComposingContext. MozReview-Commit-ID: F3F6NuCOrkJ
85757a339f97115499d430639ba6431715bcb8fa: Bug 1396302 - IMEStateManager::OnChangeFocusInternal() should check oldWidget's IME notification requests rather than sFocusedIMEWidget r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 04 Sep 2017 17:37:40 +0900 - rev 658888
Push 77917 by masayuki@d-toybox.com at Tue, 05 Sep 2017 04:03:30 +0000
Bug 1396302 - IMEStateManager::OnChangeFocusInternal() should check oldWidget's IME notification requests rather than sFocusedIMEWidget r?m_kato In some cases, sFocusedIMEWidget may be nullptr but oldWidget still has composition since IMEStateManager doesn't guarantee that NOTIFY_IME_OF_BLUR is sent after REQUEST_TO_COMMIT_COMPOSITION nor REQUEST_TO_CANCEL_COMPOSITION. Therefore, when it tries to clean up old widget's composition, it should refer the old widget's IME notification requests. MozReview-Commit-ID: 8kZvJbHfs5z
928316bbba373682b4f1e5c65438e940c67c0a07: Bug 1396548 - Handle Push Notification when app is not running. r?maliu draft
Nevin Chen <cnevinchen@gmail.com> - Mon, 04 Sep 2017 19:15:32 +0800 - rev 658887
Push 77916 by bmo:cnevinchen@gmail.com at Tue, 05 Sep 2017 03:59:41 +0000
Bug 1396548 - Handle Push Notification when app is not running. r?maliu When app is not runing, Gecko is not running. Thus we can't get Gecko pref. We should skip Gecko pref check and show notifications when we recieve push messages and while app is not running. Other checks (ie. Switchboard, Health Report...etc) remain the same. MozReview-Commit-ID: H2X18VI0cnW
02a60ac61d393aa4b0feab74fd45e3d600bd922e: Bug 1380590 - Support None and NotSet for the fallback of SVGPaint. draft
KuoE0 <kuoe0.tw@gmail.com> - Fri, 01 Sep 2017 17:27:02 +0800 - rev 658886
Push 77915 by bmo:kuoe0@mozilla.com at Tue, 05 Sep 2017 03:38:54 +0000
Bug 1380590 - Support None and NotSet for the fallback of SVGPaint. MozReview-Commit-ID: AOu89NyLzSp
62deeddcc77579419f6131cd4d0babcf982b291b: Bug 1395920 - Remove vertical dividers in tabs tray page. r?nechen draft
Jing-wei Wu <topwu.tw@gmail.com> - Tue, 05 Sep 2017 11:23:50 +0800 - rev 658885
Push 77914 by bmo:topwu.tw@gmail.com at Tue, 05 Sep 2017 03:29:46 +0000
Bug 1395920 - Remove vertical dividers in tabs tray page. r?nechen MozReview-Commit-ID: HZQcuSLbuOm
3f66400d8f5f6ec32303b995f2bd5c92ce3ed5f1: Bug 1395917 - Update reading list folder icon on bookmark panel. r?nechen draft
Jing-wei Wu <topwu.tw@gmail.com> - Tue, 05 Sep 2017 11:04:24 +0800 - rev 658884
Push 77914 by bmo:topwu.tw@gmail.com at Tue, 05 Sep 2017 03:29:46 +0000
Bug 1395917 - Update reading list folder icon on bookmark panel. r?nechen MozReview-Commit-ID: LGdn9KfZkcn
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip