d045934911e055ad4982a1f99d188bc58565d0b7: Bug 1311842 - Manually set intrinsic bounds on DrawableCompat to ensure visibility r?sebastian draft
Andrzej Hunt <ahunt@mozilla.com> - Thu, 20 Oct 2016 15:49:09 -0700 - rev 428975
Push 33447 by ahunt@mozilla.com at Mon, 24 Oct 2016 21:31:49 +0000
Bug 1311842 - Manually set intrinsic bounds on DrawableCompat to ensure visibility r?sebastian This seems to be a change and/or regression in the 23.4.0 support libraries, which results in the drawable being treated as having no (or infintely small) bounds, and therefore no drawable being shown on screen. This workaround is only needed on Android <= 4.4.4, i.e. pre-Lollipop. MozReview-Commit-ID: LOg3Dd6gtZx
969da2786598c11fb8cd18a341b880cb482b820d: Bug 1311561 - Add basic AS context menu robocop tests r?sebastian draft
Andrzej Hunt <ahunt@mozilla.com> - Thu, 20 Oct 2016 09:22:04 -0700 - rev 428974
Push 33446 by ahunt@mozilla.com at Mon, 24 Oct 2016 21:22:59 +0000
Bug 1311561 - Add basic AS context menu robocop tests r?sebastian MozReview-Commit-ID: A90BvpuHJHb
82fa56df19702391fa86bc16febe80fe61156b66: Bug 1311561 - Pre: add design support library to robocop r?sebastian,nalexander draft
Andrzej Hunt <ahunt@mozilla.com> - Thu, 20 Oct 2016 09:19:22 -0700 - rev 428973
Push 33446 by ahunt@mozilla.com at Mon, 24 Oct 2016 21:22:59 +0000
Bug 1311561 - Pre: add design support library to robocop r?sebastian,nalexander We want to access ActivityStreamContextMenu directly in our new test. That menu extends BottomSheetDialog which is contained in the design support library, hence we need to make that library available in robocop builds in order to access the AS context menu. MozReview-Commit-ID: EPyv7wvkJAE
b6571211c807e209e550833eb47dfc08a4c6ae53: Bug 1300144 - Implement Activity Stream "context" bottomsheet menu r=sebastian
Andrzej Hunt <ahunt@mozilla.com> - Mon, 24 Oct 2016 10:17:14 -0700 - rev 428972
Push 33446 by ahunt@mozilla.com at Mon, 24 Oct 2016 21:22:59 +0000
Bug 1300144 - Implement Activity Stream "context" bottomsheet menu r=sebastian MozReview-Commit-ID: ARvuWk7H99m
08a6186c2842c471e85ac5e4060841431dcef572: Bug 1300144 - Import Activity Stream (VectorDrawable) menu icons r=sebastian
Andrzej Hunt <ahunt@mozilla.com> - Fri, 07 Oct 2016 16:01:26 +0200 - rev 428971
Push 33446 by ahunt@mozilla.com at Mon, 24 Oct 2016 21:22:59 +0000
Bug 1300144 - Import Activity Stream (VectorDrawable) menu icons r=sebastian MozReview-Commit-ID: 66TGmjHYkeD
e4e419b838bfac6d82d7cdac986d5919f17122b1: Bug 1300144 - Pre: pass mUrlOpenInBackgroundListener into HighlightsItem r=sebastian
Andrzej Hunt <ahunt@mozilla.com> - Wed, 19 Oct 2016 15:41:44 -0700 - rev 428970
Push 33446 by ahunt@mozilla.com at Mon, 24 Oct 2016 21:22:59 +0000
Bug 1300144 - Pre: pass mUrlOpenInBackgroundListener into HighlightsItem r=sebastian This will be needed for opening background/private tabs from the highlights menu. MozReview-Commit-ID: 8wvFuTgl2SP
4267a799727e687e28579f0f15661b80f6a882aa: Bug 1300144 - Increase touch area for menu button r=sebastian
Andrzej Hunt <ahunt@mozilla.com> - Wed, 19 Oct 2016 16:32:29 -0700 - rev 428969
Push 33446 by ahunt@mozilla.com at Mon, 24 Oct 2016 21:22:59 +0000
Bug 1300144 - Increase touch area for menu button r=sebastian MozReview-Commit-ID: GBdLisIwFuH
9cdd8ed1733a941de56c4d022400c3e4b2ce0d12: Bug 1311741 - Remove "--non-constant-id" from aapt invocations r=nalexander
Andrzej Hunt <ahunt@mozilla.com> - Mon, 24 Oct 2016 09:39:43 -0700 - rev 428968
Push 33446 by ahunt@mozilla.com at Mon, 24 Oct 2016 21:22:59 +0000
Bug 1311741 - Remove "--non-constant-id" from aapt invocations r=nalexander This flag seems to no longer be needed, and prevents the use of switch statements for resource ID's. It was first introduced for mach based geckoview builds, however geckoview now seems to be built using gradle which is able to invoke aapt to produce better R.java's, resulting in constant Resource ID's in Fennec. MozReview-Commit-ID: EjWCX4nvlht
047185d03891ffa44e54e5e6f421f04d20fd643c: Bug 1311923 - Use WeakMaps for caching grid gap patterns r=pbro
Gabriel Luong <gabriel.luong@gmail.com> - Mon, 24 Oct 2016 09:12:40 -0700 - rev 428967
Push 33446 by ahunt@mozilla.com at Mon, 24 Oct 2016 21:22:59 +0000
Bug 1311923 - Use WeakMaps for caching grid gap patterns r=pbro
42de5eb1c5da74a9a028e298dbf23b52d3af172d: Bug 1312559 - Remove empty 'partial interface' stanza. r?smaug draft
Ralph Giles <giles@mozilla.com> - Mon, 24 Oct 2016 14:19:06 -0700 - rev 428966
Push 33445 by bmo:giles@thaumas.net at Mon, 24 Oct 2016 21:22:21 +0000
Bug 1312559 - Remove empty 'partial interface' stanza. r?smaug This was spuriously included in the commit in bug 1277359. Thanks to bz for reporting the issue. MozReview-Commit-ID: GtziWe2CyBu
9aa3cc7edb1a456ae168c297c84ac832e9536af0: Bug 1312559 - Remove empty 'partial interface' stanza. r?bz draft
Ralph Giles <giles@mozilla.com> - Mon, 24 Oct 2016 14:19:06 -0700 - rev 428965
Push 33444 by bmo:giles@thaumas.net at Mon, 24 Oct 2016 21:21:00 +0000
Bug 1312559 - Remove empty 'partial interface' stanza. r?bz This was spuriously included in the commit in bug 1277359. Thanks to bz for reporting the issue. MozReview-Commit-ID: GtziWe2CyBu
4793a0f8386d707e8715b8a12b9a2d79687420c4: Bug 1299411 - Error messages for native messaging draft
Rob Wu <rob@robwu.nl> - Sat, 24 Sep 2016 13:45:02 +0200 - rev 428964
Push 33443 by bmo:rob@robwu.nl at Mon, 24 Oct 2016 21:17:27 +0000
Bug 1299411 - Error messages for native messaging - Combine the errors for a non-existing app and lacking permissions to avoid information leakage. - Do not treat normal application exit as an error. - Create errors in the right context. - Add tests that check the error messages. MozReview-Commit-ID: HxBpeCSyyGN
e35fca245d531c7db2fb35ac39ec88c0608a8cc4: Bug 1299411 - Move native messaging to child process draft
Rob Wu <rob@robwu.nl> - Sat, 24 Sep 2016 13:25:56 +0200 - rev 428963
Push 33443 by bmo:rob@robwu.nl at Mon, 24 Oct 2016 21:17:27 +0000
Bug 1299411 - Move native messaging to child process Move `runtime.connectNative` and `runtime.sendNativeMessage` to `addon_child`. Note: This does not change the behavior for launching the native app, it is still launched from the main process. Now ExtensionUtils's Port is also used for native messaging ports. Now the behavior of `runtime.connect` and `runtime.connectNative` are identical from the extension's perspective. In particular: - `disconnect()` does not throw when called again (bug 1287229). - `onDisconnect` is called with error messages (tests will be added in the next commit). MozReview-Commit-ID: AyU9amiLeoL
56b781e1c38753f11afa5fa68cc257d15bf8ff01: Bug 1299411 - s/on/once/ in NativeApp's sendMessage draft
Rob Wu <rob@robwu.nl> - Sat, 24 Sep 2016 13:22:31 +0200 - rev 428962
Push 33443 by bmo:rob@robwu.nl at Mon, 24 Oct 2016 21:17:27 +0000
Bug 1299411 - s/on/once/ in NativeApp's sendMessage This communicates more clearly that we expect only one message/event. MozReview-Commit-ID: 8jDYBVwqQtz
685bc0d23b065f2ae801a1979dcb4fd77423c74a: Bug 1299411 - Remove extension param from NativeApp draft
Rob Wu <rob@robwu.nl> - Sat, 24 Sep 2016 13:18:48 +0200 - rev 428961
Push 33443 by bmo:rob@robwu.nl at Mon, 24 Oct 2016 21:17:27 +0000
Bug 1299411 - Remove extension param from NativeApp The extension is always available as `context.extension`, so do not unnecessarily pass the extension as a separate parameter. MozReview-Commit-ID: 9OaestUAGVk
f846976d82d1619d02d9bcab8332a4d5bdb977a8: Bug 1299411 - Deduplicate context getter logic in ParentAPIManager draft
Rob Wu <rob@robwu.nl> - Sat, 24 Sep 2016 13:10:39 +0200 - rev 428960
Push 33443 by bmo:rob@robwu.nl at Mon, 24 Oct 2016 21:17:27 +0000
Bug 1299411 - Deduplicate context getter logic in ParentAPIManager MozReview-Commit-ID: E9MpHhal7WF
1f71a189da119d236f5d495d4b026754988998a2: Bug 1299411 - separate serialization from sending draft
Rob Wu <rob@robwu.nl> - Sat, 24 Sep 2016 13:03:20 +0200 - rev 428959
Push 33443 by bmo:rob@robwu.nl at Mon, 24 Oct 2016 21:17:27 +0000
Bug 1299411 - separate serialization from sending Serialization of the message should happen in the same process as the extension context, whereas sending the message should be in the same process as the owner of the native messaging host. With webext-oop, the former is an addon process and the latter the main process. Therefore it is necessary to separate the two roles. MozReview-Commit-ID: 8BJZmn2QjLJ
211d5faf7a93483622ebf20749125aa19c8df90f: Bug 1299411 - Propagate errors to port.onDisconnect draft
Rob Wu <rob@robwu.nl> - Fri, 30 Sep 2016 22:42:28 +0200 - rev 428958
Push 33443 by bmo:rob@robwu.nl at Mon, 24 Oct 2016 21:17:27 +0000
Bug 1299411 - Propagate errors to port.onDisconnect MozReview-Commit-ID: EPaVtV4WkcQ
9e3559c16f36c405c11b86fa34be18adc1ea18e1: Bug 1299411 - Unify fire and fireWithoutClone. draft
Rob Wu <rob@robwu.nl> - Sat, 24 Sep 2016 11:48:43 +0200 - rev 428957
Push 33443 by bmo:rob@robwu.nl at Mon, 24 Oct 2016 21:17:27 +0000
Bug 1299411 - Unify fire and fireWithoutClone. Unify implementation of fire and fireWithoutClone. `fireWithoutClone` was running the callbacks synchronously. After this commit the callback is run asynchronously. This is safe because the only user of this method is `Port`'s `onDisconnect`. MozReview-Commit-ID: 1kiYavsu3e7
259137af431758fb984bf20c1f9545f730e906e2: Bug 1299411 - Pass port parameter to port.onMessage draft
Rob Wu <rob@robwu.nl> - Sat, 24 Sep 2016 11:34:26 +0200 - rev 428956
Push 33443 by bmo:rob@robwu.nl at Mon, 24 Oct 2016 21:17:27 +0000
Bug 1299411 - Pass port parameter to port.onMessage This should have been a part of bug 1298810, but that only set the argument for native messaging ports, which does not use Port from ExtensionUtils. The port parameter must also be included in runtime's Port.onMessage to avoid regressions when the port implementations are unified and native messaging starts using runtime's Port. Note that starting from this commit, multiple onMessage listeners receive the same (cloned) message instead of a new clone per listener. This is a side effect of using `fire.withoutClone` instead of `fire`: `fire` clones all parameters, but ports are not cloneable so we have to use `fire.withoutClone` instead. This change with regards to message cloning is fully compatible with Chrome's messaging API (which also passes the same message object to all `port.onMessage` calls). MozReview-Commit-ID: AUDuUKHkXCM
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip