cf852fc7100f938b0e3038d86acf04544065445a: Bug 1315874 - Add MightNeedBaseStyle helper method; r=dholbert
Brian Birtles <birtles@gmail.com> - Mon, 03 Apr 2017 16:49:09 +0900 - rev 556540
Push 52578 by dholbert@mozilla.com at Thu, 06 Apr 2017 01:25:10 +0000
Bug 1315874 - Add MightNeedBaseStyle helper method; r=dholbert We will use this in a subsequent patch in this series to determine if we need to fetch a style context at the beginning of ComposeAttribute (when we create the nsISMILAttr) or not. MozReview-Commit-ID: CFBNmmFNNef
1f233c0466f62f140f03b68fca7714f216baa63b: Bug 1315874 - Add a method to nsSMILCSSValueType that takes a StyleAnimationValue; r=dholbert
Brian Birtles <birtles@gmail.com> - Thu, 30 Mar 2017 16:53:15 +0900 - rev 556539
Push 52578 by dholbert@mozilla.com at Thu, 06 Apr 2017 01:25:10 +0000
Bug 1315874 - Add a method to nsSMILCSSValueType that takes a StyleAnimationValue; r=dholbert In a subsequent patch we will extract a StyleAnimationValue from an nsStyleContext. Rather than serializing it and then re-parsing it into a StyleAnimationValue, this patch adds a method to directly accept a StyleAnimationValue since that is what nsSMILCSSValueType stores internally anyway. MozReview-Commit-ID: KBaLYAzAlWZ
09d2b2c67b7fe274ab094d7b623ec19e544959b1: Bug 1315874 - Add test that SMIL does not trigger CSS Transitions; r=dbaron
Mantaroh Yoshinaga <mantaroh@gmail.com> - Mon, 16 Jan 2017 14:07:39 +0900 - rev 556538
Push 52578 by dholbert@mozilla.com at Thu, 06 Apr 2017 01:25:10 +0000
Bug 1315874 - Add test that SMIL does not trigger CSS Transitions; r=dbaron MozReview-Commit-ID: D8zZTFkoY6p
628d8aa03600d319eca1c3cee5b145169b1ea72b: Bug 1353944 - Update enums for mp4parse 0.8.0. r?kinetik draft
Ralph Giles <giles@mozilla.com> - Wed, 05 Apr 2017 17:30:47 -0700 - rev 556537
Push 52577 by bmo:giles@thaumas.net at Thu, 06 Apr 2017 01:08:09 +0000
Bug 1353944 - Update enums for mp4parse 0.8.0. r?kinetik The support to namespace prefixing in moz-cheddar means we can simplify exported enum names on the rust side. However this makes for some spelling changes on the C side. MozReview-Commit-ID: 4t6NDusx0uI
f1f5393744f98c94cd0c995846c63981acf8892a: Bug 1353944 - Update to mp4parse 0.8.0. r?kinetik draft
Ralph Giles <giles@mozilla.com> - Wed, 05 Apr 2017 16:19:47 -0700 - rev 556536
Push 52577 by bmo:giles@thaumas.net at Thu, 06 Apr 2017 01:08:09 +0000
Bug 1353944 - Update to mp4parse 0.8.0. r?kinetik Sync with crates.io version. Just enum spelling changes. MozReview-Commit-ID: BS02zEoJaV1
7160a3d89708f37a3df0d7b914c3aa01ad7a369e: Bug 1353941: Convert a MOZ_RELEASE_ASSERT() expression to "if" + MOZ_CRASH(), to work around clang 3.8 segfault. r?froydnj draft
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 05 Apr 2017 17:55:29 -0700 - rev 556535
Push 52576 by dholbert@mozilla.com at Thu, 06 Apr 2017 00:55:40 +0000
Bug 1353941: Convert a MOZ_RELEASE_ASSERT() expression to "if" + MOZ_CRASH(), to work around clang 3.8 segfault. r?froydnj MozReview-Commit-ID: Bq2DM61YvQ3
7b411012273312ef82426c61b348f3ca2f2391aa: Bug 1267480 - Only open the preferences once during the test run and reload it for subsequent tests to improve the speed of the browser_security.js test. r?gijs draft
Jared Wein <jwein@mozilla.com> - Wed, 05 Apr 2017 20:53:48 -0400 - rev 556534
Push 52575 by bmo:jaws@mozilla.com at Thu, 06 Apr 2017 00:54:16 +0000
Bug 1267480 - Only open the preferences once during the test run and reload it for subsequent tests to improve the speed of the browser_security.js test. r?gijs MozReview-Commit-ID: KmzwTxvbf4r
3937e8931d8de369532b71686060466706761238: Bug 1353941: Convert MOZ_RELEASE_ASSERT() expression to "if" + MOZ_CRASH(), to workaround clang 3.8 segfault. r?froydnj draft
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 05 Apr 2017 17:51:59 -0700 - rev 556533
Push 52574 by dholbert@mozilla.com at Thu, 06 Apr 2017 00:52:14 +0000
Bug 1353941: Convert MOZ_RELEASE_ASSERT() expression to "if" + MOZ_CRASH(), to workaround clang 3.8 segfault. r?froydnj MozReview-Commit-ID: Bq2DM61YvQ3
9bb63b720a83464622da48d56d24200d38a6ec26: Bug 812687 part 9: Add tests for "order" property's influence on list-numbering, baseline, and focus order in a flexbox. (no review, test-only) draft
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 05 Apr 2017 16:47:30 -0700 - rev 556532
Push 52574 by dholbert@mozilla.com at Thu, 06 Apr 2017 00:52:14 +0000
Bug 812687 part 9: Add tests for "order" property's influence on list-numbering, baseline, and focus order in a flexbox. (no review, test-only) MozReview-Commit-ID: EEkPlCgzknG
4392b36037697b9e233758ea09dfcee3018d03e5: Bug 812687 part 8: Add a test for "order" on flex items with abspos siblings. r=mats draft
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 05 Apr 2017 16:47:30 -0700 - rev 556531
Push 52574 by dholbert@mozilla.com at Thu, 06 Apr 2017 00:52:14 +0000
Bug 812687 part 8: Add a test for "order" on flex items with abspos siblings. r=mats MozReview-Commit-ID: aCBQER5r2G
60670d5c11df601a5d72604536f501e114bf5ec6: Bug 812687 part 7: Minor cleanup in existing test_flexbox_order mochitests. (no review, test-only) draft
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 05 Apr 2017 16:47:29 -0700 - rev 556530
Push 52574 by dholbert@mozilla.com at Thu, 06 Apr 2017 00:52:14 +0000
Bug 812687 part 7: Minor cleanup in existing test_flexbox_order mochitests. (no review, test-only) This patch: - does s/var/let/ to upgrade to modern JS best-practices. - Wraps some lines that are too long. - Changes loops to "for (let foo of [...])" rather than foreach+function-pointer. - Changes some copypasted cleanup code to use a loop instead (which will be especially useful in a forthcoming version of this test that'll add another thing to clean up). MozReview-Commit-ID: DWK8jFbfqeB
06e10ebda68d2444bd3f31aae6b9991ee5a12978: Bug 812687 part 6: Rename & invert polarity of a flexbox frame-state-bit, for consistency with grid. r=mats draft
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 05 Apr 2017 16:47:29 -0700 - rev 556529
Push 52574 by dholbert@mozilla.com at Thu, 06 Apr 2017 00:52:14 +0000
Bug 812687 part 6: Rename & invert polarity of a flexbox frame-state-bit, for consistency with grid. r=mats This patch is just flipping some logic in a way that should produce the same outcome, so it shouldn't affect behavior. MozReview-Commit-ID: LM4HbJD3D9w
b8be2f4f9d53c28cc8039dbce584f2ad5a1cf9cd: Bug 812687 part 5: Adjust nsFlexContainerFrame to use CSSOrderAwareFrameIterator instead of reordering its child frame list. r=mats draft
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 05 Apr 2017 16:47:29 -0700 - rev 556528
Push 52574 by dholbert@mozilla.com at Thu, 06 Apr 2017 00:52:14 +0000
Bug 812687 part 5: Adjust nsFlexContainerFrame to use CSSOrderAwareFrameIterator instead of reordering its child frame list. r=mats This patch shouldn't change our layout order or paint order for flex items (though it will change our behavior for the better when an abspos child is present, as discussed in bug 1345873). This patch *will* change the tab-index behavior of flex items. Previously, the default tab order would match the visual order (i.e. it would respect "order"), because it depends on the frame tree, and we sorted the frame tree by "order". Now, the tab-index will come from the DOM order (the unmodified frame tree), as the spec requires. MozReview-Commit-ID: 9OsqQX1sEn3
fbc8fc189e8214ccabce7744417863948bc30fc6: Bug 812687 part 4: Add an optional parameter which can make CSSOrderAwareFrameIterator use the legacy "box-ordinal-group" property. r=mats draft
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 05 Apr 2017 16:47:29 -0700 - rev 556527
Push 52574 by dholbert@mozilla.com at Thu, 06 Apr 2017 00:52:14 +0000
Bug 812687 part 4: Add an optional parameter which can make CSSOrderAwareFrameIterator use the legacy "box-ordinal-group" property. r=mats This patch just adds an optional codepath that isn't taken yet, so it shouldn't affect our behavior. (The next patch in the series will make use of this new codepath.) Note: the large code-comment that this patch adds is taken mostly-verbatim from some nsFlexContainerFrame.cpp code. (The original copy will be removed by the next patch in this series, when we switch to take advantage of this new mechanism.) MozReview-Commit-ID: 9pkJ346rrXg
09316d3d3b97f4d0aaa3572fa0814efe09dbcc15: Bug 812687 part 3: Move CSSOrderAwareFrameIterator code to its own .h/.cpp file. r=mats draft
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 05 Apr 2017 16:47:29 -0700 - rev 556526
Push 52574 by dholbert@mozilla.com at Thu, 06 Apr 2017 00:52:14 +0000
Bug 812687 part 3: Move CSSOrderAwareFrameIterator code to its own .h/.cpp file. r=mats This patch just moves code, so it should not affect our behavior at all. MozReview-Commit-ID: 4yxSR5rWUV1
61d59bb1072b887277de698647e019af7c86ef0c: Bug 812687 part 2: Rename GridItemCSSOrderIterator to CSSOrderAwareFrameIterator (& similar for its Reverse form). r=mats draft
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 05 Apr 2017 16:47:29 -0700 - rev 556525
Push 52574 by dholbert@mozilla.com at Thu, 06 Apr 2017 00:52:14 +0000
Bug 812687 part 2: Rename GridItemCSSOrderIterator to CSSOrderAwareFrameIterator (& similar for its Reverse form). r=mats This patch is purely type-renames, so it should not affect our behavior at all. MozReview-Commit-ID: 51zRGFyVDtT
03d5adb15db213e2c937767a26f4ca2f8fa9edee: Bug 812687 part 1: Rename GridItemCSSOrderIteratorT to CSSOrderAwareFrameIteratorT, and drop "Grid" from its method names. r=mats draft
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 05 Apr 2017 16:47:29 -0700 - rev 556524
Push 52574 by dholbert@mozilla.com at Thu, 06 Apr 2017 00:52:14 +0000
Bug 812687 part 1: Rename GridItemCSSOrderIteratorT to CSSOrderAwareFrameIteratorT, and drop "Grid" from its method names. r=mats This patch is purely type-renames & method-renames, so it should not affect our behavior at all. MozReview-Commit-ID: 5N7zru0uPfD
ca8440c0eeb360d1eaa6b5bbad829bd1646adb35: Bug 1350844 - Typo fix in local variable name, r=woof!
Steve Fink <sfink@mozilla.com> - Tue, 04 Apr 2017 15:48:51 -0700 - rev 556523
Push 52574 by dholbert@mozilla.com at Thu, 06 Apr 2017 00:52:14 +0000
Bug 1350844 - Typo fix in local variable name, r=woof!
b20d152b6a8e54ccc29bbf749ea348fdb9279ce5: Bug 1351947 - Remove bias in skiplist tower height, r=shu
Steve Fink <sfink@mozilla.com> - Wed, 29 Mar 2017 20:07:36 -0700 - rev 556522
Push 52574 by dholbert@mozilla.com at Thu, 06 Apr 2017 00:52:14 +0000
Bug 1351947 - Remove bias in skiplist tower height, r=shu This was generating a random int, counting number of consecutive low-order bits, and returning max(that, 1), which would result in a 3/4 chance of returning 1, 1/8 of returning 2, 1/16 of returning 3, etc. But we don't want the spike in probably at height 1. So instead, just add one to the number of bits to get a plain ½^i distribution of i=1..MAX_HEIGHT.
d98072a1b4922cdb1cea422652db2a16f42de639: Bug 1345453 - Clear pending exceptions in unhandlable OOM cases in onNewScript and onNewWasmInstance in Debugger. (r=jimb)
Shu-yu Guo <shu@rfrn.org> - Wed, 05 Apr 2017 16:33:56 -0700 - rev 556521
Push 52574 by dholbert@mozilla.com at Thu, 06 Apr 2017 00:52:14 +0000
Bug 1345453 - Clear pending exceptions in unhandlable OOM cases in onNewScript and onNewWasmInstance in Debugger. (r=jimb)
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip