cee66b2d4bea37619fb9d18335b90db19d9ac9d2: Bug 1348747 - Part 2: Support jmp rel 8 in WindowsDllDetourPatcher. r?aklotz draft
Cervantes Yu <cyu@mozilla.com> - Tue, 21 Mar 2017 15:09:20 +0800 - rev 502102
Push 50175 by cyu@mozilla.com at Tue, 21 Mar 2017 08:13:44 +0000
Bug 1348747 - Part 2: Support jmp rel 8 in WindowsDllDetourPatcher. r?aklotz MozReview-Commit-ID: 5hPBmxtBCnu
30017ab822a142b74e75fc608146e5bd2c26c15b: Bug 1348747 - Part 1: Fix WindowsDllDetourPatcher that generates extra 0xff byte when generating a x64 jmp instruction. r?aklotz draft
Cervantes Yu <cyu@mozilla.com> - Tue, 21 Mar 2017 15:08:35 +0800 - rev 502101
Push 50175 by cyu@mozilla.com at Tue, 21 Mar 2017 08:13:44 +0000
Bug 1348747 - Part 1: Fix WindowsDllDetourPatcher that generates extra 0xff byte when generating a x64 jmp instruction. r?aklotz MozReview-Commit-ID: 8TfcwXh6GUN
b26f92714831e03345acc10479b283980227b546: Bug 1322570 Part 8 - Run debug code only if the style source is a gecko rule node. draft
Ting-Yu Lin <tlin@mozilla.com> - Mon, 20 Mar 2017 17:05:16 +0800 - rev 502100
Push 50174 by bmo:tlin@mozilla.com at Tue, 21 Mar 2017 08:04:34 +0000
Bug 1322570 Part 8 - Run debug code only if the style source is a gecko rule node. Per bug 1322570 comment 27, the debug code is only useful in Gecko-backed style system. To prevent the assertion in nsStyleContext::GetParent() when running stylo, run them only in gecko. MozReview-Commit-ID: DOcJ3T7vS1J
10c3083dc98c0dd214b20c398512f3bcccd572c7: Bug 1322570 Part 7 - Use GetParentAllowServo() in nsMathMLChar. draft
Ting-Yu Lin <tlin@mozilla.com> - Mon, 20 Mar 2017 14:14:30 +0800 - rev 502099
Push 50174 by bmo:tlin@mozilla.com at Tue, 21 Mar 2017 08:04:34 +0000
Bug 1322570 Part 7 - Use GetParentAllowServo() in nsMathMLChar. The nsMathMLChar has SetStyleContext() that can change nsStyleContext. It's not obvious how to get parent style context other than calling GetParent(). So white-list this case for now. Fixed tests like layout/reftests/bugs/347348-1.xhtml. MozReview-Commit-ID: JZU1IzcMxs8
0ebea99b27192a8a465296d711cee24bc7c5a30f: Bug 1322570 Part 6 - Use GetParentAllowServo() in RestyleManager. draft
Ting-Yu Lin <tlin@mozilla.com> - Mon, 20 Mar 2017 14:14:01 +0800 - rev 502098
Push 50174 by bmo:tlin@mozilla.com at Tue, 21 Mar 2017 08:04:34 +0000
Bug 1322570 Part 6 - Use GetParentAllowServo() in RestyleManager. Fixed tests like layout/reftests/bidi/670226-1.html. MozReview-Commit-ID: DuEXNZhFC7M
a2a824ed61ff41b15799765d075d4807f325d386: Bug 1322570 Part 5 - Use GetParentAllowServo() related to first letter frame. draft
Ting-Yu Lin <tlin@mozilla.com> - Mon, 20 Mar 2017 14:13:32 +0800 - rev 502097
Push 50174 by bmo:tlin@mozilla.com at Tue, 21 Mar 2017 08:04:34 +0000
Bug 1322570 Part 5 - Use GetParentAllowServo() related to first letter frame. ::first-letter is not support by stylo yet. (bug 1324618) MozReview-Commit-ID: KwQk2jhn53c
e33e724708efaa94a396178ad787d95b6391346c: Bug 1322570 Part 4 - Use GetParentAllowServo() in KeyframeEffectReadOnly::UpdateProperties. draft
Ting-Yu Lin <tlin@mozilla.com> - Mon, 20 Mar 2017 14:13:01 +0800 - rev 502096
Push 50174 by bmo:tlin@mozilla.com at Tue, 21 Mar 2017 08:04:34 +0000
Bug 1322570 Part 4 - Use GetParentAllowServo() in KeyframeEffectReadOnly::UpdateProperties. Per bug 1322570 Comment 7, we could drop the GetParentAllowServo() when we invoke UpdateProperties() from a SquentialTask, so allow it for now. MozReview-Commit-ID: 52NauGaz4Zv
39a4ba36e838b7cf0cd4ba495ed5dd19d6441da2: Bug 1322570 Part 3 - Get StyleContext from parent frame in nsFlexContainerFrame::Init(). draft
Ting-Yu Lin <tlin@mozilla.com> - Mon, 20 Mar 2017 14:12:28 +0800 - rev 502095
Push 50174 by bmo:tlin@mozilla.com at Tue, 21 Mar 2017 08:04:34 +0000
Bug 1322570 Part 3 - Get StyleContext from parent frame in nsFlexContainerFrame::Init(). In stylo, nsStyleContext::GetParent() is not valid. MozReview-Commit-ID: 5FbgUwobG3U
a980f6bf3fb03d77d040022aed5f275a1ab2c88b: Bug 1322570 Part 2 - Rewrite nsStylePosition methods to stop using nsStyleContext::GetParent(). draft
Ting-Yu Lin <tlin@mozilla.com> - Mon, 20 Mar 2017 14:12:08 +0800 - rev 502094
Push 50174 by bmo:tlin@mozilla.com at Tue, 21 Mar 2017 08:04:34 +0000
Bug 1322570 Part 2 - Rewrite nsStylePosition methods to stop using nsStyleContext::GetParent(). To reduce the usage of nsStyleContext::GetParent() to minimum, we rewrite those nsStylePosition methods to take nsIFrame* instead of nsStyleContext* so that those GetParent() in them becomes nsIFrame::GetParent(). In general, StyleContext's parent does not always equal to the parent frame's StyleContext. Fortunately, per bug 1322570 comment 21, when this is not hold up, getting the StyleContext() from the parent frame is more likely to be correct than the parent StyleContext(). So we don't loose correctness after rewriting this. However, we still cannot drop ComputedJustifyItems(nsStyleContext*) because it still in used by nsRuleNode and nsComputedDOMStyle. MozReview-Commit-ID: 6kAAWSFojd5
1e12fe2be9ed412471f0304df7738383ff9efd17: Bug 1322570 Part 1 - Add MOZ_ASSERT in nsStyleContext::GetParent() to disallow usage by stylo. draft
Ting-Yu Lin <tlin@mozilla.com> - Mon, 20 Mar 2017 14:11:06 +0800 - rev 502093
Push 50174 by bmo:tlin@mozilla.com at Tue, 21 Mar 2017 08:04:34 +0000
Bug 1322570 Part 1 - Add MOZ_ASSERT in nsStyleContext::GetParent() to disallow usage by stylo. Also, add GetParentAllowServo() to whitelist the usage in servo-backed style system in subsequent parts so that we could revisit them later. MozReview-Commit-ID: JthU18Ftx02
06af616aa28ba52c5cbb5850b0f03b4c1f16b4df: Bug 1349130 - Fixed wrong reference files in reftest-stylo.list draft
Shing Lyu <slyu@mozilla.com> - Tue, 21 Mar 2017 16:01:50 +0800 - rev 502092
Push 50173 by bmo:slyu@mozilla.com at Tue, 21 Mar 2017 08:03:36 +0000
Bug 1349130 - Fixed wrong reference files in reftest-stylo.list MozReview-Commit-ID: LRcPOPzVWFK
3616ce479bff5ff2231a4f309451fd8108d24e0d: Bug 1322570 Part 8 - Run debug code only if the style source is a gecko rule node. draft
Ting-Yu Lin <tlin@mozilla.com> - Mon, 20 Mar 2017 17:05:16 +0800 - rev 502091
Push 50172 by bmo:tlin@mozilla.com at Tue, 21 Mar 2017 08:03:02 +0000
Bug 1322570 Part 8 - Run debug code only if the style source is a gecko rule node. Per bug 1322570 comment 27, the debug code is only useful in Gecko-backed style system. To prevent the assertion in nsStyleContext::GetParent() when running stylo, run them only in gecko. MozReview-Commit-ID: DOcJ3T7vS1J
e0954278d5913631c763c03349a9509d837d140d: Bug 1349124 - Replace ServoComputedStyleValues with ServoComputedValuesWithParent. draft
Boris Chiou <boris.chiou@gmail.com> - Tue, 21 Mar 2017 15:41:23 +0800 - rev 502090
Push 50171 by bmo:boris.chiou@gmail.com at Tue, 21 Mar 2017 08:00:56 +0000
Bug 1349124 - Replace ServoComputedStyleValues with ServoComputedValuesWithParent. MozReview-Commit-ID: 5POa8DRjmc8
a030eeb68b374d7d111faa4caaf37997cc28e40f: Bug 1322570 Part 8 - Run debugging code only if the style source is gecko rule node. draft
Ting-Yu Lin <tlin@mozilla.com> - Mon, 20 Mar 2017 17:05:16 +0800 - rev 502089
Push 50170 by bmo:tlin@mozilla.com at Tue, 21 Mar 2017 07:54:38 +0000
Bug 1322570 Part 8 - Run debugging code only if the style source is gecko rule node. Per bug 1322570 comment 27, the debugging code is only useful in Gecko-backed style system. To prevent the assertion in nsStyleContext::GetParent() when running stylo, run the debug checking code only in gecko. MozReview-Commit-ID: DOcJ3T7vS1J
b0f0f97370c5d1ec86b385cd5332cd9b3dfdc51f: Bug 1322570 Part 7 - Use GetParentAllowServo() in nsMathMLChar. draft
Ting-Yu Lin <tlin@mozilla.com> - Mon, 20 Mar 2017 14:14:30 +0800 - rev 502088
Push 50170 by bmo:tlin@mozilla.com at Tue, 21 Mar 2017 07:54:38 +0000
Bug 1322570 Part 7 - Use GetParentAllowServo() in nsMathMLChar. The nsMathMLChar has SetStyleContext() that can change nsStyleContext. It's not obvious how to get parent style context other than calling GetParent(). So white-list this case for now. Fixed tests like layout/reftests/bugs/347348-1.xhtml. MozReview-Commit-ID: JZU1IzcMxs8
ea3a4ba3641fa991da2ea348c7846b61f3362b93: Bug 1322570 Part 6 - Use GetParentAllowServo() in RestyleManager. draft
Ting-Yu Lin <tlin@mozilla.com> - Mon, 20 Mar 2017 14:14:01 +0800 - rev 502087
Push 50170 by bmo:tlin@mozilla.com at Tue, 21 Mar 2017 07:54:38 +0000
Bug 1322570 Part 6 - Use GetParentAllowServo() in RestyleManager. Fixed tests like layout/reftests/bidi/670226-1.html. MozReview-Commit-ID: DuEXNZhFC7M
6c061c25102d01a2bb2681040b9382b1ec194fcd: Bug 1322570 Part 5 - Use GetParentAllowServo() related to first letter frame. draft
Ting-Yu Lin <tlin@mozilla.com> - Mon, 20 Mar 2017 14:13:32 +0800 - rev 502086
Push 50170 by bmo:tlin@mozilla.com at Tue, 21 Mar 2017 07:54:38 +0000
Bug 1322570 Part 5 - Use GetParentAllowServo() related to first letter frame. ::first-letter is not support by stylo yet. (bug 1324618) MozReview-Commit-ID: KwQk2jhn53c
07933b19cd6616aaace8ac32b7adf23bdce54578: Bug 1322570 Part 4 - Use GetParentAllowServo() in KeyframeEffectReadOnly::UpdateProperties. draft
Ting-Yu Lin <tlin@mozilla.com> - Mon, 20 Mar 2017 14:13:01 +0800 - rev 502085
Push 50170 by bmo:tlin@mozilla.com at Tue, 21 Mar 2017 07:54:38 +0000
Bug 1322570 Part 4 - Use GetParentAllowServo() in KeyframeEffectReadOnly::UpdateProperties. Per bug 1322570 Comment 7, we could drop the GetParentAllowServo() when we invoke UpdateProperties() from a SquentialTask, so allow it for now. MozReview-Commit-ID: 52NauGaz4Zv
8b8e9ffdaaff73e5a1a3808cd2554bf0e40f8dfb: Bug 1322570 Part 3 - Get StyleContext from parent frame in nsFlexContainerFrame::Init(). draft
Ting-Yu Lin <tlin@mozilla.com> - Mon, 20 Mar 2017 14:12:28 +0800 - rev 502084
Push 50170 by bmo:tlin@mozilla.com at Tue, 21 Mar 2017 07:54:38 +0000
Bug 1322570 Part 3 - Get StyleContext from parent frame in nsFlexContainerFrame::Init(). In stylo, nsStyleContext::GetParent() is not valid. MozReview-Commit-ID: 5FbgUwobG3U
4bfc112a2bb895524f8157bfdd37c3713f45e9b9: Bug 1322570 Part 2 - Rewrite nsStylePosition methods to stop using nsStyleContext::GetParent(). draft
Ting-Yu Lin <tlin@mozilla.com> - Mon, 20 Mar 2017 14:12:08 +0800 - rev 502083
Push 50170 by bmo:tlin@mozilla.com at Tue, 21 Mar 2017 07:54:38 +0000
Bug 1322570 Part 2 - Rewrite nsStylePosition methods to stop using nsStyleContext::GetParent(). To reduce the usage of nsStyleContext::GetParent() to minimum, we rewrite those nsStylePosition methods to take nsIFrame* instead of nsStyleContext* so that those GetParent() in them becomes nsIFrame::GetParent(). In general, StyleContext's parent does not always equal to the parent frame's StyleContext. Fortunately, per bug 1322570 comment 21, when this is not hold up, getting the StyleContext() from the parent frame is more likely to be correct than the parent StyleContext(). So we don't loose correctness after rewriting this. However, we still cannot drop ComputedJustifyItems(nsStyleContext*) because it still in used by nsRuleNode and nsComputedDOMStyle. MozReview-Commit-ID: 6kAAWSFojd5
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip