ce895dbddcb6711061392628807e590bd7b302ec: Bug 1390748 - Remove ChannelMediaDecoder::CloneImpl() and remove subclasses of ChannelMediaDecoder. r?jwwang draft
Chris Pearce <cpearce@mozilla.com> - Tue, 15 Aug 2017 17:52:17 +1200 - rev 647261
Push 74340 by bmo:cpearce@mozilla.com at Wed, 16 Aug 2017 05:34:55 +0000
Bug 1390748 - Remove ChannelMediaDecoder::CloneImpl() and remove subclasses of ChannelMediaDecoder. r?jwwang MozReview-Commit-ID: 6nlBArYgwEJ
529ad935c284f3319d76ed273cb0a3783799a3b2: Bug 1390748 - Create DecoderTraits::IsSupportedType(const MediaContainerType&). r?jwwang draft
Chris Pearce <cpearce@mozilla.com> - Tue, 15 Aug 2017 17:38:16 +1200 - rev 647260
Push 74340 by bmo:cpearce@mozilla.com at Wed, 16 Aug 2017 05:34:55 +0000
Bug 1390748 - Create DecoderTraits::IsSupportedType(const MediaContainerType&). r?jwwang Most ChannelMediaDecoder::CloneImpl() functions just check to see whether their "is enabled" pref is still true, and then clone their true type. If we had a function to check whether the decoder for an arbitrary type was still enabled, we'd not need the "is enabled" checks in the CloneImpl() implementations. We'd then have removed the last custom behaviour in the ChannelMediaDecoder subclasses. MozReview-Commit-ID: D7kW6kb6ztW
a8bf3839046c98cc4922778459016a6787f708ac: Bug 1390748 - Pre-declare MediaDecoder in HTMLMediaElement. r?jwwang draft
Chris Pearce <cpearce@mozilla.com> - Tue, 15 Aug 2017 17:09:06 +1200 - rev 647259
Push 74340 by bmo:cpearce@mozilla.com at Wed, 16 Aug 2017 05:34:55 +0000
Bug 1390748 - Pre-declare MediaDecoder in HTMLMediaElement. r?jwwang I noticed that touching MediaDecoder rebuilds a lot of seemingly unrelated code. This is because HTMLMediaElement includes MediaDecoder.h, and HTMLMediaElement is included in a number of places. Having HTMLMediaElement.h predeclare rather than include fixes it. MozReview-Commit-ID: I0vrPgqvvge
375d16f1760d1b704414663e4b764a10eb9f7c9b: Bug 1390748 - Create default MediaDecoder::GetMozDebugReaderData() implementation. r?jwwang draft
Chris Pearce <cpearce@mozilla.com> - Tue, 15 Aug 2017 17:07:13 +1200 - rev 647258
Push 74340 by bmo:cpearce@mozilla.com at Wed, 16 Aug 2017 05:34:55 +0000
Bug 1390748 - Create default MediaDecoder::GetMozDebugReaderData() implementation. r?jwwang We have three implementations, in the MP4, WebM and MediaSource decoders. The WebM and MP4 are the same. Ogg and other decoders don't have an implementation, but if we create a default implementation in MediaDecoder, they'll get it for free. MediaSourceDecoder needs a custom override still. MozReview-Commit-ID: AXxn2Xhn0Jn
7c8157437cd63619dee8184e434dbe5bb0419610: Bug 1390748 - Remove unnececssary 'public:' in MediaDecoder.h. r?jwwang draft
Chris Pearce <cpearce@mozilla.com> - Tue, 15 Aug 2017 16:38:05 +1200 - rev 647257
Push 74340 by bmo:cpearce@mozilla.com at Wed, 16 Aug 2017 05:34:55 +0000
Bug 1390748 - Remove unnececssary 'public:' in MediaDecoder.h. r?jwwang There's an existing 'public:' further up. MozReview-Commit-ID: 7CMmpVkZ7oz
9eafd90755e1ecd5a75126dc047669f58251feb2: Bug 1390748 - Make MediaDecoder::CreateStateMachine() non-virtual. r?jwwang draft
Chris Pearce <cpearce@mozilla.com> - Tue, 15 Aug 2017 16:37:00 +1200 - rev 647256
Push 74340 by bmo:cpearce@mozilla.com at Wed, 16 Aug 2017 05:34:55 +0000
Bug 1390748 - Make MediaDecoder::CreateStateMachine() non-virtual. r?jwwang MediaDecoder::CreateStateMachine is only virtual so that Ogg can attach the reader's metadata/seekable produces to its chaining event. The MediaSourceDecoder also overrides CreateStateMachine(), but it's not called by anything external, so its implementation doesn't actually need to be virtual. MozReview-Commit-ID: 2x6bpK6Fdzd
6b3dfdac14adefb2d3325749b8b1cea0425cfbd1: Bug 1390748 - Remove OggDecoder::CreateStateMachine(). r?jwwang draft
Chris Pearce <cpearce@mozilla.com> - Tue, 15 Aug 2017 16:21:35 +1200 - rev 647255
Push 74340 by bmo:cpearce@mozilla.com at Wed, 16 Aug 2017 05:34:55 +0000
Bug 1390748 - Remove OggDecoder::CreateStateMachine(). r?jwwang MozReview-Commit-ID: 2JgZ2Ppv6as
7b1625969353a21f1b463c93a05a9b56f25e3c48: Bug 1390406 - Remove unnecessary includes in dom/media/mediasource. r?jya draft
Chris Pearce <cpearce@mozilla.com> - Tue, 15 Aug 2017 16:13:00 +1200 - rev 647254
Push 74340 by bmo:cpearce@mozilla.com at Wed, 16 Aug 2017 05:34:55 +0000
Bug 1390406 - Remove unnecessary includes in dom/media/mediasource. r?jya MozReview-Commit-ID: 1aTncGfBicu
c1f7e90e511ffe092b76bcc815ab4293836e6b72: Bug 1389980 - Ensure we only interact with WMF on MTA threads. r?mattwoodrow,r?aklotz draft
Chris Pearce <cpearce@mozilla.com> - Tue, 15 Aug 2017 10:00:14 +1200 - rev 647253
Push 74340 by bmo:cpearce@mozilla.com at Wed, 16 Aug 2017 05:34:55 +0000
Bug 1389980 - Ensure we only interact with WMF on MTA threads. r?mattwoodrow,r?aklotz The IMFTransform interface used by MFTDecoder is documented to require to run on an MTA threads: https://msdn.microsoft.com/en-us/library/windows/desktop/ee892371(v=vs.85).aspx#components We're currently using IMFTransform objects on the main thread, which is STA. So delegate calls to the IMFTransform to the MTA thread when necessary, to ensure it always runs on an MTA thread. The existing uses of IMFTransform objects in the decode thread pool threads will be fine, as those threads are already MTA. We also defer initialization of WMF to the MTA thread, so that we're always interacting with WMF on an MTA thread. MozReview-Commit-ID: Dm8XpdvJLkS
5bd5cbfa39466b6d72da87072af9d551257c8684: Bug 1389980 - Remove MP4Decoder::IsVideoAccelerated() as it is unused. r?mattwoodrow draft
Chris Pearce <cpearce@mozilla.com> - Tue, 15 Aug 2017 10:15:43 +1200 - rev 647252
Push 74340 by bmo:cpearce@mozilla.com at Wed, 16 Aug 2017 05:34:55 +0000
Bug 1389980 - Remove MP4Decoder::IsVideoAccelerated() as it is unused. r?mattwoodrow MozReview-Commit-ID: Eg0ggufsqDt
209195fe6c68c4267c5406ec6154976bcd7dff28: Bug 1389435 - Use GCC 6 to build the Firefox we ship on Linux. r?froydnj draft
Mike Hommey <mh+mozilla@glandium.org> - Wed, 16 Aug 2017 13:35:14 +0900 - rev 647251
Push 74339 by bmo:mh+mozilla@glandium.org at Wed, 16 Aug 2017 04:52:45 +0000
Bug 1389435 - Use GCC 6 to build the Firefox we ship on Linux. r?froydnj
3b63e623cf6be3cbbdbfe50ad2edaf366de68f0f: Bug 1389435 - Explicitly use GCC 4.9 for hazard builds. r?sfink draft
Mike Hommey <mh+mozilla@glandium.org> - Wed, 16 Aug 2017 13:49:37 +0900 - rev 647250
Push 74339 by bmo:mh+mozilla@glandium.org at Wed, 16 Aug 2017 04:52:45 +0000
Bug 1389435 - Explicitly use GCC 4.9 for hazard builds. r?sfink The GCC plugin used for hazard builds was built for GCC 4.9. Until a new plugin is built by a toolchain job for the "default" version of GCC we build Firefox with, the builds using the plugin need to stay with the version the plugin was built for.
c3d0b7e8cc68b0d8597dc60e875c2f6d25c93326: Bug 1389435 - Forbid toolchain dependencies on aliases. r?dustin draft
Mike Hommey <mh+mozilla@glandium.org> - Tue, 15 Aug 2017 09:39:48 +0900 - rev 647249
Push 74339 by bmo:mh+mozilla@glandium.org at Wed, 16 Aug 2017 04:52:45 +0000
Bug 1389435 - Forbid toolchain dependencies on aliases. r?dustin This extends bug 1386920 in a more general way on toolchain jobs.
d4dcedfa27db1122ff97f145e3fd8f67e5c5f0d2: Bug 1363116 - Remove the report{ExtraWarning,StrictMode}ErrorNumberVA wrappers in EitherParser. r?arai draft
Mike Hommey <mh+mozilla@glandium.org> - Wed, 16 Aug 2017 13:24:15 +0900 - rev 647248
Push 74339 by bmo:mh+mozilla@glandium.org at Wed, 16 Aug 2017 04:52:45 +0000
Bug 1363116 - Remove the report{ExtraWarning,StrictMode}ErrorNumberVA wrappers in EitherParser. r?arai Copy construction for va_list is implementation dependent, and most likely doesn't actually work properly on some platforms. While the wrapping in EitherParser might currently work on tier-1 platforms, it also triggers a warning on newer GCC versions that could very well indicate that they might not work entirely properly. Mixing va_list, copy construction and templates variadics surely sounds like something very fragile. While I understand that the pending changes from bug 1351107 might be relying on the current state of the code, I'd rather that bug be reworked so as to please newer versions of GCC than having to figure out what parts of that bug are still relevant after bug 1351105 and blocking bug 1389435 further.
94f10db6dbbc8f1de7c456f0e755892b0bde7b64: Bug 1390704 - Skip 694165-1.xhtml crashtest on stylo debug. r?bholley draft
Mike Hommey <mh+mozilla@glandium.org> - Wed, 16 Aug 2017 12:54:04 +0900 - rev 647247
Push 74339 by bmo:mh+mozilla@glandium.org at Wed, 16 Aug 2017 04:52:45 +0000
Bug 1390704 - Skip 694165-1.xhtml crashtest on stylo debug. r?bholley
faba4924e39029fd1c6837a2651d98e469587981: Bug 1387973 - Modify transition test cases for {text,box}-shadow without color. r?birtles draft
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Wed, 16 Aug 2017 13:48:22 +0900 - rev 647246
Push 74338 by hikezoe@mozilla.com at Wed, 16 Aug 2017 04:49:02 +0000
Bug 1387973 - Modify transition test cases for {text,box}-shadow without color. r?birtles As for Gecko we can't interpolate between value with color and value without color yet (bug 726550) so that transition does not happen for the cases. As for Servo we can interpolate them but the results are wrong (bug 1390697). MozReview-Commit-ID: 9T0ELBUP0pL
2da8926e91a3f504d6167451c91e57c975883101: Bug 1387973 - Implement distance for shadow list. r?boris draft
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Wed, 16 Aug 2017 11:33:06 +0900 - rev 647245
Push 74338 by hikezoe@mozilla.com at Wed, 16 Aug 2017 04:49:02 +0000
Bug 1387973 - Implement distance for shadow list. r?boris MozReview-Commit-ID: D0jd6Lm4fek
2159099346dbe8dff47752732e6d22a9be671d22: Bug 1384062 - Reset SystemResourceMonitor._process after the process has shutdown. r?ahal draft
Mike Hommey <mh+mozilla@glandium.org> - Wed, 16 Aug 2017 13:16:16 +0900 - rev 647244
Push 74337 by bmo:mh+mozilla@glandium.org at Wed, 16 Aug 2017 04:43:38 +0000
Bug 1384062 - Reset SystemResourceMonitor._process after the process has shutdown. r?ahal When SystemResourceMonitor.stop is called twice, the second time fails on the `assert self._running` at the beginning of the function. One could argue that the API is not meant to be called twice, but it also could be argued that this puts the burden of tracking whether stop has been called on the caller, while SystemResourceMonitor already tracks that state. Now, since during the first stop the _process has been join()ed, and the underlying process died, and since the first thing stop does is check whether self._process has a value, we might as well reset self._process after it was join()ed.
51df3a7008451b244b876252209838ec528899be: Bug 1387697 - Make UITour locate page actions on the urlbar first then on the page action panel, r?Gijs draft
Fischer.json <fischer.json@gmail.com> - Mon, 14 Aug 2017 18:45:25 +0800 - rev 647243
Push 74336 by bmo:fliu@mozilla.com at Wed, 16 Aug 2017 04:43:09 +0000
Bug 1387697 - Make UITour locate page actions on the urlbar first then on the page action panel, r?Gijs MozReview-Commit-ID: 8TocyThHLzZ
411052c36a53374bf342ccb41009ae1b5eded07e: Bug 1341126 implement open for browser/page/sidebar actions, r?kmag draft
Shane Caraveo <scaraveo@mozilla.com> - Wed, 08 Mar 2017 23:36:25 -0800 - rev 647242
Push 74335 by mixedpuppy@gmail.com at Wed, 16 Aug 2017 04:39:34 +0000
Bug 1341126 implement open for browser/page/sidebar actions, r?kmag MozReview-Commit-ID: DYBUPFzimt3
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip