ce77d98823a4c7a2937f59f0b2ced23bff7eb339: Backed out changeset b15136f926ca (bug 1272778) for build bustage
Wes Kocher <wkocher@mozilla.com> - Fri, 13 May 2016 16:05:12 -0700 - rev 367066
Push
18132 by kevin.m.wern@gmail.com at Sat, 14 May 2016 04:10:50 +0000
Backed out changeset b15136f926ca (
bug 1272778) for build bustage
b15136f926caef2db1d493dd63cc43ad8dde2336: Bug 1272778. Use IntRects for clip rects instead of Rects. r=mstange
Jeff Muizelaar <jmuizelaar@mozilla.com> - Fri, 13 May 2016 16:15:17 -0400 - rev 367065
Push
18132 by kevin.m.wern@gmail.com at Sat, 14 May 2016 04:10:50 +0000
Bug 1272778. Use IntRects for clip rects instead of Rects. r=mstange
Previously, we took an IntRect converted to Rect and then later wanted
ints in the backend. This avoids all of that.
b1092342e654d9dda9e2a5ba845faddde2ddd887: Bug 1272840 - Resurrect the URL to block-and-line.html
draft
Ting-Yu Lin <tlin@mozilla.com> - Sat, 14 May 2016 11:44:38 +0800 - rev 367064
Push
18131 by bmo:tlin@mozilla.com at Sat, 14 May 2016 03:50:53 +0000
Bug 1272840 - Resurrect the URL to block-and-line.html
DONTBUILD (NPOTB)
MozReview-Commit-ID: Hqk3kSUftRM
d9647b84c4ecb065346c98690848cf46e8b3d0b9: Bug 1272831 - Add AutoRestore::Value() to retrieve the saved value.
draft
Ting-Yu Lin <tlin@mozilla.com> - Sat, 14 May 2016 09:47:14 +0800 - rev 367063
Push
18130 by bmo:tlin@mozilla.com at Sat, 14 May 2016 03:09:18 +0000
Bug 1272831 - Add AutoRestore::Value() to retrieve the saved value.
MozReview-Commit-ID: eZCWmTpvXi
2afd8fa9bb5df5577e5566468bb423b76c63cc77: Merge inbound to central, a=merge
Wes Kocher <wkocher@mozilla.com> - Fri, 13 May 2016 16:43:37 -0700 - rev 367062
Push
18129 by bmo:tlin@mozilla.com at Sat, 14 May 2016 03:07:57 +0000
Merge inbound to central, a=merge
cc2b7fe9d3a9760d164e42d2b841e06018bb0fff: Bug 1181055 - video play button does not work if the VIDEO element has onclick handler calling play(). r?gijs
draft
Jared Wein <jwein@mozilla.com> - Fri, 13 May 2016 21:42:33 -0400 - rev 367061
Push
18128 by jwein@mozilla.com at Sat, 14 May 2016 01:42:31 +0000
Bug 1181055 - video play button does not work if the VIDEO element has onclick handler calling play(). r?gijs
MozReview-Commit-ID: c6V9LMIdK0
d363eebe3514354fff249d1ba01221323774fbd1: Bug 1181055 - video play button does not work if the VIDEO element has onclick handler calling play(). r?gijs
draft
Jared Wein <jwein@mozilla.com> - Fri, 13 May 2016 21:40:26 -0400 - rev 367060
Push
18127 by jwein@mozilla.com at Sat, 14 May 2016 01:40:22 +0000
Bug 1181055 - video play button does not work if the VIDEO element has onclick handler calling play(). r?gijs
MozReview-Commit-ID: c6V9LMIdK0
4fd7975262ac3af23d0a5f6b921cbe7a0863760e: Bug 1272817 - Return early if file is empty + regression test. r=sebastian
draft
Michael Comella <michael.l.comella@gmail.com> - Fri, 13 May 2016 18:14:25 -0700 - rev 367059
Push
18126 by michael.l.comella@gmail.com at Sat, 14 May 2016 01:14:43 +0000
Bug 1272817 - Return early if file is empty + regression test. r=sebastian
MozReview-Commit-ID: FPdDr2t1wEy
cad27c227ca7819c8a2de6b1e557dc5cb2b83fec: Bug 1269398: Add visitType, visitId, and fromVisitId fields to history visit query results. r?mak
draft
Kris Maglione <maglione.k@gmail.com> - Fri, 13 May 2016 13:47:24 -0700 - rev 367058
Push
18125 by maglione.k@gmail.com at Sat, 14 May 2016 00:39:40 +0000
Bug 1269398: Add visitType, visitId, and fromVisitId fields to history visit query results. r?mak
MozReview-Commit-ID: BCsztVsCH98
e8978a5ce9a3444d4dc9401eae1a9af0156f3eac: amend-subprocess
draft
Kris Maglione <maglione.k@gmail.com> - Tue, 10 May 2016 12:36:05 -0700 - rev 367057
Push
18125 by maglione.k@gmail.com at Sat, 14 May 2016 00:39:40 +0000
amend-subprocess
MozReview-Commit-ID: KFfQJ6SnLnw
683e2fa9c3dd6191bbf4162064d7b73bf90cdca1: Bug 687787 - Support focusin/focusout events r=smaug
draft
Kevin Wern <kevin.m.wern@gmail.com> - Sun, 20 Mar 2016 04:39:32 -0700 - rev 367056
Push
18124 by kevin.m.wern@gmail.com at Fri, 13 May 2016 23:14:31 +0000
Bug 687787 - Support focusin/focusout events r=smaug
Add support for focusin and focusout in DOM. The event sequence is either:
(for focuses)
- focusin
- focus
or
(for refocuses)
- focusout
- focusin
- blur
- focus
(for unfocuses)
- focusout
- blur
Additionally, add the necessary attributes to ensure only one focus occurs
as the result of a series of events. Also ensure that focusout doesn't
recurse if focus() is called in an event callback.
Include mochitest.
MozReview-Commit-ID: LGPPEC3WH55
083c404c7d48de134ada0e90c31529fd821a0c17: Bug 1272768 - Teach `mach resource-usage` to load arbitrary URLs; r?chmanchester
draft
Gregory Szorc <gps@mozilla.com> - Thu, 12 May 2016 17:01:36 -0700 - rev 367055
Push
18123 by bmo:gps@mozilla.com at Fri, 13 May 2016 23:08:46 +0000
Bug 1272768 - Teach `mach resource-usage` to load arbitrary URLs; r?chmanchester
Firefox automation now uploads resource usage JSON files as
job artifacts (see
bug 1272202). Now that the build system
writes the same data format and `mach resource-usage` can
read this data format, let's teach `mach resource-usage`
to load arbitrary URLs. This allows people to view system
resource usage for arbitrary jobs in automation.
Currently, you have to look at Treeherder to find the URL to
the build-resources.json artifact. Perhaps in the future
we can make finding the URL easier. Or we could integrate
source resource viewing into Treeherder itself (this is
probably preferred).
This commit continues the tradition of `mach resource-usage`
being a hacked up mess. Instead of loading the URL in
the browser, we download the URL from Python then serve it
from the HTTP server running as part of `mach resource-usage`.
This is somewhat horrible. But it was easiest to implement.
It also conveniently bypasses any cross origin request
restrictions the browser may impose. So it is useful.
MozReview-Commit-ID: IR1Cfs7SrRN
a49fd98c7fbd8642517ad6d0b79a407777fb5a13: Bug 1272768 - Use mozsystemmonitor for writing JSON; r?chmanchester
draft
Gregory Szorc <gps@mozilla.com> - Fri, 13 May 2016 13:31:43 -0700 - rev 367054
Push
18123 by bmo:gps@mozilla.com at Fri, 13 May 2016 23:08:46 +0000
Bug 1272768 - Use mozsystemmonitor for writing JSON; r?chmanchester
We currently have our own system monitor serialization in
building.py. It predates as_dict() from mozsystemmonitor. Let's
use the "upstream" data format so we only have a single format
to consume.
This change required updating the in-tree resource viewer to
be compatible with the new data format.
This commit stops short of getting rid of the existing
data massaging code in building.py. Another day perhaps.
MozReview-Commit-ID: 1OJrSiyJjMX
d035a4e34c7bbc6b504e578050e9abe9c4727589: Bug 1211723 follow up - Explicitly delete implicitly deleted copy constructors for VS2013; r=Waldo
Nick Fitzgerald <fitzgen@gmail.com> - Fri, 13 May 2016 15:18:59 -0700 - rev 367053
Push
18123 by bmo:gps@mozilla.com at Fri, 13 May 2016 23:08:46 +0000
Bug 1211723 follow up - Explicitly delete implicitly deleted copy constructors for VS2013; r=Waldo
2a218727e6e69350525bf4725f014d170c377821: Backed out changeset 2ac62de7365d (bug 1271002) for crash in GTest: [@ mozilla::image::RasterImage::UpdateImageContainer]. r=backout
Sebastian Hengst <archaeopteryx@coole-files.de> - Sat, 14 May 2016 00:08:18 +0200 - rev 367052
Push
18123 by bmo:gps@mozilla.com at Fri, 13 May 2016 23:08:46 +0000
Backed out changeset 2ac62de7365d (
bug 1271002) for crash in GTest: [@ mozilla::image::RasterImage::UpdateImageContainer]. r=backout
0569f59c7ce73929e405e1ea6c14fc343e0aee25: Bug 1272782 - Use mozsystemmonitor 0.3 in mozharness; r=catlee
Gregory Szorc <gps@mozilla.com> - Fri, 13 May 2016 14:14:10 -0700 - rev 367051
Push
18123 by bmo:gps@mozilla.com at Fri, 13 May 2016 23:08:46 +0000
Bug 1272782 - Use mozsystemmonitor 0.3 in mozharness; r=catlee
MozReview-Commit-ID: 6XxWnWGkiZn
ca9ed07960f52ebc677f3cd4e07a2d57322cd9df: Bug 1272782 - Bump mozsystemmonitor version to 0.3; r=ahal
Gregory Szorc <gps@mozilla.com> - Fri, 13 May 2016 14:11:40 -0700 - rev 367050
Push
18123 by bmo:gps@mozilla.com at Fri, 13 May 2016 23:08:46 +0000
Bug 1272782 - Bump mozsystemmonitor version to 0.3; r=ahal
So we can release the bug fixes we just made.
MozReview-Commit-ID: HgfPQkkwd6r
f7f3a7bff29c65efe0274815741531c166c8f21d: Bug 1272782 - Don't wait forever for child process to exit; r=ahal
Gregory Szorc <gps@mozilla.com> - Fri, 13 May 2016 14:10:39 -0700 - rev 367049
Push
18123 by bmo:gps@mozilla.com at Fri, 13 May 2016 23:08:46 +0000
Bug 1272782 - Don't wait forever for child process to exit; r=ahal
I believe this is the source of hangs/timeouts in automation.
join() waits forever. We add code to wait at most N seconds before
force terminating the process. The timeout is a bit high. But it is
better than infinite.
MozReview-Commit-ID: KwyO4RZ9OqL
c67cb230d266a1fbd93a4561daa6fbfe240d891b: Bug 1272782 - Wait longer and stop after "done" message; r=ahal
Gregory Szorc <gps@mozilla.com> - Fri, 13 May 2016 14:05:17 -0700 - rev 367048
Push
18123 by bmo:gps@mozilla.com at Fri, 13 May 2016 23:08:46 +0000
Bug 1272782 - Wait longer and stop after "done" message; r=ahal
Before, we kept waiting for data in the pipe after receiving the
"done" message. This didn't really make much sense because the
"done" message should be the final thing sent over the pipe!
e9113fd6cdb8 (
bug 1239939) recently dropped the poll interval
of the pipe from 1.0 to 0.1s. This appears to have introduced
an intermittent failure in a test. The race condition was
between the child process sending data and the parent process
timing out (after only 0.1s) waiting for that data. Increasing
the timeout makes the failure reproduce less often. Although
technically the race condition is still present! I'm not
inclined to fix it at this time, however.
The rationale for dropping the pipe timeout was that it was
causing lag when terminating short-lived processes. Now that
we abort the pipe reading/polling loop as soon as the "done"
message is received, we no longer poll the pipe after receiving
"done" and no longer have to worry about its timeout impacting
shutdown time.
MozReview-Commit-ID: EeENQ95RAs1
bd21c16b035a5f4d79ac2cd15d35260e528e910e: Bug 1272782 - Send tuple properly; r=ahal
Gregory Szorc <gps@mozilla.com> - Fri, 13 May 2016 13:57:59 -0700 - rev 367047
Push
18123 by bmo:gps@mozilla.com at Fri, 13 May 2016 23:08:46 +0000
Bug 1272782 - Send tuple properly; r=ahal
Found this bug when auditing the code for issues. We are attempting
to send a tuple but were forgetting the trailing comma on a single
element tuple.
Fortunately, this doesn't appear to impact anything because
the receiving end of the pipe doesn't care what data it receives.
MozReview-Commit-ID: E34fBqxgUSq