ce31b0e389710627baab06b9a82ff6cc9f342faa: Bug 1395616 - Add permission string for default search engine. r?mixedpuppy draft
Michael Kaply <mozilla@kaply.com> - Thu, 31 Aug 2017 10:52:07 -0500 - rev 656719
Push 77300 by mozilla@kaply.com at Thu, 31 Aug 2017 15:52:36 +0000
Bug 1395616 - Add permission string for default search engine. r?mixedpuppy MozReview-Commit-ID: FjXdnT9ZqFl
3292c3659887c4b0aad18621b84d296d61965810: Bug 1389341 - start generating jsdoc for AddonManager API r?kmag draft
Robert Helmer <rhelmer@mozilla.com> - Thu, 24 Aug 2017 19:05:59 -0700 - rev 656718
Push 77299 by bmo:rhelmer@mozilla.com at Thu, 31 Aug 2017 15:52:21 +0000
Bug 1389341 - start generating jsdoc for AddonManager API r?kmag MozReview-Commit-ID: LZf6GfImgMA
4d4d9807674c9f8509e4a7b52f73383e4e009205: Bug 1389341 - add basic support for sphinx-js to mach doc r?gps draft
Robert Helmer <rhelmer@mozilla.com> - Thu, 24 Aug 2017 19:09:49 -0700 - rev 656717
Push 77299 by bmo:rhelmer@mozilla.com at Thu, 31 Aug 2017 15:52:21 +0000
Bug 1389341 - add basic support for sphinx-js to mach doc r?gps MozReview-Commit-ID: L2Xa2onqpzh
b79ce60d3b86a30da5eb142b2e15eb9f19808399: Bug 1390461 - Update langpack-webext to use WEBEXT_LANGPACKS mk flag. r?pike draft
Zibi Braniecki <zbraniecki@mozilla.com> - Sun, 27 Aug 2017 17:27:19 -0700 - rev 656716
Push 77298 by bmo:gandalf@aviary.pl at Thu, 31 Aug 2017 15:43:56 +0000
Bug 1390461 - Update langpack-webext to use WEBEXT_LANGPACKS mk flag. r?pike MozReview-Commit-ID: HdfCwaDvjTa
72adb4951192f1e0da7bbc7c6eb84f58085e6dfd: Bug 1395586: Other build fixes (to be squashed too). r?heycam draft
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 31 Aug 2017 17:12:37 +0200 - rev 656715
Push 77297 by bmo:emilio@crisal.io at Thu, 31 Aug 2017 15:40:29 +0000
Bug 1395586: Other build fixes (to be squashed too). r?heycam MozReview-Commit-ID: FnHq8JhI7wD
ad36b36e59f4965afac6b550eb926c4dfad401ea: Bug 1395586: layout/style build fixes (to be squashed). r?heycam draft
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 31 Aug 2017 17:12:13 +0200 - rev 656714
Push 77297 by bmo:emilio@crisal.io at Thu, 31 Aug 2017 15:40:29 +0000
Bug 1395586: layout/style build fixes (to be squashed). r?heycam MozReview-Commit-ID: CqIegsDyGSe
a9c756c478f934a187dfcb6504f105242d006c4d: Bug 1395586: Add accessors and privatize trivial nsStyleDisplay members. r?heycam draft
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 31 Aug 2017 17:09:32 +0200 - rev 656713
Push 77297 by bmo:emilio@crisal.io at Thu, 31 Aug 2017 15:40:29 +0000
Bug 1395586: Add accessors and privatize trivial nsStyleDisplay members. r?heycam While at it, also reorder some of them to save some space. The idea is to autogenerate code for these, and to pack them using bitfields. It still needs some more code, but I think I'll try to get something next week. This is preliminary anyway, but I wanted to land it since they're huge changes. MozReview-Commit-ID: JQPiaqSHCuy
ee5eb935f73f7729706c6781451710e6a86935e3: Bug 1381831 - Improve about:telemetry start page r?chutten draft
flyingrub <flyinggrub@gmail.com> - Mon, 21 Aug 2017 13:29:07 +0200 - rev 656712
Push 77296 by bmo:flyinggrub@gmail.com at Thu, 31 Aug 2017 15:33:41 +0000
Bug 1381831 - Improve about:telemetry start page r?chutten Make about:telemetry start page a useful entry point into Telemetry MozReview-Commit-ID: JIgU3acT1fS
4d573b57d0b45bd9b36e88950b7f567436b1c204: Bug 1381831 - Improve about:telemetry start page r?chutten draft
flyingrub <flyinggrub@gmail.com> - Mon, 21 Aug 2017 13:29:07 +0200 - rev 656711
Push 77295 by bmo:flyinggrub@gmail.com at Thu, 31 Aug 2017 15:25:44 +0000
Bug 1381831 - Improve about:telemetry start page r?chutten Make about:telemetry start page a useful entry point into Telemetry MozReview-Commit-ID: JIgU3acT1fS
9e1b860f71d3438a954603bfb29e790c24b7824c: Bug 1394461 - Update illustration and copy for about:rights. r?dao, shorlander draft
Erica Wright <ewright@mozilla.com> - Thu, 31 Aug 2017 11:20:11 -0400 - rev 656710
Push 77294 by bmo:ewright@mozilla.com at Thu, 31 Aug 2017 15:20:27 +0000
Bug 1394461 - Update illustration and copy for about:rights. r?dao, shorlander MozReview-Commit-ID: 3kxO8DYG6R8
f425105ee892b9cc087a06d75d23aa7d4aad2b02: Bug 1391019 - Replace the py(3) task with py-compat lint task, r?gps draft
Andrew Halberstadt <ahalberstadt@mozilla.com> - Thu, 31 Aug 2017 10:12:30 -0400 - rev 656709
Push 77293 by ahalberstadt@mozilla.com at Thu, 31 Aug 2017 15:17:15 +0000
Bug 1391019 - Replace the py(3) task with py-compat lint task, r?gps MozReview-Commit-ID: ABtq9dnPo9T
7f81e382656208f8f7ae20c632f6fd0ed4ff1e52: Bug 1391019 - Add py2 and py3 compatability linters, r?gps draft
Andrew Halberstadt <ahalberstadt@mozilla.com> - Thu, 31 Aug 2017 10:12:02 -0400 - rev 656708
Push 77293 by ahalberstadt@mozilla.com at Thu, 31 Aug 2017 15:17:15 +0000
Bug 1391019 - Add py2 and py3 compatability linters, r?gps check_compat.py was adapted from gps' check-py3-compat.py in mercurial: https://www.mercurial-scm.org/repo/hg/file/tip/contrib/check-py3-compat.py The py3 linter simply runs ast.parse(f) for each file being linted. Any syntax errors are formatted as mozlint results and dumped to stdout as json. I looked into also importing the file (using 3.5+'s importlib.util.spec_from_file_location), but there were too many problems: 1. Lots of false positives (e.g module not found) 2. Some files seemed to run indefinitely on import I decided to punt on importing for now, we can always investigate in a follow-up. The py2 linter runs ast.parse(f), and also checks that the file has: from __future__ import absolute_import, print_function Initially every python file in the tree is excluded from the py2 check, though at least this makes it easy to find+fix, and new files in un-excluded directories will automatically be linted. MozReview-Commit-ID: ABtq9dnPo9T
da4eeed9ab8a9bee0677bdb8ad5117835173f459: Bug 1394935: Add a special case for marking something as dirty from invalidation code. r?bholley draft
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 31 Aug 2017 09:42:26 +0200 - rev 656707
Push 77292 by bmo:emilio@crisal.io at Thu, 31 Aug 2017 15:16:37 +0000
Bug 1394935: Add a special case for marking something as dirty from invalidation code. r?bholley Not sure about the name, or whether making it a static or not (a static seemed slightly clearer, but nbd, feel free to bikeshed about it). MozReview-Commit-ID: FHGmcoprN2Q
0b58b85bdbccde1d06751ab2bcda2c58a7c7bfed: Bug 1394935: Assert that if we find a common ancestor using the dirty bits, it is the actual common flattened tree ancestor. r?bholley draft
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 31 Aug 2017 09:42:25 +0200 - rev 656706
Push 77292 by bmo:emilio@crisal.io at Thu, 31 Aug 2017 15:16:37 +0000
Bug 1394935: Assert that if we find a common ancestor using the dirty bits, it is the actual common flattened tree ancestor. r?bholley MozReview-Commit-ID: GRJ539QXS9e
ef9733365ec62a05cbf6cb9bd30c0633d4303382: Bug 1394935: Introduce nsContentUtils::CommonFlattenedTreeAncestorForStyle. r?bholley draft
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 31 Aug 2017 09:42:24 +0200 - rev 656705
Push 77292 by bmo:emilio@crisal.io at Thu, 31 Aug 2017 15:16:37 +0000
Bug 1394935: Introduce nsContentUtils::CommonFlattenedTreeAncestorForStyle. r?bholley MozReview-Commit-ID: GThZUOIe30o
4de0a48dd68891345cd6175b0248c9fd00ee3f89: Bug 1394935: Fix a little typo in NoteDirtyElement. r?bholley draft
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 31 Aug 2017 09:42:23 +0200 - rev 656704
Push 77292 by bmo:emilio@crisal.io at Thu, 31 Aug 2017 15:16:37 +0000
Bug 1394935: Fix a little typo in NoteDirtyElement. r?bholley MozReview-Commit-ID: LMQlNcJjz80
a7514501d84e9078a2ac84ba13b839e5d9183c78: Bug 1394935: Assert that we don't call into NoteDirtyElement with extra bits on the restyle root's parent chain. r?bholley draft
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 31 Aug 2017 09:42:22 +0200 - rev 656703
Push 77292 by bmo:emilio@crisal.io at Thu, 31 Aug 2017 15:16:37 +0000
Bug 1394935: Assert that we don't call into NoteDirtyElement with extra bits on the restyle root's parent chain. r?bholley MozReview-Commit-ID: Kt5aZSRBvlE
ce953033da836cdae737902e858b747a45d5ebfe: Bug 1394935: Assert that the content we're marking dirty is under the restyle root. r?bholley draft
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 31 Aug 2017 09:42:21 +0200 - rev 656702
Push 77292 by bmo:emilio@crisal.io at Thu, 31 Aug 2017 15:16:37 +0000
Bug 1394935: Assert that the content we're marking dirty is under the restyle root. r?bholley This would also have catched the bug earlier. MozReview-Commit-ID: 8uNXPnpXk6m
2994bd6ccc09e79d37a545d5752f30a91485449b: Bug 1394935: Add a (commented out for now) assertion about clobbering dirty bits. r?bholley draft
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 31 Aug 2017 09:42:20 +0200 - rev 656701
Push 77292 by bmo:emilio@crisal.io at Thu, 31 Aug 2017 15:16:37 +0000
Bug 1394935: Add a (commented out for now) assertion about clobbering dirty bits. r?bholley Will get this fixed tomorrow, I have patches but forgot to push to try. MozReview-Commit-ID: 3Dcb1MTo8g5
c5a812d133cfd7720667ea3da9d24f97b405a441: Bug 1394935: Assert that the new root is always higher up in the tree than the old root. r?bholley draft
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 31 Aug 2017 09:42:19 +0200 - rev 656700
Push 77292 by bmo:emilio@crisal.io at Thu, 31 Aug 2017 15:16:37 +0000
Bug 1394935: Assert that the new root is always higher up in the tree than the old root. r?bholley The bug here is that we're clobbering a restyle root with another one which is down in the tree, when calling NoteDirtyElement on the document element with the flags already propagated. This assertion would've catched it earlier, and make it more obvious. MozReview-Commit-ID: 3mucQvr7A1x
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip