cbfe33f44fa03de434bee3674aeb01079e5f887c: Bug 1350729 - Implement fake refcount logging for nsFakeStringBuffer. r=dbaron draft
Andrew McCreight <continuation@gmail.com> - Fri, 14 Jul 2017 10:20:23 -0700 - rev 609916
Push 68739 by bmo:continuation@gmail.com at Mon, 17 Jul 2017 19:21:58 +0000
Bug 1350729 - Implement fake refcount logging for nsFakeStringBuffer. r=dbaron Running with XPCOM_MEM_LOG_CLASSES=nsStringBuffer triggers an assertion in refcount logging for nsFakeStringBuffers. These are given an initial refcount of 1, without calling NS_LOG_ADDREF. Then, AddRef() is called on these objects in StaticAtom::StaticAtom(), and we tell the refcount logging system about the fake buffer, and that it has a refcount of 0, triggering the assertion. The first part of the fix is to call NS_LOG_ADDREF for this initial refcount, in StaticAtom(). This first fix causes refcount logging to start reporting that the fake string buffers leak, when XPCOM_MEM_LOG_CLASSES is not set. This is because refcount logging is now getting told about these objects being AddRefed at 1, which it takes to mean that an object is created. To work around this issue, I add an array gFakeBuffers that contains every fake string buffer we create, and tell the refcount logging system that these objects are all being destroyed, when the atom table is being shut down. This could result in some bogosity if the fake buffers are "leaked" but hopefully this is still an improvement over the current state. MozReview-Commit-ID: 5AxoBYAlYRU
3fc8bf8bbe41b27cbdf46e85aafd0b9aebdd342b: Bug 1381347 - Use deprecated quitApplication command in Marionette client; r?whimboo draft
Andreas Tolfsen <ato@sny.no> - Mon, 17 Jul 2017 20:19:30 +0100 - rev 609915
Push 68738 by bmo:ato@sny.no at Mon, 17 Jul 2017 19:21:27 +0000
Bug 1381347 - Use deprecated quitApplication command in Marionette client; r?whimboo Firefox update tests will break if we do not use the `quitApplication' command, since the `quit' command is not available in Firefox 53. MozReview-Commit-ID: KJoCPBh9NKh
49800fc099986b50b21b1ab2bd5442ea834390f8: Bug 1381579 - Remove async from functions in ExtensionPreferencesManager that don't need to be async, r?aswan draft
Bob Silverberg <bsilverberg@mozilla.com> - Mon, 17 Jul 2017 15:09:37 -0400 - rev 609914
Push 68737 by bmo:bob.silverberg@gmail.com at Mon, 17 Jul 2017 19:09:57 +0000
Bug 1381579 - Remove async from functions in ExtensionPreferencesManager that don't need to be async, r?aswan Also adds test_ext_browserSettings.js back into xpcshell-common.ini. It was somehow removed from the ini files in https://hg.mozilla.org/mozilla-central/rev/9704283b0e3a and never added back. MozReview-Commit-ID: 7Nv1jj7KMe2
063d933b39fa945fef9352c5856687382a7e99f2: Bug 1367904 - Part 17: stylo: Clean up GetContext, call it UpdateWithElementState; r?bholley draft
Manish Goregaokar <manishearth@gmail.com> - Mon, 17 Jul 2017 11:42:24 -0700 - rev 609913
Push 68736 by bmo:manishearth@gmail.com at Mon, 17 Jul 2017 18:43:09 +0000
Bug 1367904 - Part 17: stylo: Clean up GetContext, call it UpdateWithElementState; r?bholley MozReview-Commit-ID: I23w5hFatk8
0103b6e6e01cd058fe66e0488949599dc60c7075: Bug 1367904 - Part 16: stylo: Stop using mStyleIfVisited in Servo; r?bholley draft
Manish Goregaokar <manishearth@gmail.com> - Mon, 17 Jul 2017 11:42:20 -0700 - rev 609912
Push 68736 by bmo:manishearth@gmail.com at Mon, 17 Jul 2017 18:43:09 +0000
Bug 1367904 - Part 16: stylo: Stop using mStyleIfVisited in Servo; r?bholley MozReview-Commit-ID: JxoMr6fz7lh
72d470bebc06533899c25852d029806416e1cc56: Bug 1367904 - Part 15: stylo: Override ArenaRefPtr for ServoStyleContexts; r?bholley draft
Manish Goregaokar <manishearth@gmail.com> - Mon, 17 Jul 2017 11:42:16 -0700 - rev 609911
Push 68736 by bmo:manishearth@gmail.com at Mon, 17 Jul 2017 18:43:09 +0000
Bug 1367904 - Part 15: stylo: Override ArenaRefPtr for ServoStyleContexts; r?bholley MozReview-Commit-ID: BV4ek093JCR
03dc8439d7cd88e9de9d9f338b976549f946a35f: Bug 1367904 - Part 14: stylo: Remove FFI calls for fetching style structs from ServoComputedValues; r?bholley draft
Manish Goregaokar <manishearth@gmail.com> - Mon, 17 Jul 2017 11:42:12 -0700 - rev 609910
Push 68736 by bmo:manishearth@gmail.com at Mon, 17 Jul 2017 18:43:09 +0000
Bug 1367904 - Part 14: stylo: Remove FFI calls for fetching style structs from ServoComputedValues; r?bholley MozReview-Commit-ID: 2HrVZl9HZu1
b6f905b155454ee0a765e789d78719cdc52d7c68: Bug 1367904 - Part 13: stylo: Flatten ServoComputedValues into ServoStyleContext; r?bholley draft
Manish Goregaokar <manishearth@gmail.com> - Mon, 17 Jul 2017 11:42:08 -0700 - rev 609909
Push 68736 by bmo:manishearth@gmail.com at Mon, 17 Jul 2017 18:43:09 +0000
Bug 1367904 - Part 13: stylo: Flatten ServoComputedValues into ServoStyleContext; r?bholley This patch also removes the duplication of style contexts during the restyle, because otherwise pointer equality of ServoComputedValues stops holding (and we assert on that in a few places) MozReview-Commit-ID: 7Evc1p8ZfM2
81435d4746acf74413007b0e88cfce6683c835f5: Bug 1367904 - Part 11: stylo: Use ServoStyleContext in ServoStyleSet/ServoRestyleManager; r?bholley draft
Manish Goregaokar <manishearth@gmail.com> - Mon, 17 Jul 2017 11:42:04 -0700 - rev 609908
Push 68736 by bmo:manishearth@gmail.com at Mon, 17 Jul 2017 18:43:09 +0000
Bug 1367904 - Part 11: stylo: Use ServoStyleContext in ServoStyleSet/ServoRestyleManager; r?bholley MozReview-Commit-ID: JJOBixTSCZq
deaef6b918e51ea95701352582c04299bbe14bc2: Bug 1367904 - Part 10: stylo: Switch Gecko over to ServoStyleContext; r?bholley draft
Manish Goregaokar <manishearth@gmail.com> - Mon, 17 Jul 2017 11:42:00 -0700 - rev 609907
Push 68736 by bmo:manishearth@gmail.com at Mon, 17 Jul 2017 18:43:09 +0000
Bug 1367904 - Part 10: stylo: Switch Gecko over to ServoStyleContext; r?bholley MozReview-Commit-ID: EmopKVjEzlz
40760bd6d79895fcd1e3a120227cd6b3e3a52baa: Bug 1367904 - Part 9: stylo: Make Servo Arc types use ptr to T instead of ptr to ArcInner<T>; r?bholley draft
Manish Goregaokar <manishearth@gmail.com> - Mon, 17 Jul 2017 11:41:56 -0700 - rev 609906
Push 68736 by bmo:manishearth@gmail.com at Mon, 17 Jul 2017 18:43:09 +0000
Bug 1367904 - Part 9: stylo: Make Servo Arc types use ptr to T instead of ptr to ArcInner<T>; r?bholley MozReview-Commit-ID: CQs2Sxd59am
2fdbe83e065d8c939c98938737a2c23acd79a846: Bug 1367904 - Part 7: stylo: Use ComputedValuesInner instead of ComputedValues when we don't need it; r?bholley draft
Manish Goregaokar <manishearth@gmail.com> - Mon, 17 Jul 2017 11:41:52 -0700 - rev 609905
Push 68736 by bmo:manishearth@gmail.com at Mon, 17 Jul 2017 18:43:09 +0000
Bug 1367904 - Part 7: stylo: Use ComputedValuesInner instead of ComputedValues when we don't need it; r?bholley MozReview-Commit-ID: CMtiwigDpip
1dd387c7fac9c473ac0566e34e72c35fb104991d: Bug 1367904 - Part 6: stylo: Introduce ComputedValuesInner; r?bholley draft
Manish Goregaokar <manishearth@gmail.com> - Mon, 17 Jul 2017 11:41:48 -0700 - rev 609904
Push 68736 by bmo:manishearth@gmail.com at Mon, 17 Jul 2017 18:43:09 +0000
Bug 1367904 - Part 6: stylo: Introduce ComputedValuesInner; r?bholley MozReview-Commit-ID: 7BU0Pzhuul3
02955940d16052406fc0cefaa2898c99bc280579: Bug 1367904 - Part 5: stylo: Make GetBaseComputedValuesForElement return a style context; r?bholley draft
Manish Goregaokar <manishearth@gmail.com> - Mon, 17 Jul 2017 11:41:44 -0700 - rev 609903
Push 68736 by bmo:manishearth@gmail.com at Mon, 17 Jul 2017 18:43:09 +0000
Bug 1367904 - Part 5: stylo: Make GetBaseComputedValuesForElement return a style context; r?bholley MozReview-Commit-ID: K5WpWc26xNZ
797ec88c581e1004633ec15900a5f8e80fcafc77: Bug 1367904 - Part 4: stylo: Replace real ComputedValues with bindgenned ComputedValues2; r?bholley draft
Manish Goregaokar <manishearth@gmail.com> - Mon, 17 Jul 2017 11:41:41 -0700 - rev 609902
Push 68736 by bmo:manishearth@gmail.com at Mon, 17 Jul 2017 18:43:09 +0000
Bug 1367904 - Part 4: stylo: Replace real ComputedValues with bindgenned ComputedValues2; r?bholley MozReview-Commit-ID: GRkycXueUVr
fb73b64242e53609bd4e83b632be72de28aae4fb: Bug 1367904 - Part 3: stylo: Use RawOffsetArc in ComputedValues; r?bholley draft
Manish Goregaokar <manishearth@gmail.com> - Mon, 17 Jul 2017 11:41:37 -0700 - rev 609901
Push 68736 by bmo:manishearth@gmail.com at Mon, 17 Jul 2017 18:43:09 +0000
Bug 1367904 - Part 3: stylo: Use RawOffsetArc in ComputedValues; r?bholley MozReview-Commit-ID: 1zexSgkcQv0
51f7e615f196cdbcda4baddddd6a59dd84117436: Bug 1367904 - Part 2: stylo: Add RawOffsetArc<T>; r?bholley draft
Manish Goregaokar <manishearth@gmail.com> - Mon, 17 Jul 2017 11:41:34 -0700 - rev 609900
Push 68736 by bmo:manishearth@gmail.com at Mon, 17 Jul 2017 18:43:09 +0000
Bug 1367904 - Part 2: stylo: Add RawOffsetArc<T>; r?bholley MozReview-Commit-ID: 6LcLxiRP9Y6
0ed80932cdd5e822f56d40e58ec2ea2b7923d259: Bug 1367904 - Part 1: stylo: Create C++-side ServoComputedValues; r?bholley draft
Manish Goregaokar <manishearth@gmail.com> - Mon, 17 Jul 2017 11:41:30 -0700 - rev 609899
Push 68736 by bmo:manishearth@gmail.com at Mon, 17 Jul 2017 18:43:09 +0000
Bug 1367904 - Part 1: stylo: Create C++-side ServoComputedValues; r?bholley MozReview-Commit-ID: 1k7KFShSHAY
fc259f6f72c9ebc1d50edfefe5b9722fa8ce6cdd: Bug 1377299: Add packet dump hooks r+drno draft
Byron Campen [:bwc] <docfaraday@gmail.com> - Thu, 29 Jun 2017 19:14:06 -0500 - rev 609898
Push 68735 by bcampen@mozilla.com at Mon, 17 Jul 2017 18:40:11 +0000
Bug 1377299: Add packet dump hooks r+drno MozReview-Commit-ID: Jr7n49OOduG
67c86ec7135f293de3ca742674ddcdb60987a4f5: Bug 1341275 - review: Add comment explaining FaviconView.getWidth non-zero values. r=trivial draft
Michael Comella <michael.l.comella@gmail.com> - Mon, 17 Jul 2017 11:37:45 -0700 - rev 609897
Push 68734 by michael.l.comella@gmail.com at Mon, 17 Jul 2017 18:39:58 +0000
Bug 1341275 - review: Add comment explaining FaviconView.getWidth non-zero values. r=trivial MozReview-Commit-ID: 33RXaB4gCkK
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip