cbe591df0fc84b8ea8024f018da458a55008bd6b: Bug 1460509 - part 48: Make HTMLEditRules::CheckForEmptyBlock() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 16 May 2018 00:10:11 +0900 - rev 798766
Push 110840 by masayuki@d-toybox.com at Wed, 23 May 2018 13:41:58 +0000
Bug 1460509 - part 48: Make HTMLEditRules::CheckForEmptyBlock() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato Additionally, this patch renames it to MaybeDeleteTopMostEmptyAncestor() for making its name explain what it does. MozReview-Commit-ID: 1i7zeq9In2T
fbc062e17ec7663cf7ec23aa7c610af427b4d955: Bug 1460509 - part 47: Make HTMLEditRules::ExpandSelectionForDeletion() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 15 May 2018 19:15:56 +0900 - rev 798765
Push 110840 by masayuki@d-toybox.com at Wed, 23 May 2018 13:41:58 +0000
Bug 1460509 - part 47: Make HTMLEditRules::ExpandSelectionForDeletion() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato MozReview-Commit-ID: BdumFS7Rluv
5f0c37e2f604b38cd2700fc881f00e982dfad088: Bug 1460509 - part 46: Make HTMLEditRules::NormalizeSelection() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 15 May 2018 18:59:27 +0900 - rev 798764
Push 110840 by masayuki@d-toybox.com at Wed, 23 May 2018 13:41:58 +0000
Bug 1460509 - part 46: Make HTMLEditRules::NormalizeSelection() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato MozReview-Commit-ID: 5yf1ZJ5sQ1t
721d4dddaa2a5a4af8898e08777f75b8b4dc2e44: Bug 1460509 - part 45: Test if HTMLEditRules::PromoteRange() won't get range in Selection r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 15 May 2018 18:39:27 +0900 - rev 798763
Push 110840 by masayuki@d-toybox.com at Wed, 23 May 2018 13:41:58 +0000
Bug 1460509 - part 45: Test if HTMLEditRules::PromoteRange() won't get range in Selection r?m_kato PromoteRange() related methods do not change Selection nor the DOM tree. Therefore, they must be safe. However, only PromoteRange() takes an nsRange instance and modifies it. If it's in Selection, that causes selectionchange event. Therefore, we should check if given range is in Selection with MOZ_ASSERT(). MozReview-Commit-ID: AXkmHFB4P08
137b2f47174b3c469933f7bef433bad57fe73c60: Bug 1460509 - part 44: Make HTMLEditRules::GetNodesForOperation() and related methods return NS_ERROR_EDITOR_DESTROYED if they cause destroying the editor r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 15 May 2018 18:07:34 +0900 - rev 798762
Push 110840 by masayuki@d-toybox.com at Wed, 23 May 2018 13:41:58 +0000
Bug 1460509 - part 44: Make HTMLEditRules::GetNodesForOperation() and related methods return NS_ERROR_EDITOR_DESTROYED if they cause destroying the editor r?m_kato Despite of the name of GetNodesForOperation() and related methods, it changes the DOM tree if their aTouchContent is TouchContent::yes (by default). Therefore, they should return NS_ERROR_EDITOR_DESTROYED if they cause destroying the editor and all callers should check the result. Therefore, this patch mark them as MOZ_MUST_USE. Additionally, because of importance of aTouchContent, this patch makes the arguments not optional. This change must make other developers being careful to use them. (Although TouchContent does not feel dangerous. We should rename it to make its risk clearer.) On the other hand, this patch removes aTouchContent from GetParagraphFormatNodes() since it's always called with TouchContent::no. Therefore, this method is always safe. Although I tried to document those methods, but I have not understood them completely yet. Perhaps, we should redesign them in another bug both to learn them and making them faster and simpler. MozReview-Commit-ID: 4vknJGUdwEe
29a58365db705ddab2c83c30c9b14b6e771f2377: Bug 1460509 - part 43: Make HTMLEditRules::BustUpInlinesAtRangeEndpoints() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 15 May 2018 17:21:08 +0900 - rev 798761
Push 110840 by masayuki@d-toybox.com at Wed, 23 May 2018 13:41:58 +0000
Bug 1460509 - part 43: Make HTMLEditRules::BustUpInlinesAtRangeEndpoints() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato MozReview-Commit-ID: CSYCey8ugA8
da8dc60eeb184fe4d0abcefafddf748ac525b6b1: Bug 1460509 - part 42: Make HTMLEditRules::BustUpInlinesAtBRs() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 15 May 2018 17:04:28 +0900 - rev 798760
Push 110840 by masayuki@d-toybox.com at Wed, 23 May 2018 13:41:58 +0000
Bug 1460509 - part 42: Make HTMLEditRules::BustUpInlinesAtBRs() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato MozReview-Commit-ID: 5KGPE8mPqge
188287c29177ed4e25ea5a5cd02348ff85941172: Bug 1460509 - part 41: Make HTMLEditRules::ReturnInHeader() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 15 May 2018 16:36:53 +0900 - rev 798759
Push 110840 by masayuki@d-toybox.com at Wed, 23 May 2018 13:41:58 +0000
Bug 1460509 - part 41: Make HTMLEditRules::ReturnInHeader() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato MozReview-Commit-ID: r03QSPXsZ2
b9ab6125007ace745d804062c150d8a001567960: Bug 1460509 - part 40: Make HTMLEditRules::ReturnInParagraph() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 15 May 2018 16:22:59 +0900 - rev 798758
Push 110840 by masayuki@d-toybox.com at Wed, 23 May 2018 13:41:58 +0000
Bug 1460509 - part 40: Make HTMLEditRules::ReturnInParagraph() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato MozReview-Commit-ID: cnR8uXTfno
86b9a8f9acfab8ef16f9e6c6463c3a73bc030b4d: Bug 1460509 - part 39: Make HTMLEditRules::SplitParagraph() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 15 May 2018 16:15:35 +0900 - rev 798757
Push 110840 by masayuki@d-toybox.com at Wed, 23 May 2018 13:41:58 +0000
Bug 1460509 - part 39: Make HTMLEditRules::SplitParagraph() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato MozReview-Commit-ID: 38hfUl88xXI
273206c93252971dc29658db96312487f90dde8d: Bug 1460509 - part 38: Make HTMLEditRules::ReturnInListItem() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 15 May 2018 15:32:11 +0900 - rev 798756
Push 110840 by masayuki@d-toybox.com at Wed, 23 May 2018 13:41:58 +0000
Bug 1460509 - part 38: Make HTMLEditRules::ReturnInListItem() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato MozReview-Commit-ID: Jl0oiBCuYPb
2593bf4ba86d0d8e489019c223cf509e8c9bde41: Bug 1460509 - part 37: Make HTMLEditRules::MakeBlockquote() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 15 May 2018 15:09:13 +0900 - rev 798755
Push 110840 by masayuki@d-toybox.com at Wed, 23 May 2018 13:41:58 +0000
Bug 1460509 - part 37: Make HTMLEditRules::MakeBlockquote() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato MozReview-Commit-ID: 3pUx52d6EYd
b6d111b1f3d4eae47fb96f3b00bbd3f91af8413c: Bug 1460509 - part 36: Make HTMLEditRules::RemoveBlockStyle() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 15 May 2018 00:43:07 +0900 - rev 798754
Push 110840 by masayuki@d-toybox.com at Wed, 23 May 2018 13:41:58 +0000
Bug 1460509 - part 36: Make HTMLEditRules::RemoveBlockStyle() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato MozReview-Commit-ID: KDfxeD9k0UN
f94116dd9e963c971e6b9bc9027188fa4646f6d6: Bug 1460509 - part 35: Make HTMLEditRules::ApplyBlockStyle() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 15 May 2018 00:08:46 +0900 - rev 798753
Push 110840 by masayuki@d-toybox.com at Wed, 23 May 2018 13:41:58 +0000
Bug 1460509 - part 35: Make HTMLEditRules::ApplyBlockStyle() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato MozReview-Commit-ID: 1ddHNx7lF9P
cf57752d514063481155c116e01d856a4cd1b63f: Bug 1460509 - part 34: Make HTMLEditRules::MaybeSplitAncestorsForInsertWithTransaction() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 14 May 2018 23:55:53 +0900 - rev 798752
Push 110840 by masayuki@d-toybox.com at Wed, 23 May 2018 13:41:58 +0000
Bug 1460509 - part 34: Make HTMLEditRules::MaybeSplitAncestorsForInsertWithTransaction() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato MozReview-Commit-ID: 7MqtKPNAOZ1
ab036ff607ee93a005f7d9e0ca8421a7a76c1dc3: Bug 1460509 - part 33: Make HTMLEditRules::JoinNearestEditableNodesWithTransaction() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 14 May 2018 23:51:23 +0900 - rev 798751
Push 110840 by masayuki@d-toybox.com at Wed, 23 May 2018 13:41:58 +0000
Bug 1460509 - part 33: Make HTMLEditRules::JoinNearestEditableNodesWithTransaction() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato Unfortunately, we need to make it take out argument for returning new first child point of right node. If we can create JoinNodesResult which have nsresult and EditorDOMPoint, we can avoid that, but EditorBase::JoinNodes() does not want it. So, even if we create such class, only 2 callers of the methods are its users... MozReview-Commit-ID: 1zwVZ0FriwN
4e5baa212eb0faf7e14d1e5bbd7bdb556065cebb: Bug 1460509 - part 32: Mark HTMLEditRules::CacheInlineStyles() as MOZ_MUST_USE since it may cause destroying the editor and returns NS_ERROR_EDITOR_DESTROYED in such case r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 14 May 2018 23:24:40 +0900 - rev 798750
Push 110840 by masayuki@d-toybox.com at Wed, 23 May 2018 13:41:58 +0000
Bug 1460509 - part 32: Mark HTMLEditRules::CacheInlineStyles() as MOZ_MUST_USE since it may cause destroying the editor and returns NS_ERROR_EDITOR_DESTROYED in such case r?m_kato MozReview-Commit-ID: FJHxJ1j02l1
2883b6d37cc69778dd9ba3190fd28bebb1048766: Bug 1460509 - part 31: Make HTMLEditRules::GetInlineStyles() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 14 May 2018 23:20:28 +0900 - rev 798749
Push 110840 by masayuki@d-toybox.com at Wed, 23 May 2018 13:41:58 +0000
Bug 1460509 - part 31: Make HTMLEditRules::GetInlineStyles() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato MozReview-Commit-ID: 3Nk1gBttuwM
05a4ba8cb0b3ef67deb6de66bdc764f31e42b993: Bug 1460509 - part 30: Make HTMLEditRules::ReapplyCachedStyles() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 14 May 2018 23:14:50 +0900 - rev 798748
Push 110840 by masayuki@d-toybox.com at Wed, 23 May 2018 13:41:58 +0000
Bug 1460509 - part 30: Make HTMLEditRules::ReapplyCachedStyles() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato MozReview-Commit-ID: HSv2els7Lys
1ee689274b0e610f38723bbc86798f5fa86100c2: Bug 1460509 - part 29: Make HTMLEditRules::AdjustSpecialBreaks() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 14 May 2018 22:56:06 +0900 - rev 798747
Push 110840 by masayuki@d-toybox.com at Wed, 23 May 2018 13:41:58 +0000
Bug 1460509 - part 29: Make HTMLEditRules::AdjustSpecialBreaks() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato And this patch renames it to InsertBRElementToEmptyListItemsAndTableCellsInChangedRange(). MozReview-Commit-ID: 1DGhcI93YAk
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip