c76aa324c7c2b57ce42a8b26c48778782b41be76: Bug 1328053 - Correct thumb position when shift-click scrolling r=mats a=jcristau
Kearwood Gilbert <kgilbert@mozilla.com> - Wed, 25 Jan 2017 14:45:23 -0800 - rev 482598
Push 45112 by mchiang@mozilla.com at Mon, 13 Feb 2017 05:49:16 +0000
Bug 1328053 - Correct thumb position when shift-click scrolling r=mats a=jcristau During the refactoring of nsSliderFrame::SetCurrentPositionInternal in Bug 957445, one of the two calls to nsSliderFrame::UpdateAttribute was missed. This resulted in the position, identified with nsGkAtoms::curpos, not being updated immediately after the call to nsSliderFrame::SetCurrentThumbPosition MozReview-Commit-ID: 6gedouG4OFX
46497fa848f7b678b5d1bbfd28ed8d1828443b9b: Bug 1328023 - Part 2. Add test for undo. r=masayuki, a=jcristau
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 30 Jan 2017 17:27:26 +0900 - rev 482597
Push 45112 by mchiang@mozilla.com at Mon, 13 Feb 2017 05:49:16 +0000
Bug 1328023 - Part 2. Add test for undo. r=masayuki, a=jcristau MozReview-Commit-ID: 6ZuluRWrYxb
e235e56f062a8bb2bfec3ea17fa098ecd422b476: Bug 1328023 - Part 1. Don't use RangeUpdater except to composition transaction. r=masayuki, a=jcristau
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 30 Jan 2017 17:25:43 +0900 - rev 482596
Push 45112 by mchiang@mozilla.com at Mon, 13 Feb 2017 05:49:16 +0000
Bug 1328023 - Part 1. Don't use RangeUpdater except to composition transaction. r=masayuki, a=jcristau Part 3 fix of bug 1310912 is incorrect for not composition transaction. PlaceholderTransation is for saving and restoring current selection for undo. So we shouldn't use range updater to normal transaction. Composition transaction can modify multiple nodes and it merges text node for ime into single text node. So if current selection is into IME text node, it might be failed to restore selection by UndoTransaction. So we need update selection by range updater to work UndoTransaction. Also, CompositionTransaction::UndoTransaction will set selection after committed text. So at finally, selection will set correct position that composition transaction wants. MozReview-Commit-ID: 1NcH32YoKPQ
0e1d4619f4c6e18f9add95dce45a6969f7310a00: Bug 1327953 - Fix enabling the 'Restore Default Search Engines' button when removing a default engine, r=Standard8 a=jcristau
Florian Quèze <florian@queze.net> - Mon, 30 Jan 2017 08:10:00 +0100 - rev 482595
Push 45112 by mchiang@mozilla.com at Mon, 13 Feb 2017 05:49:16 +0000
Bug 1327953 - Fix enabling the 'Restore Default Search Engines' button when removing a default engine, r=Standard8 a=jcristau
a8eefd5c63efa9ed822399b161a702cdae2cf4f8: Bug 1327946 - Remove conditional moz-user-focus on identity block from urlbar. r=Gijs, a=lizzard
Johann Hofmann <jhofmann@mozilla.com> - Tue, 24 Jan 2017 11:42:09 +0100 - rev 482594
Push 45112 by mchiang@mozilla.com at Mon, 13 Feb 2017 05:49:16 +0000
Bug 1327946 - Remove conditional moz-user-focus on identity block from urlbar. r=Gijs, a=lizzard MozReview-Commit-ID: 9F39TeDIGUf
5ae7001fbd3f6441525f70a8c4c2db12c5ce5b00: Bug 1319660 - Fix possible crash when editing contentEditable; r=esawin r=masayuki r=smaug a=lizzard a=jcristau
Jim Chen <nchen@mozilla.com> - Mon, 23 Jan 2017 14:35:04 -0500 - rev 482593
Push 45112 by mchiang@mozilla.com at Mon, 13 Feb 2017 05:49:16 +0000
Bug 1319660 - Fix possible crash when editing contentEditable; r=esawin r=masayuki r=smaug a=lizzard a=jcristau Bug 1319660 - 1. Don't take shortcut if old replacement ranges don't match; r=esawin The block at [1] is a shortcut we take when we reconcile Java text changes with Gecko text changes. However, we only checked that the new ranges are the same, i.e. that the new Gecko text is the same as the new Java text. We should also be checking that the old ranges are the same, i.e. that the replaced Gecko text is the same as the replaced Java text. [1] https://dxr.mozilla.org/mozilla-central/rev/bbbd2f7539f224a482cc6d2dd10e6a5f31c8baf3/mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoEditable.java#1233 Bug 1319660 - 2. Use previous node instead of sibling when adjusting last node; r=masayuki r=smaug nsContentIterator in pre mode adjusts its last node if the node is a childless node like <br>. However, right now it's using GetPrevSibling, which can lead to error in some edge cases such as: <p></p><div><br></div> In this case, if the last node is <br> with offset 0, GetPrevSibling will return <p> because <p> is <br>'s parent's previous sibling, and the last node will be set to <p>. However, the correct last node in this case is <div>, because <br> with offset 0 refers to the position to the left of <br>, which is <div> with offset 0. In this case, PrevNode returns the correct <div> value, so we should set the last node to the result of PrevNode. For the first node, for a childless node in pre mode, GetNextSibling and NextNode are the same, so there is no bug in this case. Nevertheless, this patch changes the call to NextNode to be consistent with calling PrevNode for the last node. Bug 1319660 - 3. Add test for correctly adjusting last node in content iterator; r=masayuki Add a test for the previous patch that makes sure querying selected text in an edge case works correctly. Bug 1319660 - 4. Add test for start node regression; r=me Add a new test case for the NextNode() regression. r=me for trivial test-only patch. Bug 1319660 - 5. Restore GetNextSibling call for first node of pre-content-iterator; r=smaug The last patch changed the `GetNextSibling()` call to `NextNode()` because I assumed they're equivalent in this case. That turned out to not be the case because we can reach this line even if the node has children -- the index just has to be after the last child. So this patch restores the `GetNextSibling` call to restore the correct behavior. I also added some comment to clarify that we can reach this line due to one of two conditions: 1) the node has no children; 2) the node has children but the index is after the last child. This patch also replaces the `HasChildren()` check when setting `cChild`. If the index is after the last child (i.e. index == childCount), `GetChildAt()` fails and we erroneously log an assertion warning, even though the input was valid. The new check handles all cases whether start node has children or not.
e388fdc06380d4689d5a914fa7708452cc223e8b: Bug 1315450 EditorEventListener::MouseClick() should check if mEditorBase is available before calling its ForceCompositionEnd() r=smaug, a=jcristau
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 30 Jan 2017 17:03:02 +0900 - rev 482592
Push 45112 by mchiang@mozilla.com at Mon, 13 Feb 2017 05:49:16 +0000
Bug 1315450 EditorEventListener::MouseClick() should check if mEditorBase is available before calling its ForceCompositionEnd() r=smaug, a=jcristau IMEStateManager::OnClickInEditor() may cause anything because it may set input context. For example, it may cause opening VKB, changing focus or reflow. So, mEditorBase here might have been gone. MozReview-Commit-ID: C0SVzb5SueS
3354522f515533c93aab4d0d0178b37079b4dd5a: Bug 1313933 - Explicitly bypass history when loading RDM UI. r=ochameau a=jcristau
J. Ryan Stinnett <jryans@gmail.com> - Fri, 27 Jan 2017 16:03:04 -0600 - rev 482591
Push 45112 by mchiang@mozilla.com at Mon, 13 Feb 2017 05:49:16 +0000
Bug 1313933 - Explicitly bypass history when loading RDM UI. r=ochameau a=jcristau By using `LOAD_FLAGS_BYPASS_HISTORY`, we can tell session history explicitly to ignore the entry for the container UI (which is meant to remain hidden from the user). This allows us to remove the horrible racy hack that attempted to have the same effect. MozReview-Commit-ID: LnhJpO9UbNI
c9d3429e9d3c95ef350fc2fe2bb3e0accc34a86b: Bug 1313933 - Cleanup logging in RDM tab remoteness test. r=ochameau a=jcristau
J. Ryan Stinnett <jryans@gmail.com> - Thu, 26 Jan 2017 16:27:07 -0600 - rev 482590
Push 45112 by mchiang@mozilla.com at Mon, 13 Feb 2017 05:49:16 +0000
Bug 1313933 - Cleanup logging in RDM tab remoteness test. r=ochameau a=jcristau MozReview-Commit-ID: LSZGbhd6wg7
4c4d63ac9997522d8e19fbcf3fcf5b34727481bc: Bug 1115055 EditorEventListener::MouseDown() should check if mEditorBase is nullptr before calling its ForceCompositionEnd() r=smaug a=jcristau
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 30 Jan 2017 17:43:53 +0900 - rev 482589
Push 45112 by mchiang@mozilla.com at Mon, 13 Feb 2017 05:49:16 +0000
Bug 1115055 EditorEventListener::MouseDown() should check if mEditorBase is nullptr before calling its ForceCompositionEnd() r=smaug a=jcristau EditorEventListener::MouseDown() may be called by HTMLEditorEventListener::MouseDown() too. In this case, mEditorBase may be nullptr. Therefore, EditorEventListener::MouseDown() should check if mEditorBase is still available before using it. MozReview-Commit-ID: 1wAgPdt3db0
005919b0717191c77f6a11b1d4facd659cb4368e: Bug 1333436 - Guard against slicing onto the same shared memory block. r=bbouvier a=lizzard
Lars T Hansen <lhansen@mozilla.com> - Tue, 24 Jan 2017 18:20:01 +0100 - rev 482588
Push 45112 by mchiang@mozilla.com at Mon, 13 Feb 2017 05:49:16 +0000
Bug 1333436 - Guard against slicing onto the same shared memory block. r=bbouvier a=lizzard
47435662c2ca1787eb996a827d789a57e1a4a392: Bug 1333436 - Add assertions about overlaps to the safe-for-races memcpy blocks. r=bbouvier a=lizzard
Lars T Hansen <lhansen@mozilla.com> - Tue, 24 Jan 2017 18:39:21 +0100 - rev 482587
Push 45112 by mchiang@mozilla.com at Mon, 13 Feb 2017 05:49:16 +0000
Bug 1333436 - Add assertions about overlaps to the safe-for-races memcpy blocks. r=bbouvier a=lizzard
0d5fd88afc55a306466f7d98f895ea9181cc5526: Bug 1334026 - Show the the insecure field warning on insecure password fields even if they're not marked. r=mconley a=lizzard
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Tue, 31 Jan 2017 16:03:52 -0800 - rev 482586
Push 45112 by mchiang@mozilla.com at Mon, 13 Feb 2017 05:49:16 +0000
Bug 1334026 - Show the the insecure field warning on insecure password fields even if they're not marked. r=mconley a=lizzard MozReview-Commit-ID: JwEYWQmexj
7d746d214c73fe9b43cd9c7f02466d0db802a3d6: Bug 1334647 - Make canvas.drawImage trigger a JS error rather than a critical error on an invalid target. r=rhunt, a=jcristau
Lee Salzman <lsalzman@mozilla.com> - Tue, 31 Jan 2017 11:17:50 -0500 - rev 482585
Push 45112 by mchiang@mozilla.com at Mon, 13 Feb 2017 05:49:16 +0000
Bug 1334647 - Make canvas.drawImage trigger a JS error rather than a critical error on an invalid target. r=rhunt, a=jcristau MozReview-Commit-ID: 3TxJM0tjhVC
e5f851a668419416d2328143ecb08783d21697f8: Bug 1334129 - TraceLogger - On destruction remove the logger from the mainlogger list. r=bbouvier, a=jcristau
Hannes Verschore <hv1989@gmail.com> - Fri, 27 Jan 2017 18:01:36 +0100 - rev 482584
Push 45112 by mchiang@mozilla.com at Mon, 13 Feb 2017 05:49:16 +0000
Bug 1334129 - TraceLogger - On destruction remove the logger from the mainlogger list. r=bbouvier, a=jcristau
27fed9b44e87b15f4fd76bc1c3db5f954e4a3e55: Bug 1332602 - Propagate JS errors in FileReader. r=smaug, a=test-only
Andrea Marchesini <amarchesini@mozilla.com> - Tue, 24 Jan 2017 12:12:15 +0100 - rev 482583
Push 45112 by mchiang@mozilla.com at Mon, 13 Feb 2017 05:49:16 +0000
Bug 1332602 - Propagate JS errors in FileReader. r=smaug, a=test-only
42caf6d5245ff30d0a4bd7249d1d7ebb7044d6c7: Bug 1334052 - Fix racy tab switching. r=mrbkap, a=test-only
Gabor Krizsanits <gkrizsanits@mozilla.com> - Tue, 31 Jan 2017 10:12:55 +0100 - rev 482582
Push 45112 by mchiang@mozilla.com at Mon, 13 Feb 2017 05:49:16 +0000
Bug 1334052 - Fix racy tab switching. r=mrbkap, a=test-only
2678b49156fb6cc9b7f1cb61e90983b78f2c849a: Bug 1334613 - [mozdevice] - Use root to kill processes on Android 7+. r=gbrown, a=test-only
Bob Clary <bclary@bclary.com> - Mon, 30 Jan 2017 16:09:14 -0800 - rev 482581
Push 45112 by mchiang@mozilla.com at Mon, 13 Feb 2017 05:49:16 +0000
Bug 1334613 - [mozdevice] - Use root to kill processes on Android 7+. r=gbrown, a=test-only
8e911bf5de822c82d33e78bc5da07a0c811e635e: Bug 1333736 - Disable usage of new tab page by default. r=maja_zf a=test-only
Henrik Skupin <mail@hskupin.info> - Wed, 25 Jan 2017 14:50:24 +0100 - rev 482580
Push 45112 by mchiang@mozilla.com at Mon, 13 Feb 2017 05:49:16 +0000
Bug 1333736 - Disable usage of new tab page by default. r=maja_zf a=test-only Now that Marionette can load about:blank multiple times right after each other there is no need to prevent using it when turning of the new tab page. test_about_blank_for_new_docshell can also be updated by using a new tab for the test. This also gives us a new docshell and can also be run for Fennec. MozReview-Commit-ID: GWxtsH3nQt
cf1c3ab4b7aaa33f0b46dd2061351afe69ebc523: Bug 1332876 - test. a=test-only
Mats Palmgren <mats@mozilla.com> - Mon, 30 Jan 2017 04:54:38 +0100 - rev 482579
Push 45112 by mchiang@mozilla.com at Mon, 13 Feb 2017 05:49:16 +0000
Bug 1332876 - test. a=test-only
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip