c75b03d7e9278ba08d26ff60389fa266f0dfb362: Bug 1278014 part.13 Rename SelectionType::SELECTION_URLSECONDARY to SelectionType::eURLSecondary r?smaug draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 09 Jun 2016 20:47:48 +0900 - rev 377066
Push 20740 by masayuki@d-toybox.com at Thu, 09 Jun 2016 15:36:42 +0000
Bug 1278014 part.13 Rename SelectionType::SELECTION_URLSECONDARY to SelectionType::eURLSecondary r?smaug MozReview-Commit-ID: C2IW7nqjEkD
bb9065b7109bf12dd08cf994078b17cd03268c39: Bug 1278014 part.12 Rename SelectionType::SELECTION_FIND to SelectionType::eFind r?smaug draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 09 Jun 2016 20:35:20 +0900 - rev 377065
Push 20740 by masayuki@d-toybox.com at Thu, 09 Jun 2016 15:36:42 +0000
Bug 1278014 part.12 Rename SelectionType::SELECTION_FIND to SelectionType::eFind r?smaug MozReview-Commit-ID: BZxBnCDBghi
2db74688104c37e90bff3d7a6175c480039d608a: Bug 1278014 part.11 Rename SelectionType::SELECTION_ACCESSIBILITY to SelectionType::eAccessibility r?smaug draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 09 Jun 2016 20:32:36 +0900 - rev 377064
Push 20740 by masayuki@d-toybox.com at Thu, 09 Jun 2016 15:36:42 +0000
Bug 1278014 part.11 Rename SelectionType::SELECTION_ACCESSIBILITY to SelectionType::eAccessibility r?smaug MozReview-Commit-ID: 2nU4KQB5S7N
71ff2c1a75a75bc40fbbe03aa2396843631bd0dc: Bug 1278014 part.10 Rename SelectionType::SELECTION_IME_SELECTEDCONVERTEDTEXT to SelectionType::eIMESelectedClause r?smaug draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 09 Jun 2016 19:29:29 +0900 - rev 377063
Push 20740 by masayuki@d-toybox.com at Thu, 09 Jun 2016 15:36:42 +0000
Bug 1278014 part.10 Rename SelectionType::SELECTION_IME_SELECTEDCONVERTEDTEXT to SelectionType::eIMESelectedClause r?smaug MozReview-Commit-ID: 8v3mqcYorOI
74145712837805175b776f7150df0836de1d8a7b: Bug 1278014 part.9 Rename SelectionType::SELECTION_IME_CONVERTEDTEXT to SelectionType::eIMEConvertedClause r?smaug draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 09 Jun 2016 19:14:17 +0900 - rev 377062
Push 20740 by masayuki@d-toybox.com at Thu, 09 Jun 2016 15:36:42 +0000
Bug 1278014 part.9 Rename SelectionType::SELECTION_IME_CONVERTEDTEXT to SelectionType::eIMEConvertedClause r?smaug MozReview-Commit-ID: 5UNqhB2ZEcZ
a343746ec0769c58c08ee78741990e49c5ad68ff: Bug 1278014 part.8 Rename SelectionType::SELECTION_IME_SELECTEDRAWTEXT to SelectionType::eIMESelectedRawClause r?smaug draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 09 Jun 2016 19:03:40 +0900 - rev 377061
Push 20740 by masayuki@d-toybox.com at Thu, 09 Jun 2016 15:36:42 +0000
Bug 1278014 part.8 Rename SelectionType::SELECTION_IME_SELECTEDRAWTEXT to SelectionType::eIMESelectedRawClause r?smaug MozReview-Commit-ID: DgprOxg87K6
3b0c3edb32be05adc19a509059c42cda7e379d69: Bug 1278014 part.7 Rename SelectionType::SELECTION_IME_RAWINPUT to SelectionType::eIMERawClause r?smaug draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 09 Jun 2016 18:51:49 +0900 - rev 377060
Push 20740 by masayuki@d-toybox.com at Thu, 09 Jun 2016 15:36:42 +0000
Bug 1278014 part.7 Rename SelectionType::SELECTION_IME_RAWINPUT to SelectionType::eIMERawClause r?smaug MozReview-Commit-ID: BRe10Lyx5mt
7647ac38da341f56f8dc5f313b60979101253c8e: Bug 1278014 part.6 Rename SelectionType::SELECTION_SPELLCHECK to SelectionType::eSpellCheck r?smaug draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 09 Jun 2016 18:37:36 +0900 - rev 377059
Push 20740 by masayuki@d-toybox.com at Thu, 09 Jun 2016 15:36:42 +0000
Bug 1278014 part.6 Rename SelectionType::SELECTION_SPELLCHECK to SelectionType::eSpellCheck r?smaug MozReview-Commit-ID: 4n2jEVax37O
967587b88bda929f53187634176b50a1a2508f6f: Bug 1278014 part.5 Rename SelectionType::SELECTION_NORMAL to SelectionType::eNormal r?smaug draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 09 Jun 2016 18:35:22 +0900 - rev 377058
Push 20740 by masayuki@d-toybox.com at Thu, 09 Jun 2016 15:36:42 +0000
Bug 1278014 part.5 Rename SelectionType::SELECTION_NORMAL to SelectionType::eNormal r?smaug MozReview-Commit-ID: AAdxTTKEvrk
f009dc159e164452f1ef964db77ae3d322be28a8: Bug 1278014 part.4 Rename SelectionType::SELECTION_NONE to SelectionType::eNone r?smaug draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 09 Jun 2016 18:07:18 +0900 - rev 377057
Push 20740 by masayuki@d-toybox.com at Thu, 09 Jun 2016 15:36:42 +0000
Bug 1278014 part.4 Rename SelectionType::SELECTION_NONE to SelectionType::eNone r?smaug MozReview-Commit-ID: BRfzs8sColP
e9627a95e4fe5f532537b40c08c00fb3cf3928d6: Bug 1278014 part.3 Define 2 constants for number of SelectionType and number of SelectionType except "none" r?smaug draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 09 Jun 2016 16:50:21 +0900 - rev 377056
Push 20740 by masayuki@d-toybox.com at Thu, 09 Jun 2016 15:36:42 +0000
Bug 1278014 part.3 Define 2 constants for number of SelectionType and number of SelectionType except "none" r?smaug This patch defines two constants kSelectionTypeCount and kPresentSelectionTypeCount. The former is same as nsISelectionController::NUM_SELECTIONTYPES. The latter is kSelectionTypeCount - 1 for excluding SELECTION_NONE. The latter is useful in some loops which handle all selection types except SELECTION_NONE. Note that this patch fixes a bug of nsFrameSelection. That doesn't treat SELECTION_NONE as a selection (see the definition of index), however, it defines redundant item and doesn't use it actually. Additionally, it computes invalid selection type in each loop. Therefore, without this patch, debug build hits MOZ_ASSERT() in ToSelectionType(RawSelectionType). Note that these constants are defined as anonymous enum because we cannot define as const (or static) even with extern. If we'd try to do it, it caused link error or not available in nsFrameSelection.cpp as constant value since they were not initialized if they were initialized in nsSelection.cpp. Therefore, these constants are defined as enum items but using "k" prefix. MozReview-Commit-ID: H6sH7NBEXlE
520cc372c7906188dfa3dbc151a36805e21d8907: Bug 1278014 part.2 Define mozilla::SelectionType as an enum class and use it instead of RawSelectionType as far as possible r?smaug draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 09 Jun 2016 16:59:15 +0900 - rev 377055
Push 20740 by masayuki@d-toybox.com at Thu, 09 Jun 2016 15:36:42 +0000
Bug 1278014 part.2 Define mozilla::SelectionType as an enum class and use it instead of RawSelectionType as far as possible r?smaug This patch defines mozilla::SelectionType as an enum class. This is safer than nsISelectionController::SELECTION_* since setting illegal value to its variable is checked at build time. So, as far as possible, this should be used everywhere (but of course, this isn't available in scriptable interfaces). And also this implements some useful methods for managing SelectionType and RawSelectionType which are implemented in layout/nsSelection.cpp because nsISelectionController is implemented by both PresShell and nsTextEditorState. Therefore, implementing one of them may make hard to find them. On the other hand, nsSelection.cpp is a better file name to look for them. Note that this patch creates mozilla::Selection::RawType() for binding. Native code should keep using Selection::Type() but the binding code needs to use RawType() due to impossible to convert from SelectionType to RawSelectionType without explicit cast. MozReview-Commit-ID: 81vX7A0hHQN
929c2618e7d9259bf9f959af9cf9c9abb46d8456: Bug 1278014 part.1 Rename SelectionType in nsISelectionController.idl to mozilla::RawSelectionType r?smaug draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 07 Jun 2016 22:42:06 +0900 - rev 377054
Push 20740 by masayuki@d-toybox.com at Thu, 09 Jun 2016 15:36:42 +0000
Bug 1278014 part.1 Rename SelectionType in nsISelectionController.idl to mozilla::RawSelectionType r?smaug mozilla::SelectionType will be an enum class. Therefore, we need to rename SelectionType with a word "raw" since it's a type for raw nsISelectionController::SELECTION_*. MozReview-Commit-ID: K8SO0bbpv0Y
96429da584b15fee9d461c750add56dc7b58dab2: Bug 1278084 part.3 TextComposition shouldn't decide composition string which is only an ideographic space as a placeholder r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 07 Jun 2016 21:25:24 +0900 - rev 377053
Push 20740 by masayuki@d-toybox.com at Thu, 09 Jun 2016 15:36:42 +0000
Bug 1278084 part.3 TextComposition shouldn't decide composition string which is only an ideographic space as a placeholder r?m_kato Currently, when TextComposition tries to forcibly commit composition synchronously, it cancels the composition if there is only an ideographic space since legacy Chinese IMEs for Windows were used an ideographic space as a placeholder and shows actual composition string in its owning window (called reading window). However, Japanese TIPs basically use composition to input an ideographic space. Unfortunately, this intentional input of an ideographic space is always canceled if an editor commits to composition at every input event in TSF mode because TSF cannot commit during a call of ITextStore::RequestLock(). Additionally, we will enable e10s mode, then, on all platforms, requesting commit composition is handled asynchronously. Therefore, we should make the hack disabled in default settings now. If we'll find a way to distinguish if an ideographic space is a placeholder, we should recover this hack. Note that such input fields cannot handle such legacy IMEs, so, disabling the hack in default settings must be fine. MozReview-Commit-ID: IdBcfBxeJum
13edb99ce0e74bb160a78315ac909ecf2e50fb77: Bug 1278084 part.2 TSFTextStore should allow TSF to lock the document even during destroying r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 08 Jun 2016 19:12:07 +0900 - rev 377052
Push 20740 by masayuki@d-toybox.com at Thu, 09 Jun 2016 15:36:42 +0000
Bug 1278084 part.2 TSFTextStore should allow TSF to lock the document even during destroying r?m_kato While a TSFTextStore instance is being destroyed, TSFTextStore::Destroy() tries to commit remaining composition and notify TSF of destroying the view. At this moment, TSF/TIP may try to commit the composition or retrieve the contents with calling ITextStoreACP::RequestLock() but currently TSFTextStore disallows the requests to lock of them. This means that TSFTextStore never sends composition commit events asynchronously. Therefore, TextComposition may keep waiting remaining composition events but this causes odd behavior because they won't be fired. For avoiding this issue, TSFTextStore should behave as normal even while it's being destroyed. Fortunately, if there is a composition, it always has mLockedContent and mSelection. So, it can compute expected results of TSF/TIP with them. MozReview-Commit-ID: 2DSCGXXkLx1
4bcb914519611384d13955c724feb4692685731e: Bug 1278084 part.1 Don't release TSF objects during handling a key message r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 06 Jun 2016 21:07:24 +0900 - rev 377051
Push 20740 by masayuki@d-toybox.com at Thu, 09 Jun 2016 15:36:42 +0000
Bug 1278084 part.1 Don't release TSF objects during handling a key message r?m_kato While TIP is handling a key message, TSFTextStore shouldn't release any TSF objects since it may cause hitting a bug of TIPs. Actually, MS-IME for Japanese on Windows 10 crashes when TSFTextStore is destroyed during composition because probably it accesses some destroyed objects to request to commit composition or query contents. MozReview-Commit-ID: 9CTjHhAvG04
a2c0c7820126695e0903460f9eea5fe87e5ee971: Bug 1277295 Remove obsolete reference to storage service r?kmag draft
Andrew Swan <aswan@mozilla.com> - Wed, 08 Jun 2016 14:28:00 -0700 - rev 377050
Push 20739 by aswan@mozilla.com at Thu, 09 Jun 2016 15:13:55 +0000
Bug 1277295 Remove obsolete reference to storage service r?kmag MozReview-Commit-ID: 27BEb2XGQkZ
02b1518460026cf07a3b28f6a8048a07ddeb9c75: Bug 1279243 - Add quit_instance() and restart_instance() to marionette driver. Use those methods to implement restart(); r=maja_zf draft
André Reinald <areinald@mozilla.com> - Thu, 09 Jun 2016 17:10:13 +0200 - rev 377049
Push 20738 by areinald@mozilla.com at Thu, 09 Jun 2016 15:13:42 +0000
Bug 1279243 - Add quit_instance() and restart_instance() to marionette driver. Use those methods to implement restart(); r=maja_zf MozReview-Commit-ID: 84FV6t49VdF
d435736c356d4b6fca5841e2d240b498ff43858c: Bug 1277295 Remove obsolete reference to storage service r?mossop draft
Andrew Swan <aswan@mozilla.com> - Wed, 08 Jun 2016 14:28:00 -0700 - rev 377048
Push 20737 by aswan@mozilla.com at Thu, 09 Jun 2016 15:12:57 +0000
Bug 1277295 Remove obsolete reference to storage service r?mossop MozReview-Commit-ID: 27BEb2XGQkZ
7f7f1ca1d0cd9c805679e9d196d85cc8f4687779: Bug 1190627 - Part 7 - Add telemetry probe for measuring how often we restore from the backup session copy. r=margaret draft
Jan Henning <jh+bugzilla@buttercookie.de> - Wed, 01 Jun 2016 22:04:59 +0200 - rev 377047
Push 20736 by mozilla@buttercookie.de at Thu, 09 Jun 2016 14:50:37 +0000
Bug 1190627 - Part 7 - Add telemetry probe for measuring how often we restore from the backup session copy. r=margaret MozReview-Commit-ID: JTR54Vk18jW
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip