c43501ded79cdf6cfb0cea65f9ae0a4ff179f2ad: Bug 1462725 - Add TelemetryEvents class to Savant JSM; r=rhelmer draft
Bianca Danforth <bdanforth@mozilla.com> - Wed, 23 May 2018 07:17:05 -0700 - rev 803197
Push 112042 by bdanforth@mozilla.com at Sat, 02 Jun 2018 00:51:23 +0000
Bug 1462725 - Add TelemetryEvents class to Savant JSM; r=rhelmer This class will handle enabling/disabling the "savant" category of event telemetry. MozReview-Commit-ID: F7sjsscOcV6
cb8ede76462f9bc33f52940edc3be7b698145456: Bug 1462725 - Add pref-controlled logging to Savant module; r=rhelmer draft
Bianca Danforth <bdanforth@mozilla.com> - Wed, 23 May 2018 07:14:02 -0700 - rev 803196
Push 112042 by bdanforth@mozilla.com at Sat, 02 Jun 2018 00:51:23 +0000
Bug 1462725 - Add pref-controlled logging to Savant module; r=rhelmer MozReview-Commit-ID: JFMo1s5lajo
3f4343b9ca0a2a842013b90ba44208b068bdefcb: Bug 1462725 - Init Savant module at Firefox startup with study pref; r=rhelmer draft
Bianca Danforth <bdanforth@mozilla.com> - Wed, 23 May 2018 07:10:59 -0700 - rev 803195
Push 112042 by bdanforth@mozilla.com at Sat, 02 Jun 2018 00:51:23 +0000
Bug 1462725 - Init Savant module at Firefox startup with study pref; r=rhelmer This module observes the study pref to enable/disable the study. MozReview-Commit-ID: Ht7M1gT05wG
c28becad0c10b906454d7e424f9a9402799ea8dd: Bug 1464766 - Allow to relax the addon signature requirements. r?rhelmer draft
Mike Hommey <mh+mozilla@glandium.org> - Mon, 28 May 2018 16:15:13 +0900 - rev 803194
Push 112041 by bmo:mh+mozilla@glandium.org at Sat, 02 Jun 2018 00:47:32 +0000
Bug 1464766 - Allow to relax the addon signature requirements. r?rhelmer
5d17a96f93d539e44ca4689353ae3cfaba2b63bb: Bug 1465117 - Add additional options to backfilling action task draft
Brian Stack <bstack@mozilla.com> - Fri, 01 Jun 2018 16:44:16 -0700 - rev 803193
Push 112040 by bstack@mozilla.com at Sat, 02 Jun 2018 00:27:25 +0000
Bug 1465117 - Add additional options to backfilling action task MozReview-Commit-ID: FMGjhQbg4im
3a3a0e2d8c81bb262623b092ba5b79ca78dce510: Bug 1465117 - Add additional options to backfilling action task draft
Brian Stack <bstack@mozilla.com> - Fri, 01 Jun 2018 16:44:16 -0700 - rev 803192
Push 112039 by bstack@mozilla.com at Sat, 02 Jun 2018 00:07:12 +0000
Bug 1465117 - Add additional options to backfilling action task MozReview-Commit-ID: FMGjhQbg4im
d5068f3976d78b608e7676410cec7b573078c8c3: Bug 1364784 - Allow more modifier combinations for webextensions commands key; r?mstriemer draft
Adam Plaice <plaice.adam+persona@gmail.com> - Sat, 02 Jun 2018 00:56:44 +0200 - rev 803191
Push 112038 by bmo:plaice.adam+persona@gmail.com at Fri, 01 Jun 2018 23:58:36 +0000
Bug 1364784 - Allow more modifier combinations for webextensions commands key; r?mstriemer This allows keyboard shortcuts containing both "Ctrl" and "Alt" in the manifest of webextensions (in the "commands" -> "suggested_key" key), rather than just one of these modifiers. The equivalent combinations on MacOS (any two of "Command", "Alt" and "MacCtrl") are also allowed. Non-sensical combinations (such as "Ctrl+MacCtrl" or "Ctrl+Ctrl") are forbidden. MozReview-Commit-ID: 59tC2efLm5q
c9c5d09549426c76fbf20ed2c45bde07cafceab4: Bug 1434206 - Keep LookupResult objects in smart pointers. r?gcp draft
Francois Marier <francois@mozilla.com> - Fri, 01 Jun 2018 16:15:28 -0700 - rev 803190
Push 112037 by fmarier@mozilla.com at Fri, 01 Jun 2018 23:56:25 +0000
Bug 1434206 - Keep LookupResult objects in smart pointers. r?gcp Replace raw pointers to LookupResult with RefPtrs and eplace the nsAutoPtr objects + raw pointers params with UniquePtrs. Also remove unnecessarily paranoid OOM checks when creating single LookupResult objects since those are pretty small. MozReview-Commit-ID: G85RNnAat6H
8be3cb417e783e7b5a8ad1e469c09a0737b13a2e: Bug 1434206 - Make DBSserviceWorkerProxy as const as possible. r?gcp draft
Francois Marier <francois@mozilla.com> - Thu, 24 May 2018 16:40:35 -0700 - rev 803189
Push 112037 by fmarier@mozilla.com at Fri, 01 Jun 2018 23:56:25 +0000
Bug 1434206 - Make DBSserviceWorkerProxy as const as possible. r?gcp MozReview-Commit-ID: KPzzmb1Jehi
06a05164a3eda41dccdbb810b82e565166ceb0c8: Bug 1434206 - Keep CacheResult objects in smart pointers. r?gcp draft
Francois Marier <francois@mozilla.com> - Fri, 01 Jun 2018 15:49:14 -0700 - rev 803188
Push 112037 by fmarier@mozilla.com at Fri, 01 Jun 2018 23:56:25 +0000
Bug 1434206 - Keep CacheResult objects in smart pointers. r?gcp Some of the objects were kept in UniquePtr and nsAutoPtr but that seemed unnecessary complexity given that we can simply use RefPtr everywhere. It's also possible to make all of the CacheResult arrays const since we don't ever modify the elements once they are added. MozReview-Commit-ID: 5OlcbkQLrGb
9fc22832c3ff241d626948d1380e3dac3076761c: Bug 1434206 - Clarify when the lookupcache arrays should be cleared. r?gcp draft
Francois Marier <francois@mozilla.com> - Mon, 21 May 2018 15:58:12 -0700 - rev 803187
Push 112037 by fmarier@mozilla.com at Fri, 01 Jun 2018 23:56:25 +0000
Bug 1434206 - Clarify when the lookupcache arrays should be cleared. r?gcp MozReview-Commit-ID: 7smtnCC0MGT
16ac402021c5b716e2502c86367c5d3ea9f915b4: Bug 1434206 - Make LookupCache objects const as much as possible. r?gcp draft
Francois Marier <francois@mozilla.com> - Mon, 21 May 2018 15:11:01 -0700 - rev 803186
Push 112037 by fmarier@mozilla.com at Fri, 01 Jun 2018 23:56:25 +0000
Bug 1434206 - Make LookupCache objects const as much as possible. r?gcp MozReview-Commit-ID: AqC6NUh6ifm
7ceaff599d388ed30ccd9ac5bc98b78f153a5127: Bug 1434206 - Keep LookupCache objects in smart pointers. r?gcp draft
Francois Marier <francois@mozilla.com> - Wed, 16 May 2018 19:13:48 -0700 - rev 803185
Push 112037 by fmarier@mozilla.com at Fri, 01 Jun 2018 23:56:25 +0000
Bug 1434206 - Keep LookupCache objects in smart pointers. r?gcp The existing mix of UniquePtr and raw pointers is confusing when trying to figure out the exact lifetime of these objects. MozReview-Commit-ID: Br4S7BXEFKs
d177937211d89d3d17e81cd0635e33382bada9a9: Bug 1434206 - Add const to functions and members that can take it. r?gcp draft
Francois Marier <francois@mozilla.com> - Wed, 16 May 2018 15:39:33 -0700 - rev 803184
Push 112037 by fmarier@mozilla.com at Fri, 01 Jun 2018 23:56:25 +0000
Bug 1434206 - Add const to functions and members that can take it. r?gcp MozReview-Commit-ID: D8IQoLZkFaA
033931eb6dac21706f65db26071e23cb8f907213: Bug 1434206 - Replace a pointer with a reference. r?gcp draft
Francois Marier <francois@mozilla.com> - Tue, 15 May 2018 17:18:18 -0700 - rev 803183
Push 112037 by fmarier@mozilla.com at Fri, 01 Jun 2018 23:56:25 +0000
Bug 1434206 - Replace a pointer with a reference. r?gcp This will prevent our holding on to this pointer incorrectly in the future. MozReview-Commit-ID: H8ueIOK1qAK
8c478b78556e6abe26dc2a9de08472ef9e1c5986: Bug 1434206 - Make TableUpdate objects const as much as possible. r?gcp draft
Francois Marier <francois@mozilla.com> - Fri, 11 May 2018 16:02:37 -0700 - rev 803182
Push 112037 by fmarier@mozilla.com at Fri, 01 Jun 2018 23:56:25 +0000
Bug 1434206 - Make TableUpdate objects const as much as possible. r?gcp I tried to make TableUpdateArray point to const TableUpdate objects everywhere but there were two problems: - HashStore::ApplyUpdate() triggers a few Merge() calls which include sorting the underlying TableUpdate object first. - LookupCacheV4::ApplyUpdate() calls TableUpdateV4::NewChecksum() when the checksum is missing and that sets mChecksum. MozReview-Commit-ID: LIhJcoxo7e7
11ffb133a04386b0d90a28d66b349b9fd2bedc67: Bug 1434206 - Keep TableUpdate objects in smart pointers. r?gcp draft
Francois Marier <francois@mozilla.com> - Fri, 01 Jun 2018 15:48:48 -0700 - rev 803181
Push 112037 by fmarier@mozilla.com at Fri, 01 Jun 2018 23:56:25 +0000
Bug 1434206 - Keep TableUpdate objects in smart pointers. r?gcp Manually keeping tabs on the lifetime of these objects is a pain and is the likely source of some of our crashes. I suspect we might also be leaking memory. This change creates an explicit copy of the main array into the update thread to avoid using a non-thread-safe shared data structure. This is a shallow copy. Only the pointers to the TableUpdates are copied, which means one pointer per list (e.g. 5 in total for google4 in a new profile). MozReview-Commit-ID: 221d6GkKt0M
7522949f3ec6aa2a26b8b6bf19324c6cc34e08ee: Bug 1434206 - Assert that gethash processing happens on the right thread. r?gcp draft
Francois Marier <francois@mozilla.com> - Fri, 11 May 2018 11:47:26 -0700 - rev 803180
Push 112037 by fmarier@mozilla.com at Fri, 01 Jun 2018 23:56:25 +0000
Bug 1434206 - Assert that gethash processing happens on the right thread. r?gcp MozReview-Commit-ID: FbF8LzCZ3XO
751777858b9b730c2c4dd60df724aea5154bd3dd: Bug 1434206 - Don't cache gethash response if we failed to apply results. r?gcp draft
Francois Marier <francois@mozilla.com> - Fri, 01 Jun 2018 15:33:30 -0700 - rev 803179
Push 112037 by fmarier@mozilla.com at Fri, 01 Jun 2018 23:56:25 +0000
Bug 1434206 - Don't cache gethash response if we failed to apply results. r?gcp MozReview-Commit-ID: APJ1qhofU3t
9c977c359c5bfa2ee23db114f16b862ec134f645: Bug 1464123 - implement node.py action for use by mozbuild files draft
Dan Mosedale <dmose@meer.net> - Tue, 15 May 2018 18:01:18 -0700 - rev 803178
Push 112036 by bmo:dmose@mozilla.org at Fri, 01 Jun 2018 23:51:35 +0000
Bug 1464123 - implement node.py action for use by mozbuild files MozReview-Commit-ID: KYV9lI28Lox
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 tip