c364407df542acb392484ca5749e2c6f22979c66: Bug 1460509 - part 47: Make HTMLEditRules::ExpandSelectionForDeletion() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 15 May 2018 19:15:56 +0900 - rev 796793
Push 110360 by masayuki@d-toybox.com at Fri, 18 May 2018 10:24:57 +0000
Bug 1460509 - part 47: Make HTMLEditRules::ExpandSelectionForDeletion() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato MozReview-Commit-ID: BdumFS7Rluv
c8ac225a701bc3ee50562173918ff283c1a1268d: Bug 1460509 - part 46: Make HTMLEditRules::NormalizeSelection() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 15 May 2018 18:59:27 +0900 - rev 796792
Push 110360 by masayuki@d-toybox.com at Fri, 18 May 2018 10:24:57 +0000
Bug 1460509 - part 46: Make HTMLEditRules::NormalizeSelection() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato MozReview-Commit-ID: 5yf1ZJ5sQ1t
590dd34c3ecf6c39e279480fe02c91c46aa3ffed: Bug 1460509 - part 45: Test if HTMLEditRules::PromoteRange() won't get range in Selection r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 15 May 2018 18:39:27 +0900 - rev 796791
Push 110360 by masayuki@d-toybox.com at Fri, 18 May 2018 10:24:57 +0000
Bug 1460509 - part 45: Test if HTMLEditRules::PromoteRange() won't get range in Selection r?m_kato PromoteRange() related methods do not change Selection nor the DOM tree. Therefore, they must be safe. However, only PromoteRange() takes an nsRange instance and modifies it. If it's in Selection, that causes selectionchange event. Therefore, we should check if given range is in Selection with MOZ_ASSERT(). MozReview-Commit-ID: AXkmHFB4P08
0ce9222c0b1919aa9e91632f1bce6943e7472932: Bug 1460509 - part 44: Make HTMLEditRules::GetNodesForOperation() and related methods return NS_ERROR_EDITOR_DESTROYED if they cause destroying the editor r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 15 May 2018 18:07:34 +0900 - rev 796790
Push 110360 by masayuki@d-toybox.com at Fri, 18 May 2018 10:24:57 +0000
Bug 1460509 - part 44: Make HTMLEditRules::GetNodesForOperation() and related methods return NS_ERROR_EDITOR_DESTROYED if they cause destroying the editor r?m_kato Despite of the name of GetNodesForOperation() and related methods, it changes the DOM tree if their aTouchContent is TouchContent::yes (by default). Therefore, they should return NS_ERROR_EDITOR_DESTROYED if they cause destroying the editor and all callers should check the result. Therefore, this patch mark them as MOZ_MUST_USE. Additionally, because of importance of aTouchContent, this patch makes the arguments not optional. This change must make other developers being careful to use them. (Although TouchContent does not feel dangerous. We should rename it to make its risk clearer.) On the other hand, this patch removes aTouchContent from GetParagraphFormatNodes() since it's always called with TouchContent::no. Therefore, this method is always safe. Although I tried to document those methods, but I have not understood them completely yet. Perhaps, we should redesign them in another bug both to learn them and making them faster and simpler. MozReview-Commit-ID: 4vknJGUdwEe
6b9e1ef9da4b7532243f298b290bdd299606d8a6: Bug 1460509 - part 43: Make HTMLEditRules::BustUpInlinesAtRangeEndpoints() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 15 May 2018 17:21:08 +0900 - rev 796789
Push 110360 by masayuki@d-toybox.com at Fri, 18 May 2018 10:24:57 +0000
Bug 1460509 - part 43: Make HTMLEditRules::BustUpInlinesAtRangeEndpoints() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato MozReview-Commit-ID: CSYCey8ugA8
d078ca1b7e9e19bb4c52b8edb4e32af9e7f5f639: Bug 1460509 - part 42: Make HTMLEditRules::BustUpInlinesAtBRs() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 15 May 2018 17:04:28 +0900 - rev 796788
Push 110360 by masayuki@d-toybox.com at Fri, 18 May 2018 10:24:57 +0000
Bug 1460509 - part 42: Make HTMLEditRules::BustUpInlinesAtBRs() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato MozReview-Commit-ID: 5KGPE8mPqge
9743a1b17160736c6e299b7e91c31b3bf2ad25c5: Bug 1460509 - part 41: Make HTMLEditRules::ReturnInHeader() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 15 May 2018 16:36:53 +0900 - rev 796787
Push 110360 by masayuki@d-toybox.com at Fri, 18 May 2018 10:24:57 +0000
Bug 1460509 - part 41: Make HTMLEditRules::ReturnInHeader() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato MozReview-Commit-ID: r03QSPXsZ2
9e0aa9e24fc110e89dfb059c448023875c6b2ad2: Bug 1460509 - part 40: Make HTMLEditRules::ReturnInParagraph() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 15 May 2018 16:22:59 +0900 - rev 796786
Push 110360 by masayuki@d-toybox.com at Fri, 18 May 2018 10:24:57 +0000
Bug 1460509 - part 40: Make HTMLEditRules::ReturnInParagraph() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato MozReview-Commit-ID: cnR8uXTfno
91911b7366fca5a968392704757dac367ca41111: Bug 1460509 - part 39: Make HTMLEditRules::SplitParagraph() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 15 May 2018 16:15:35 +0900 - rev 796785
Push 110360 by masayuki@d-toybox.com at Fri, 18 May 2018 10:24:57 +0000
Bug 1460509 - part 39: Make HTMLEditRules::SplitParagraph() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato MozReview-Commit-ID: 38hfUl88xXI
eb10ea1916b981a99a6a027316f59909a88b78e6: Bug 1460509 - part 38: Make HTMLEditRules::ReturnInListItem() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 15 May 2018 15:32:11 +0900 - rev 796784
Push 110360 by masayuki@d-toybox.com at Fri, 18 May 2018 10:24:57 +0000
Bug 1460509 - part 38: Make HTMLEditRules::ReturnInListItem() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato MozReview-Commit-ID: Jl0oiBCuYPb
45a68ab3f12bbc6cec4ba9f594bc108d9676a9e1: Bug 1460509 - part 37: Make HTMLEditRules::MakeBlockquote() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 15 May 2018 15:09:13 +0900 - rev 796783
Push 110360 by masayuki@d-toybox.com at Fri, 18 May 2018 10:24:57 +0000
Bug 1460509 - part 37: Make HTMLEditRules::MakeBlockquote() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato MozReview-Commit-ID: 3pUx52d6EYd
1604c847cfa934217545fba6c96b4ec2fec31b10: Bug 1460509 - part 36: Make HTMLEditRules::RemoveBlockStyle() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 15 May 2018 00:43:07 +0900 - rev 796782
Push 110360 by masayuki@d-toybox.com at Fri, 18 May 2018 10:24:57 +0000
Bug 1460509 - part 36: Make HTMLEditRules::RemoveBlockStyle() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato MozReview-Commit-ID: KDfxeD9k0UN
df6ac443dbaad53f29f47098dfe5feab600ef708: Bug 1460509 - part 35: Make HTMLEditRules::ApplyBlockStyle() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 15 May 2018 00:08:46 +0900 - rev 796781
Push 110360 by masayuki@d-toybox.com at Fri, 18 May 2018 10:24:57 +0000
Bug 1460509 - part 35: Make HTMLEditRules::ApplyBlockStyle() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato MozReview-Commit-ID: 1ddHNx7lF9P
63ab0da0ac122db80ef48da91c9e729be899a6dd: Bug 1460509 - part 34: Make HTMLEditRules::MaybeSplitAncestorsForInsertWithTransaction() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 14 May 2018 23:55:53 +0900 - rev 796780
Push 110360 by masayuki@d-toybox.com at Fri, 18 May 2018 10:24:57 +0000
Bug 1460509 - part 34: Make HTMLEditRules::MaybeSplitAncestorsForInsertWithTransaction() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato MozReview-Commit-ID: 7MqtKPNAOZ1
795e42d4b54d561e318d19db23c2f255b7266267: Bug 1460509 - part 33: Make HTMLEditRules::JoinNearestEditableNodesWithTransaction() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 14 May 2018 23:51:23 +0900 - rev 796779
Push 110360 by masayuki@d-toybox.com at Fri, 18 May 2018 10:24:57 +0000
Bug 1460509 - part 33: Make HTMLEditRules::JoinNearestEditableNodesWithTransaction() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato Unfortunately, we need to make it take out argument for returning new first child point of right node. If we can create JoinNodesResult which have nsresult and EditorDOMPoint, we can avoid that, but EditorBase::JoinNodes() does not want it. So, even if we create such class, only 2 callers of the methods are its users... MozReview-Commit-ID: 1zwVZ0FriwN
8fc602a901a9dcaeda5bb664528182275591b1d8: Bug 1460509 - part 32: Mark HTMLEditRules::CacheInlineStyles() as MOZ_MUST_USE since it may cause destroying the editor and returns NS_ERROR_EDITOR_DESTROYED in such case r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 14 May 2018 23:24:40 +0900 - rev 796778
Push 110360 by masayuki@d-toybox.com at Fri, 18 May 2018 10:24:57 +0000
Bug 1460509 - part 32: Mark HTMLEditRules::CacheInlineStyles() as MOZ_MUST_USE since it may cause destroying the editor and returns NS_ERROR_EDITOR_DESTROYED in such case r?m_kato MozReview-Commit-ID: FJHxJ1j02l1
3f5a7999e9b59e4cadc5f4312d896687e57cd019: Bug 1460509 - part 31: Make HTMLEditRules::GetInlineStyles() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 14 May 2018 23:20:28 +0900 - rev 796777
Push 110360 by masayuki@d-toybox.com at Fri, 18 May 2018 10:24:57 +0000
Bug 1460509 - part 31: Make HTMLEditRules::GetInlineStyles() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato MozReview-Commit-ID: 3Nk1gBttuwM
16f497b092cb2194a84d254541599188c7404dae: Bug 1460509 - part 30: Make HTMLEditRules::ReapplyCachedStyles() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 14 May 2018 23:14:50 +0900 - rev 796776
Push 110360 by masayuki@d-toybox.com at Fri, 18 May 2018 10:24:57 +0000
Bug 1460509 - part 30: Make HTMLEditRules::ReapplyCachedStyles() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato MozReview-Commit-ID: HSv2els7Lys
300a21591aa5e857f8e5e80f32c3cb3c3dde873c: Bug 1460509 - part 29: Make HTMLEditRules::AdjustSpecialBreaks() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 14 May 2018 22:56:06 +0900 - rev 796775
Push 110360 by masayuki@d-toybox.com at Fri, 18 May 2018 10:24:57 +0000
Bug 1460509 - part 29: Make HTMLEditRules::AdjustSpecialBreaks() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato And this patch renames it to InsertBRElementToEmptyListItemsAndTableCellsInChangedRange(). MozReview-Commit-ID: 1DGhcI93YAk
2111f4b9a3a4b716c62c0f62ced4436a4c2fa404: Bug 1460509 - part 28: Make HTMLEditRules::AdjustWhitespace() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 14 May 2018 22:42:08 +0900 - rev 796774
Push 110360 by masayuki@d-toybox.com at Fri, 18 May 2018 10:24:57 +0000
Bug 1460509 - part 28: Make HTMLEditRules::AdjustWhitespace() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato MozReview-Commit-ID: 6dFP6BYDXMg
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip