c315df2bc37345ff4761dc307ea356b8fc176d22: Bug 1194751 - Part 8. Implement ScreenHelperCocoa and delete old nsScreenManagerCocoa/nsScreenCocoa. r?mstange draft
Kan-Ru Chen <kanru@kanru.info> - Thu, 09 Mar 2017 19:34:49 +0800 - rev 495878
Push 48453 by kchen@mozilla.com at Thu, 09 Mar 2017 11:54:08 +0000
Bug 1194751 - Part 8. Implement ScreenHelperCocoa and delete old nsScreenManagerCocoa/nsScreenCocoa. r?mstange ScreenHelperCocoa is the platform dependent part of the original nsScreenManagerCocoa and nsScreenCocoa. It registers NSApplicationDidChangeScreenParametersNotification and pushes updates to ScreenManager. See patch part 4. for how ScreenManager works. MozReview-Commit-ID: 1A5ha4Ys2dL
ae7ce11b64adfd4ed16d15930c0e0c63a4f4c20f: Bug 1194751 - Part 7. Implement ScreenHelperWin and delete old nsScreenManagerWin/nsScreenWin. r?jimm draft
Kan-Ru Chen <kanru@kanru.info> - Thu, 09 Mar 2017 19:32:31 +0800 - rev 495877
Push 48453 by kchen@mozilla.com at Thu, 09 Mar 2017 11:54:08 +0000
Bug 1194751 - Part 7. Implement ScreenHelperWin and delete old nsScreenManagerWin/nsScreenWin. r?jimm ScreenHelperWin is the platform dependent part of the original nsScreenManagerWin and nsScreenWin. It listens the WM_DISPLAYCHANGE message and pushes updates to ScreenManager. See patch part 4. for how ScreenManager works. MozReview-Commit-ID: 20A3ZQKmH9a
04cfa611c869b0567cde5037fef00e186b95ab2e: Bug 1194751 - Part 6.1 change nsScreenManagerAndroid::ScreenForId to a concrete method. r?snorp draft
Kan-Ru Chen <kanru@kanru.info> - Thu, 09 Mar 2017 19:30:53 +0800 - rev 495876
Push 48453 by kchen@mozilla.com at Thu, 09 Mar 2017 11:54:08 +0000
Bug 1194751 - Part 6.1 change nsScreenManagerAndroid::ScreenForId to a concrete method. r?snorp nsIScreen::GetId and nsIScreenManager::ScreenForId is removed in patch part 6. These methods are still used by Fennec on Android to implement Presentation API support so I changed them to concrete methods in nsScreenAndroid and nsScreenManagerAndroid. nsScreenAndroid and nsScreenManagerAndroid does not use the generic Screen and ScreenManager class because its implementation is quite different. MozReview-Commit-ID: 4rxxIgvNxMb
e00d8cfcd99ffa47be9404ed7cc7bcd01c794482: Bug 1194751 - Part 6. Use mozilla::widget::ScreenManager in content process. r?mconley draft
Kan-Ru Chen <kanru@kanru.info> - Thu, 09 Mar 2017 19:30:26 +0800 - rev 495875
Push 48453 by kchen@mozilla.com at Thu, 09 Mar 2017 11:54:08 +0000
Bug 1194751 - Part 6. Use mozilla::widget::ScreenManager in content process. r?mconley This is the most important part of the patch series. It removes the PScreenManager protocol and use ScreenManager directly in the content processes. Initial and subsequent updates are sent via PContent::RefreshScreens. struct ScreenDetails are kept to serialize Screen over IPC. nsIScreenManager::ScreenForNativeWidget is removed because nsIWidget::GetWidgetScreen can replace it. nsIScreen::GetId is removed because it's not useful for the more general Screen class. MozReview-Commit-ID: 5dJO3isgBuQ
272ffdb8d023fca3c5d59bb53cbeb903f173d321: Bug 1194751 - Part 5. Implement ScreenHelperGTK and delete old nsScreenManagerGtk/nsScreenGtk. r?karlt draft
Kan-Ru Chen <kanru@kanru.info> - Thu, 09 Mar 2017 19:29:44 +0800 - rev 495874
Push 48453 by kchen@mozilla.com at Thu, 09 Mar 2017 11:54:08 +0000
Bug 1194751 - Part 5. Implement ScreenHelperGTK and delete old nsScreenManagerGtk/nsScreenGtk. r?karlt ScreenHelperGTK is the platform dependent part of the original nsScreenManagerGtk and nsScreenGtk. It registers monitors-changed event listener from gtk and pushes updates to ScreenManager. See patch part 4. for how ScreenManager works. MozReview-Commit-ID: KBo7ZLFTjM3
bee3e19feb5a06f2b84977c470f12eff605db50d: Bug 1194751 - Part 4. Add ScreenManager and Screen classes. r?mconley,jimm,karlt draft
Kan-Ru Chen <kanru@kanru.info> - Thu, 09 Mar 2017 19:16:40 +0800 - rev 495873
Push 48453 by kchen@mozilla.com at Thu, 09 Mar 2017 11:54:08 +0000
Bug 1194751 - Part 4. Add ScreenManager and Screen classes. r?mconley,jimm,karlt ScreenManager takes the common parts of ScreenManagerWin, ScreenManagerGtk and ScreenManagerCocoa. It caches all screen information in the new Screen class. The cache are updated when the OS notifies there is a monitor config change; all changes will be pushed to content processes via PContent (patch part 6.) Screen is a pure data object. All platform dependent logic will be in widget specific helper classes. Each process will have a singleton ScreenManager object. Widget specific helper object is held alive by the ScreenManager when necessary, for example to receive updates from the OS. The change to to VsyncDispatcher.cpp is due to unified-build bustage. ScreenManager::ScreenForNativeWidget is not implemented because it will be removed in patch part 6. MozReview-Commit-ID: 5ezytAXSqHp
770f7a59f5bd81899eacdc92f4dccd4a8c31f4fa: Bug 1194751 - Part 3. Remove unused nsIScreen::rotation attribute. r?jimm draft
Kan-Ru Chen <kanru@kanru.info> - Thu, 09 Mar 2017 19:16:33 +0800 - rev 495872
Push 48453 by kchen@mozilla.com at Thu, 09 Mar 2017 11:54:08 +0000
Bug 1194751 - Part 3. Remove unused nsIScreen::rotation attribute. r?jimm It's only used by gonk. Remove it will make removing PScreenManager easier. MozReview-Commit-ID: GCHonrz30xK
833999fea474cafff4a5bbdd0a5acd94b5d73aad: Bug 1194751 - Part 2. Remove unused nsIScreen::LockMinimumBrightness and related methods. r?snorp draft
Kan-Ru Chen <kanru@kanru.info> - Thu, 09 Mar 2017 19:16:29 +0800 - rev 495871
Push 48453 by kchen@mozilla.com at Thu, 09 Mar 2017 11:54:08 +0000
Bug 1194751 - Part 2. Remove unused nsIScreen::LockMinimumBrightness and related methods. r?snorp It's not used anywhere in gecko or addons. Remove it will make removing PScreenManager easier. MozReview-Commit-ID: K3BHnktO7wU
a85771990fb5beead609dfecd8e5f64a4a83fdb3: Bug 1194751 - Part 1. Remove nsIScreenManager::GetNumberOfScreens. r?jimm draft
Kan-Ru Chen <kanru@kanru.info> - Thu, 09 Mar 2017 19:16:24 +0800 - rev 495870
Push 48453 by kchen@mozilla.com at Thu, 09 Mar 2017 11:54:08 +0000
Bug 1194751 - Part 1. Remove nsIScreenManager::GetNumberOfScreens. r?jimm It's not used anywhere. Remove it will make removing PScreenManager easier. MozReview-Commit-ID: 5dn8kDhTZVl
29b725d10423feaad89b0b3a0d4620767b4e5759: Bug 1345739 - Implement nsStyleImageRequest::GetImageURI. draft
cku <cku@mozilla.com> - Thu, 09 Mar 2017 13:03:32 +0800 - rev 495869
Push 48452 by bmo:cku@mozilla.com at Thu, 09 Mar 2017 11:49:33 +0000
Bug 1345739 - Implement nsStyleImageRequest::GetImageURI. MozReview-Commit-ID: Jqhio1RaqG1
9a9ff8b1b37915e30c7164d7fa4d442cb54ade50: Bug 1345739 - Implement nsStyleImageRequest::GetImageURI. draft
cku <cku@mozilla.com> - Thu, 09 Mar 2017 13:03:32 +0800 - rev 495868
Push 48451 by bmo:cku@mozilla.com at Thu, 09 Mar 2017 11:47:03 +0000
Bug 1345739 - Implement nsStyleImageRequest::GetImageURI. MozReview-Commit-ID: Jqhio1RaqG1
31a52ed1e0968a957d57f208442c39f46be86959: Bug 1314405 - Provide a readme for eslint-plugin-mozilla, and add some more details to its package.json. r?Mossop draft
Mark Banner <standard8@mozilla.com> - Thu, 09 Mar 2017 11:45:04 +0000 - rev 495867
Push 48450 by bmo:standard8@mozilla.com at Thu, 09 Mar 2017 11:46:07 +0000
Bug 1314405 - Provide a readme for eslint-plugin-mozilla, and add some more details to its package.json. r?Mossop MozReview-Commit-ID: DdzWwWEFvf6
e6b7b2308db3f0f14920327d674ab7071e5e0f21: Bug 1194751 - Part 8. Implement ScreenHelperCocoa and delete old nsScreenManagerCocoa/nsScreenCocoa. r?mstange draft
Kan-Ru Chen <kanru@kanru.info> - Thu, 09 Mar 2017 19:34:49 +0800 - rev 495866
Push 48449 by kchen@mozilla.com at Thu, 09 Mar 2017 11:41:57 +0000
Bug 1194751 - Part 8. Implement ScreenHelperCocoa and delete old nsScreenManagerCocoa/nsScreenCocoa. r?mstange ScreenHelperCocoa is the platform dependent part of the original nsScreenManagerCocoa and nsScreenCocoa. It registers NSApplicationDidChangeScreenParametersNotification and pushes updates to ScreenManager. See patch part 4. for how ScreenManager works. MozReview-Commit-ID: 1A5ha4Ys2dL
fa679d8521b4144128c128eae2cc835b1b7286a8: Bug 1194751 - Part 7. Implement ScreenHelperWin and delete old nsScreenManagerWin/nsScreenWin. r?jimm draft
Kan-Ru Chen <kanru@kanru.info> - Thu, 09 Mar 2017 19:32:31 +0800 - rev 495865
Push 48449 by kchen@mozilla.com at Thu, 09 Mar 2017 11:41:57 +0000
Bug 1194751 - Part 7. Implement ScreenHelperWin and delete old nsScreenManagerWin/nsScreenWin. r?jimm ScreenHelperWin is the platform dependent part of the original nsScreenManagerWin and nsScreenWin. It listens the WM_DISPLAYCHANGE message and pushes updates to ScreenManager. See patch part 4. for how ScreenManager works. MozReview-Commit-ID: 20A3ZQKmH9a
ba2df8637ddb6d56a28523acf24bd7d73dae851f: Bug 1194751 - Part 6.1 change nsScreenManagerAndroid::ScreenForId to a concrete method. r?snorp draft
Kan-Ru Chen <kanru@kanru.info> - Thu, 09 Mar 2017 19:30:53 +0800 - rev 495864
Push 48449 by kchen@mozilla.com at Thu, 09 Mar 2017 11:41:57 +0000
Bug 1194751 - Part 6.1 change nsScreenManagerAndroid::ScreenForId to a concrete method. r?snorp nsIScreen::GetId and nsIScreenManager::ScreenForId is removed in patch part 6. These methods are still used by Fennec on Android to implement Presentation API support so I changed them to concrete methods in nsScreenAndroid and nsScreenManagerAndroid. nsScreenAndroid and nsScreenManagerAndroid does not use the generic Screen and ScreenManager class because its implementation is quite different. MozReview-Commit-ID: 4rxxIgvNxMb
27de32b2aec9eefaacbc81deadfc9c71878a9c6a: Bug 1194751 - Part 6. Use mozilla::widget::ScreenManager in content process. r?mconley draft
Kan-Ru Chen <kanru@kanru.info> - Thu, 09 Mar 2017 19:30:26 +0800 - rev 495863
Push 48449 by kchen@mozilla.com at Thu, 09 Mar 2017 11:41:57 +0000
Bug 1194751 - Part 6. Use mozilla::widget::ScreenManager in content process. r?mconley This is the most important part of the patch series. It removes the PScreenManager protocol and use ScreenManager directly in the content processes. Initial and subsequent updates are sent via PContent::RefreshScreens. struct ScreenDetails are kept to serialize Screen over IPC. nsIScreenManager::ScreenForNativeWidget is removed because nsIWidget::GetWidgetScreen can replace it. nsIScreen::GetId is removed because it's not useful for the more general Screen class. MozReview-Commit-ID: 5dJO3isgBuQ
79491bf1b9a16aa42da2c6c48bcedd8bcb237202: Bug 1194751 - Part 5. Implement ScreenHelperGTK and delete old nsScreenManagerGtk/nsScreenGtk. r?karlt draft
Kan-Ru Chen <kanru@kanru.info> - Thu, 09 Mar 2017 19:29:44 +0800 - rev 495862
Push 48449 by kchen@mozilla.com at Thu, 09 Mar 2017 11:41:57 +0000
Bug 1194751 - Part 5. Implement ScreenHelperGTK and delete old nsScreenManagerGtk/nsScreenGtk. r?karlt ScreenHelperGTK is the platform dependent part of the original nsScreenManagerGtk and nsScreenGtk. It registers monitors-changed event listener from gtk and pushes updates to ScreenManager. See patch part 4. for how ScreenManager works. MozReview-Commit-ID: KBo7ZLFTjM3
a7d07e3c381ad29b3f897af2107010590b1f0eee: Bug 1194751 - Part 4. Add ScreenManager and Screen classes. r?mconley,jimm,karlt draft
Kan-Ru Chen <kanru@kanru.info> - Thu, 09 Mar 2017 19:16:40 +0800 - rev 495861
Push 48449 by kchen@mozilla.com at Thu, 09 Mar 2017 11:41:57 +0000
Bug 1194751 - Part 4. Add ScreenManager and Screen classes. r?mconley,jimm,karlt ScreenManager takes the common parts of ScreenManagerWin, ScreenManagerGtk and ScreenManagerCocoa. It caches all screen information in the new Screen class. The cache are updated when the OS notifies there is a monitor config change; all changes will be pushed to content processes via PContent (patch part 6.) Screen is a pure data object. All platform dependent logic will be in widget specific helper classes. Each process will have a singleton ScreenManager object. Widget specific helper object is held alive by the ScreenManager when necessary, for example to receive updates from the OS. The change to to VsyncDispatcher.cpp is due to unified-build bustage. ScreenManager::ScreenForNativeWidget is not implemented because it will be removed in patch part 6. MozReview-Commit-ID: 5ezytAXSqHp
a1237e597eac9663837fbe27873a2031418594e3: Bug 1194751 - Part 3. Remove unused nsIScreen::rotation attribute. r?jimm draft
Kan-Ru Chen <kanru@kanru.info> - Thu, 09 Mar 2017 19:16:33 +0800 - rev 495860
Push 48449 by kchen@mozilla.com at Thu, 09 Mar 2017 11:41:57 +0000
Bug 1194751 - Part 3. Remove unused nsIScreen::rotation attribute. r?jimm It's only used by gonk. Remove it will make removing PScreenManager easier. MozReview-Commit-ID: GCHonrz30xK
f19453ca12db560f6a9b0b690bd3203d7780fe2d: Bug 1194751 - Part 2. Remove unused nsIScreen::LockMinimumBrightness and related methods. r?snorp draft
Kan-Ru Chen <kanru@kanru.info> - Thu, 09 Mar 2017 19:16:29 +0800 - rev 495859
Push 48449 by kchen@mozilla.com at Thu, 09 Mar 2017 11:41:57 +0000
Bug 1194751 - Part 2. Remove unused nsIScreen::LockMinimumBrightness and related methods. r?snorp It's not used anywhere in gecko or addons. Remove it will make removing PScreenManager easier. MozReview-Commit-ID: K3BHnktO7wU
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip