c2f415c31e2c0eb352d467daa7f50fb8f6ede329: Bug 1436798: style: Move author-style-disabled handling to push_applicable_declarations. draft
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 08 Feb 2018 13:05:28 +0100 - rev 752877
Push 98405 by bmo:emilio@crisal.io at Fri, 09 Feb 2018 01:50:06 +0000
Bug 1436798: style: Move author-style-disabled handling to push_applicable_declarations. This will make it easier to handle it properly for Shadow DOM, though this patch doesn't do that. This also makes some method inline and infallible for convenience, since nobody checks the errors anyway. MozReview-Commit-ID: Hq3erAUs5tf
8af6199f59c786eacfe9a4231637ed3ecba2033e: style: Make AuthorStylesEnabled an enum. draft
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 08 Feb 2018 12:40:27 +0100 - rev 752876
Push 98405 by bmo:emilio@crisal.io at Fri, 09 Feb 2018 01:50:06 +0000
style: Make AuthorStylesEnabled an enum. Chances are we need to pass it around in a bit. Also invert the boolean because I don't want to reason about double negations, even if they're simple. MozReview-Commit-ID: KhX4lDKwDoj
ecd4c82a41f3c781d9c6a892af810b809633e11f: style: Save some work if the origin is not dirty. draft
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 08 Feb 2018 12:29:11 +0100 - rev 752875
Push 98405 by bmo:emilio@crisal.io at Fri, 09 Feb 2018 01:50:06 +0000
style: Save some work if the origin is not dirty. MozReview-Commit-ID: EGHztVLj9i3
cde49484057f26d5365257bd027e3606a8014e3d: style: Rename OriginValidity to DataValidity. draft
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 08 Feb 2018 12:27:31 +0100 - rev 752874
Push 98405 by bmo:emilio@crisal.io at Fri, 09 Feb 2018 01:50:06 +0000
style: Rename OriginValidity to DataValidity. MozReview-Commit-ID: FpsYUlWLWTt
58fc3d8a3889eb2c7e063212cdce3044e3fe0e1d: style: Assert we don't try to do dumb stuff. draft
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 08 Feb 2018 12:21:27 +0100 - rev 752873
Push 98405 by bmo:emilio@crisal.io at Fri, 09 Feb 2018 01:50:06 +0000
style: Assert we don't try to do dumb stuff. MozReview-Commit-ID: 6DpkiwUdccD
37611524b428b2c599ee0088686d3ed4e7825940: style: Move the dirty bit to SheetCollection. draft
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 08 Feb 2018 12:20:02 +0100 - rev 752872
Push 98405 by bmo:emilio@crisal.io at Fri, 09 Feb 2018 01:50:06 +0000
style: Move the dirty bit to SheetCollection. MozReview-Commit-ID: DO9vv9vmSzF
0f91743fc541bb1f1efe3ff2c9139d2d7179c6b1: style: Rename StylesheetSet to DocumentStylesheetSet. draft
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 08 Feb 2018 11:55:50 +0100 - rev 752871
Push 98405 by bmo:emilio@crisal.io at Fri, 09 Feb 2018 01:50:06 +0000
style: Rename StylesheetSet to DocumentStylesheetSet. MozReview-Commit-ID: 5Xl1eRLu1VF
ba743f9fdfa27d348500e4b5366c504e45f8ff86: Bug 1434802: Tweak specified font family serialization in Gecko so that it is simpler. r?xidorn draft
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 07 Feb 2018 18:20:23 +0100 - rev 752870
Push 98405 by bmo:emilio@crisal.io at Fri, 09 Feb 2018 01:50:06 +0000
Bug 1434802: Tweak specified font family serialization in Gecko so that it is simpler. r?xidorn In particular, every time that there's at least more than one identifier, switch to quoted family name, since the reconstruction of the serialization will be lossy anyway. This allows us to avoid copies and all that. What Chrome implements doesn't make much sense in the sense that they always serialize: font-family: "foo"; -> font-family: foo; font-family: foo bar; -> font-family: "foo bar"; font-family: foo\ bar; -> font-family: "foo bar"; This patch makes us match on the second case, but not on the rest, because I think Gecko's behavior is preferable in those cases. MozReview-Commit-ID: JwBECA93lfi
cf4d6abf8f90a8c414b957f96836bd0c2c7947e0: Bug 1426445: Add sanity check that worker uid/gid is 1000 in run-task; r?dustin,gps draft
Tom Prince <mozilla@hocat.ca> - Tue, 02 Jan 2018 14:22:36 -0700 - rev 752869
Push 98404 by bmo:mozilla@hocat.ca at Fri, 09 Feb 2018 01:46:08 +0000
Bug 1426445: Add sanity check that worker uid/gid is 1000 in run-task; r?dustin,gps MozReview-Commit-ID: 7T7rQpLhJIN
ba66144a9a7ede9bfbc8eab7dd491146e7c6bb8f: Bug 1434508 - better serialization of paymentrequest data. r?MattN draft
Sam Foster <sfoster@mozilla.com> - Wed, 31 Jan 2018 16:19:49 -0800 - rev 752868
Push 98403 by bmo:sfoster@mozilla.com at Fri, 09 Feb 2018 01:44:37 +0000
Bug 1434508 - better serialization of paymentrequest data. r?MattN * Add a serializeRequest method to paymentDialogWrapper to correctly serialize the nsIArray values * Test results of serializing a request with multiple displayItems, shippingOptions, paymentMethods and modifiers MozReview-Commit-ID: DTqzTAjvdxq
c54e2691dc009e3bf00a207370d8be17a8f7f2d4: Bug 1267462 part 10: Fix flexbox code in nsFrame::ComputeSize[WithIntrinsicDimensions] to use logical axes & coords. r?mats draft
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 08 Feb 2018 15:17:24 -0800 - rev 752867
Push 98402 by dholbert@mozilla.com at Fri, 09 Feb 2018 01:40:46 +0000
Bug 1267462 part 10: Fix flexbox code in nsFrame::ComputeSize[WithIntrinsicDimensions] to use logical axes & coords. r?mats This patch makes a bunch of tests start passing, so it removes some 'fails' annotations. MozReview-Commit-ID: DCxkXFnztLc
13fabd24b82f66bfcef76030ef651df7677d0d34: Bug 1267462 part 9: Fix IsCrossSizeDefinite() helper-method to use logical axes & coords. r?mats draft
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 08 Feb 2018 15:17:03 -0800 - rev 752866
Push 98402 by dholbert@mozilla.com at Fri, 09 Feb 2018 01:40:46 +0000
Bug 1267462 part 9: Fix IsCrossSizeDefinite() helper-method to use logical axes & coords. r?mats MozReview-Commit-ID: Eda6ltmcDgQ
870de7564cd30b117e0bf579b6f29cd2b9794872: Bug 1267462 part 8: Rename ReflowInput.mFlags.mIsFlexContainerMeasuringHeight with s/Height/BSize/, to match reality. r?mats draft
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 08 Feb 2018 15:15:11 -0800 - rev 752865
Push 98402 by dholbert@mozilla.com at Fri, 09 Feb 2018 01:40:46 +0000
Bug 1267462 part 8: Rename ReflowInput.mFlags.mIsFlexContainerMeasuringHeight with s/Height/BSize/, to match reality. r?mats This patch doesn't change behavior; it's simply a rename. I'm also fixing one mistyped mention of this variable in a comment in nsFlexContainerFrame.cpp. (The comment had "Reflow" rather than "Height" in its mention of this variable-name.) MozReview-Commit-ID: KRW7FCVSlto
f464b3b3471f4ab25dd9b41614efaf66eefc6be8: Bug 1267462 part 7: Generalize nsFlexContainerFrame::ResolveAutoFlexBasisAndMinSize and helpers to use logical axes & coords. r?mats draft
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 08 Feb 2018 15:15:07 -0800 - rev 752864
Push 98402 by dholbert@mozilla.com at Fri, 09 Feb 2018 01:40:46 +0000
Bug 1267462 part 7: Generalize nsFlexContainerFrame::ResolveAutoFlexBasisAndMinSize and helpers to use logical axes & coords. r?mats In particlar, this patch: - ...renames a bunch of 'auto'-BSize-measurement functions/variables from "Height" to "BSize". (I thought about splitting this part out, but typically the correctness of the renames was intrinsically tied to the logic generalizations that I'm performing here, and vice versa, so it seemed clearest to group it all together.) - ...replaces some calls to IsMainAxisHorizontal() with the more general "FlexItem::IsInlineAxisMainAxis()" API, for cases when we're reasoning about whether a flex item's main-size is really just its (easier-to-resolve) ISize. - ...replaces some calls to IsCrossAxisHorizontal() with either IsColumnOriented() or FlexItem::IsInlineAxisCrossAxis() (depending on whether we're reasoning about the flex container's cross-size vs. a flex item's cross size). This makes a bunch of tests start passing (including a "received" w3c reftest/wpt-test), so this patch also removes some failure annotations. MozReview-Commit-ID: 3uR1mOzvytX
235b06096f649d709e5a9cf74f192648fe31bb32: Bug 1267462 part 6: Add FlexItem methods to test whether its inline axis is in container's main vs. cross axis. r?mats draft
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 08 Feb 2018 15:01:09 -0800 - rev 752863
Push 98402 by dholbert@mozilla.com at Fri, 09 Feb 2018 01:40:46 +0000
Bug 1267462 part 6: Add FlexItem methods to test whether its inline axis is in container's main vs. cross axis. r?mats This patch doesn't affect behavior -- it's just adding a new member-var & accessor with no usages. The next patch in the series will add some usages. MozReview-Commit-ID: NKBvKnb7Jw
5a2cf8262a98844c5beeb63b853ca934f578aaa2: Bug 1267462 part 5: Move WritingMode member-var earlier in FlexItem class. r?mats draft
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 08 Feb 2018 14:58:47 -0800 - rev 752862
Push 98402 by dholbert@mozilla.com at Fri, 09 Feb 2018 01:40:46 +0000
Bug 1267462 part 5: Move WritingMode member-var earlier in FlexItem class. r?mats This patch doesn't affect behavior. It simply reorders a member variable to be near the beginning of the FlexItem class, so that the next patch in this series can use that member-variable when initializing another member in the constructor init list. (You're only allowed to use earlier member-vars like this, since member-vars get initialized in order.) MozReview-Commit-ID: 9v4Dr0Ir6i7
5624dafbac8438baf4f45c90e6171e70b97dc05a: Bug 1267462 part 4: Add more reftests for flex items with text & orthogonal flows (as modified copies of previous patch's final column-oriented test). r?mats draft
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 08 Feb 2018 13:01:24 -0800 - rev 752861
Push 98402 by dholbert@mozilla.com at Fri, 09 Feb 2018 01:40:46 +0000
Bug 1267462 part 4: Add more reftests for flex items with text & orthogonal flows (as modified copies of previous patch's final column-oriented test). r?mats MozReview-Commit-ID: AQ59jsEcUn3
0a913d6f6803d7e060427144e5330df256245b76: Bug 1267462 part 3: Add more reftests for flex items with text & orthogonal flows (as modified copies of previous patch's test). r?mats draft
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 08 Feb 2018 13:01:23 -0800 - rev 752860
Push 98402 by dholbert@mozilla.com at Fri, 09 Feb 2018 01:40:46 +0000
Bug 1267462 part 3: Add more reftests for flex items with text & orthogonal flows (as modified copies of previous patch's test). r?mats This patch includes two tests with a row-oriented vertical-writing-mode flex container, and one test with a column-oriented flex container. (And then the next patch in this series will add some more column-oriented variants as copies of this patch's last test.) Note: All of the tests in this patch *already* pass (unlike other tests added in this bug), so they don't have a 'fails' annotation in reftest.list. MozReview-Commit-ID: oaMvhjxv16
508ea555befcec0fa462dc5dd45bf87ecb61b2f5: Bug 1267462 part 2: Add a reftest for flex items with text & orthogonal flows. r?mats draft
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 08 Feb 2018 13:01:23 -0800 - rev 752859
Push 98402 by dholbert@mozilla.com at Fri, 09 Feb 2018 01:40:46 +0000
Bug 1267462 part 2: Add a reftest for flex items with text & orthogonal flows. r?mats MozReview-Commit-ID: FrxV0JlhTRP
5d4074dd0347680b15d9a1e700fb15f7aff61973: Bug 1267462 part 1: Add copies of some existing flexbox reftests, now with orthogonal flows / vertical writing modes. r?mats draft
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 08 Feb 2018 13:01:23 -0800 - rev 752858
Push 98402 by dholbert@mozilla.com at Fri, 09 Feb 2018 01:40:46 +0000
Bug 1267462 part 1: Add copies of some existing flexbox reftests, now with orthogonal flows / vertical writing modes. r?mats In nearly all of these cases, the writing-mode tweak isn't supposed to affect the test's rendering, so I'm reusing the original test's reference case. The only exception: a few of the copied tests have some "spacer" elements with `display:inline-block`, which stack horizontally (in the inline axis) in the original testcase. In the new copy of the test, I'm dropping that inline-block styling, so that they continue to stack horizontally (in the vertical writing mode's block axis) and continue to match the original reference case. These tests are marked as 'fails' for now, but they'll start passing as of a later patch in this series. MozReview-Commit-ID: JLzT61JHudz
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip