beff84029fe3920a4c9cc56f44e109df93758a84: Bug 1437417 part 1: a11y: Fix some issues in IsModuleVersionLessThan and make it reusable. r?MarcoZ draft
James Teh <jteh@mozilla.com> - Tue, 13 Feb 2018 16:48:16 +1000 - rev 754328
Push 98820 by bmo:jteh@mozilla.com at Tue, 13 Feb 2018 06:54:55 +0000
Bug 1437417 part 1: a11y: Fix some issues in IsModuleVersionLessThan and make it reusable. r?MarcoZ 1. Move IsModuleVersionLessThan into the Compatibility class and export it in the header file. 2. The function previously referred to the third component of the version as the minor version; i.e. it was testing major.bbbb.minor.dddd. This is incorrect and might confuse people using this in future code. The minor version is the second component; i.e. major.minor.cccc.dddd. cccc and dddd are often named build and revision, but the naming here is less consistent. 3. Rather than accepting separate version components, the function now accepts a single 64 bit value. This makes comparison easier and also allows for comparison against magic values in other code; e.g. a value meaning "all versions". This value can be created from separate components using the MAKE_FILE_VERSION macro. 4. Previously, it was assumed that a dll path could not be longer than MAX_PATH, but it can actually be longer. The function now handles this. 5. The function previously didn't do any error checking, which could have led to null pointer dereferences and possibly other pain. This was fine when it was only being used for JAWS, which we know always has version info, but this could be problematic for other callers. We return true if there is a failure, assuming that no version info implies an earlier version. 6. The code now uses smart pointers instead of raw pointers, making memory management simpler. 7. Updated the JAWS version check accordingly. MozReview-Commit-ID: 9Y6gUQSX0P5
1e37063aebed1f514bb2cc40a99078409bbd05f3: Bug 1364025 followup - Fix Payment Request interface IDL test to not check dom.idl. r?bz draft
Xidorn Quan <me@upsuper.org> - Tue, 13 Feb 2018 17:23:30 +1100 - rev 754327
Push 98819 by xquan@mozilla.com at Tue, 13 Feb 2018 06:24:37 +0000
Bug 1364025 followup - Fix Payment Request interface IDL test to not check dom.idl. r?bz MozReview-Commit-ID: 93Lcg6wo1Xs
483d75d8efbf75f9922e9e947edd41a28bd2d541: Bug 1364025 - Add Unscopable to Document.fullscreen. r=bz draft
Xidorn Quan <me@upsuper.org> - Tue, 13 Feb 2018 17:19:46 +1100 - rev 754326
Push 98819 by xquan@mozilla.com at Tue, 13 Feb 2018 06:24:37 +0000
Bug 1364025 - Add Unscopable to Document.fullscreen. r=bz MozReview-Commit-ID: CK8pbdKeBas
ce4306093f2a12c73f733f013a04a845b003c286: Backed out changeset 221bee012f86 (bug 1364025) for wpt failures in payment-request/interfaces.https.html
Phil Ringnalda <philringnalda@gmail.com> - Mon, 12 Feb 2018 21:43:34 -0800 - rev 754325
Push 98819 by xquan@mozilla.com at Tue, 13 Feb 2018 06:24:37 +0000
Backed out changeset 221bee012f86 (bug 1364025) for wpt failures in payment-request/interfaces.https.html CLOSED TREE
53218d52fdfb4ddc4dd223f644ed3ad445e05cd9: Bug 1428432 - Fix for mochitest chrome failures at devtools/client/shared/components/test/mochitest/test_tree_12.html. CLOSED TREE
Yura Zenevich <yura.zenevich@gmail.com> - Mon, 12 Feb 2018 23:46:41 -0500 - rev 754324
Push 98819 by xquan@mozilla.com at Tue, 13 Feb 2018 06:24:37 +0000
Bug 1428432 - Fix for mochitest chrome failures at devtools/client/shared/components/test/mochitest/test_tree_12.html. CLOSED TREE MozReview-Commit-ID: 6G9M7fWUA9i
221bee012f8648f0d93d5adc27a7917c946fefe5: Bug 1364025 - Add Unscopable to Document.fullscreen. r=bz
Xidorn Quan <me@upsuper.org> - Tue, 13 Feb 2018 14:51:12 +1100 - rev 754323
Push 98819 by xquan@mozilla.com at Tue, 13 Feb 2018 06:24:37 +0000
Bug 1364025 - Add Unscopable to Document.fullscreen. r=bz MozReview-Commit-ID: CK8pbdKeBas
2f7e769b59422126015b4017b0fd48ae27b80faa: Bug 1428431 - added accessible highlighter classes for content and chrome docs. r=pbro
Yura Zenevich <yura.zenevich@gmail.com> - Mon, 05 Feb 2018 15:02:41 -0500 - rev 754322
Push 98819 by xquan@mozilla.com at Tue, 13 Feb 2018 06:24:37 +0000
Bug 1428431 - added accessible highlighter classes for content and chrome docs. r=pbro MozReview-Commit-ID: JeBMoiCvENV
034c72b76050e6a0e65567724e4f32b4f3c529db: Bug 1428432 - further improve keyboard accessibility for VirtualizedTree. r=nchevobbe
Yura Zenevich <yura.zenevich@gmail.com> - Tue, 06 Feb 2018 15:21:01 -0500 - rev 754321
Push 98819 by xquan@mozilla.com at Tue, 13 Feb 2018 06:24:37 +0000
Bug 1428432 - further improve keyboard accessibility for VirtualizedTree. r=nchevobbe MozReview-Commit-ID: 8Es17Q5J87a
e1a06c67ea6a6b28fc2e5606ca8f0e751f599c8c: Bug 1428432 - prevent unnecessary VirtualizedTree render when the client height does not change. r=nchevobbe
Yura Zenevich <yura.zenevich@gmail.com> - Tue, 06 Feb 2018 15:20:47 -0500 - rev 754320
Push 98819 by xquan@mozilla.com at Tue, 13 Feb 2018 06:24:37 +0000
Bug 1428432 - prevent unnecessary VirtualizedTree render when the client height does not change. r=nchevobbe MozReview-Commit-ID: FErkeNwUuGF
f81606cd29582cceb6a339c122336fefbe80ae15: Bug 1428436 - further improving TreeView accessibility. r=Honza
Yura Zenevich <yura.zenevich@gmail.com> - Thu, 01 Feb 2018 16:04:14 -0500 - rev 754319
Push 98819 by xquan@mozilla.com at Tue, 13 Feb 2018 06:24:37 +0000
Bug 1428436 - further improving TreeView accessibility. r=Honza MozReview-Commit-ID: 8plUv815ErP
d719873a21a9de87308434fdab2ac87b827a8af6: Bug 1428442 - enabling tab highlighting for more than one tool at a time. r=gregtatum
Yura Zenevich <yura.zenevich@gmail.com> - Mon, 05 Feb 2018 16:11:23 -0500 - rev 754318
Push 98819 by xquan@mozilla.com at Tue, 13 Feb 2018 06:24:37 +0000
Bug 1428442 - enabling tab highlighting for more than one tool at a time. r=gregtatum MozReview-Commit-ID: 7iMABzVuOYG
a6088a5f48ee299386a84d2f771902267d7355b1: Bug 1437255. Use a null prototype for @@unscopables objects in the DOM. r=qdot
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 12 Feb 2018 15:46:11 -0500 - rev 754317
Push 98819 by xquan@mozilla.com at Tue, 13 Feb 2018 06:24:37 +0000
Bug 1437255. Use a null prototype for @@unscopables objects in the DOM. r=qdot MozReview-Commit-ID: 9YjnPHe78Tg
1757b17e21b52cb6020d80433ff72c855e28e6dd: Bug 1436902 part 5. Change generated event classes to use NS_INLINE_DECL_REFCOUNTING_INHERITED when possible. r=mccr8
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 12 Feb 2018 15:45:51 -0500 - rev 754316
Push 98819 by xquan@mozilla.com at Tue, 13 Feb 2018 06:24:37 +0000
Bug 1436902 part 5. Change generated event classes to use NS_INLINE_DECL_REFCOUNTING_INHERITED when possible. r=mccr8 This makes 23 generated event clases use NS_INLINE_DECL_REFCOUNTING_INHERITED. MozReview-Commit-ID: 7dyWTc1AUfH
f9e3ae4647ac24614cd7086ac05de1e15a26dfc2: Bug 1436902 part 4. Refactor event codegen a bit to make it easier to tell whether the event class needs cycle collection. r=mccr8
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 12 Feb 2018 15:45:10 -0500 - rev 754315
Push 98819 by xquan@mozilla.com at Tue, 13 Feb 2018 06:24:37 +0000
Bug 1436902 part 4. Refactor event codegen a bit to make it easier to tell whether the event class needs cycle collection. r=mccr8 I looked at the diff in the generated code, and the only change is that SpeechRecognitionEvent's unlink impl goes from: NS_IMPL_CYCLE_COLLECTION_UNLINK_BEGIN_INHERITED(SpeechRecognitionEvent, Event) NS_IMPL_CYCLE_COLLECTION_UNLINK(mResults) tmp->mInterpretation.setUndefined(); NS_IMPL_CYCLE_COLLECTION_UNLINK(mEmma) NS_IMPL_CYCLE_COLLECTION_UNLINK_END to: NS_IMPL_CYCLE_COLLECTION_UNLINK_BEGIN_INHERITED(SpeechRecognitionEvent, Event) NS_IMPL_CYCLE_COLLECTION_UNLINK(mResults) NS_IMPL_CYCLE_COLLECTION_UNLINK(mEmma) + tmp->mInterpretation.setUndefined(); NS_IMPL_CYCLE_COLLECTION_UNLINK_END MozReview-Commit-ID: FISIphljlT6
91d647c847e56cb0db2be19647507cec207b1d08: Bug 1436902 part 3. Replace usage of NS_IMPL_ISUPPORTS_INHERITED0 with NS_INLINE_DECL_REFCOUNTING_INHERITED when possible. r=mccr8
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 12 Feb 2018 15:44:40 -0500 - rev 754314
Push 98819 by xquan@mozilla.com at Tue, 13 Feb 2018 06:24:37 +0000
Bug 1436902 part 3. Replace usage of NS_IMPL_ISUPPORTS_INHERITED0 with NS_INLINE_DECL_REFCOUNTING_INHERITED when possible. r=mccr8 The change to RootAccessible.cpp fixes an obvious bug introduced in bug 741707. The visibility changes in gfx/thebes are because NS_DECL_ISUPPORTS has a trailing "public:" that those classes were relying on to have public constructors. MozReview-Commit-ID: IeB8KIJCGhU
606c47199b309415485694446b5ccf99d6ee0350: Bug 1436902 part 2. Use NS_INLINE_DECL_REFCOUNTING_INHERITED for some classes that have otherwise-empty QI impls. r=mccr8
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 12 Feb 2018 15:43:55 -0500 - rev 754313
Push 98819 by xquan@mozilla.com at Tue, 13 Feb 2018 06:24:37 +0000
Bug 1436902 part 2. Use NS_INLINE_DECL_REFCOUNTING_INHERITED for some classes that have otherwise-empty QI impls. r=mccr8 MozReview-Commit-ID: 95xACATqz7p
68bab9b6f40b820fb8bb387c995720f18eaf150a: Bug 1436902 part 1. Add a new NS_INLINE_DECL_REFCOUNTING_INHERITED macro that declares addref/release only for logging purposes. r=mccr8
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 12 Feb 2018 15:43:48 -0500 - rev 754312
Push 98819 by xquan@mozilla.com at Tue, 13 Feb 2018 06:24:37 +0000
Bug 1436902 part 1. Add a new NS_INLINE_DECL_REFCOUNTING_INHERITED macro that declares addref/release only for logging purposes. r=mccr8 MozReview-Commit-ID: JTT5RzJ7IVu
4ca928e3c74008885671e122dd05cee40432fc98: Bug 1428453 - Baldr: use new traps for float-to-int conversions (r=bbouvier)
Luke Wagner <luke@mozilla.com> - Mon, 12 Feb 2018 15:31:02 -0600 - rev 754311
Push 98819 by xquan@mozilla.com at Tue, 13 Feb 2018 06:24:37 +0000
Bug 1428453 - Baldr: use new traps for float-to-int conversions (r=bbouvier)
b54df6ca0ab8b8dc7bdfa65e32ca1e0f367bb754: Bug 1428453 - Baldr: use new traps for idiv (r=bbouvier)
Luke Wagner <luke@mozilla.com> - Mon, 12 Feb 2018 15:30:46 -0600 - rev 754310
Push 98819 by xquan@mozilla.com at Tue, 13 Feb 2018 06:24:37 +0000
Bug 1428453 - Baldr: use new traps for idiv (r=bbouvier)
18e4d706ecdfe1c7794f581f614ad1f3a1c0ec86: Bug 1428453 - Baldr: use new traps for integer overflow (r=bbouvier)
Luke Wagner <luke@mozilla.com> - Mon, 12 Feb 2018 15:30:30 -0600 - rev 754309
Push 98819 by xquan@mozilla.com at Tue, 13 Feb 2018 06:24:37 +0000
Bug 1428453 - Baldr: use new traps for integer overflow (r=bbouvier)
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip